metainspector 5.0.0.rc1 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb39fe43b5a67a67f0543043ded76d44001eb677
-  data.tar.gz: 3183a8d0f564b3acda845436470b07b466345050
+  metadata.gz: 70611d34eb28467a1b3ae1950b4e56f62e27aad1
+  data.tar.gz: 39eed33ee8c1a90dd48734ee74caafe68da97c92
 SHA512:
-  metadata.gz: f0d5f4b1dda14174e082956f354c4995b34525f0da33c81c002f422dc12d06c3af9eed5b919c39030daedc3305957ed54dc7462d596e564d51cb9d3b38f069c7
-  data.tar.gz: 478ef7aef64b6310106733dd32bdd111e9342a84831d93369d35d275149196613acea262e02d3c058ce0b2daeb55aed4b1729a886031e7a7697df1e3f72b6017
+  metadata.gz: aafccfa73f466485093c4eb7c8af88593557fd124fbfa945034080606ed4aeec32a89d115f3e397e03eaff3045b1268ba16e03ba2737a0da5ccd728370fc8491
+  data.tar.gz: ccaa60674d85635828f6dc835351011b841f1e53f385e1a68e0d579dcdba7ccdaf381e1cf1a58085d1e07243f2a0428e4d31ea346050d7ba24988f43f3175f61

data/.travis.yml

@@ -1,3 +1,4 @@
 rvm:
 - 2.0.0
-- 2.1.3
+- 2.1.8
+- 2.2.4

data/README.md

@@ -22,7 +22,7 @@ If you're using it on a Rails application, just add it to your Gemfile and run `
 gem 'metainspector'
 ```
 
-This gem is tested on Ruby versions 2.0.0 and 2.1.3.
+This gem is tested on Ruby versions 2.0.0, 2.1.8 and 2.2.4.
 
 ## Usage
 
@@ -322,7 +322,7 @@ customize the way we request the page, like for example disabling SSL verificati
 MetaInspector.new('https://example.com')
 # Faraday::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed
 
-MetaInpector.new('https://example.com', faraday_options: { ssl: { verify: false } })
+MetaInspector.new('https://example.com', faraday_options: { ssl: { verify: false } })
 # Now we can access the page
 ```
 

data/lib/meta_inspector/request.rb

@@ -37,7 +37,7 @@ module MetaInspector
       @response ||= fetch
     rescue Faraday::TimeoutError => e
       raise MetaInspector::TimeoutError.new(e)
-    rescue Faraday::Error::ConnectionFailed, Faraday::SSLError, URI::InvalidURIError => e
+    rescue Faraday::Error::ConnectionFailed, Faraday::SSLError, URI::InvalidURIError, FaradayMiddleware::RedirectLimitReached => e
       raise MetaInspector::RequestError.new(e)
     end
 

data/lib/meta_inspector/url.rb

@@ -62,7 +62,7 @@ module MetaInspector
       else
         Addressable::URI.join(base_url, url).normalize.to_s
       end
-    rescue MetaInspector::ParserError
+    rescue MetaInspector::ParserError, Addressable::URI::InvalidURIError
       nil
     end
 

data/lib/meta_inspector/version.rb

@@ -1,3 +1,3 @@
 module MetaInspector
-  VERSION = '5.0.0.rc1'
+  VERSION = '5.0.0'
 end

data/meta_inspector.gemspec

@@ -15,12 +15,12 @@ Gem::Specification.new do |gem|
   gem.version       = MetaInspector::VERSION
 
   gem.add_dependency 'nokogiri', '~> 1.6'
-  gem.add_dependency 'faraday', '~> 0.9.0'
+  gem.add_dependency 'faraday', '~> 0.9'
   gem.add_dependency 'faraday_middleware', '~> 0.10'
-  gem.add_dependency 'faraday-cookie_jar', '~> 0.0.6'
-  gem.add_dependency 'faraday-http-cache', '~> 1.2.2'
-  gem.add_dependency 'addressable', '~> 2.3.5'
-  gem.add_dependency 'fastimage'
+  gem.add_dependency 'faraday-cookie_jar', '~> 0.0'
+  gem.add_dependency 'faraday-http-cache', '~> 1.2'
+  gem.add_dependency 'addressable', '~> 2.4'
+  gem.add_dependency 'fastimage', '~> 1.8'
   gem.add_dependency 'nesty', '~> 1.0'
 
   gem.add_development_dependency 'rspec', '~> 3.0'

data/spec/meta_inspector/links_spec.rb

@@ -101,9 +101,9 @@ describe MetaInspector do
       end
     end
 
-    it "should not crash with links that have weird href values" do
+    it "should not crash with links that have weird href values, filtering them out" do
       m = MetaInspector.new('http://example.com/invalid_href')
-      expect(m.links.non_http).to eq(["%3Cp%3Eftp://ftp.cdrom.com", "skype:joeuser?call", "telnet://telnet.cdrom.com"])
+      expect(m.links.non_http).to eq(["skype:joeuser?call", "telnet://telnet.cdrom.com"])
     end
   end
 

data/spec/meta_inspector/redirections_spec.rb

@@ -18,6 +18,21 @@ describe MetaInspector do
       end
     end
 
+    context "when there are too many redirects" do
+      before(:all) { WebMock.enable! }
+      after(:all)  { WebMock.disable! }
+
+      before do
+        12.times { |i| register_redirect(i, i+1) }
+      end
+
+      it "raises an error" do
+        expect {
+          MetaInspector.new("http://example.org/1")
+        }.to raise_error MetaInspector::RequestError
+      end
+    end
+
     context "when there are cookies required for proper redirection" do
       before(:all) { WebMock.enable! }
       after(:all)  { WebMock.disable! }
@@ -39,4 +54,11 @@ describe MetaInspector do
       end
     end
   end
+
+  private
+
+  def register_redirect(from, to)
+    stub_request(:get, "http://example.org/#{from}")
+      .to_return(:status => 302, :body => "", :headers => { "Location" => "http://example.org/#{to}" })
+  end
 end

data/spec/request_spec.rb

@@ -63,6 +63,14 @@ describe MetaInspector::Request do
         MetaInspector::Request.new(url('http://example.com/fail'))
       end.to raise_error(MetaInspector::RequestError)
     end
+
+    it "should handle ssl errors" do
+      allow(TCPSocket).to receive(:open).and_raise(OpenSSL::SSL::SSLError)
+
+      expect do
+        MetaInspector::Request.new(url('https://example.com'))
+      end.to raise_error(MetaInspector::RequestError)
+    end
   end
 
   private

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metainspector
 version: !ruby/object:Gem::Version
-  version: 5.0.0.rc1
+  version: 5.0.0
 platform: ruby
 authors:
 - Jaime Iniesta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-18 00:00:00.000000000 Z
+date: 2015-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
@@ -58,56 +58,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.6
+        version: '0.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.6
+        version: '0.0'
 - !ruby/object:Gem::Dependency
   name: faraday-http-cache
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.2
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.2
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.5
+        version: '2.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.5
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: fastimage
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: nesty
   requirement: !ruby/object:Gem::Requirement
@@ -360,12 +360,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: MetaInspector is a ruby gem for web scraping purposes, that returns metadata