metainspector 4.7.2 → 5.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 86567f0c8cb2d8e951680599d7dab6046629c0bc
-  data.tar.gz: 306df75553413f3ba939da9c28404975ddfe82c3
+  metadata.gz: cb39fe43b5a67a67f0543043ded76d44001eb677
+  data.tar.gz: 3183a8d0f564b3acda845436470b07b466345050
 SHA512:
-  metadata.gz: 9940923917a65cff55d20624feca56818da777a8a4914d571d031e8f7b8d55e1062853cded7462f8e42b84407f07f4257007d1ce46de7bcb5bc22a0d0c515391
-  data.tar.gz: 9b960da1faef8aafab695995496646d8035ff015999bf8ed7baee22166c35473da32370ecfb252961b798c171fd2c1d27d4bc5a2d52986f4bdc71190ac1ab7ce
+  metadata.gz: f0d5f4b1dda14174e082956f354c4995b34525f0da33c81c002f422dc12d06c3af9eed5b919c39030daedc3305957ed54dc7462d596e564d51cb9d3b38f069c7
+  data.tar.gz: 478ef7aef64b6310106733dd32bdd111e9342a84831d93369d35d275149196613acea262e02d3c058ce0b2daeb55aed4b1729a886031e7a7697df1e3f72b6017

data/README.md

@@ -385,28 +385,11 @@ page = MetaInspector.new('http://example.com', faraday_http_cache: { store: cach
 
 ## Exception Handling
 
-By default, MetaInspector will raise the exceptions found. We think that this is the safest default: in case the URL you're trying to scrape is unreachable, you should clearly be notified, and treat the exception as needed in your app.
+Web page scraping is tricky, you can expect to find different exceptions during the request of the page or the parsing of its contents. MetaInspector will encapsulate these exceptions on these main errors:
 
-However, if you prefer you can also set the `warn_level: :warn` option, so that exceptions found will just be warned on the standard output, instead of being raised.
-
-You can also set the `warn_level: :store` option so that exceptions found will be silenced, and left for you to inspect on `page.exceptions`. You can also ask for `page.ok?`, wich will return `true` if no exceptions are stored.
-
-You should avoid using the `:store` option, or use it wisely, as silencing errors can be problematic, it's always better to face the errors and treat them accordingly.
-
-If you're using this exception store, you're advised to first initialize the document, check if it seems OK, and then proceed with the extractions, like this:
-
-```ruby
-# This will fail because the URL will return a text/xml document
-page = MetaInspector.new("http://example.com/rss",
-                          html_content_only: true,
-                          warn_level: :store )
-
-if page.ok?
-  puts "TITLE: #{page.title}"
-else
-  puts "There were some exceptions: #{page.exceptions}"
-end
-```
+* `MetaInspector::TimeoutError`. When fetching a web page has taken too long.
+* `MetaInspector::RequestError`. When there has been an error on the request phase. Examples: page not found, SSL failure, invalid URI.
+* `MetaInspector::ParserError`. When there has been an error parsing the contents of the page. Example: trying to parse an image file.
 
 ## Examples
 

data/examples/basic_scraping.rb

@@ -4,7 +4,8 @@
 #
 #   ruby basic_scraping.rb jaimeiniesta.com
 
-require 'metainspector'
+require '../lib/metainspector'
+puts "Using MetaInspector #{MetaInspector::VERSION}"
 
 # Get the starting URL
 url = ARGV[0] || (puts "Enter an url"; gets.strip)

data/examples/link_checker.rb

@@ -2,9 +2,10 @@
 #
 # Usage example:
 #
-#   ruby link_checker.rb alazan.com
+#   ruby link_checker.rb example.com
 
-require 'metainspector'
+require '../lib/metainspector'
+puts "Using MetaInspector #{MetaInspector::VERSION}"
 
 class BrokenLinkChecker
 
@@ -39,11 +40,11 @@ class BrokenLinkChecker
   end
 
   def process_next_on_queue
-    page = MetaInspector.new(@queue.pop, :warn_level => :store)
+    page = MetaInspector.new(@queue.pop)
 
     page.links.all.select {|l| l =~ /^http(s)?:\/\//i}.each do |link|
       check_status(link, page.url)
-    end if page.ok?
+    end
 
     @visited.push(page.url)
 
@@ -90,7 +91,7 @@ class BrokenLinkChecker
     else
       false
     end
-  rescue Exception => e
+  rescue
     false
   end
 end

data/examples/spider.rb

@@ -2,9 +2,10 @@
 #
 # Usage example:
 #
-#   ruby spider.rb jaimeiniesta.com
+#   ruby spider.rb example.com
 
-require 'metainspector'
+require '../lib/metainspector'
+puts "Using MetaInspector #{MetaInspector::VERSION}"
 
 # Two arrays, one for the scraping queue and one for the visited links
 queue   = []

data/lib/meta_inspector.rb

@@ -1,6 +1,5 @@
 require 'forwardable'
-require File.expand_path(File.join(File.dirname(__FILE__), 'meta_inspector/exceptionable'))
-require File.expand_path(File.join(File.dirname(__FILE__), 'meta_inspector/exception_log'))
+require File.expand_path(File.join(File.dirname(__FILE__), 'meta_inspector/errors'))
 require File.expand_path(File.join(File.dirname(__FILE__), 'meta_inspector/request'))
 require File.expand_path(File.join(File.dirname(__FILE__), 'meta_inspector/url'))
 require File.expand_path(File.join(File.dirname(__FILE__), 'meta_inspector/parser'))

data/lib/meta_inspector/document.rb

@@ -1,9 +1,7 @@
 module MetaInspector
   # A MetaInspector::Document knows about its URL and its contents
   class Document
-    attr_reader :html_content_only, :allow_redirections, :warn_level, :headers
-
-    include MetaInspector::Exceptionable
+    attr_reader :html_content_only, :allow_redirections, :headers
 
     # Initializes a new instance of MetaInspector::Document, setting the URL
     # Options:
@@ -14,8 +12,6 @@ module MetaInspector
     #   content-type is not text/html. Defaults to false.
     # * allow_redirections: when true, follow HTTP redirects. Defaults to true
     # * document: the html of the url as a string
-    # * warn_level: what to do when encountering exceptions.
-    #   Can be :warn, :raise or nil
     # * headers: object containing custom headers for the request
     # * normalize_url: true by default
     # * faraday_options: an optional hash of options to pass to Faraday on the request
@@ -29,23 +25,18 @@ module MetaInspector
       @document           = options[:document]
       @download_images    = options[:download_images]
       @headers            = options[:headers]
-      @warn_level         = options[:warn_level]
-      @exception_log      = options[:exception_log] || MetaInspector::ExceptionLog.new(warn_level: warn_level)
       @normalize_url      = options[:normalize_url]
       @faraday_options    = options[:faraday_options]
       @faraday_http_cache = options[:faraday_http_cache]
-      @url                = MetaInspector::URL.new(initial_url, exception_log:      @exception_log,
-                                                                normalize:          @normalize_url)
+      @url                = MetaInspector::URL.new(initial_url, normalize:          @normalize_url)
       @request            = MetaInspector::Request.new(@url,    allow_redirections: @allow_redirections,
                                                                 connection_timeout: @connection_timeout,
                                                                 read_timeout:       @read_timeout,
                                                                 retries:            @retries,
-                                                                exception_log:      @exception_log,
                                                                 headers:            @headers,
                                                                 faraday_options:    @faraday_options,
                                                                 faraday_http_cache: @faraday_http_cache) unless @document
-      @parser             = MetaInspector::Parser.new(self,     exception_log:      @exception_log,
-                                                                download_images:    @download_images)
+      @parser             = MetaInspector::Parser.new(self,     download_images:    @download_images)
     end
 
     extend Forwardable
@@ -93,7 +84,6 @@ module MetaInspector
       { :timeout            => 20,
         :retries            => 3,
         :html_content_only  => false,
-        :warn_level         => :raise,
         :headers            => {
                                  'User-Agent'      => default_user_agent,
                                  'Accept-Encoding' => 'identity'
@@ -109,12 +99,10 @@ module MetaInspector
 
     def document
       @document ||= if html_content_only && content_type != 'text/html'
-                      fail "The url provided contains #{content_type} content instead of text/html content"
+                      fail MetaInspector::ParserError.new "The url provided contains #{content_type} content instead of text/html content"
                     else
                       @request.read
                     end
-    rescue Exception => e
-      @exception_log << e
     end
   end
 end

data/lib/meta_inspector/errors.rb

@@ -0,0 +1,13 @@
+require 'nesty'
+
+module MetaInspector
+  class Error < StandardError
+    include Nesty::NestedError
+  end
+
+  class TimeoutError < Error; end
+
+  class RequestError < Error; end
+
+  class ParserError < Error; end
+end

data/lib/meta_inspector/parser.rb

@@ -8,11 +8,8 @@ module MetaInspector
   # passing itself as a reference for coordination purposes
   #
   class Parser
-    include MetaInspector::Exceptionable
-
     def initialize(document, options = {})
       @document        = document
-      @exception_log   = options[:exception_log]
       @head_links_parser = MetaInspector::Parsers::HeadLinksParser.new(self)
       @meta_tag_parser = MetaInspector::Parsers::MetaTagsParser.new(self)
       @links_parser    = MetaInspector::Parsers::LinksParser.new(self)
@@ -34,8 +31,6 @@ module MetaInspector
     # Returns the whole parsed document
     def parsed
       @parsed ||= Nokogiri::HTML(@document.to_s)
-    rescue Exception => e
-      @exception_log << e
     end
   end
 end

data/lib/meta_inspector/request.rb

@@ -7,8 +7,6 @@ module MetaInspector
 
   # Makes the request to the server
   class Request
-    include MetaInspector::Exceptionable
-
     def initialize(initial_url, options = {})
       @url                = initial_url
 
@@ -16,7 +14,6 @@ module MetaInspector
       @connection_timeout = options[:connection_timeout]
       @read_timeout       = options[:read_timeout]
       @retries            = options[:retries]
-      @exception_log      = options[:exception_log]
       @headers            = options[:headers]
       @faraday_options    = options[:faraday_options] || {}
       @faraday_http_cache = options[:faraday_http_cache]
@@ -38,10 +35,10 @@ module MetaInspector
 
     def response
       @response ||= fetch
-    rescue Faraday::TimeoutError, Faraday::Error::ConnectionFailed, Faraday::SSLError,
-           RuntimeError, URI::InvalidURIError => e
-      @exception_log << e
-      nil
+    rescue Faraday::TimeoutError => e
+      raise MetaInspector::TimeoutError.new(e)
+    rescue Faraday::Error::ConnectionFailed, Faraday::SSLError, URI::InvalidURIError => e
+      raise MetaInspector::RequestError.new(e)
     end
 
     private

data/lib/meta_inspector/url.rb

@@ -4,12 +4,9 @@ module MetaInspector
   class URL
     attr_reader :url
 
-    include MetaInspector::Exceptionable
-
     def initialize(initial_url, options = {})
       options        = defaults.merge(options)
 
-      @exception_log = options[:exception_log]
       @normalize     = options[:normalize]
 
       self.url = initial_url
@@ -61,11 +58,11 @@ module MetaInspector
     # schema as the base_url
     def self.absolutify(url, base_url)
       if url =~ /^\w*\:/i
-        MetaInspector::URL.new(url, exception_log: MetaInspector::ExceptionLog.new(warn_level: :store)).url
+        MetaInspector::URL.new(url).url
       else
         Addressable::URI.join(base_url, url).normalize.to_s
       end
-    rescue Addressable::URI::InvalidURIError
+    rescue MetaInspector::ParserError
       nil
     end
 
@@ -85,15 +82,13 @@ module MetaInspector
     def normalized(url)
       Addressable::URI.parse(url).normalize.to_s
     rescue Addressable::URI::InvalidURIError => e
-      @exception_log << e
-      nil
+      raise MetaInspector::ParserError.new(e)
     end
 
     def parsed(url)
       Addressable::URI.parse(url)
     rescue Addressable::URI::InvalidURIError => e
-      @exception_log << e
-      nil
+      raise MetaInspector::ParserError.new(e)
     end
   end
 end

data/lib/meta_inspector/version.rb

@@ -1,3 +1,3 @@
 module MetaInspector
-  VERSION = '4.7.2'
+  VERSION = '5.0.0.rc1'
 end

data/meta_inspector.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'faraday-http-cache', '~> 1.2.2'
   gem.add_dependency 'addressable', '~> 2.3.5'
   gem.add_dependency 'fastimage'
+  gem.add_dependency 'nesty', '~> 1.0'
 
   gem.add_development_dependency 'rspec', '~> 3.0'
   gem.add_development_dependency 'fakeweb', '1.3.0'

data/spec/document_spec.rb

@@ -75,83 +75,34 @@ describe MetaInspector::Document do
   end
 
   describe 'exception handling' do
-    let(:logger) { MetaInspector::ExceptionLog.new }
-
     it "should parse images when parse_html_content_type_only is not specified" do
-      expect(logger).not_to receive(:<<)
-
-      image_url = MetaInspector::Document.new('http://pagerankalert.com/image.png', exception_log: logger)
-      image_url.title
+      expect do
+        image_url = MetaInspector::Document.new('http://pagerankalert.com/image.png')
+        image_url.title
+      end.to_not raise_error
     end
 
     it "should parse images when parse_html_content_type_only is false" do
-      expect(logger).not_to receive(:<<)
-
-      image_url = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: false, exception_log: logger)
-      image_url.title
+      expect do
+        image_url = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: false)
+        image_url.title
+      end.to_not raise_error
     end
 
     it "should handle errors when content is image/jpeg and html_content_type_only is true" do
-      expect(logger).to receive(:<<).with(an_instance_of(RuntimeError))
+      expect do
+        image_url = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true)
 
-      image_url = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, exception_log: logger)
-
-      image_url.title
+        image_url.title
+      end.to raise_error(MetaInspector::ParserError)
     end
 
     it "should handle errors when content is not text/html and html_content_type_only is true" do
-      expect(logger).to receive(:<<).with(an_instance_of(RuntimeError))
-
-      tar_url = MetaInspector::Document.new('http://pagerankalert.com/file.tar.gz', html_content_only: true, exception_log: logger)
-
-      tar_url.title
-    end
-
-    context 'when a warn_level of :store is passed in' do
-      before do
-        @bad_request = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, warn_level: :store)
-        @bad_request.title
-      end
-
-      it 'stores the exceptions' do
-        expect(@bad_request.exceptions).not_to be_empty
-      end
-
-      it 'makes ok? to return false' do
-        expect(@bad_request).not_to be_ok
-      end
-    end
-
-    context 'when a warn_level of :warn is passed in' do
-      before do
-        $stderr = StringIO.new
-      end
-
-      after do
-        $stderr = STDERR
-      end
-
-      it 'warns on STDERR' do
-        bad_request = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, warn_level: :warn)
-        bad_request.title
-
-        $stderr.rewind
-        expect($stderr.string.chomp).to eq("The url provided contains image/png content instead of text/html content")
-      end
-
-      it 'does not raise an exception' do
-        expect {
-          bad_request = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, warn_level: :warn)
-          bad_request.title
-        }.to_not raise_exception
-      end
-
-      it 'does not store exceptions' do
-        bad_request = MetaInspector::Document.new('http://pagerankalert.com/image.png', html_content_only: true, warn_level: :warn)
-        bad_request.title
+      expect do
+        tar_url = MetaInspector::Document.new('http://pagerankalert.com/file.tar.gz', html_content_only: true)
 
-        expect( bad_request.exceptions ).to be_empty
-      end
+        tar_url.title
+      end.to raise_error(MetaInspector::ParserError)
     end
   end
 

data/spec/meta_inspector/meta_inspector_spec.rb

@@ -11,7 +11,7 @@ describe MetaInspector do
     def cache.read(k) self[k]; end
     def cache.write(k, v) self[k] = v; end
 
-    expect(MetaInspector.new('http://example.com', warn_level: :store, faraday_http_cache: { store: cache })).to be_ok
+    MetaInspector.new('http://example.com', faraday_http_cache: { store: cache })
 
     expect(cache.keys).not_to be_empty
   end

data/spec/meta_inspector/redirections_spec.rb

@@ -2,8 +2,6 @@ require 'spec_helper'
 
 describe MetaInspector do
   describe "redirections" do
-    let(:logger) { MetaInspector::ExceptionLog.new }
-
     context "when redirections are turned off" do
       it "disallows redirections" do
         page = MetaInspector.new("http://facebook.com", :allow_redirections => false)
@@ -14,9 +12,7 @@ describe MetaInspector do
 
     context "when redirections are on (default)" do
       it "allows follows redirections" do
-        expect(logger).not_to receive(:<<)
-
-        page = MetaInspector.new("http://facebook.com", exception_log: logger)
+        page = MetaInspector.new("http://facebook.com")
 
         expect(page.url).to eq("https://www.facebook.com/")
       end
@@ -37,9 +33,7 @@ describe MetaInspector do
         stub_request(:get, "http://blogs.clarionledger.com/dechols/2014/03/24/digital-medicine/?nclick_check=1")
           .with(:headers => {"Cookie" => "EMETA_COOKIE_CHECK=1"})
 
-        expect(logger).not_to receive(:<<)
-
-        page = MetaInspector.new("http://blogs.clarionledger.com/dechols/2014/03/24/digital-medicine/", exception_log: logger)
+        page = MetaInspector.new("http://blogs.clarionledger.com/dechols/2014/03/24/digital-medicine/")
 
         expect(page.url).to eq("http://blogs.clarionledger.com/dechols/2014/03/24/digital-medicine/?nclick_check=1")
       end

data/spec/request_spec.rb

@@ -48,8 +48,6 @@ describe MetaInspector::Request do
   end
 
   describe 'exception handling' do
-    let(:logger) { MetaInspector::ExceptionLog.new }
-
     before(:each) do
       FakeWeb.allow_net_connect = true
     end
@@ -60,9 +58,10 @@ describe MetaInspector::Request do
 
     it "should handle socket errors" do
       allow(TCPSocket).to receive(:open).and_raise(SocketError)
-      expect(logger).to receive(:<<).with(an_instance_of(Faraday::Error::ConnectionFailed))
 
-      MetaInspector::Request.new(url('http://caca232dsdsaer3sdsd-asd343.org'), exception_log: logger)
+      expect do
+        MetaInspector::Request.new(url('http://example.com/fail'))
+      end.to raise_error(MetaInspector::RequestError)
     end
   end
 

data/spec/url_spec.rb

@@ -110,17 +110,16 @@ describe MetaInspector::URL do
   end
 
   describe "handling malformed URLs" do
-    before(:each) do
-      @logger = double('ExceptionLog')
-      expect(@logger).to receive(:<<)
+    it "detects empty URLs" do
+      expect do
+        MetaInspector::URL.new('')
+      end.to raise_error(MetaInspector::ParserError)
     end
 
-    it "handles empty URLs" do
-      MetaInspector::URL.new('', exception_log: @logger)
-    end
-
-    it "handles incomplete URLs" do
-      MetaInspector::URL.new('', exception_log: @logger)
+    it "detects incomplete URLs" do
+      expect do
+        MetaInspector::URL.new('http:')
+      end.to raise_error(MetaInspector::ParserError)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metainspector
 version: !ruby/object:Gem::Version
-  version: 4.7.2
+  version: 5.0.0.rc1
 platform: ruby
 authors:
 - Jaime Iniesta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-23 00:00:00.000000000 Z
+date: 2015-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: nesty
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -258,8 +272,7 @@ files:
 - examples/spider.rb
 - lib/meta_inspector.rb
 - lib/meta_inspector/document.rb
-- lib/meta_inspector/exception_log.rb
-- lib/meta_inspector/exceptionable.rb
+- lib/meta_inspector/errors.rb
 - lib/meta_inspector/parser.rb
 - lib/meta_inspector/parsers/base.rb
 - lib/meta_inspector/parsers/head_links.rb
@@ -273,7 +286,6 @@ files:
 - lib/metainspector.rb
 - meta_inspector.gemspec
 - spec/document_spec.rb
-- spec/exception_log_spec.rb
 - spec/fixtures/100x100.jpg.response
 - spec/fixtures/10x10.jpg.response
 - spec/fixtures/404.response
@@ -348,9 +360,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.8

data/lib/meta_inspector/exception_log.rb

@@ -1,31 +0,0 @@
-module MetaInspector
-
-  # Stores the exceptions passed to it, warning about them if required
-  class ExceptionLog
-    attr_reader :exceptions, :warn_level
-
-    def initialize(options = {})
-      @warn_level = options[:warn_level] || :raise
-      @exceptions = []
-    end
-
-    def <<(exception)
-      case warn_level
-      when :raise
-        fail exception
-      when :warn
-        warn exception
-      when :store
-        @exceptions << exception
-      end
-    end
-
-    def ok?
-      if warn_level == :store
-        exceptions.empty?
-      else
-        warn 'ExceptionLog#ok? should only be used when warn_level is :store'
-      end
-    end
-  end
-end

data/lib/meta_inspector/exceptionable.rb

@@ -1,9 +0,0 @@
-module MetaInspector
-  #
-  # This module extracts two common methods for classes that use ExceptionLog
-  #
-  module Exceptionable
-    extend Forwardable
-    delegate [:exceptions, :ok?] => :@exception_log
-  end
-end

data/spec/exception_log_spec.rb

@@ -1,79 +0,0 @@
-require 'spec_helper'
-
-describe MetaInspector::ExceptionLog do
-
-  describe "warn_level" do
-    it "should be :raise by default" do
-      expect(MetaInspector::ExceptionLog.new.warn_level).to eq(:raise)
-    end
-
-    it "should raise exceptions when warn_level is :raise" do
-      logger    = MetaInspector::ExceptionLog.new(warn_level: :raise)
-      exception = StandardError.new("this should be raised")
-
-      expect {
-        logger << exception
-      }.to raise_exception(StandardError, "this should be raised")
-    end
-
-    it "should warn about the error if warn_level is :warn" do
-      logger    = MetaInspector::ExceptionLog.new(warn_level: :warn)
-      exception = StandardError.new("an error message")
-
-      expect(logger).to receive(:warn).with(exception)
-      logger << exception
-    end
-
-    it "should store the error if warn_level is :store" do
-      logger    = MetaInspector::ExceptionLog.new(warn_level: :store)
-      exception = StandardError.new("an error message")
-      expect {
-        logger << exception
-      }.to change { logger.exceptions.size }.by(1)
-    end
-  end
-
-  describe "storing exceptions" do
-    let(:logger) { MetaInspector::ExceptionLog.new(warn_level: :store) }
-
-    it "should store exceptions" do
-      expect {
-        logger << StandardError.new("an error message")
-      }.to change { logger.exceptions.length }.from(0).to(1)
-    end
-
-    it "should return stored exceptions" do
-      first   = StandardError.new("first message")
-      second  = StandardError.new("second message")
-
-      logger << first
-      logger << second
-
-      expect(logger.exceptions).to eq([first, second])
-    end
-
-    describe "ok?" do
-      it "should be true if no exceptions stored" do
-        expect(logger).to be_ok
-      end
-
-      it "should be false if some exception stored" do
-        logger << StandardError.new("some message")
-        expect(logger).not_to be_ok
-      end
-
-      it "should warn about misuse if warn_level is :raise" do
-        logger    = MetaInspector::ExceptionLog.new(warn_level: :raise)
-        expect(logger).to receive(:warn).with("ExceptionLog#ok? should only be used when warn_level is :store")
-        logger.ok?
-      end
-
-      it "should warn about misuse if warn_level is :warn" do
-        logger    = MetaInspector::ExceptionLog.new(warn_level: :warn)
-        expect(logger).to receive(:warn).with("ExceptionLog#ok? should only be used when warn_level is :store")
-        logger.ok?
-      end
-    end
-  end
-
-end