metahash-rb 1.1.0 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c50e809216c3a73ef2046daea65464fa70523202
-  data.tar.gz: 24b5731caac076b56137652e1aef1811eb7af6e3
+  metadata.gz: b21c51283eacfaf1a20c154f7999eb8843e310e6
+  data.tar.gz: a9e649da99e7b72785265b348d1534907bd74262
 SHA512:
-  metadata.gz: 229d38b0eb040f5bc90e6eed6f2e173411647b1195d5544c0aeb1f3dc632f0f81dfb7d7a637b5b879f2de74c7d8dece3f71bf1e53e981df03799a962b024397d
-  data.tar.gz: d4c9b695e64e7ebb188997f1b0491e5e27268a838c9e1f7b902c8837f6801faa31c14cfed2727a4bb068209ffa3fda762996b33df5caed284bb328236144046a
+  metadata.gz: c36be5a77381a5bcab17dc5bf313c35ddfb239ef67b27f00358d530cf4f2dc38722bd54db466f859dc906cc2616b4ee1d9b3414a6f7bb0f306394e6a6c042966
+  data.tar.gz: 007622bcea83aea25e888c798885333ae35d1af3c50bb315f1665cc3a42552f2aa57f7da49607ab84a81e554286b162b8e56dabb49f6297c8d4b955fd3a12111

data/README.md

@@ -17,9 +17,9 @@ Provides a subclass of Hash and a wrapper around Rails' serialize attribute for
 Arand new Metadata objects act just like hashes:
 
     h = Metadata.new
-    h 
+    h
     => {}
-    
+
 Accessing nested data requires no wrapping conditions checking for existence of the rquested data:
 
     h.outer.inner
@@ -29,18 +29,23 @@ Possible real-word example:
 
     if (min_numbers = h.password_rules.formats.numbers.minimum).present?
       # some code using min_numbers
-    else 
+    else
       # data doesn't exist in h
-      
+
       h.password_rules.formats.numbers.minimum = 1
-      # h 
+      # h
       # => { password_rules: { formats: { numbers: { minimum: 1 } } } }
     end
 
+Convert an existing hash to metadata
+
+    {a: 1}.to_metadata.a
+    # => 1
+
 #### Access to values stored in nested hashes via method call syntax
 
     h = Metadata.new( { outer: { inner: { hash_key: "value" } } } )
-    
+
     h.outer.inner.hash_key
     => "value"
 
@@ -49,7 +54,7 @@ Possible real-word example:
     h = Metadata.new
     h
     => {}
-    
+
     h.outer.inner = 2
     h
     => { outer: { inner: 2 } }

data/lib/metahash/metaclass.rb

@@ -2,30 +2,32 @@
 # allows the adding of methods to instances,
 # but not the entire set of instances for a
 # particular class
-module Metaclass
-  # The hidden singleton lurks behind everyone
-  def metaclass
-    class << self
-      self
+module MetaHash
+  module Metaclass
+    # The hidden singleton lurks behind everyone
+    def metaclass
+      class << self
+        self
+      end
     end
-  end
 
-  def meta_eval(&block)
-    metaclass.instance_eval(&block)
-  end
+    def meta_eval(&block)
+      metaclass.instance_eval(&block)
+    end
 
-  # Adds methods to a metaclass
-  def meta_def(name, &block)
-    meta_eval {
-      define_method(name, &block)
-    }
-  end
+    # Adds methods to a metaclass
+    def meta_def(name, &block)
+      meta_eval {
+        define_method(name, &block)
+      }
+    end
 
-  # unused
-  # Defines an instance method within a class
-  # def class_def(name, &block)
-  #   class_eval {
-  #     define_method(name, &block)
-  #   }
-  # end
+    # unused
+    # Defines an instance method within a class
+    # def class_def(name, &block)
+    #   class_eval {
+    #     define_method(name, &block)
+    #   }
+    # end
+  end
 end

data/lib/metahash/metadata.rb

@@ -20,7 +20,7 @@
 #     h[:inner][:key] == "value"
 #
 class Metadata < Hash
-  include Metaclass
+  include MetaHash::Metaclass
   # in the event we are overriding a method, have a way to
   # get back to the original
   METHOD_BACKUP_KEY = "metadata_original_"
@@ -67,14 +67,12 @@ class Metadata < Hash
   # @raise [ArgumentError] if one of the keys is method of Hash
   def method_missing(method_name, *args)
     # check for assignment
-    if (key = method_name.to_s).include?("=")
-      key = key.chop.to_sym
-
-      assign_value(key, args[0])
+    if method_name.to_s[-1] == "="
+      assign_value(method_name, args[0])
     else
       value = self[method_name]
-      if not value
-        @empty_nested_hashes << method_name.to_sym
+      if value.nil?
+        @empty_nested_hashes << method_name
         value = self
       end
       value
@@ -84,19 +82,23 @@ class Metadata < Hash
 
   # Metdata has indifferent access
   def [](key)
+    # self.send(key)
     super(key.to_sym)
   end
 
   # # Metadata has indifferent access,
   # # so just say that all the keys are symbols.
   def []=(key, value)
+    if value.is_a?(Hash) && !value.is_a?(Metadata)
+      value = Metadata.new(value)
+    end
     super(key.to_sym, value)
   end
 
   # tests the ability to use this key as a key in a hash
   # @param [Symbol] key
   # @return [Boolean] whether or not this can be used as a hash key
-  def valid_key?(key)
+  def key_not_in_use?(key)
     not self.respond_to?(key)
   end
 
@@ -126,9 +128,13 @@ class Metadata < Hash
 
   private
 
+  # @param [Symbol] key "field_name=""
   def assign_value(key, value)
+    key = key.to_s.chop
     deepest_metadata = self
 
+    value = Metadata.new(value) if value.is_a?(Hash)
+
     if not @empty_nested_hashes.empty?
       @empty_nested_hashes.each do |key|
         deepest_metadata = deepest_metadata[key] = Metadata.new

data/lib/metahash/version.rb

@@ -1,3 +1,3 @@
 module MetaHash
-  VERSION = "1.1.0"
+  VERSION = "1.1.2"
 end

data/spec/hash_spec.rb

@@ -4,6 +4,13 @@ describe Hash do
   context "to_metadata" do
     subject(:h){ { a: 1 }.to_metadata }
 
-    it { is_expected.to be_a Metadata }
+    it "is a Metadata" do
+      expect(h).to be_a Metadata
+    end
+
+    it "behaves like a Metdata" do
+      expect(h.a).to eq 1
+    end
   end
+
 end

data/spec/metadata_spec.rb

@@ -33,16 +33,21 @@ describe Metadata do
         expect(m["b"]).to eq 2
       end
 
+      it "converts a hash to metadata" do
+        m[:h] = { a: 2 }
+        expect(m.h).to be_a Metadata
+      end
+
     end
 
-    describe "valid_key?" do
+    describe "key_not_in_use?" do
 
       it "is true for keys that aren't methods" do
-        expect(m.valid_key?(:b)).to eq true
+        expect(m.key_not_in_use?(:b)).to eq true
       end
 
       it "is false for existing methods" do
-        expect(m.valid_key?(:to_hash)).to eq false
+        expect(m.key_not_in_use?(:to_hash)).to eq false
       end
     end
 
@@ -122,35 +127,69 @@ describe Metadata do
   context "assigns values" do
     let(:m){Metadata.new}
 
-    it "sets a non-exsiting deep value" do
-      m.a.b = 2
-      expect(m.a.b).to eq 2
-    end
 
-    it "sets with specific keys" do
-      m.a.min = 2
-      m.a.max = 3
-      expect(m.a.min).to eq 2
-      expect(m.a.max).to eq 3
+    it "allows multiple ways of assigning the same key" do
+      m.a = "1"
+      m[:a] = "2"
+      expect(m.a).to eq "1"
     end
 
-    it "overrides existing methods if set" do
-      m.keys = 2
-      expect(m.keys).to eq 2
-    end
+    context "via attribute assignment style" do
+      it "sets a non-exsiting deep value" do
+        m.a.b = 2
+        expect(m.a.b).to eq 2
+      end
 
-    it "overrides existing methods if set to non-simple objects" do
-      m.a.b = 2
-      m.a.keys = 3
-      expect(m.a.keys).to eq 3
+      it "sets with specific keys" do
+        m.a.min = 2
+        m.a.max = 3
+        expect(m.a.min).to eq 2
+        expect(m.a.max).to eq 3
+      end
+
+      it "overrides existing methods if set" do
+        m.keys = 2
+        expect(m.keys).to eq 2
+      end
+
+      it "overrides existing methods if set to non-simple objects" do
+        m.a.b = 2
+        m.a.keys = 3
+        expect(m.a.keys).to eq 3
+      end
+
+      it "can overrid min and max of deeply nested hashes" do
+        m.password_rules.formats.digits.max = 3
+        m.password_rules.formats.digits.min = 2
+
+        expect(m.password_rules.formats.digits.min).to eq 2
+        expect(m.password_rules.formats.digits.max).to eq 3
+      end
+
+      it "handles falsy values" do
+        m.a = false
+        expect(m.a).to eq false
+      end
+
+      it "converts hashes to metadata" do
+        m.a = { sub: 2 }
+        expect(m.a.sub).to eq 2
+      end
     end
 
-    it "can overrid min and max of deeply nested hashes" do
-      m.password_rules.formats.digits.max = 3
-      m.password_rules.formats.digits.min = 2
+    context "via hash style" do
+      it "handels falsy values" do
+        m[:a] = false
+        expect(m[:a]).to eq false
+        expect(m.a).to eq false
+      end
 
-      expect(m.password_rules.formats.digits.min).to eq 2
-      expect(m.password_rules.formats.digits.max).to eq 3
+      it "sets a non-existing deep value" do
+        pending "not yet supported"
+        m[:a][:b] = 2
+        expect(m[:a][:b]).to eq 2
+        expect(m.a.b).to eq 2
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metahash-rb
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.2
 platform: ruby
 authors:
 - L. Preston Sego III
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-12 00:00:00.000000000 Z
+date: 2014-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -144,7 +144,7 @@ rubyforge_project:
 rubygems_version: 2.4.1
 signing_key: 
 specification_version: 4
-summary: MetaHash-1.1.0
+summary: MetaHash-1.1.2
 test_files:
 - spec/hash_spec.rb
 - spec/metadata_spec.rb