metadata_presenter 3.3.5 → 3.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de5dd13825b342affe023f56997462ed149f8b47b8893ef9f6fdfd8682486c78
-  data.tar.gz: 920e393d3abccb2c5cb7f8c54af1f3aae85a2e7792282ccf0afa58fd1229905e
+  metadata.gz: 34190d9913834c0b264dfb8e315d45e46b72682ee33256e4c7640960b7ce40f9
+  data.tar.gz: e1ac014de5cb62a356a35c76796f9a912baea5881a6153cfe0b0eb9c4322b167
 SHA512:
-  metadata.gz: a4fb4a7d1b420edf3883e25b39848b9cf7cb85918e2a6fe4519daea4d0623ae4f2e2d8fa5d48f38b4c1adfbd5f83b74bfd65ebe4c5105b124a3e6e2a93a6a0d8
-  data.tar.gz: a03c51b5b0e0a8ab88c80ff50a4f747a813800bfe428527e6666ef785835e45e172bd62335632195e7f33bafac8a2cd654bc658f8a5649406401db68d495652e
+  metadata.gz: 9e736c7788345ea5b7542131dbe423feb2a6127498c72aea97730e4453f4627ef2463af779624b09da7fc605649699444bd2c17b2c9bf53442628bdd15523d2d
+  data.tar.gz: e995e5a75ce1f93a5ab1af7ba617082c39d82f5ae32cff527b184dfcd75363814f0626a437247a7d7866b6ee19db14b3514018ec200899318390a30cdd0cbd44

data/app/models/metadata_presenter/grid.rb

@@ -112,7 +112,7 @@ module MetadataPresenter
         destinations_count = service.branches.map do |branch|
           exiting_destinations_from_branch(branch).count
         end
-        destinations_count.sum
+        [destinations_count.sum, 1].max # ensure there is always 1 row
       end
     end
 
@@ -294,12 +294,12 @@ module MetadataPresenter
     # Therefore replace any Pointers after the first one with Spacers.
     def trim_to_first_pointer
       max_potential_rows.times do |row|
-        first_index_of = first_pointer(row)
-        next unless first_index_of
+        index_of_first_pointer = first_pointer(row)
+        next unless index_of_first_pointer
 
-        next_column = first_index_of + 1
-        @ordered.drop(next_column).each do |column|
-          column[row] = MetadataPresenter::Spacer.new
+        starting_column = index_of_first_pointer + 1
+        @ordered.drop(starting_column).each.with_index(starting_column) do |_, column_index|
+          @ordered[column_index][row] = MetadataPresenter::Spacer.new
         end
       end
     end

data/app/models/metadata_presenter/page_answers.rb

@@ -44,7 +44,8 @@ module MetadataPresenter
 
       return {} unless file_details
 
-      if file_details.is_a?(ActionController::Parameters)
+      case file_details
+      when ActionController::Parameters
         unless file_details.permitted?
           Rails.logger.warn("[PageAnswers#upload_answer] Permitting unfiltered params in component `#{component_id}`")
           file_details.permit!
@@ -53,7 +54,7 @@ module MetadataPresenter
         file_details.merge(
           'original_filename' => sanitize_filename(file_details['original_filename'])
         )
-      elsif file_details.is_a?(Hash)
+      when Hash
         file_details.merge(
           'original_filename' => sanitize_filename(file_details['original_filename'])
         )

data/lib/metadata_presenter/version.rb

@@ -1,3 +1,3 @@
 module MetadataPresenter
-  VERSION = '3.3.5'.freeze
+  VERSION = '3.3.6'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metadata_presenter
 version: !ruby/object:Gem::Version
-  version: 3.3.5
+  version: 3.3.6
 platform: ruby
 authors:
 - MoJ Forms
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-12-04 00:00:00.000000000 Z
+date: 2023-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: govuk_design_system_formbuilder