metadata_presenter 0.6.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 895460d73f90e04b682711defdba71d7cce582761efadc78171c31291304220b
-  data.tar.gz: 7de5ba6ad3af9c30665bdf676dfc8fdc22cbd468b434c8486e4af5716e0e9224
+  metadata.gz: 9281493cf00e63b59db192a9dcc1f47192ed7d6443df62d74c326f742c90719a
+  data.tar.gz: a97f03eebbaa1a4bdd86ee988344705acab5197cebaccae1d756b0f841cceb10
 SHA512:
-  metadata.gz: df217acae89ba5d92dfbed9a452a5f5d7aaed4d59fe2249664c31198e83db2b457b0aa37056e2ddcd6297700f44dcb050c8253657fbdd3ee3732c659b036aa1c
-  data.tar.gz: d180c076e54ea004b37b9e922e3533391f8f3b937b8e9232662cbb1bb050e25ec6b88e6393b7ca5ff684338906dfb89177121381b33985bf91dd096bde1be85d
+  metadata.gz: ce1d3450e7c8daf6957c8c961436cd33438f03ec9d760952bae673e8dacc32b0fa5f451fc17fc0e9e22da6501656c5062cdb221482bffb68bcd77356e4bf16d4
+  data.tar.gz: 312895b3acf5acb4dd7c7de5ffa13a54f2888745a59a13f83b2f6aaa2d97cacbe91107d5abfaad46f724b04401335817a9380d22b9a5067d8e42f53f21eeb425

data/app/validators/metadata_presenter/base_validator.rb

@@ -42,6 +42,8 @@ module MetadataPresenter
     end
 
     def valid?
+      return true if user_answer.blank? && allow_blank?
+
       if invalid_answer?
         error_message = custom_error_message || default_error_message
         page.errors.add(component.id, error_message)
@@ -62,6 +64,12 @@ module MetadataPresenter
       message % error_message_hash if message.present?
     end
 
+    # @return [String] user answer for the specific component
+    #
+    def user_answer
+      answers[component.name]
+    end
+
     # The default error message will be look using the schema key.
     # Assuming the schema key is 'grogu' then the default message
     # will look for 'error.grogu.value'.
@@ -115,5 +123,15 @@ module MetadataPresenter
         schema_key.to_sym => component.validation[schema_key]
       }
     end
+
+    # Method signature to be overwrite in the subclass if you do not want to allow
+    # blank values. We should not allow blank when performing the required
+    # validation.
+    #
+    # @return [TrueClass]
+    #
+    def allow_blank?
+      true unless self.class.name.demodulize.include?('RequiredValidator')
+    end
   end
 end

data/app/validators/metadata_presenter/max_length_validator.rb

@@ -1,7 +1,7 @@
 module MetadataPresenter
   class MaxLengthValidator < BaseValidator
     def invalid_answer?
-      answers[component.name].to_s.size > component.validation[schema_key]
+      user_answer.to_s.size > component.validation[schema_key]
     end
   end
 end

data/app/validators/metadata_presenter/min_length_validator.rb

@@ -1,7 +1,7 @@
 module MetadataPresenter
   class MinLengthValidator < BaseValidator
     def invalid_answer?
-      answers[component.name].to_s.size < component.validation[schema_key]
+      user_answer.to_s.size < component.validation[schema_key]
     end
   end
 end

data/app/validators/metadata_presenter/number_validator.rb

@@ -0,0 +1,7 @@
+module MetadataPresenter
+  class NumberValidator < BaseValidator
+    def invalid_answer?
+      Float(user_answer, exception: false).blank?
+    end
+  end
+end

data/app/validators/metadata_presenter/required_validator.rb

@@ -1,7 +1,7 @@
 module MetadataPresenter
   class RequiredValidator < BaseValidator
     def invalid_answer?
-      answers[component.name].blank?
+      user_answer.blank?
     end
   end
 end

data/app/validators/metadata_presenter/validate_answers.rb

@@ -31,18 +31,7 @@ module MetadataPresenter
     def component_validations(component)
       return [] if component.validation.blank?
 
-      component.validation.reject do |_, value|
-        value.blank? ||
-        (optional_question?(component) && question_not_answered?)
-      end.keys
-    end
-
-    def optional_question?(component)
-      component.validation['required'] == false
-    end
-
-    def question_not_answered?
-      answers.values.any?(&:blank?)
+      component.validation.select { |_,value| value.present? }.keys
     end
   end
 end

data/app/views/metadata_presenter/component/_number.html.erb

@@ -0,0 +1,8 @@
+<%=
+  f.govuk_text_field component.id.to_sym,
+    label: { text: component.label },
+    hint: { text: component.hint },
+    name: "answers[#{component.name}]",
+    value: answer(component.name),
+    width: component.width_class_input.to_i
+%>

data/default_metadata/component/number.json

@@ -0,0 +1,12 @@
+{
+  "_id": "component.number",
+  "_type": "number",
+  "errors": {},
+  "hint": "Component hint",
+  "label": "Component label",
+  "name": "component-name",
+  "width_class_input": "10",
+  "validation": {
+    "number": true
+  }
+}

data/default_metadata/component/radios.json

@@ -0,0 +1,10 @@
+{
+  "_id": "component.radios",
+  "_type": "radios",
+  "errors": {},
+  "hint": "Component hint",
+  "label": "Component label",
+  "items": [],
+  "name": "component-name",
+  "legend": "Required legend"
+}

data/default_metadata/definition/radio.json

@@ -0,0 +1,6 @@
+{
+  "_id": "definition.radio",
+  "_type": "radio",
+  "label": "Required label",
+  "value": "radio-value"
+}

data/default_metadata/string/error.number.json

@@ -0,0 +1,6 @@
+{
+  "_id": "error.number",
+  "_type": "string.error",
+  "description": "Input (number) is not a number",
+  "value": "Enter a number for %{control}"
+}

data/fixtures/version.json

@@ -124,6 +124,28 @@
       "heading": "Parent name",
       "url": "/parent-name"
     },
+    {
+      "_id": "page.your_age",
+      "url": "your-age",
+      "_type":"page.singlequestion",
+      "_uuid":"59d1326c-32e6-45e9-b57a-bcc8e2fb6b2c",
+      "heading":"Your age",
+      "components": [
+        {
+          "_id": "your_age_number_1",
+          "hint": "Component hint",
+          "name": "your_age_number_1",
+          "_type": "number",
+          "label": "Your age",
+          "errors": {},
+          "validation": {
+            "number": true,
+            "required": true
+          },
+          "width_class_input": "10"
+        }
+      ]
+    },
     {
       "_uuid": "7b748584-100e-4d81-a54a-5049190136cc",
       "_id": "page.family_hobbies",
@@ -143,6 +165,37 @@
       "heading": "Family Hobbies",
       "url": "/family-hobbies"
     },
+    {
+      "_uuid": "4251b25e-08de-4dcb-8f2f-dd9848dcdca6",
+      "_id": "page.radio-buttons",
+      "_type": "page.singlequestion",
+      "components": [
+        {
+          "_id": "radio-buttons_radios_1",
+          "_type": "radios",
+          "errors": {},
+          "hint": "Component hint",
+          "label": "Component label",
+          "items": [
+            {
+              "_id": "radio-buttons_radio_1",
+              "_type": "radio",
+              "label": "Yes",
+              "value": "radio_value_1"
+            },
+            {
+              "_id": "radio-buttons_radio_2",
+              "_type": "radio",
+              "label": "No",
+              "value": "radio_value_2"
+            }
+          ],
+          "name": "radio-buttons_radios_1"
+        }
+      ],
+      "heading": "Parent name",
+      "url": "/radio-buttons"
+    },
     {
       "_uuid": "e819d0c2-7062-4997-89cf-44d26d098404",
       "_id": "page._check-answers",

data/lib/metadata_presenter/version.rb

@@ -1,3 +1,3 @@
 module MetadataPresenter
-  VERSION = '0.6.1'
+  VERSION = '0.8.2'
 end

data/schemas/component/number.json

@@ -0,0 +1,29 @@
+{
+  "$id": "http://gov.uk/schema/v1.0.0/number",
+  "_name": "component.number",
+  "title": "Number",
+  "description": "Let users enter a number",
+  "type": "object",
+  "properties": {
+    "_type": {
+      "const": "number"
+    },
+    "name": {
+      "inputType": "number"
+    },
+    "width_class_input": {
+      "default": "10"
+    }
+  },
+  "allOf": [
+    {
+      "$ref": "definition.field"
+    },
+    {
+      "$ref": "validations#/definitions/number_bundle"
+    },
+    {
+      "$ref": "definition.width_class.input"
+    }
+  ]
+}

data/schemas/component/radios.json

@@ -0,0 +1,37 @@
+{
+  "$id": "http://gov.uk/schema/v1.0.0/radios",
+  "_name": "component.radios",
+  "title": "Radios",
+  "description": "Let users select one option from a list",
+  "type": "object",
+  "properties": {
+    "_type": {
+      "const": "radios"
+    },
+    "items": {
+      "title": "Options",
+      "description": "Items that users can select",
+      "type": "array",
+      "items": {
+        "$ref": "definition.radio"
+      }
+    }
+  },
+  "allOf": [
+    {
+      "$ref": "definition.fieldset"
+    },
+    {
+      "$ref": "definition.name"
+    }
+  ],
+  "transforms": {
+    "namespace": {
+      "propagation": "items[*].conditional_component"
+    }
+  },
+  "required": [
+    "name",
+    "items"
+  ]
+}

data/schemas/{text → component}/text.json

@@ -1,6 +1,6 @@
 {
   "$id": "http://gov.uk/schema/v1.0.0/text",
-  "_name": "text",
+  "_name": "component.text",
   "title": "Text",
   "description": "Let users enter text that’s no longer than a single line",
   "type": "object",

data/schemas/{textarea → component}/textarea.json

@@ -1,6 +1,6 @@
 {
-  "_id": "component.textarea",
-  "_name": "textarea",
+	"$id": "http://gov.uk/schema/v1.0.0/textarea",
+	"_name": "component.textarea",
   "title": "Textarea",
   "description": "Let users enter text that can be longer than a single line",
   "type": "object",

data/schemas/definition/conditionalcomponent.json

@@ -0,0 +1,12 @@
+{
+  "$id": "http://gov.uk/schema/v1.0.0/definition/conditionalcomponent",
+  "_name": "definition.conditionalcomponent",
+  "nestable": true,
+  "title": "Conditional component",
+  "description": "Component revealed when user chooses option",
+  "allOf": [
+    {
+      "$ref": "definition.component"
+    }
+  ]
+}

data/schemas/definition/fieldset.json

@@ -0,0 +1,37 @@
+{
+  "$id": "http://gov.uk/schema/v1.0.0/definition/fieldset",
+  "_name": "definition.fieldset",
+  "title": "Fieldset",
+  "description": "Group related form inputs",
+  "type": "object",
+  "category": [
+    "control",
+    "fieldset"
+  ],
+  "properties": {
+    "_type": {
+      "const": "fieldset"
+    },
+    "legend": {
+      "title": "Legend",
+      "description": "Text to use in fieldset legend",
+      "type": "string"
+    },
+    "hint": {
+      "title": "Hint",
+      "description": "Text to help users answer a question - appears in grey under the legend",
+      "type": "string"
+    }
+  },
+  "allOf": [
+    {
+      "$ref": "definition.repeatable"
+    },
+    {
+      "$ref": "definition.grouping"
+    }
+  ],
+  "required": [
+    "legend"
+  ]
+}

data/schemas/definition/grouping.json

@@ -0,0 +1,27 @@
+{
+  "$id": "http://gov.uk/schema/v1.0.0/definition/grouping",
+  "_name": "definition.grouping",
+  "title": "Grouping definition",
+  "allOf": [
+    {
+      "$ref": "definition.component"
+    },
+    {
+      "$ref": "definition.components"
+    },
+    {
+      "$ref": "definition.namespace"
+    },
+    {
+      "$ref": "definition.html_attributes"
+    }
+  ],
+  "category": [
+    "grouping"
+  ],
+  "transforms": {
+    "namespace": {
+      "propagation": "components[?(@.$control || @.$grouping)]"
+    }
+  }
+}

data/schemas/definition/option.json

@@ -0,0 +1,35 @@
+{
+  "$id": "http://gov.uk/schema/v1.0.0/definition/option",
+  "_name": "definition.option",
+  "title": "Option definition",
+  "properties": {
+    "value": {
+      "title": "Option value",
+      "description": "Value captured by system when users choose this option",
+      "type": "string"
+    },
+    "hasDivider": {
+      "title": "Option divider",
+      "description": "Whether to display a textual divider before the option - defaults to ‘or’",
+      "type": "boolean"
+    }
+  },
+  "allOf": [
+    {
+      "$ref": "definition.block"
+    },
+    {
+      "$ref": "definition.label"
+    },
+    {
+      "$ref": "definition.namespace"
+    }
+  ],
+  "required": [
+    "value"
+  ],
+  "category": [
+    "component",
+    "option"
+  ]
+}

data/schemas/definition/radio.json

@@ -0,0 +1,30 @@
+{
+  "$id": "http://gov.uk/schema/v1.0.0/definition/radio",
+  "_name": "definition.radio",
+  "idSeed": "value",
+  "title": "Radio option",
+  "description": "Component that provides a radio option",
+  "type": "object",
+  "properties": {
+    "_type": {
+      "const": "radio"
+    },
+    "hint": {
+      "title": "Hint text",
+      "description": "Text to help users understand an option - appears in grey under the label",
+      "type": "string",
+      "content": true
+    },
+    "conditional_component": {
+      "$ref": "definition.conditionalcomponent"
+    }
+  },
+  "allOf": [
+    {
+      "$ref": "definition.option"
+    }
+  ],
+  "required": [
+    "label"
+  ]
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metadata_presenter
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.8.2
 platform: ruby
 authors:
 - MoJ Online
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-09 00:00:00.000000000 Z
+date: 2021-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -240,11 +240,13 @@ files:
 - app/validators/metadata_presenter/base_validator.rb
 - app/validators/metadata_presenter/max_length_validator.rb
 - app/validators/metadata_presenter/min_length_validator.rb
+- app/validators/metadata_presenter/number_validator.rb
 - app/validators/metadata_presenter/required_validator.rb
 - app/validators/metadata_presenter/validate_answers.rb
 - app/validators/metadata_presenter/validate_schema.rb
 - app/views/errors/404.html
 - app/views/layouts/metadata_presenter/application.html.erb
+- app/views/metadata_presenter/component/_number.html.erb
 - app/views/metadata_presenter/component/_text.html.erb
 - app/views/metadata_presenter/component/_textarea.html.erb
 - app/views/metadata_presenter/header/show.html.erb
@@ -256,10 +258,13 @@ files:
 - config/initializers/default_metadata.rb
 - config/initializers/schemas.rb
 - config/routes.rb
+- default_metadata/component/number.json
+- default_metadata/component/radios.json
 - default_metadata/component/text.json
 - default_metadata/component/textarea.json
 - default_metadata/config/meta.json
 - default_metadata/config/service.json
+- default_metadata/definition/radio.json
 - default_metadata/page/checkanswers.json
 - default_metadata/page/confirmation.json
 - default_metadata/page/singlequestion.json
@@ -267,6 +272,7 @@ files:
 - default_metadata/service/base.json
 - default_metadata/string/error.max_length.json
 - default_metadata/string/error.min_length.json
+- default_metadata/string/error.number.json
 - default_metadata/string/error.required.json
 - fixtures/non_finished_service.json
 - fixtures/service.json
@@ -276,6 +282,10 @@ files:
 - lib/metadata_presenter/test_helpers.rb
 - lib/metadata_presenter/version.rb
 - lib/tasks/metadata_presenter_tasks.rake
+- schemas/component/number.json
+- schemas/component/radios.json
+- schemas/component/text.json
+- schemas/component/textarea.json
 - schemas/condition/condition.json
 - schemas/config/meta.json
 - schemas/config/service.json
@@ -290,22 +300,26 @@ files:
 - schemas/definition/condition.text.json
 - schemas/definition/condition.value_type.json
 - schemas/definition/conditional.boolean.json
+- schemas/definition/conditionalcomponent.json
 - schemas/definition/conditions.all.json
 - schemas/definition/conditions.any.json
 - schemas/definition/conditions.exactly.json
 - schemas/definition/control.json
 - schemas/definition/data.json
 - schemas/definition/field.json
+- schemas/definition/fieldset.json
+- schemas/definition/grouping.json
 - schemas/definition/html_attributes.json
 - schemas/definition/label.json
 - schemas/definition/link_list.json
 - schemas/definition/name.json
 - schemas/definition/namespace.json
 - schemas/definition/next_page.json
+- schemas/definition/option.json
 - schemas/definition/page.content.json
 - schemas/definition/page.form.json
 - schemas/definition/page.json
-- schemas/definition/page.singlequestion.json
+- schemas/definition/radio.json
 - schemas/definition/repeatable.json
 - schemas/definition/width_class.input.json
 - schemas/definition/width_class.json
@@ -313,13 +327,12 @@ files:
 - schemas/link/link.json
 - schemas/page/checkanswers.json
 - schemas/page/confirmation.json
+- schemas/page/singlequestion.json
 - schemas/page/start.json
 - schemas/request/service.json
 - schemas/service/base.json
 - schemas/service/configuration.json
 - schemas/service/locale.json
-- schemas/text/text.json
-- schemas/textarea/textarea.json
 - schemas/validations/validations.json
 homepage: https://moj-online.service.justice.gov.uk
 licenses: