metadata_presenter 0.1.8 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc59d58800c23dd0836423c3d0f02b76516db564afd6343d989291f23cddce3b
-  data.tar.gz: '078b3a6ab2888fb5a1f6f6ba8f925af66713469787af6991df362e1c19fcf245'
+  metadata.gz: 8d63e1cea66a08843a4d86c36815aaaf649740b9294f3f2cb6d28c2a5d3419b7
+  data.tar.gz: 107523910c75eeeb0b6c370a33888aaf606003062a1f9eb6484e39daab72c94f
 SHA512:
-  metadata.gz: cdee22833e4d58cad16595fcd5b664be8b28641a4c0aeed6b7f5cb19f06a481330bfbb53a429442d8a72faf70a4dec97bffbdea0f368774d472377690635fdde
-  data.tar.gz: 7afb80b5201bdf97117c79bb604eba016207b4ec2caf7bad7ebf64a6426fdb51b2ccf4211bda81c8de0e33bd43d50dea6369a84cecf3987632191e6913037f4b
+  metadata.gz: 3db0ce4844763159256923131e9889681865394462e0ddffde652b75b036e4a60894d2b417dbc700f6fb1644c970c1e130550b899b52a6500e0990cbdd0468b3
+  data.tar.gz: d9fd3ead4df126b0629d337950c1ebb30818369ebe826921f3be08b1a38983cbfdb9a2fafcbc388f837bea816ea345130728c01454647c19dc4114778b74473b

data/README.md

@@ -47,6 +47,7 @@ that you need to write the following methods in your controller:
 
 1. save_user_data
 2. load_user_data
+3. editable?
 
 The user answers can be accessed via `params[:answers]`.
 
@@ -63,6 +64,18 @@ An example of implementation:
  end
 ```
 
+The `editable?` is related if the pages and components could be editable in the
+mountable app:
+
+```ruby
+  class MyAwesomeController
+    def editable?
+      false
+    end
+    helper_method :editable?
+  end
+```
+
 ## Generate documentation
 
 Run `rake doc` and open the doc/index.html

data/app/controllers/metadata_presenter/answers_controller.rb

@@ -1,5 +1,7 @@
 module MetadataPresenter
   class AnswersController < EngineController
+    before_action :check_page_exists
+
     def create
       if page.validate_answers(answers_params)
         save_user_data # method signature
@@ -12,15 +14,16 @@ module MetadataPresenter
     private
 
     def page
-      @page ||= MetadataPresenter::Page.new(
-        service.find_page(params[:page_url]).metadata
-      )
+      @page ||= begin
+        current_page = service.find_page_by_url(page_url)
+        MetadataPresenter::Page.new(current_page.metadata) if current_page
+      end
     end
 
     def redirect_to_next_page
       next_page = NextPage.new(service).find(
         session: session,
-        current_page_url: params[:page_url]
+        current_page_url: page_url
       )
 
       if next_page.present?
@@ -38,5 +41,13 @@ module MetadataPresenter
     def answers_params
       params[:answers] ? params[:answers].permit! : {}
     end
+
+    def page_url
+      request.env['PATH_INFO']
+    end
+
+    def check_page_exists
+      not_found if page.blank?
+    end
   end
 end

data/app/controllers/metadata_presenter/pages_controller.rb

@@ -2,7 +2,7 @@ module MetadataPresenter
   class PagesController < EngineController
     def show
       @user_data = load_user_data # method signature
-      @page ||= service.find_page(request.env['PATH_INFO'])
+      @page ||= service.find_page_by_url(request.env['PATH_INFO'])
 
       if @page
         render template: @page.template

data/app/helpers/metadata_presenter/application_helper.rb

@@ -1,5 +1,23 @@
 module MetadataPresenter
   module ApplicationHelper
+    ## Display user answers on the view
+    ## When the user doesn't answered yet the component will be blank
+    # or with data otherwise, so doing the if in every output is not
+    # pratical.
+    #
+    # The below example search for 'first_name' in the user data instance
+    # variable as long your load_user_data in the controller sets the variable.
+    #
+    # @example
+    #   <%= a('first_name') %>
+    #
+    def a(component_key)
+      if @user_data.present?
+        @user_data[component_key]
+      end
+    end
+    alias answer a
+
     def to_markdown(text)
       (Kramdown::Document.new(text).to_html).html_safe
     end

data/app/models/metadata_presenter/component.rb

@@ -1,5 +1,5 @@
 class MetadataPresenter::Component < MetadataPresenter::Metadata
   def to_partial_path
-    "component/#{type}"
+    "metadata_presenter/component/#{type}"
   end
 end

data/app/models/metadata_presenter/metadata.rb

@@ -8,6 +8,10 @@ class MetadataPresenter::Metadata
     @metadata = OpenStruct.new(metadata)
   end
 
+  def to_json
+    self.to_h.to_json
+  end
+
   def id
     metadata._id
   end

data/app/models/metadata_presenter/next_page.rb

@@ -9,7 +9,7 @@ module MetadataPresenter
     def find(session:, current_page_url:)
       if session[:return_to_check_you_answer].present?
         session[:return_to_check_you_answer] = nil
-        service.pages.find { |page| page.type == 'page.summary' }
+        service.pages.find { |page| page.type == 'page.checkanswers' }
       else
         service.next_page(from: current_page_url)
       end

data/app/models/metadata_presenter/page.rb

@@ -6,10 +6,18 @@ module MetadataPresenter
       ValidateAnswers.new(page: self, answers: answers).valid?
     end
 
+    def uuid
+      _uuid
+    end
+
     def ==(other)
       id == other.id if other.respond_to? :id
     end
 
+    def editable_attributes
+      self.to_h.reject { |k,_| k.in?([:_id, :_type, :steps]) }
+    end
+
     def components
       metadata.components&.map do |component|
         MetadataPresenter::Component.new(component)

data/app/models/metadata_presenter/service.rb

@@ -7,12 +7,16 @@ class MetadataPresenter::Service < MetadataPresenter::Metadata
     pages.first
   end
 
-  def find_page(path)
-    pages.find { |page| page.url == path }
+  def find_page_by_url(url)
+    pages.find { |page| strip_slash(page.url) == strip_slash(url) }
+  end
+
+  def find_page_by_uuid(uuid)
+    pages.find { |page| page.uuid == uuid }
   end
 
   def next_page(from:)
-    current_page = find_page(from)
+    current_page = find_page_by_url(from)
     pages[pages.index(current_page) + 1] if current_page.present?
   end
 
@@ -25,4 +29,12 @@ class MetadataPresenter::Service < MetadataPresenter::Metadata
       page.type == 'page.confirmation'
     end
   end
+
+  private
+
+  def strip_slash(url)
+    return url if url == '/'
+
+    url.gsub(/^\//, '')
+  end
 end

data/app/views/metadata_presenter/component/_text.html.erb

@@ -3,5 +3,5 @@
     label: { text: component.label },
     hint: { text: component.hint },
     name: "answers[#{component.name}]",
-    value: @user_data[component.name]
+    value: answer(component.name)
 %>

data/app/views/metadata_presenter/page/{summary.html.erb → checkanswers.html.erb}

@@ -25,7 +25,7 @@
     <% end %>
 
     <%= form_for @page, url: reserved_submissions_path do |f| %>
-      <div data-block-id="page.summary.answers" data-block-type="answers">
+      <div data-block-id="page.checkanswers.answers" data-block-type="answers">
         <dl class="fb-block fb-block-answers govuk-summary-list">
           <% @service.pages.each do |page| %>
             <% Array(page.components).each do |component| %>
@@ -35,7 +35,7 @@
                 </dt>
 
                 <dd class="govuk-summary-list__value">
-                  <%= @user_data[component.name] %>
+                  <%=a component.name %>
                 </dd>
                 <dd class="govuk-summary-list__actions">
                 <%= link_to(
@@ -66,7 +66,7 @@
         </div>
       <% end %>
 
-      <button data-prevent-double-click="true" class="fb-block fb-block-actions govuk-button" data-module="govuk-button" data-block-id="actions" data-block-type="actions">
+      <button <%= 'disabled' if editable? %> data-prevent-double-click="true" class="fb-block fb-block-actions govuk-button" data-module="govuk-button" data-block-id="actions" data-block-type="actions">
         Accept and send application
       </button>
     <% end %>

data/app/views/metadata_presenter/page/singlequestion.html.erb

@@ -5,13 +5,13 @@
           <%= @page.heading.html_safe %>
       </h1>
 
-      <%= form_for @page, url: reserved_answers_path(@page.url) do |f| %>
+      <%= form_for @page, url: @page.url, method: :post do |f| %>
         <%= f.govuk_error_summary %>
         <% @page.components.each do |component| %>
           <%= render partial: component, locals: { component: component, f: f } %>
         <% end %>
 
-        <%= f.govuk_submit %>
+        <%= f.govuk_submit(disabled: editable?) %>
       <% end %>
     </div>
   </div>

data/app/views/metadata_presenter/page/start.html.erb

@@ -25,8 +25,8 @@
         </p>
       <%- end %>
 
-      <%= form_tag(reserved_answers_path(@page.url), method: :post) do %>
-        <button class='govuk-button govuk-button--start govuk-!-margin-top-2'>
+      <%= form_tag(@page.url, method: :post) do %>
+        <button <%= 'disabled' if editable? %> class='govuk-button govuk-button--start govuk-!-margin-top-2'>
         Start
           <svg class="govuk-button__start-icon" xmlns="http://www.w3.org/2000/svg" width="17.5" height="19" viewBox="0 0 33 40" aria-hidden="true" focusable="false">
             <path fill="currentColor" d="M0 0h13l20 20-20 20H0l20-20z" />

data/config/routes.rb

@@ -1,8 +1,10 @@
 MetadataPresenter::Engine.routes.draw do
   root to: 'service#start'
 
-  post '/reserved/:page_url/answers', to: 'answers#create', as: :reserved_answers
   post '/reserved/submissions', to: 'submissions#create', as: :reserved_submissions
   get '/reserved/change-answer', to: 'change_answer#create', as: :change_answer
+
+  post '/', to: 'answers#create'
+  match '*path', to: 'answers#create', via: :post
   match '*path', to: 'pages#show', via: :all
 end

data/default_metadata/page/{summary.json → checkanswers.json}

@@ -1,7 +1,8 @@
 {
-  "_id": "page.summary",
-  "_type": "page.summary",
+  "_id": "page.checkanswers",
+  "_type": "page.checkanswers",
   "heading": "Check your answers",
   "send_heading": "Now send your application",
-  "send_body": "By submitting this application you confirm that, to the best of your knowledge, the details you are providing are correct."
+  "send_body": "By submitting this application you confirm that, to the best of your knowledge, the details you are providing are correct.",
+  "components": []
 }

data/default_metadata/page/start.json

@@ -0,0 +1,10 @@
+{
+  "_id": "page.start",
+  "_type": "page.start",
+  "heading": "Service name goes here",
+  "lede": "This is your start page first paragraph. You can only have one paragraph here.",
+  "body": "Use this service to:\r\n\r\n* do something\r\n* update your name, address or other details\r\n* do something else\r\n\r\nRegistering takes around 5 minutes.",
+  "before_you_start": "###Before you start\r\nYou can also register by post.\r\n\r\nThe online service is also available in Welsh (Cymraeg).\r\n\r\nYou cannot register for this service if you’re in the UK illegally.",
+  "steps": [],
+  "url": "/"
+}

data/default_metadata/service/base.json

@@ -3,17 +3,6 @@
   "_type": "service.base",
   "service_name": "Service name",
   "configuration": {},
-  "pages": [
-    {
-      "_id": "page.start",
-      "_type": "page.start",
-      "heading": "Service name goes here",
-      "lede": "This is your start page first paragraph. You can only have one paragraph here.",
-      "body": "Use this service to:\r\n\r\n* do something\r\n* update your name, address or other details\r\n* do something else\r\n\r\nRegistering takes around 5 minutes.",
-      "before_you_start": "###Before you start\r\nYou can also register by post.\r\n\r\nThe online service is also available in Welsh (Cymraeg).\r\n\r\nYou cannot register for this service if you’re in the UK illegally.",
-      "steps": [],
-      "url": "/"
-    }
-  ],
+  "pages": [],
   "locale": "en"
 }

data/fixtures/service.json

@@ -35,6 +35,7 @@
   },
   "pages": [
     {
+      "_uuid": "9626b2e9-5ef0-4070-8331-ac55151b22c4",
       "_id": "page.start",
       "_type": "page.start",
       "heading": "Service name goes here",

data/fixtures/version.json

@@ -36,6 +36,7 @@
   },
   "pages": [
     {
+      "_uuid": "fa391697-ae82-4416-adc3-3433e54ce535",
       "_id": "page.start",
       "_type": "page.start",
       "heading": "Service name goes here",
@@ -52,6 +53,7 @@
       "url": "/"
     },
     {
+      "_uuid": "847c4a0c-1c5f-4391-8847-42c8d82f1d0b",
       "_id": "page.name",
       "_type": "page.singlequestion",
       "components": [
@@ -71,6 +73,7 @@
       "url": "/name"
     },
     {
+      "_uuid": "ccf49acb-ad33-4fd3-8a7e-f0594b86cc96",
       "_id": "page.email-address",
       "_type": "page.singlequestion",
       "heading": "Email address",
@@ -102,6 +105,7 @@
       "url": "/email-address"
     },
     {
+      "_uuid": "7b748584-100e-4d81-a54a-5049190136cc",
       "_id": "page.parent_name",
       "_type": "page.singlequestion",
       "components": [
@@ -121,8 +125,9 @@
       "url": "/parent-name"
     },
     {
+      "_uuid": "e819d0c2-7062-4997-89cf-44d26d098404",
       "_id": "page._check-answers",
-      "_type": "page.summary",
+      "_type": "page.checkanswers",
       "body": "Optional content",
       "heading": "Review your answer",
       "lede": "First paragraph",
@@ -132,6 +137,7 @@
       "url": "/check-answers"
     },
     {
+      "_uuid": "b238a22f-c180-48d0-a7d9-8aad2036f1f2",
       "_id": "page._confirmation",
       "_type": "page.confirmation",
       "body": "You'll receive a confirmation email",

data/lib/metadata_presenter/version.rb

@@ -1,3 +1,3 @@
 module MetadataPresenter
-  VERSION = '0.1.8'
+  VERSION = '0.4.0'
 end

data/schemas/definition/page.json

@@ -4,6 +4,10 @@
   "id_seed": "url",
   "title": "Page definition",
   "properties": {
+    "_uuid": {
+      "title": "Unique identifier of the page",
+      "description": "Used internally in the editor and the runner."
+    },
     "url": {
       "title": "URL",
       "description": "The page’s relative url - it must not contain any spaces",
@@ -95,6 +99,7 @@
     }
   ],
   "required": [
+    "_uuid",
     "url"
   ],
   "category": [

data/schemas/page/{summary.json → checkanswers.json}

@@ -1,12 +1,12 @@
 {
-  "$id": "http://gov.uk/schema/v1.0.0/page/summary",
-  "_name": "page.summary",
+  "$id": "http://gov.uk/schema/v1.0.0/page/checkanswers",
+  "_name": "page.checkanswers",
   "title": "Check answers",
   "description": "Let users check and change their answers before submitting",
   "type": "object",
   "properties": {
     "_type": {
-      "const": "page.summary"
+      "const": "page.checkanswers"
     },
     "section_heading": {
       "title": "Section heading",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metadata_presenter
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.4.0
 platform: ruby
 authors:
 - MoJ Online
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-20 00:00:00.000000000 Z
+date: 2021-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -247,20 +247,21 @@ files:
 - app/views/layouts/metadata_presenter/application.html.erb
 - app/views/metadata_presenter/component/_text.html.erb
 - app/views/metadata_presenter/header/show.html.erb
+- app/views/metadata_presenter/page/checkanswers.html.erb
 - app/views/metadata_presenter/page/confirmation.html.erb
 - app/views/metadata_presenter/page/form.html.erb
 - app/views/metadata_presenter/page/singlequestion.html.erb
 - app/views/metadata_presenter/page/start.html.erb
-- app/views/metadata_presenter/page/summary.html.erb
 - config/initializers/default_metadata.rb
 - config/initializers/schemas.rb
 - config/routes.rb
 - default_metadata/component/text.json
 - default_metadata/config/meta.json
 - default_metadata/config/service.json
+- default_metadata/page/checkanswers.json
 - default_metadata/page/confirmation.json
 - default_metadata/page/singlequestion.json
-- default_metadata/page/summary.json
+- default_metadata/page/start.json
 - default_metadata/service/base.json
 - default_metadata/string/error.max_length.json
 - default_metadata/string/error.min_length.json
@@ -308,9 +309,9 @@ files:
 - schemas/definition/width_class.json
 - schemas/errors/errors.json
 - schemas/link/link.json
+- schemas/page/checkanswers.json
 - schemas/page/confirmation.json
 - schemas/page/start.json
-- schemas/page/summary.json
 - schemas/request/service.json
 - schemas/service/base.json
 - schemas/service/configuration.json