metacrunch-elasticsearch 4.0.1 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54f127cb7af8ebc5f9b7246d0241994a499fad0d
-  data.tar.gz: f7fca4e9e60e2d2c6951147bb57f177dc21350e2
+  metadata.gz: a464a5a3f84b26ffa4009cfee481605da96c875d
+  data.tar.gz: 8e00dd3a71cc2112443672994e61e98f174ef9ac
 SHA512:
-  metadata.gz: 198b86f27ce9a318ea975201f95f837be6b56408d6c302d08ba29ba9ec3469868ff367959bcab670d147180a2cba9dae89a0c594ec0551ea807be938513aaa48
-  data.tar.gz: ef8828c5ff6eac6002edaaa0beca1cc7eb29125ca5251c53eab3a35ca21b25910dfd5a63afc3d2af70332f28a7142e8e5aa0b303720c932cd757d826031cfbd6
+  metadata.gz: 120cff49cbfe64a633be9aba66eb470a83b27a4cdb007cd6d4df8fea29c2c7f0d38f42b4ecf52b07ba5699a3b7052aa025915c778dfdaf5bf9897dd6b5ff0ba3
+  data.tar.gz: 7252049dc4fb97f097af07378af81e6562de53e455dc5a979072c7ce52193c3611fc2994c4c912cae9f3ceaa252c65fa3edf442fba1de80f85434897b11639cf

data/Readme.md

@@ -94,7 +94,6 @@ destination Metacrunch::Elasticsearch::Destination.new(elasticsearch [, OPTIONS]
 
 **Options**
 
-* `:raise_on_result_errors`: If set to `true` an error is raised if one of the bulk operations return with an error. Defaults to `false`.
 * `:result_callback`: You can set a `Proc` that gets called with the result from the bulk operation. Defaults to `nil`.
 * `:bulk_options`: A hash of options for the Eleasticsearch bulk API as described [here](https://github.com/elastic/elasticsearch-ruby/blob/master/elasticsearch-api/lib/elasticsearch/api/actions/bulk.rb). Setting `body` here will be ignored. Defaults to `{}`.
 

data/lib/metacrunch/elasticsearch/destination.rb

@@ -4,7 +4,7 @@ module Metacrunch
   class Elasticsearch::Destination
 
     DEFAULT_OPTIONS = {
-      raise_on_result_errors: false,
+      raise_on_result_errors: false, # deprecated
       result_callback: nil,
       bulk_options: {}
     }
@@ -12,6 +12,11 @@ module Metacrunch
     def initialize(elasticsearch_client, options = {})
       @client = elasticsearch_client
       @options = DEFAULT_OPTIONS.deep_merge(options)
+
+      @deprecator = ActiveSupport::Deprecation.new("5.0.0", "metacrunch-elasticsearch")
+      if @options[:raise_on_result_errors]
+        @deprecator.deprecation_warning("Option :raise_on_result_errors")
+      end
     end
 
     def write(data)
@@ -22,9 +27,6 @@ module Metacrunch
       bulk_options[:body] = data
       result = @client.bulk(bulk_options)
 
-      # Raise an exception if one of the results produced an error and the user wants to know about it
-      raise DestinationError.new(errors: result["errors"]) if result["errors"] && @options[:raise_on_result_errors]
-
       # if the user provided a callback proc, call it
       @options[:result_callback].call(result) if @options[:result_callback]&.respond_to?(:call)
     end
@@ -34,14 +36,4 @@ module Metacrunch
     end
 
   end
-
-  class Elasticsearch::DestinationError < StandardError
-
-    attr_reader :errors
-
-    def initialize(msg = nil, errors:)
-      @errors = errors
-    end
-
-  end
 end

data/lib/metacrunch/elasticsearch/version.rb

@@ -1,5 +1,5 @@
 module Metacrunch
   module Elasticsearch
-    VERSION = "4.0.1"
+    VERSION = "4.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: metacrunch-elasticsearch
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.1.0
 platform: ruby
 authors:
 - René Sprotte
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-12 00:00:00.000000000 Z
+date: 2017-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport