metaclean 1.0.2 → 4.0.1

data/lib/metaclean/qpdf.rb

@@ -1,17 +1,15 @@
 # frozen_string_literal: true
 
-# ───────────────────────────────────────────────────────────────────────────
 # Wrapper around `qpdf` — a PDF structural cleaner.
 #
-# Why qpdf in addition to mat2/ExifTool? PDFs can carry metadata in places
-# those two don't always reach: orphaned objects, unused image streams,
-# old revisions kept in the file. qpdf rebuilds the PDF from scratch using
-# only the objects actually referenced by the document. That's a great
-# final pass after the other tools have stripped the obvious metadata.
-# ───────────────────────────────────────────────────────────────────────────
+# Why qpdf on top of mat2/ExifTool? PDFs hide metadata in places those two
+# don't always reach: orphaned objects, unused image streams, old revisions.
+# qpdf rebuilds the PDF using only referenced objects — a final pass after the
+# other tools have stripped the obvious metadata.
 
 require 'open3'
 require 'fileutils'
+require 'securerandom'
 
 module Metaclean
   module Qpdf
@@ -20,21 +18,21 @@ module Metaclean
     def available?
       return @available if defined?(@available)
 
-      _out, _err, status = Open3.capture3('qpdf', '--version')
+      out, _err, status = Open3.capture3('qpdf', '--version')
       @available = status.success?
+      # `qpdf --version` prints "qpdf version 11.9.0" on its first line. We
+      # keep just the bare number (`.split.last`) so callers don't each have
+      # to post-process it — matching Exiftool.version / Mat2.version. Captured
+      # here so `version` reuses it instead of re-spawning the binary.
+      @version = @available ? out.lines.first.to_s.strip.split.last : nil
+      @available
     rescue Errno::ENOENT
+      @version = nil
       @available = false
     end
 
     def version
-      return nil unless available?
-
-      out, _err, status = Open3.capture3('qpdf', '--version')
-      # `qpdf --version` prints multiple lines starting with the version line.
-      # `.lines.first` grabs only that line.
-      status.success? ? out.lines.first.to_s.strip : nil
-    rescue Errno::ENOENT
-      nil
+      available? ? @version : nil
     end
 
     # Rebuilds a PDF in place. The qpdf flags here:
@@ -51,25 +49,31 @@ module Metaclean
     def rebuild!(path)
       raise Error, 'qpdf not available' unless available?
 
-      # Including `Process.pid` in the temp name avoids collisions if two
-      # metaclean processes happen to run at the same time on shared storage.
-      tmp = "#{path}.qpdf.tmp.#{Process.pid}"
+      src = Metaclean.safe_path(path)
+      tmp = tmp_path_for(path)
 
       _out, err, status = Open3.capture3(
         'qpdf', '--linearize', '--object-streams=generate',
-        '--remove-unreferenced-resources=yes', path.to_s, tmp
+        '--remove-unreferenced-resources=yes', src, Metaclean.safe_path(tmp)
       )
 
       # qpdf has a quirk: exit code 3 means "succeeded with warnings" (output
       # is still produced and valid). We treat that the same as success.
       success = status.success? || status.exitstatus == 3
-      unless success
-        File.delete(tmp) if File.exist?(tmp)
-        raise Error, "qpdf failed: #{err.strip}"
-      end
+      raise Error, "qpdf failed: #{err.strip}" unless success && File.exist?(tmp)
 
-      FileUtils.mv(tmp, path.to_s)
+      FileUtils.mv(tmp, src)
       true
+    ensure
+      # Interrupt-safety: drop the temp if we died (or failed) before the
+      # rename. On success it's already moved, so this is a no-op.
+      File.delete(tmp) if tmp && File.exist?(tmp)
+    end
+
+    # Short sibling temp in the same directory: same-fs rename, unpredictable
+    # name, and no risk of exceeding filename length by appending to a long PDF.
+    def tmp_path_for(path)
+      File.join(File.dirname(path), "#{Metaclean::TMP_MARKER}qpdf.#{Process.pid}.#{SecureRandom.hex(8)}.pdf")
     end
   end
 end