metaa 0.0.12 → 0.0.13

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    MWY1YmFjNmQ1N2U0ZjYyNDQ0MjhlMDFjYmQ3MzA5NGY4ZDZmZmU0MQ==
+  data.tar.gz: !binary |-
+    MzViZGQ3OGNhZWE4YzE1Njg1MDZjZTA2ZjJmMDc0NzcwZWMyNDYwYg==
+SHA512:
+  metadata.gz: !binary |-
+    ZWM3NTFlMmQwNjlkZTFjMTFiYmU4ZThmZTFlNTRhYTM1Njg2NzI4Y2E2NzBh
+    ZWM3YmM5NGIyZTAwMDUwMDM0YzhkYzA1YjgxZjU3NmU0NTJiOTBhZTEzNjk3
+    NjAzNzdlZDdiYjBmMGM0OTg2Y2QyODgzZTEzNDE1YjQzYTg1YmM=
+  data.tar.gz: !binary |-
+    MzQ1OWFmZWYzMWUyZWZjOTAzNGQxZjA0Zjg3MGFjZmRkOGRhZGQ5YTA4NGRk
+    N2JkZGUwM2ZmMWYwNjljZTI4MzNmY2IyNzAxMTVjZjg4ZjhhYjliZjZhYTFk
+    MjAzNTc2NGViYzk0MjU2YTg4ZWU1NTcxMTQ1ZDEyMzM2YjdmOWE=

data/README.md

@@ -24,8 +24,8 @@ After generated, the meta class will look like this:
 # app/meta/product_meta.rb
 class ProductMeta < Metaa::Meta
   def define_meta
-    # Define meta tags of your record here. Each definition will require a hash for the meta attributes,
-    #  and each attribute can be a string, symbol or lambda/proc, for example:
+    # Define meta tags of your record here.
+    # Each definition will require a hash for the meta attributes, for example:
     # meta name:    "title",
     #      content: object.title # you can access the record through 'object' variable
 

data/lib/generators/rails/templates/meta.rb

@@ -5,8 +5,8 @@ class <%= class_name %>Meta < <%= parent_class_name %>
 class <%= class_name %>
   <%- end -%>
   def define_meta
-    # Define meta tags of your record here. Each definition will require a hash for the meta attributes,
-    #  and each attribute can be a string, symbol or lambda/proc, for example:
+    # Define meta tags of your record here.
+    # Each definition will require a hash for the meta attributes, for example:
     # meta name:    "title",
     #      content: object.title # you can access to the model through 'object' method
 

data/lib/metaa.rb

@@ -3,7 +3,6 @@ require 'action_view'
 require "metaa/version"
 require 'metaa/tag'
 require 'metaa/tag_collection'
-require 'metaa/definition'
 require 'metaa/meta'
 require 'metaa/concern'
 require 'metaa/railtie' if defined?(Rails)

data/lib/metaa/meta.rb

@@ -6,27 +6,20 @@ module Metaa
       @object = object
     end
 
-    def meta(attributes = {})
-      definitions << Definition.new(attributes)
+    def tag_collection
+      @tag_collection ||= TagCollection.new
     end
 
-    def definitions
-      @definitions ||= []
+    def meta(attributes = {})
+      tag_collection.add(attributes)
     end
 
-    # lazy define meta tags then collect
-    def tag_collection
-      @tag_collection ||= begin
-        define_meta
-        TagCollection.new(
-          definitions.map do |definition|
-            definition.attributes_for(object)
-          end
-        )
-      end
+    def define_meta
+      raise NotImplementedError
     end
 
     def to_html
+      define_meta if tag_collection.empty?
       tag_collection.to_html
     end
   end

data/lib/metaa/tag_collection.rb

@@ -4,6 +4,14 @@ module Metaa
       add(tags)
     end
 
+    def tags
+      @tags ||= []
+    end
+
+    def empty?
+      tags.empty?
+    end
+
     def add(new_tags)
       new_tags = [new_tags] if !new_tags.is_a? Array
       new_tags.each do |tag|
@@ -12,10 +20,6 @@ module Metaa
       end
     end
 
-    def tags
-      @tags ||= []
-    end
-
     def to_html
       tags.map(&:to_html).join.html_safe
     end

data/lib/metaa/version.rb

@@ -1,3 +1,3 @@
 module Metaa
-  VERSION = "0.0.12"
+  VERSION = "0.0.13"
 end

data/spec/metaa/meta_spec.rb

@@ -4,25 +4,20 @@ module Metaa
   describe Meta do
     describe '#meta' do
       it 'defines a meta tag' do
-        klass = Class.new(Meta) do
-          def define_meta
-            meta name: 'title'
-          end
-        end
-
-        meta_obj = klass.new
-        meta_obj.define_meta # trigger due to lazy load
+        meta_obj = Class.new(Meta).new
+        meta_obj.meta name: 'title'
 
-        expect(meta_obj.definitions.length).to eq 1
+        tags = meta_obj.tag_collection.tags
+        expect(tags.length).to eq 1
 
-        definition = meta_obj.definitions.first
-        expect(definition.attributes).to eq({
+        tag = tags.first
+        expect(tag.attributes).to eq({
           name: 'title'
         })
       end
     end
 
-    describe '#tags' do
+    describe '#tag_collection' do
       it 'returns meta tags for an object' do
         klass = Class.new(Meta) do
           def define_meta
@@ -35,11 +30,7 @@ module Metaa
         object_mock = double title: 'a title'
         meta        = klass.new(object_mock)
 
-
-        expect(meta.tag_collection.tags.length).to eq 1
-
-        tag = meta.tag_collection.tags.first
-        expect(tag.to_html).to eq "<meta content=\"a title\" name=\"title\" property=\"text\" />"
+        expect(meta.tag_collection).to be_a TagCollection
       end
     end
 
@@ -57,6 +48,9 @@ module Metaa
         meta = klass.new(object_mock)
 
         expect(meta.to_html).to eq "<meta content=\"a title\" name=\"title\" property=\"text\" />"
+
+        # run it again would render the same result
+        expect(meta.to_html).to eq "<meta content=\"a title\" name=\"title\" property=\"text\" />"
       end
     end
   end

data/spec/metaa/tag_collection_spec.rb

@@ -2,14 +2,30 @@ require 'spec_helper'
 
 module Metaa
   describe TagCollection do
+    describe '#empty?' do
+      it 'returns empty if there is not tag' do
+        meta_collection = TagCollection.new
+        expect(meta_collection).to be_empty
+      end
+    end
+
     describe '#add' do
-      it 'add a meta object to internal list' do
+      it 'makes the list not to be empty anymore' do
         meta_collection = TagCollection.new
         meta_collection.add Tag.new({name: 'keywords', content: 'abc'})
-        expect(meta_collection.tags.first.attributes).to eq({name: 'keywords', content: 'abc'})
+        expect(meta_collection).not_to be_empty
+      end
+
+      it 'adds a meta object to internal list' do
+        meta_collection = TagCollection.new
+        meta_collection.add Tag.new({name: 'keywords', content: 'abc'})
+        expect(meta_collection.tags).not_to be_empty
+
+        added_tag = meta_collection.tags.first
+        expect(added_tag.attributes).to eq({name: 'keywords', content: 'abc'})
       end
 
-      it 'add a hash as a new meta object to internal list' do
+      it 'adds a hash as a new meta object to internal list' do
         meta_collection = TagCollection.new
         meta_collection.add({name: 'keywords', content: 'abc'})
         expect(meta_collection.tags.first.attributes).to eq({name: 'keywords', content: 'abc'})

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: metaa
 version: !ruby/object:Gem::Version
-  version: 0.0.12
-  prerelease: 
+  version: 0.0.13
 platform: ruby
 authors:
 - anhkind
@@ -14,7 +13,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: ammeter
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -62,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -78,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -86,7 +76,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -94,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-mocks
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -102,7 +90,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -110,7 +97,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -118,7 +104,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -142,7 +127,6 @@ files:
 - lib/generators/rspec/templates/meta_spec.rb
 - lib/metaa.rb
 - lib/metaa/concern.rb
-- lib/metaa/definition.rb
 - lib/metaa/meta.rb
 - lib/metaa/railtie.rb
 - lib/metaa/tag.rb
@@ -151,39 +135,36 @@ files:
 - metaa.gemspec
 - spec/generators/meta/meta_generator_spec.rb
 - spec/metaa/concern_spec.rb
-- spec/metaa/definition_spec.rb
 - spec/metaa/meta_spec.rb
 - spec/metaa/tag_collection_spec.rb
 - spec/metaa/tag_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/anhkind/metaa
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.1.10
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Meta tags with ease.
 test_files:
 - spec/generators/meta/meta_generator_spec.rb
 - spec/metaa/concern_spec.rb
-- spec/metaa/definition_spec.rb
 - spec/metaa/meta_spec.rb
 - spec/metaa/tag_collection_spec.rb
 - spec/metaa/tag_spec.rb

data/lib/metaa/definition.rb

@@ -1,20 +0,0 @@
-module Metaa
-  class Definition
-    attr_reader :attributes
-
-    def initialize(attributes = {})
-      @attributes = attributes
-    end
-
-    def attributes_for(object)
-      object_attributes = {}
-
-      attributes.each do |attr, val|
-        object_val              = val.respond_to?(:call) ? val.call(object) : val.to_s
-        object_attributes[attr] = object_val
-      end
-
-      object_attributes
-    end
-  end
-end

data/spec/metaa/definition_spec.rb

@@ -1,23 +0,0 @@
-require 'spec_helper'
-
-module Metaa
-  describe Definition do
-    describe '#attributes_for' do
-      it 'returns calculated attributes for an object' do
-        definition =  Definition.new({
-          name:     'title',
-          property: :text,
-          content:  ->(object){ object.title }
-        })
-
-        object_mock = double title: 'a title'
-
-        expect(definition.attributes_for(object_mock)).to eq({
-          name:     'title',
-          property: 'text',
-          content:  'a title'
-        })
-      end
-    end
-  end
-end