meta_presenter 0.2.4 → 1.0.1

data/gemfiles/rails6.gemfile

@@ -0,0 +1,19 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "actionpack", "6.0.0"
+gem "actionmailer", "6.0.0"
+
+group :development, :test do
+  gem "builder"
+  gem "byebug", platforms: [:mri, :mingw, :x64_mingw]
+  gem "rb-readline"
+  gem "rspec"
+end
+
+group :development do
+  gem "rubocop", "~> 1.57", require: false
+end
+
+gemspec path: "../"

data/gemfiles/rails7.gemfile

@@ -0,0 +1,19 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "actionpack", "7.0.1"
+gem "actionmailer", "7.0.1"
+
+group :development, :test do
+  gem "builder"
+  gem "byebug", platforms: [:mri, :mingw, :x64_mingw]
+  gem "rb-readline"
+  gem "rspec"
+end
+
+group :development do
+  gem "rubocop", "~> 1.57", require: false
+end
+
+gemspec path: "../"

data/lib/meta_presenter/builder.rb

@@ -1,10 +1,8 @@
 require 'active_support/core_ext/object/try'
 
 module MetaPresenter
-
   # Builds a presenter class for a controller and method
   class Builder
-
     # @return [ActionController::Base, ActionMailer::Base] Controller that this presenter will delegate methods to
     attr_reader :controller
 
@@ -20,7 +18,7 @@ module MetaPresenter
       @action_name = action_name
     end
 
-    # Error for there's no presenter class defined but a file for it exists
+    # Error when there's no presenter class defined but a file for it exists
     class FileExistsButPresenterNotDefinedError < NameError
       # Create a new error
       #
@@ -40,90 +38,91 @@ module MetaPresenter
 
     # @return [Class] Class constant for the built MetaPresenter::Base presenter
     def presenter_class
-      # Try to find the presenter class (Not guaranteed, 
+      # Try to find the presenter class (Not guaranteed,
       # for example if the presenter class wasn't defined
       # or if the file wasn't found)
       klass = nil
       ancestors.each do |klass_name|
         klass = presenter_class_for(klass_name)
-        break if !klass.nil?
+        break unless klass.nil?
       end
 
       klass
     end
 
     def presenter_base_dir
-      File.join(Rails.root, "app", "presenters")
+      File.join(Rails.root, 'app', 'presenters')
     end
 
     private
-      def all_ancestors
-        controller.class.ancestors.select do |ancestor|
-          if controller.class <= ActionController::Base
-            ancestor <= ActionController::Base
-          elsif controller.class <= ActionMailer::Base
-            ancestor <= ActionMailer::Base
-          else
-            raise InvalidControllerError.new(controller)
-          end
-        end
-      end
 
-      def mailer_ancestors
-        ancestors_until(ApplicationMailer) do |klass|
-          "Mailers::#{klass.name.gsub('Mailer', '')}"
+    def all_ancestors
+      controller.class.ancestors.select do |ancestor|
+        if controller.class <= ActionController::Base
+          ancestor <= ActionController::Base
+        elsif controller.class <= ActionMailer::Base
+          ancestor <= ActionMailer::Base
+        else
+          raise InvalidControllerError, controller
         end
       end
+    end
 
-      def controller_ancestors
-        ancestors_until(ApplicationController) do |klass|
-          klass.try(:name).try(:gsub, 'Controller', '')
-        end
+    def mailer_ancestors
+      ancestors_until(ApplicationMailer) do |klass|
+        "Mailers::#{klass.name.gsub('Mailer', '')}"
       end
-    
-      def presenter_class_for(klass_name)
-        presenter_class_name = "::#{klass_name}Presenter"
-        begin
-          return presenter_class_name.constantize
-
-        # No corresponding presenter class was found
-        rescue NameError => e
-          filename = "#{presenter_class_name.underscore}.rb"
-          presenter_file_path = File.join(presenter_base_dir, filename)
-          if File.exists?(presenter_file_path)
-            raise FileExistsButPresenterNotDefinedError.new(presenter_class_name, presenter_file_path)
-          else
-            return nil
-          end
-        end
+    end
+
+    def controller_ancestors
+      ancestors_until(ApplicationController) do |klass|
+        klass.try(:name).try(:gsub, 'Controller', '')
       end
+    end
 
-      def ancestors
-        # Different ancestors depending on whether
-        # we're dealing with a mailer or a controller
-        list = if all_ancestors.map(&:to_s).include?("ActionMailer::Base")
-          mailer_ancestors
-        else
-          controller_ancestors
+    def presenter_class_for(klass_name)
+      presenter_class_name = "::#{klass_name}Presenter"
+      begin
+        presenter_class_name.constantize
+
+      # No corresponding presenter class was found
+      rescue NameError => e
+        filename = "#{presenter_class_name.underscore}.rb"
+        presenter_file_path = File.join(presenter_base_dir, filename)
+        if File.exist?(presenter_file_path)
+          raise FileExistsButPresenterNotDefinedError.new(presenter_class_name, presenter_file_path)
         end
 
-        # add a presenter class for our current action
-        # to the front of the list
-        presenter_class_name_for_current_action = "#{list.first}::#{action_name.camelcase}"
-        list.unshift(presenter_class_name_for_current_action)
+        nil
       end
+    end
 
-      # The list of ancestors is very long.
-      # Trim it down to just the length of the class we are looking for.
-      # 
-      # Takes an optional block method to transform the result
-      # with a map operation
-      def ancestors_until(until_class)
-        # trim down the list
-        ancestors_list = all_ancestors[0..all_ancestors.index(until_class)]
-
-        # map to the fully qualified class name
-        ancestors_list.map { |klass| yield(klass) }
-      end
+    def ancestors
+      # Different ancestors depending on whether
+      # we're dealing with a mailer or a controller
+      list = if all_ancestors.map(&:to_s).include?('ActionMailer::Base')
+               mailer_ancestors
+             else
+               controller_ancestors
+             end
+
+      # add a presenter class for our current action
+      # to the front of the list
+      presenter_class_name_for_current_action = "#{list.first}::#{action_name.camelcase}"
+      list.unshift(presenter_class_name_for_current_action)
+    end
+
+    # The list of ancestors is very long.
+    # Trim it down to just the length of the class we are looking for.
+    #
+    # Takes an optional block method to transform the result
+    # with a map operation
+    def ancestors_until(until_class, &block)
+      # trim down the list
+      ancestors_list = all_ancestors[0..all_ancestors.index(until_class)]
+
+      # map to the fully qualified class name
+      ancestors_list.map(&block)
+    end
   end
-end
+end

data/lib/meta_presenter/helpers.rb

@@ -1,5 +1,4 @@
 require 'meta_presenter/builder'
-require 'active_support/concern'
 require 'active_support/rescuable'
 
 module MetaPresenter
@@ -16,21 +15,23 @@ module MetaPresenter
   # end
   #
   module Helpers
-    extend ActiveSupport::Concern
-    included do
-      # Sets up the `presenter.` method as helper within your views
-      # If you want to customize this for yourself just alias_method it
-      helper_method :presenter
+    def self.included(base)
+      base.instance_eval do
+        # Sets up the `presenter.` method as helper within your views
+        # If you want to customize this for yourself just alias_method it
+        helper_method :presenter
+      end
     end
 
     private
-      # Initialize presenter with the current controller
-      def presenter
-        @presenter ||= begin
-          controller = self
-          klass = MetaPresenter::Builder.new(controller, action_name).presenter_class
-          klass.new(controller)
-        end
+
+    # Initialize presenter with the current controller
+    def presenter
+      @presenter ||= begin
+        controller = self
+        klass = MetaPresenter::Builder.new(controller, action_name).presenter_class
+        klass.new(controller)
       end
+    end
   end
-end
+end

data/meta_presenter.gemspec

@@ -1,32 +1,30 @@
-
-
 Gem::Specification.new do |s|
   s.name          = 'meta_presenter'
-  s.version       = '0.2.4'
+  s.version       = '1.0.1'
   s.platform      = Gem::Platform::RUBY
   s.authors       = ['szTheory']
-  s.description   = %q{Write highly focused and testable view presenter classes for your Rails controllers and actions}
-  s.summary       = %q{MetaPresenter is a Ruby gem for writing highly focused and testable view Rails presenter classes. For each controller/action pair you get a presenter class in app/presenters that you can use in your views with with presenter.method_name. This helps you decompose your helper logic into tight, easily testable classes. There's even a DSL for method delegation on objects to reduce boilerplate.}
+  s.description   = 'Write highly focused and testable view presenter classes for your Rails controllers and actions'
+  s.summary       = "MetaPresenter is a Ruby gem for writing highly focused and testable view Rails presenter classes. For each controller/action pair you get a presenter class in app/presenters that you can use in your views with with presenter.method_name. This helps you decompose your helper logic into tight, easily testable classes. There's even a DSL for method delegation on objects to reduce boilerplate."
   s.homepage      = 'https://github.com/szTheory/meta_presenter'
   s.license       = 'MIT'
   s.metadata = {
-    "source_code_uri" => "https://github.com/szTheory/meta_presenter",
+    'source_code_uri' => 'https://github.com/szTheory/meta_presenter',
+    'rubygems_mfa_required' => 'true'
   }
 
   s.files         = `git ls-files`.split($/)
-  s.test_files    = s.files.grep(%r{^(test|spec)/})
   s.require_paths = ['lib']
 
-  s.required_ruby_version = '>= 2.1.0'
+  s.required_ruby_version = '>= 2.7.5'
 
-  s.add_dependency 'actionpack', '>= 3.0.12'
-  s.add_dependency 'actionmailer', '>= 3.0.12'
+  s.add_dependency 'actionmailer', '>= 6', '>= 7.0.1'
+  s.add_dependency 'actionpack', '>= 6', '>= 7.0.1'
 
-  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'appraisal'
   s.add_development_dependency 'bundler'
+  s.add_development_dependency 'coveralls'
+  s.add_development_dependency 'pry'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rb-readline'
-  s.add_development_dependency 'pry'
-  s.add_development_dependency 'coveralls'
-  s.add_development_dependency 'appraisal'
+  s.add_development_dependency 'rspec'
 end

data/spec/meta_presenter/builder_spec.rb

@@ -24,27 +24,27 @@ describe MetaPresenter::Builder do
       expect(controller_ancestors.first).to eql(controller_class)
     end
 
-    context "application controller" do
+    context 'application controller' do
       let(:controller_class) { ApplicationController }
 
       it { is_expected.to be ApplicationPresenter }
     end
 
-    context "controller without a presenter" do
+    context 'controller without a presenter' do
       let(:controller_class) { WithoutPresenterController }
 
-      let(:presenter_file_path) { File.join(object.presenter_base_dir, "without_presenter_presenter.rb") }
+      let(:presenter_file_path) { File.join(object.presenter_base_dir, 'without_presenter_presenter.rb') }
 
-      context "but file exists" do
+      context 'but file exists' do
         before do
-          expect(File).to be_exists(presenter_file_path)
+          expect(File).to be_exist(presenter_file_path)
         end
 
         it { expect { subject }.to raise_error(MetaPresenter::Builder::FileExistsButPresenterNotDefinedError) }
       end
     end
 
-    context "neither a controller nor a mailer" do
+    context 'neither a controller nor a mailer' do
       let(:controller_class) { OpenStruct }
 
       before do
@@ -55,7 +55,7 @@ describe MetaPresenter::Builder do
       it { expect { subject }.to raise_error(MetaPresenter::Builder::InvalidControllerError) }
     end
 
-    context "mailer" do
+    context 'mailer' do
       let(:controller_class) { ApplicationMailer }
 
       before do
@@ -65,40 +65,38 @@ describe MetaPresenter::Builder do
       it { is_expected.to be Mailers::ApplicationPresenter }
     end
 
-    context "subclass of ApplicationController" do
+    context 'subclass of ApplicationController' do
       let(:controller_class) { PagesController }
 
       before do
         expect(controller_class.ancestors).to include(ApplicationController)
       end
 
-      context "action with a presenter class defined" do
-        let(:action_name) { "logs" }
+      context 'action with a presenter class defined' do
+        let(:action_name) { 'logs' }
         before { expect(Object).to_not be_const_defined('LogsPresenter') }
 
         it { is_expected.to be Pages::LogsPresenter }
       end
 
-      context "action without a presenter class defined" do
-        let(:action_name) { "fairy" }
+      context 'action without a presenter class defined' do
+        let(:action_name) { 'fairy' }
         before { expect(Object).to_not be_const_defined('FairyPresenter') }
 
-        context "parent presenter defines the method" do
-
-          it "defers to the parent presenter" do
+        context 'parent presenter defines the method' do
+          it 'defers to the parent presenter' do
             expect(subject).to be PagesPresenter
           end
         end
 
         context "parent presenter doesn't define the method" do
-
-          it "defers to the parent presenter" do
+          it 'defers to the parent presenter' do
             expect(subject).to be PagesPresenter
           end
         end
 
-        context "but the file exists" do
-          let(:action_name) { "only_file_exists" }
+        context 'but the file exists' do
+          let(:action_name) { 'only_file_exists' }
 
           it do
             expect { subject }.to raise_error(MetaPresenter::Builder::FileExistsButPresenterNotDefinedError)
@@ -107,11 +105,11 @@ describe MetaPresenter::Builder do
       end
     end
 
-    context "namespaced" do
+    context 'namespaced' do
       let(:controller_class) { Admin::DashboardController }
-      let(:action_name) { "inbox" }
+      let(:action_name) { 'inbox' }
 
       it { is_expected.to be Admin::Dashboard::InboxPresenter }
     end
   end
-end
+end

data/spec/spec_helper.rb

@@ -1,22 +1,18 @@
-# spec coverage
-require 'coveralls'
-Coveralls.wear!
-
 # debug tool
-require "pry"
+require 'pry'
 
 # main lib module
-require "meta_presenter"
+require 'meta_presenter'
 
 # support files
-Dir["#{__dir__}/support/*.rb"].each {|file| require file }
+Dir["#{__dir__}/support/*.rb"].each { |file| require file }
 
 # Simulate the Rails env.
 # Instead of loading the Rails environment, we stub the bare amount
 # and load from spec/support/app as if it were a Rails app
 begin
   # mount app dir tree
-  Dir["#{__dir__}/support/app/**/*.rb"].each {|file| require file }
+  Dir["#{__dir__}/support/app/**/*.rb"].each { |file| require file }
 
   # mock Rails
   module Rails
@@ -28,4 +24,4 @@ begin
       allow(Rails).to receive(:root).and_return(File.join(__dir__, 'support'))
     end
   end
-end
+end

data/spec/support/app/controllers/admin/dashboard_controller.rb

@@ -1,2 +1,6 @@
-class Admin::DashboardController < ApplicationController
-end
+require_relative '../application_controller'
+
+class Admin
+  class DashboardController < ::ApplicationController
+  end
+end

data/spec/support/app/presenters/admin/dashboard/inbox_presenter.rb

@@ -1,8 +1,8 @@
 require_relative '../dashboard_presenter'
 
-module Admin
-  module Dashboard
+class Admin
+  class Dashboard
     class InboxPresenter < Admin::DashboardPresenter
     end
   end
-end
+end

data/spec/support/app/presenters/admin/dashboard_presenter.rb

@@ -1,4 +1,5 @@
-module Admin
-  class DashboardPresenter < ApplicationPresenter
+require_relative '../../presenters/application_presenter'
+class Admin
+  class DashboardPresenter < ::ApplicationPresenter
   end
 end

data/spec/support/app/presenters/pages/logs_presenter.rb

@@ -1,4 +1,6 @@
-module Pages
-  class LogsPresenter < PagesPresenter
+require_relative '../pages_presenter'
+
+class Pages
+  class LogsPresenter < ::PagesPresenter
   end
-end
+end