meta_presenter 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eee3276e576c1200170aa138a0ae0f268f5e1f493c4f438fcbf718cd618ca566
-  data.tar.gz: d266e84619d51137569f4fd93da00a4981d8efc62d8593cdd9fbca5aa2192a2d
+  metadata.gz: a6f42b2b3dce01fdf2f0acb8588fe6377af542ac0b28ecf2a40d76b951a4f8cf
+  data.tar.gz: 9dc1717fe89a41bf9d99c1095d88117255dffa34a9485ed0ebd4742466005361
 SHA512:
-  metadata.gz: fe3f40333c7deacc1001faa760db23800102f68a3d4f1baf3b3289942fa5fe0900df225645b4c95e5b25d636d86367b69efecf1432261c9c3a2d6204d1fa6646
-  data.tar.gz: c3a7743081fe37d99d0057cd7ce1fa65fc3532950fa0aea9869361beaa518bc0c8ca15664788ba91bb980ef4cb4a1c3fb4e4a8a3de1df19ce155fe3a3725d9a0
+  metadata.gz: 789b9c804d600a9a715851e9fd77345acb7f11ba930c6e09c05d729b743792b6ceabba74b6dd28e6756eda7ef39dfa089f4b9d1ae261ac32398fde54da967b99
+  data.tar.gz: 45401a3342a6e079605a863c9ce0f505182834263fbee7233cf94c72055774b619b78e4e14b91383406a3d5c324ec082c14e7c3b5566bc5a6ce183c253837316

data/.gitignore

@@ -47,4 +47,8 @@ build-iPhoneSimulator/
 .ruby-gemset
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
-.rvmrc
+.rvmrc
+
+# appraisal
+# https://github.com/thoughtbot/appraisal
+gemfiles/*.gemfile.lock

data/.travis.yml

@@ -10,4 +10,13 @@ rvm:
   - 2.3.0
   - 2.4.0
   - 2.5.0
+gemfile:
+  - gemfiles/actionpack4.gemfile
+  - gemfiles/actionpack5.gemfile
+matrix:
+  exclude:
+    - rvm: 2.1.0
+      gemfile: gemfiles/actionpack5.gemfile
+    - rvm: 2.2.0
+      gemfile: gemfiles/actionpack5.gemfile
 script: bundle exec rspec

data/Appraisals

@@ -0,0 +1,12 @@
+# TODO: get actionpack 3 building!
+#appraise "actionpack3" do
+#  gem "actionpack", "3.0.0"
+#end
+
+appraise "actionpack4" do
+  gem "actionpack", "4.0.0"
+end
+
+appraise "actionpack5" do
+  gem "actionpack", "5.0.0"
+end

data/Gemfile

@@ -1,4 +1,14 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in meta_presenter.gemspec
 gemspec
+
+gem 'pry'
+
+# Hinting at development dependencies
+# Prevents bundler from taking a long-time to resolve
+group :development, :test do
+  gem 'rspec'
+  gem 'builder'
+  gem 'rb-readline'
+  gem 'coveralls'
+end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    meta_presenter (0.1.2)
+    meta_presenter (0.1.3)
       actionpack (>= 3.0)
 
 GEM
@@ -25,6 +25,10 @@ GEM
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
     builder (3.2.3)
     coderay (1.1.2)
     concurrent-ruby (1.1.3)
@@ -92,6 +96,8 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
+  appraisal
+  builder
   bundler
   coveralls
   meta_presenter!

data/README.md

@@ -20,8 +20,6 @@ Or install it yourself as:
 
     $ gem install meta_presenter
 
-TODO: add an optional task that generates the scaffolding for you. Or, you can manually create the files you want.
-
 Include MetaPresenter::Helpers in your controller or mailer:
 
     class ApplicationController < ActionController::Base
@@ -32,6 +30,10 @@ Include MetaPresenter::Helpers in your controller or mailer:
       include MetaPresenter::Base
     end
 
+## Requirements
+
+MetaPresenter supports Ruby >= 2.1 and ActionPack >= 4.0. If you'd like to help adding support for older versions please submit a pull request with passing specs.
+
 ## Example
 
 Say you have a PagesController with an action for home and logs. Underneath `app/presenters` you can add a class for each action. In this example we'll also create an application and base presenter we'll inherit from to re-use code in the per-action presenters.
@@ -148,8 +150,10 @@ If you want to customize the `presenter` method you can specify a shorthand by a
 
 ## TODO
 
-* add support by lower Ruby versions by replacing yield_self with equivalent compatible code
+* add support for actionsupport3, will require enabling it in the Appraisal file and then fixing any bugs in the build
 * tests for ActionMailer support
+* add an optional task that generates the scaffolding for you. Or, you can manually create the files you want
+* add support for layouts
 
 ## Contributing
 

data/Rakefile

@@ -0,0 +1,5 @@
+if !ENV["APPRAISAL_INITIALIZED"] && !ENV["TRAVIS"]
+  # appraisal is a ruby gem that lets us test our code
+  # against multiple dependency sets (gemfiles)
+  task :default => :appraisal
+end

data/gemfiles/.bundle/config

@@ -0,0 +1,2 @@
+---
+BUNDLE_RETRY: "1"

data/gemfiles/actionpack4.gemfile

@@ -0,0 +1,15 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pry"
+gem "actionpack", "4.0.0"
+
+group :development, :test do
+  gem "rspec"
+  gem "builder"
+  gem "rb-readline"
+  gem "coveralls"
+end
+
+gemspec path: "../"

data/gemfiles/actionpack5.gemfile

@@ -0,0 +1,15 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pry"
+gem "actionpack", "5.0.0"
+
+group :development, :test do
+  gem "rspec"
+  gem "builder"
+  gem "rb-readline"
+  gem "coveralls"
+end
+
+gemspec path: "../"

data/lib/meta_presenter/builder.rb

@@ -61,20 +61,18 @@ module MetaPresenter
       end
 
       def ancestors
-        all_ancestors.yield_self do |list|
-          # Different ancestors depending on whether
-          # we're dealing with a mailer or a controller
-          if list.map(&:to_s).include?("ActionMailer::Base")
-            mailer_ancestors
-          else
-            controller_ancestors
-          end
-        end.yield_self do |list|
-          # add a presenter class for our current action
-          # to the front of the list
-          presenter_class_name_for_current_action = "#{list.first}::#{action_name.camelcase}"
-          list.unshift(presenter_class_name_for_current_action)
+        # Different ancestors depending on whether
+        # we're dealing with a mailer or a controller
+        list = if all_ancestors.map(&:to_s).include?("ActionMailer::Base")
+          mailer_ancestors
+        else
+          controller_ancestors
         end
+
+        # add a presenter class for our current action
+        # to the front of the list
+        presenter_class_name_for_current_action = "#{list.first}::#{action_name.camelcase}"
+        list.unshift(presenter_class_name_for_current_action)
       end
 
       # The list of ancestors is very long.

data/lib/meta_presenter/helpers.rb

@@ -14,10 +14,9 @@ module MetaPresenter
       # Initialize presenter with the current controller
       def presenter
         @presenter ||= begin
-          yield_self do |controller|
-            klass = MetaPresenter::Builder.new(controller, action_name).presenter_class
-            klass.new(controller)
-          end
+          controller = self
+          klass = MetaPresenter::Builder.new(controller, action_name).presenter_class
+          klass.new(controller)
         end
       end
   end

data/meta_presenter.gemspec

@@ -1,28 +1,31 @@
-# coding: utf-8
 
-Gem::Specification.new do |spec|
-  spec.name          = 'meta_presenter'
-  spec.version       = '0.1.2'
-  spec.authors       = ['szTheory']
-  spec.description   = %q{Presenter pattern in your Rails controllers and actions}
-  spec.summary       = %q{MetaPresenter is a Ruby gem that gives you access to the powerful presenter pattern in your Rails controllers. For each controller/action pair you get a presenter class in `app/presenters` that you can use in your views with with `presenter.method_name`. This helps you decompose your helper logic into small, tight, classes that are easily testable. There's even a DSL for method delegation on objects to reduce boilerplate.}
-  spec.homepage      = 'https://github.com/szTheory/meta_presenter'
-  spec.license       = 'MIT'
-  spec.metadata = {
+
+Gem::Specification.new do |s|
+  s.name          = 'meta_presenter'
+  s.version       = '0.1.3'
+  s.platform      = Gem::Platform::RUBY
+  s.authors       = ['szTheory']
+  s.description   = %q{Presenter pattern in your Rails controllers and actions}
+  s.summary       = %q{MetaPresenter is a Ruby gem that gives you access to the powerful presenter pattern in your Rails controllers. For each controller/action pair you get a presenter class in `app/presenters` that you can use in your views with with `presenter.method_name`. This helps you decompose your helper logic into small, tight, classes that are easily testable. There's even a DSL for method delegation on objects to reduce boilerplate.}
+  s.homepage      = 'https://github.com/szTheory/meta_presenter'
+  s.license       = 'MIT'
+  s.metadata = {
     "source_code_uri" => "https://github.com/szTheory/meta_presenter",
   }
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ['lib']
+  s.files         = `git ls-files`.split($/)
+  s.test_files    = s.files.grep(%r{^(test|spec)/})
+  s.require_paths = ['lib']
+
+  s.required_ruby_version = '>= 2.1.0'
 
-  spec.add_runtime_dependency 'actionpack', '>= 3.0'
+  s.add_dependency 'actionpack', '>= 3.0'
 
-  spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rb-readline'
-  spec.add_development_dependency 'pry'
-  spec.add_development_dependency 'coveralls'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'bundler'
+  s.add_development_dependency 'rake'
+  s.add_development_dependency 'rb-readline'
+  s.add_development_dependency 'pry'
+  s.add_development_dependency 'coveralls'
+  s.add_development_dependency 'appraisal'
 end

data/spec/meta_presenter/builder_spec.rb

@@ -32,13 +32,17 @@ describe MetaPresenter::Builder do
 
     context "subclass of ApplicationController" do
       let(:controller_class) { PagesController }
-      let(:action_name) { "logs" }
 
-      it { is_expected.to be Pages::LogsPresenter }
+      context "action with a presenter class defined" do
+        let(:action_name) { "logs" }
+        before { expect(Object).to_not be_const_defined('LogsPresenter') }
+
+        it { is_expected.to be Pages::LogsPresenter }
+      end
 
       context "action without a presenter class defined" do
-        # Good luck finding that FairyPresenter, doesn't exist!
         let(:action_name) { "fairy" }
+        before { expect(Object).to_not be_const_defined('FairyPresenter') }
 
         it "defers to the parent presenter" do
           expect(subject).to be PagesPresenter

data/spec/meta_presenter/helpers_spec.rb

@@ -6,7 +6,7 @@ describe MetaPresenter::Helpers do
   let(:action_name) { 'logs' }
 
   describe '#presenter' do
-    subject { controller.helpers.presenter }
+    subject { controller.view_context.presenter }
 
     before do
       allow(controller).to receive(:action_name).and_return(action_name)

data/spec/support/app/controllers/pages_controller.rb

@@ -1,4 +1,2 @@
-# require 'application_controller'
-
 class PagesController < ApplicationController
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: meta_presenter
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - szTheory
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-23 00:00:00.000000000 Z
+date: 2018-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Presenter pattern in your Rails controllers and actions
 email: 
 executables: []
@@ -116,10 +130,15 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- Appraisals
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
 - README.md
+- Rakefile
+- gemfiles/.bundle/config
+- gemfiles/actionpack4.gemfile
+- gemfiles/actionpack5.gemfile
 - lib/meta_presenter.rb
 - lib/meta_presenter/base.rb
 - lib/meta_presenter/base/delegate_all_to.rb
@@ -152,7 +171,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="