meta_information 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d556922852ac6df30c615a4a4b19bf26aaaae018
-  data.tar.gz: 493ec710dfe899e2a81290372932aefcc9c315c4
+  metadata.gz: f65e782ac7eaa37bbdf77b9b44ae5424ed3172b2
+  data.tar.gz: a51c2c644b512bebdc08d7bf268f2e7fefd22f18
 SHA512:
-  metadata.gz: 85444c64a14c7748f954e995fea8f7da7580b82355464ed333ae75dc0afc8b9ac008986cbc066b9d427f472a45c20417348a630dcbc243e405537ba65dd467d0
-  data.tar.gz: 614bdeb5835fc7a2ff75ab40a5ff2089448cf5db9636f1c490ca8d0a28fe1d51d6de2a2035129bba26acd1585b8365677a8b181d44d76a947409e15ec217ddcd
+  metadata.gz: 7a8e67c5268d725856ea3e2c001b022892b0d2b2ca557b175a94e95920b7e0833b9d28c967b19b2e91318378973c1644fdb5153c35536471baa69e3ae6f42b26
+  data.tar.gz: 2057cf51280e5d455370a188b7a98bb6652d0c9452d67ea75095ec3f17fdbe198a35c2fb18c88cb9ae388bdcad4f9e3fd5bea2b5c67663898cd8552f362a3dad

data/README.md

@@ -1,4 +1,6 @@
 # MetaInformation
+[![Gem Version](https://badge.fury.io/rb/meta_information.svg)](https://badge.fury.io/rb/meta_information)
+
 Simple gem for parsing meta information from websites. It scan all meta-tags by name or property attributes.
 ## Instalation
 Add this line to your application's Gemfile:
@@ -21,15 +23,18 @@ pp meta
 # :all_meta=>
 #  [{:type=>"name",
 #    :name=>"viewport",
+#    :property=>nil,
 #    :content=>"width=device-width, initial-scale=1.0"},
-#   {:type=>"name", :name=>"description", :content=>"some description"},
-#   {:type=>"name", :name=>"title", :content=>"i am title"},
-#   {:type=>"name", :name=>"og:title", :content=>"some content"},
-#   {:type=>"name", :name=>"og:description", :content=>"some description"},
+#   {:type=>"name", :name=>"description", :property=>nil, :content=>"some description"},
+#   {:type=>"name", :name=>"title", :property=>nil, :content=>"i am title"},
+#   {:type=>"name", :name=>"og:title", :property=>nil, :content=>"some content"},
+#   {:type=>"name", :name=>"og:description", :property=>nil, :content=>"some description"},
 #   {:type=>"name",
 #    :name=>"og:image",
-#    :content=> "https://www.awesome_site.com/assets/awesome_picture.jpg"}]}
+#    :property=>nil,
+#    :content=> "https://www.awesome_site.com/assets/awesome_picture.jpg"}]},
+#   {:type=>"property", :name=>nil, :property=>"fb:app_id", :content=>"1234567890"},
 ###
 ```
 ## License
-MIT License.
+MIT License.

data/lib/meta_information.rb

@@ -7,68 +7,71 @@ require 'open-uri'
 # for usage
 # MetaInformation.get_meta('https://some_site.com/some_page')
 module MetaInformation
-  class << self
-    def get_meta(input_url)
-      return not_valid_url_error unless valid_url?(input_url)
+  extend self
 
-      document = create_document(input_url)
-      return nokogiri_error if document == false
+  def get_meta(input_url)
+    return not_valid_url_error unless valid_url?(input_url)
 
-      meta_hash = create_meta_array(document)
-      success_hash.merge(all_meta: meta_hash)
-    end
+    document = create_document(input_url)
+    return nokogiri_error if document == false
 
-    private
+    meta_hash = create_meta_array(document)
+    success_hash.merge(all_meta: meta_hash)
+  end
 
-    def create_meta_array(document)
-      array = []
-      document.css('meta').each do |node|
-        if !node['name'].nil?
-          array.push(
-            type: 'name',
-            name: node['name'],
-            content: node['content']
-          )
-        elsif !node['property'].nil?
-          array.push(
-            type: 'property',
-            property: node['property'],
-            content: node['content']
-          )
-        end
-      end
-      array
-    end
+  private
 
-    def valid_url?(uri)
-      !!uri.match(/^(https?:\/\/)?([\w\.]+)\.([a-z]{2,6}\.?)(\/[\w\.]*)*\/?$/)
+  def create_meta_array(document)
+    array = []
+    document.css('meta').each do |node|
+      array.push(
+        type: node_type(node),
+        name: node['name'],
+        property: node['property'],
+        content: node['content']
+      )
     end
+    array
+  end
 
-    def create_document(input_url)
-      Nokogiri::HTML(open(input_url))
-    rescue
-      false
+  def node_type(node)
+    if !node['name'].nil?
+      'name'
+    elsif !node['property'].nil?
+      'property'
+    else
+      ''
     end
+  end
 
-    def not_valid_url_error
-      {
-        success: false,
-        error: 'url is not valid'
-      }
-    end
+  def valid_url?(uri)
+    !(uri =~ URI.regexp).nil?
+  end
 
-    def nokogiri_error
-      {
-        success: false,
-        error: 'error with parsing a document'
-      }
-    end
+  def create_document(input_url)
+    Nokogiri::HTML(open(input_url))
+  rescue
+    false
+  end
 
-    def success_hash
-      {
-        succes: 'true',
-        error: ''
-      }
-    end
+  def not_valid_url_error
+    {
+      success: false,
+      error: 'url is not valid'
+    }
+  end
+
+  def nokogiri_error
+    {
+      success: false,
+      error: 'error with parsing a document'
+    }
+  end
+
+  def success_hash
+    {
+      succes: 'true',
+      error: ''
+    }
   end
 end

data/lib/meta_information/version.rb

@@ -1,3 +1,3 @@
 module MetaInformation
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/spec/lib/meta_information_spec.rb

@@ -1,38 +1,68 @@
 require './lib/meta_information'
+require './spec/shared_stuff.rb'
+require './spec/config.rb'
 
 RSpec.describe 'MetaInformation' do
-  
+  include_context 'shared stuff'
+
+  describe 'get_meta' do
+    it 'should return not_valid_url_error' do
+      allow(MetaInformation).to receive(:valid_url?).and_return(false)
+      result = MetaInformation.get_meta('http://some_url.com')
+      expect(result).to(
+        eq(
+          success: false,
+          error: 'url is not valid'
+        )
+      )
+    end
+
+    describe 'with mock for valid_url?' do
+      before do
+        allow(MetaInformation).to receive(:valid_url?).and_return(true)
+      end
+      it 'should return nokogiri_error' do
+        allow(MetaInformation).to receive(:create_document).and_return(false)
+
+        result = MetaInformation.get_meta('http://some_url.com')
+        expect(result).to(
+          eq(
+            success: false,
+            error: 'error with parsing a document'
+          )
+        )
+      end
+
+      it 'should return success_hash' do
+        allow(MetaInformation).to(
+          receive(:create_document).and_return(
+            Nokogiri::HTML(default_html)
+          )
+        )
+
+        result = MetaInformation.get_meta('http://some_url.com')
+        expect(result).to(
+          eq(
+            succes: 'true',
+            error: '',
+            all_meta: default_html_meta_array
+          )
+        )
+      end
+    end
+  end
+
   describe 'create_meta_array' do
     describe 'we have meta' do
       it 'must create array' do
-        document = Nokogiri::HTML('
-          <html>
-            <meta name="description" content="" />
-            <meta name="title" content="some title" />
-            <meta property="author" content="Bob" />
-            <meta property="og:title" content="og_title" />
-            <meta property="twitter:image" content="http://some_host.com/some_path" />
-            <meta property="og:locale" content="ru_RU" />
-            <meta property="al:ios:app_store_id" content="12345678900" />
-            <body>
-              <h1>Mr. Belvedere Fan Club</h1>
-            </body>
-          </html>
-        ')
-        expect(MetaInformation.send(:create_meta_array, document)).to eq([
-          { type: 'name', name: 'description', content: '' },
-          { type: 'name', name: 'title', content: 'some title' },
-          { type: 'property', property: 'author', content: 'Bob' },
-          { type: 'property', property: 'og:title', content: 'og_title' },
-          { type: 'property', property: 'twitter:image', content: 'http://some_host.com/some_path' },
-          { type: 'property', property: 'og:locale', content: 'ru_RU' },
-          { type: 'property', property: 'al:ios:app_store_id', content: '12345678900' }
-        ])
+        document = Nokogiri::HTML(default_html)
+        result = MetaInformation.send(:create_meta_array, document)
+        expect(result).to eq(default_html_meta_array)
       end
     end
-    
-    describe 'without meta' do
-      it 'has empty array' do
+
+    describe 'without meta has empty array' do
+      it 'if have not mate' do
         first_document = Nokogiri::HTML('
           <html>
             <body>
@@ -40,31 +70,45 @@ RSpec.describe 'MetaInformation' do
             </body>
           </html>
         ')
-        second_document = Nokogiri::HTML('')
         expect(MetaInformation.send(:create_meta_array, first_document)).to eq([])
+      end
+
+      it 'if html is empty' do
+        second_document = Nokogiri::HTML('')
         expect(MetaInformation.send(:create_meta_array, second_document)).to eq([])
       end
     end
   end
 
   describe 'valid_url?' do
-    it 'must be valid' do
-      expect(MetaInformation.send(:valid_url?, 'http://www.somesite.com')).to be_truthy
-      expect(MetaInformation.send(:valid_url?, 'https://www.somesite.com')).to be_truthy
-      expect(MetaInformation.send(:valid_url?, 'https://somesite.com')).to be_truthy
-      expect(MetaInformation.send(:valid_url?, 'wwwsome_site.ru')).to be_truthy
-      expect(MetaInformation.send(:valid_url?, 'https://somesite.com/some_page')).to be_truthy
-      expect(MetaInformation.send(:valid_url?, 'https://somesite.com/some_page/page')).to be_truthy
-      expect(MetaInformation.send(:valid_url?, 'https://somesite.com.uk/some_page')).to be_truthy
+    def self.validate_valid_url(url)
+      it "#{url} must be valid" do
+        expect(MetaInformation.send(:valid_url?, url)).to be_truthy
+      end
     end
-    
-    it 'does not valid' do
-      expect(MetaInformation.send(:valid_url?, 'some_site')).to be_falsey
-      expect(MetaInformation.send(:valid_url?, 'http\\:wwwsome_site.ru')).to be_falsey
-      expect(MetaInformation.send(:valid_url?, 'com.some_site')).to be_falsey
+
+    validate_valid_url('http://www.somesite.com')
+    validate_valid_url('https://www.somesite.com')
+    validate_valid_url('https://somesite.com')
+    validate_valid_url('http://www.siteforadmin.ru')
+    validate_valid_url('https://somesite.com/some_page')
+    validate_valid_url('https://somesite.com/some_page/page')
+    validate_valid_url('http://somesite.com/some_page/2012/12/page/another_page')
+    validate_valid_url('http://somesite.com/2012/12/page-page-page')
+    validate_valid_url('https://somesite.com.uk/some_page')
+    validate_valid_url('https://meduza.io/short/2017/03/25/v-londone-proshel-mnogotysyachnyy-marsh-protiv-brekzita-fotografiya')
+
+    def self.validate_invalid_url(url)
+      it "#{url} must be invalid" do
+        expect(MetaInformation.send(:valid_url?, url)).to be_falsey
+      end
     end
+
+    validate_invalid_url('some_site')
+    validate_invalid_url('http\\:wwwsome_site.ru')
+    validate_invalid_url('com.some_site')
   end
-  
+
   describe 'private hash equal' do
     it 'not_valid_url_error hash' do
       expect(MetaInformation.send(:not_valid_url_error)).to eq({
@@ -87,4 +131,26 @@ RSpec.describe 'MetaInformation' do
       })
     end
   end
+
+  describe 'node_type' do
+    it 'must return name' do
+      document = Nokogiri::HTML('<meta name="description" content="" />')
+      node = document.css('meta').first
+      expect(MetaInformation.send(:node_type, node)).to eq('name')
+    end
+
+    it 'must return property' do
+      document = Nokogiri::HTML(
+        '<meta property="og:title" content="og_title" />'
+      )
+      node = document.css('meta').first
+      expect(MetaInformation.send(:node_type, node)).to eq('property')
+    end
+
+    it 'must return empty string' do
+      document = Nokogiri::HTML('<meta content="og_title" />')
+      node = document.css('meta').first
+      expect(MetaInformation.send(:node_type, node)).to eq('')
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: meta_information
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Vladislav Kopylov