meta_hari 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d588a4900a63c06626caa3b9474757320d223f6
-  data.tar.gz: e5129bc542ec83386fc0c372fff7a0c093b1a475
+  metadata.gz: b527913e023c68cdb8fe0c29fd1b353c4ea936ec
+  data.tar.gz: 3e891458ea7d2d25871b134c33bbfdae0ed06155
 SHA512:
-  metadata.gz: 345088ec4c31789da877a5987fa82fc71e2cbcc92e6867c7df4807d9d492f70754e82c8c2791bc8d4882e7f8d500cdcd3c907cc9650802c29bff3aac90e49d75
-  data.tar.gz: e5748efbcfa759d3181c0eef50f4da419347f618d3be997001aee3e19ab59fb1362c2886d26df098d9ba99170dcf1243251b23d1667a490e9c81363508eb22e2
+  metadata.gz: f7106a1fd62a18020d24d736dfd06c2ee47b03976875306a377184ee8cd434a40a06cc042d293c033564e1b6fc28e778d40300c29473d168a4d4d4b4be600faf
+  data.tar.gz: 2ef28481ac8e80537fd29499742ec7eb08524c21089d65a1138ab3de06dc06f86ec6d5f432f256c648537905ccbdce59175ecb4c5285ddd3b48003f90b2b6bd2

data/README.md

@@ -33,8 +33,9 @@ In order to receive product informations, just pass the URL containing
 thous informations to the method `MetaHari.spy`.
 
 ```ruby
-product = MetaHari.spy('http://www.amazon.de/Gastroback-42429-Design-Wasserkocher-Advanced/dp/B000LQXC2Q/ref=sr_1_1')
-product.inspect # => #<MetaHari::Product:0x007fd9dba99158 @name="Gastroback 42429 Design Wasserkocher Advanced Pro", @image="http://ecx.images-amazon.com/images/I/814Yl6mxLsL._SL1500_.jpg", @description="">
+product = MetaHari.spy('www.amazon.de/Gastroback-42429-Design-Wasserkocher-Advanced/dp/B000LQXC2Q/ref=sr_1_1')
+product.inspect # => #<MetaHari::Product:0x007fa3429de030 @uri=#<Addressable::URI:0x3fd1a18d5c04 URI:http://www.amazon.de/Gastroback-42429-Design-Wasserkocher-Advanced/dp/B000LQXC2Q/ref=sr_1_1>, @name="Gastroback 42429 Design Wasserkocher Advanced Pro", @image="http://ecx.images-amazon.com/images/I/814Yl6mxLsL._SL1500_.jpg", @description="">
+product.uri.to_s # => http://www.amazon.de/Gastroback-42429-Design-Wasserkocher-Advanced/dp/B000LQXC2Q/ref=sr_1_1
 ```
 
 ## Implemented spyglasses

data/lib/meta_hari.rb

@@ -21,7 +21,7 @@ require 'meta_hari/spyglass'
 module MetaHari
   class <<self
     def spy(uri, iteration = 0)
-      uri = URI.parse uri unless uri.is_a? URI
+      uri = Helpers::AddressableFactory.parse uri.to_s
       spyglass = suitable_spyglass_instance uri, iteration
       spyglass.spy
     rescue RedirectNotification => redirect

data/lib/meta_hari/helpers.rb

@@ -1,3 +1,4 @@
+require 'meta_hari/helpers/addressable_factory'
 require 'meta_hari/helpers/json_ld'
 require 'meta_hari/helpers/microdata'
 require 'meta_hari/helpers/open_graph'

data/lib/meta_hari/helpers/addressable_factory.rb

@@ -0,0 +1,38 @@
+require 'addressable/uri'
+
+# The AddressableFactory helper is trying to guess a URL out of a given string.
+#
+# Example
+# -------
+# ```ruby
+# uri = MetaHari::Helpers::AddressableFactory.parse('example.com/foo')
+# # => http://example.com/foo
+# ```
+#
+module MetaHari
+  module Helpers
+    module AddressableFactory
+      class <<self
+        def parse(url)
+          uri = Addressable::URI.parse(url)
+          fix_scheme uri
+          fix_host uri
+          uri
+        end
+
+        private
+
+        def fix_scheme(uri)
+          uri.scheme ||= 'http'
+        end
+
+        def fix_host(uri)
+          return unless uri.host.nil?
+          host, *path = uri.path.split('/')
+          uri.path = '/' + path.join('/')
+          uri.host = host
+        end
+      end
+    end
+  end
+end

data/lib/meta_hari/product.rb

@@ -1,5 +1,6 @@
 module MetaHari
   class Product
+    attr_reader :uri
     attr_reader :name
     attr_reader :image
     attr_reader :description
@@ -9,6 +10,7 @@ module MetaHari
     end
 
     def apply(attributes)
+      @uri         = attributes['uri']          if uri.nil?
       @name        = attributes['name']         if blank? name
       @image       = attributes['image']        if blank? image
       @description = attributes['description']  if blank? description

data/lib/meta_hari/spyglass/base.rb

@@ -17,7 +17,7 @@ module MetaHari
 
       def spy
         spy_list.map { |method| send method }
-          .inject(MetaHari::Product.new) { |a, e| a.apply e }
+          .inject(MetaHari::Product.new 'uri' => uri) { |a, e| a.apply e }
       end
 
       protected

data/lib/meta_hari/version.rb

@@ -1,4 +1,4 @@
 # MetaHari version
 module MetaHari
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/meta_hari.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'microdata', '~> 0.0.3'
+  spec.add_dependency 'addressable', '~> 2.3.8'
 
   spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.0'

data/spec/lib/meta_hari/helpers/addressable_factory_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe MetaHari::Helpers::AddressableFactory do
+  subject { described_class }
+
+  it { should respond_to :parse }
+
+  it 'is not changing a valid URL' do
+    uri = subject.parse 'https://example.com/foo'
+    expect(uri.to_s).to eql 'https://example.com/foo'
+  end
+
+  context 'without scheme' do
+    it 'adds http as default scheme' do
+      uri = subject.parse '//example.com/foo'
+      expect(uri.to_s).to eql 'http://example.com/foo'
+    end
+  end
+
+  context 'without a host' do
+    it 'uses the first part of the path as host' do
+      uri = subject.parse 'example.com/foo'
+      expect(uri.to_s).to eql 'http://example.com/foo'
+    end
+
+    it 'works with an empty path' do
+      uri = subject.parse 'example.com'
+      expect(uri.to_s).to eql 'http://example.com/'
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: meta_hari
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Paul Spieker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-03 00:00:00.000000000 Z
+date: 2015-07-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: microdata
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.0.3
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.3.8
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.3.8
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -166,6 +180,7 @@ files:
 - Rakefile
 - lib/meta_hari.rb
 - lib/meta_hari/helpers.rb
+- lib/meta_hari/helpers/addressable_factory.rb
 - lib/meta_hari/helpers/json_ld.rb
 - lib/meta_hari/helpers/microdata.rb
 - lib/meta_hari/helpers/open_graph.rb
@@ -177,6 +192,7 @@ files:
 - lib/meta_hari/spyglass/base.rb
 - lib/meta_hari/version.rb
 - meta_hari.gemspec
+- spec/lib/meta_hari/helpers/addressable_factory_spec.rb
 - spec/lib/meta_hari/helpers/json_ld_spec.rb
 - spec/lib/meta_hari/helpers/microdata_spec.rb
 - spec/lib/meta_hari/helpers/open_graph_spec.rb
@@ -214,6 +230,7 @@ signing_key:
 specification_version: 4
 summary: Receiving product informations from a given link.
 test_files:
+- spec/lib/meta_hari/helpers/addressable_factory_spec.rb
 - spec/lib/meta_hari/helpers/json_ld_spec.rb
 - spec/lib/meta_hari/helpers/microdata_spec.rb
 - spec/lib/meta_hari/helpers/open_graph_spec.rb