meta_hari 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59d373088784b38793845e8c6eba10af68fa3706
-  data.tar.gz: 825e11665c9ad6ca87dabdc4dde0c032bee6277d
+  metadata.gz: 4bf357320156f76fbf4f7a8b2f685732560b89f3
+  data.tar.gz: ebe62d8cc103cb7630a7d2cf5c970140c57ea691
 SHA512:
-  metadata.gz: 3ded8199c3356b1064778cde1a419b9567646a06538664e9374e89b990fff0150b2d05699521432a686617d4c0f29503e0f9ef845ade9edf900e2bcbbfa48279
-  data.tar.gz: 0a5b06b050046d22fed6967de257ae477820d392906d9dc61da048107707b1d926229fcc8380d21bebf788c6ac28d5cb779295b115b6f0aac4b51a5a02d221c3
+  metadata.gz: 9656b5d8333933c4288c7cf16940594f2806e19b471ddaef9b1d62017431146b54b26009840721e1330a2037adcf710c59db0e685d6dbc15ed4cb12fdbb51908
+  data.tar.gz: 4f59956d9d64177f16da24637b0237e06b38f258b1c147c9d1e706f6f4b666a271843304bfaae6280134483442410ff29cfc0bf8238ef5f9de4df3dec3c7d27e

data/README.md

@@ -30,7 +30,7 @@ thous informations to the method `MetaHari.spy`.
 
 ```ruby
 product = MetaHari.spy('http://www.amazon.de/Gastroback-42429-Design-Wasserkocher-Advanced/dp/B000LQXC2Q/ref=sr_1_1')
-product.inspect # => #<OpenStruct name="Gastroback 42429 Design Wasserkocher Advanced Pro", image="http://ecx.images-amazon.com/images/I/814Yl6mxLsL._SL1500_.jpg", description="">
+product.inspect # => #<MetaHari::Product:0x007fd9dba99158 @name="Gastroback 42429 Design Wasserkocher Advanced Pro", @image="http://ecx.images-amazon.com/images/I/814Yl6mxLsL._SL1500_.jpg", @description="">
 ```
 
 ## Implemented spyglasses
@@ -41,8 +41,9 @@ custom shops which can not be spyed by the generic spyglass
 
 * Amazon DE
 * Generic
-  * Shops using [JSON-LD](https://developers.google.com/structured-data/rich-snippets/products)
-  * Shops using [Microdata](https://developers.google.com/structured-data/rich-snippets/products)
+  * [JSON-LD](https://developers.google.com/structured-data/rich-snippets/products)
+  * [Microdata](https://developers.google.com/structured-data/rich-snippets/products)
+  * [Open Graph](http://ogp.me/)
 
 ### Creating a spyglass
 
@@ -58,12 +59,12 @@ module MetaHari
         %w(amazon.de www.amazon.de).include? uri.host.downcase
       end
 
-      def spy
-        OpenStruct.new(name: title, image: image, description: '')
-      end
-
       protected
 
+      def spy_list
+        [:spy_amazon]
+      end
+
       def title
         document.css('#productTitle').text
       end
@@ -73,6 +74,10 @@ module MetaHari
         data &&= data.attr 'data-old-hires'
         data && data.value
       end
+
+      def spy_amazon
+        { 'name' => title, 'image' => image, 'description' => '' }
+      end
     end
   end
 end

data/lib/meta_hari/helpers/open_graph.rb

@@ -0,0 +1,41 @@
+module MetaHari
+  module Helpers
+    class OpenGraph
+      attr_reader :document
+
+      def initialize(document)
+        @document = document
+      end
+
+      def data
+        hash
+      end
+
+      protected
+
+      def selector
+        'meta[property^="og:"]'
+      end
+
+      def hash
+        @hash ||= begin
+                    result = {}
+                    document.css(selector).each do |meta|
+                      key   = meta.attr('property').to_s.gsub(/^og:/i, '')
+                      value = meta.attr('content')
+                      result[key_map(key)] = value
+                    end
+                    result
+                  end
+      end
+
+      def key_map(key)
+        case key.downcase
+        when 'title' then 'name'
+        else
+          key.downcase
+        end
+      end
+    end
+  end
+end

data/lib/meta_hari/helpers.rb

@@ -1,5 +1,6 @@
 require 'meta_hari/helpers/json_ld'
 require 'meta_hari/helpers/microdata'
+require 'meta_hari/helpers/open_graph'
 
 module MetaHari
   module Helpers

data/lib/meta_hari/product.rb

@@ -0,0 +1,24 @@
+module MetaHari
+  class Product
+    attr_reader :name
+    attr_reader :image
+    attr_reader :description
+
+    def initialize(attributes = {})
+      apply attributes
+    end
+
+    def apply(attributes)
+      @name        = attributes['name']         if blank? name
+      @image       = attributes['image']        if blank? image
+      @description = attributes['description']  if blank? description
+      self
+    end
+
+    private
+
+    def blank?(value)
+      value.nil? || value.empty?
+    end
+  end
+end

data/lib/meta_hari/spyglass/amazon_de.rb

@@ -5,12 +5,12 @@ module MetaHari
         %w(amazon.de www.amazon.de).include? uri.host.downcase
       end
 
-      def spy
-        OpenStruct.new(name: title, image: image, description: '')
-      end
-
       protected
 
+      def spy_list
+        [:spy_amazon]
+      end
+
       def title
         document.css('#productTitle').text
       end
@@ -20,6 +20,10 @@ module MetaHari
         data &&= data.attr 'data-old-hires'
         data && data.value
       end
+
+      def spy_amazon
+        { 'name' => title, 'image' => image, 'description' => '' }
+      end
     end
   end
 end

data/lib/meta_hari/spyglass/base.rb

@@ -14,14 +14,20 @@ module MetaHari
       end
 
       def spy
-        OpenStruct.new [
-          spy_json_ld,
-          spy_microdata
-        ].inject({}) { |a, e| a.merge e }
+        spy_list.map { |method| send method }
+          .inject(MetaHari::Product.new) { |a, e| a.apply e }
       end
 
       protected
 
+      def spy_list
+        [
+          :spy_json_ld,
+          :spy_microdata,
+          :spy_open_graph
+        ]
+      end
+
       def user_agent
         [
           'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5)',
@@ -64,6 +70,11 @@ module MetaHari
         microdata = MetaHari::Helpers::Microdata.new(document, uri.to_s)
         microdata.data
       end
+
+      def spy_open_graph
+        open_graph = MetaHari::Helpers::OpenGraph.new(document)
+        open_graph.data
+      end
     end
   end
 end

data/lib/meta_hari/version.rb

@@ -1,4 +1,4 @@
 # MetaHari version
 module MetaHari
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/lib/meta_hari.rb

@@ -5,6 +5,7 @@ require 'net/http'
 require 'microdata'
 require 'meta_hari/version'
 require 'meta_hari/helpers'
+require 'meta_hari/product'
 require 'meta_hari/spyglass'
 
 # MetaHary will find product informations for a given product link. The

data/spec/lib/meta_hari/helpers/open_graph_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+describe MetaHari::Helpers::OpenGraph do
+  let(:url) do
+    [
+      'http://www.arzberg-porzellan.com/en/shop/products/bowls/sauce-boats',
+      'sauceboat-0-35-l-form-1382-blaubluten/'
+    ].join('/')
+  end
+  let(:html)     { resource_content('arzberg_porzellan.html') }
+  let(:document) { Nokogiri::HTML html }
+  let(:instance) { described_class.new document }
+  subject        { instance }
+
+  describe '#initialize' do
+    it 'assigns the document to the reader' do
+      expect(subject.document).to be document
+    end
+  end
+
+  context 'when containing Open Graph data' do
+    describe '#hash' do
+      subject { instance.send :hash }
+
+      it { should be_an Hash }
+    end
+
+    describe '#data' do
+      subject { instance.data }
+
+      it 'uses #hash' do
+        expect(instance).to receive(:hash).and_return([])
+        subject
+      end
+
+      it { should be_a Hash }
+      it { should have_key 'name' }
+      it { should have_key 'image' }
+      it { should have_key 'description' }
+
+      it 'has matching name' do
+        expect(subject['name']).to eql 'Sauceboat 0.35 l FORM 1382 | BLAUBLÜTEN'
+      end
+    end
+  end
+
+  context 'when not containing Open Graph data' do
+    let(:html) { '' }
+
+    describe '#hash' do
+      subject { instance.send :hash }
+
+      it { should be_an Hash }
+    end
+  end
+end

data/spec/lib/meta_hari/spyglass/amazon_de_spec.rb

@@ -39,7 +39,7 @@ describe MetaHari::Spyglass::AmazonDe do
     let(:html) { resource_content 'amazon_de.html' }
     subject    { instance.spy }
 
-    it { should be_an OpenStruct }
+    it { should be_an MetaHari::Product }
     it { should respond_to :name }
     it { should respond_to :image }
     it { should respond_to :description }

data/spec/lib/meta_hari/spyglass/base_spec.rb

@@ -54,7 +54,7 @@ describe MetaHari::Spyglass::Base do
         allow(instance).to receive(:fetch_data).and_return(html)
       end
 
-      it { should be_an OpenStruct }
+      it { should be_an MetaHari::Product }
       it { should respond_to :name }
       it { should respond_to :image }
       it { should respond_to :description }
@@ -88,7 +88,7 @@ describe MetaHari::Spyglass::Base do
         allow(instance).to receive(:fetch_data).and_return(html)
       end
 
-      it { should be_an OpenStruct }
+      it { should be_an MetaHari::Product }
       it { should respond_to :name }
       it { should respond_to :image }
       it { should respond_to :description }
@@ -116,5 +116,41 @@ describe MetaHari::Spyglass::Base do
         expect(subject.description).to eql expected_value
       end
     end
+
+    context 'with Open Graph document' do
+      let(:html)     { resource_content 'arzberg_porzellan.html' }
+      let(:instance) { described_class.new(uri) }
+      subject        { instance.spy }
+
+      before :each do
+        allow(instance).to receive(:fetch_data).and_return(html)
+      end
+
+      it { should be_an MetaHari::Product }
+      it { should respond_to :name }
+      it { should respond_to :image }
+      it { should respond_to :description }
+
+      it 'has the correct name' do
+        expect(subject.name).to eql 'Sauceboat 0.35 l FORM 1382 | BLAUBLÜTEN'
+      end
+
+      it 'has the correct image url' do
+        expected_value = [
+          'http://arzberg-c00.kxcdn.com/cache/dc/db',
+          'dcdbb5956e1f9fb60de351fbd21a9c4d.jpg'
+        ].join('/')
+        expect(subject.image).to eql expected_value
+      end
+
+      it 'has the correct description' do
+        expected_value = [
+          'Order online our Sauceboat 0.35 l FORM 1382 | BLAUBLÜTEN. ✓ Large',
+          'Range ✓ Best Quality ✓ Directly from the Manufacturer ▻',
+          'Arzberg-Porzellan.com'
+        ].join(' ')
+        expect(subject.description).to eql expected_value
+      end
+    end
   end
 end