RubyGems - met_museum - Versions diffs - 1.4.1 → 1.4.2 - Mend

met_museum 1.4.1 → 1.4.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (13) hide show

checksums.yaml +4 -4
data/.github/workflows/ruby.yml +1 -1
data/.rbgithook/pre-commit +2 -0
data/.ruby-version +1 -0
data/Gemfile +2 -0
data/Gemfile.lock +37 -43
data/README.md +1 -1
data/lib/met_museum/collection.rb +13 -10
data/lib/met_museum/http_status_code.rb +4 -2
data/lib/met_museum/version.rb +1 -1
data/met_museum.gemspec +0 -3
metadata +5 -32
data/.travis.yml +0 -13

checksums.yaml CHANGED Viewed

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 747d015331b55f840aa0065fbfc3e2822fda2f2f52a5a6ddede4b7f62ade5735
-  data.tar.gz: ac3158ff771e89fc1fb3d563920b02797c97c15be9dbd8a1ed5618649b53194b
+  metadata.gz: 45f5c8d43daa6e64da5cb3c6788ee090c82070d84d9dbca31afb0bb3463dfcdc
+  data.tar.gz: 2bbbf5262f1bef794f6af6b7656903d17b1b9b11b5b37679a49a6abb852a6818
 SHA512:
-  metadata.gz: c02a1a47672656535464183e79b4129b0d4b12632b48382afe8a3aff36d24af355620b51097324157f04342c361dcf62d74396916b52edf05359de6a011a37b1
-  data.tar.gz: 33eedda5f92fe536476dd03c0ba50aad36610f09440fcf15317b905baeac576108d3ac7993269a2619ed403c3ab5883a21193d87da2f72c3fb9e5358a67dd58f
+  metadata.gz: 03053e41e8aa40ab045f480a7bfbe0bfb38a2a909d5776f937938acec59afc3d964cb508e5756de2e11ae123059718659a8e4bcd74247e3eb84837c6ba9d9b9b
+  data.tar.gz: 214a6dd1cbeb31b8aa221fe794c7f3bcda4af5ef6ab41498830c8e4cd0582c2d7ea30178eff241f0c177ee618ab40dc577e1fbaa7492a2ecbadc0378bcffa13b

data/.github/workflows/ruby.yml CHANGED Viewed

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [ '2.6', '2.7', '3.0', '3.1' ]
+        ruby: [ '2.7', '3.0', '3.1' ]
     name: Ruby ${{ matrix.ruby }} spec
     steps:
     - uses: actions/checkout@v2

data/.rbgithook/pre-commit ADDED Viewed

	@@ -0,0 +1,2 @@
1	+ #!/usr/bin/env sh
2	+ bundle exec rspec spec/

data/.ruby-version ADDED Viewed

	@@ -0,0 +1 @@
1	+ 3.1.0

data/Gemfile CHANGED Viewed

@@ -6,3 +6,5 @@ end
 # Specify your gem's dependencies in met_museum.gemspec
 gemspec
+gem "rbgithook", "~> 0.1.2"

data/Gemfile.lock CHANGED Viewed

@@ -1,61 +1,54 @@
 PATH
   remote: .
   specs:
-    met_museum (1.4.1)
-      faraday
-      oj
+    met_museum (1.4.2)
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.1)
-    coderay (1.1.2)
-    diff-lcs (1.3)
-    faraday (1.2.0)
-      multipart-post (>= 1.2, < 3)
-      ruby2_keywords
-    method_source (0.9.2)
-    multipart-post (2.1.1)
-    oj (3.10.6)
-    parallel (1.19.2)
-    parser (2.7.1.4)
+    ast (2.4.2)
+    coderay (1.1.3)
+    diff-lcs (1.5.0)
+    method_source (1.0.0)
+    parallel (1.22.1)
+    parser (3.1.2.0)
       ast (~> 2.4.1)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    rainbow (3.0.0)
-    rake (13.0.1)
-    regexp_parser (1.7.1)
+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    rainbow (3.1.1)
+    rake (13.0.6)
+    rbgithook (0.1.2)
+    regexp_parser (2.5.0)
     rexml (3.2.5)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.2)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-retry (0.6.1)
+      rspec-support (~> 3.11.0)
+    rspec-retry (0.6.2)
       rspec-core (> 3.3)
-    rspec-support (3.8.0)
-    rubocop (0.86.0)
+    rspec-support (3.11.0)
+    rubocop (1.30.1)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.7)
-      rexml
-      rubocop-ast (>= 0.0.3, < 1.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.18.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.1.0)
-      parser (>= 2.7.0.1)
-    ruby-progressbar (1.10.1)
-    ruby2_keywords (0.0.5)
-    unicode-display_width (1.7.0)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.18.0)
+      parser (>= 3.1.1.0)
+    ruby-progressbar (1.11.0)
+    unicode-display_width (2.1.0)
 PLATFORMS
   ruby
@@ -65,6 +58,7 @@ DEPENDENCIES
   met_museum!
   pry
   rake (~> 13.0)
+  rbgithook (~> 0.1.2)
   rspec (~> 3.0)
   rspec-retry
   rubocop

data/README.md CHANGED Viewed

@@ -1,4 +1,4 @@
-<img src="https://img.shields.io/travis/hyuraku/met_museum.svg"> <img src="https://img.shields.io/github/license/hyuraku/met_museum.svg">
+<img src="https://img.shields.io/github/workflow/status/hyuraku/rbgithook/Ruby"> <img src="https://img.shields.io/github/license/hyuraku/met_museum.svg">
  <img src="https://img.shields.io/gem/v/met_museum.svg">
 # MetMuseum

data/lib/met_museum/collection.rb CHANGED Viewed

@@ -1,10 +1,6 @@
-require "met_museum/api_expections"
 require "met_museum/endpoint"
 require "met_museum/http_status_code"
-require "faraday"
-require "oj"
 module MetMuseum
   class Collection
     # Return a listing of all valid Object IDs available to use
@@ -116,12 +112,17 @@ module MetMuseum
     private
-    def create_request(url, dir, params = nil)
-      Faraday.new(url: url).get dir, params
+    def create_request(url, dir, params = {})
+      require 'uri'
+      require 'net/http'
+      uri = URI.join(url, dir)
+      uri.query = URI.encode_www_form(params)
+      Net::HTTP.get_response(uri)
     end
-    def response_successful?(response)
-      response.status == HTTP_OK_CODE
+    def response_successful?(response_code)
+      response_code == HTTP_OK_CODE
     end
     def check_date(date)
@@ -132,9 +133,11 @@ module MetMuseum
     end
     def arrange_response(response)
-      return Oj.load(response.body) if response_successful?(response)
+      response_code = response.code.to_i
+      require 'json'
+      return JSON.parse(response.body) if response_successful?(response_code)
-      raise MetMuseum.error_class(response), "Code: #{response.status}, response: #{response.body}"
+      raise MetMuseum.error_class(response_code), "Code: #{response_code}, response: #{response.body}"
     end
     def multi_option

data/lib/met_museum/http_status_code.rb CHANGED Viewed

@@ -1,3 +1,5 @@
+require "met_museum/api_expections"
 module MetMuseum
   HTTP_OK_CODE = 200
   HTTP_BAD_REQUEST_CODE = 400
@@ -6,8 +8,8 @@ module MetMuseum
   HTTP_NOT_FOUND_CODE = 404
   HTTP_UNPROCESSABLE_ENTITY_CODE = 429
-  def self.error_class(response)
-    case response.status
+  def self.error_class(response_code)
+    case response_code
     when HTTP_BAD_REQUEST_CODE
       BadRequestError
     when HTTP_UNAUTHORIZED_CODE

data/lib/met_museum/version.rb CHANGED Viewed

@@ -1,3 +1,3 @@
 module MetMuseum
-  VERSION = "1.4.1".freeze
+  VERSION = "1.4.2".freeze
 end

data/met_museum.gemspec CHANGED Viewed

@@ -38,7 +38,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-retry"
   spec.add_development_dependency "rubocop"
-  spec.add_dependency "faraday"
-  spec.add_dependency "oj"
 end

metadata CHANGED Viewed

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: met_museum
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - hyuraku
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-02-05 00:00:00.000000000 Z
+date: 2022-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,34 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: faraday
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: oj
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: 'The Metropolitan Museum of Art Collection API wrapper '
 email:
 - calenthird@gamil.com
@@ -117,9 +89,10 @@ extra_rdoc_files: []
 files:
 - ".github/workflows/ruby.yml"
 - ".gitignore"
+- ".rbgithook/pre-commit"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".ruby-version"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
@@ -155,7 +128,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.3.8
 signing_key:
 specification_version: 4
 summary: MET museum api wrapper

data/.travis.yml DELETED Viewed

@@ -1,13 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-rvm:
-  - 2.7.1
-  - 2.6.0
-  - 2.5.0
-script:
-  - bundle exec rspec spec/
-before_install:
-  - gem install -v 2.0.1 bundler
-  - bundle update --bundler