met_museum 1.3.4 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f318ac9ca9aedae15b10e0202143b88719a0df5324a8057f33dda6ea52e59909
-  data.tar.gz: 1fb234a9ebbfd1f6bcd39f4626446a0fabaae0f10e7a98a9b41e0bb69c3783df
+  metadata.gz: a79a7c355d8200cfccab7fdb7fbd01f37a74ee82a555de9a4697a6800616d2e4
+  data.tar.gz: 647315d7446816af5ce68035edcbedf32593a89aad70c511632f8ce3abe652c5
 SHA512:
-  metadata.gz: c88e7b0f617dd49b90f05d6d78e5e0d0172dab5465b765adf747258d012b10879206e8a5065bfde771f140bb69b9c8ec3065332172af0bcab12467e4215ae9eb
-  data.tar.gz: d972b17a10bc8042d5663a361e4c8da5d611a7dcd0d7eef887c6e95ac274eb94adc608e5ef548ca9a9c9976dcafaae1674ff1dbd821e1d22be5e812a62dfd2f4
+  metadata.gz: e31f31134b22d04612fdc5ef4f303cbfe2f25a1da5b9e0b2784b0fc3415daa8b876afba041f1747dd407dbab0cf57ca29e0a7350c6dfb0c0c0215b1fca655816
+  data.tar.gz: 28828344996f33389508a8664939a18fd3f182800dfe81bb3bf14d7b68864ecaa56d94698d73c93df6592af98be7f631d896aaf648b9d10b730fa9f3eb864fc5

data/.github/workflows/ruby.yml

@@ -0,0 +1,32 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on: [push, pull_request]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.5', '2.6', '2.7', '3.0' ]
+    name: Ruby ${{ matrix.ruby }} spec
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+      uses: ruby/setup-ruby@v1
+      # uses: ruby/setup-ruby@ec106b438a1ff6ff109590de34ddc62c540232e0
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install dependencies
+      run: bundle install
+    - name: Run spec
+      run: bundle exec rake

data/.rubocop.yml

@@ -0,0 +1,13 @@
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Documentation:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: true
+  Max: 20

data/.travis.yml

@@ -3,9 +3,9 @@ sudo: false
 language: ruby
 cache: bundler
 rvm:
+  - 2.7.1
   - 2.6.0
   - 2.5.0
-  - 2.4.2
 script:
   - bundle exec rspec spec/
 before_install:

data/Gemfile

@@ -1,7 +1,7 @@
 source "https://rubygems.org"
 
 group :development do
-  gem 'pry'
+  gem "pry"
 end
 
 # Specify your gem's dependencies in met_museum.gemspec

data/Gemfile.lock

@@ -1,24 +1,32 @@
 PATH
   remote: .
   specs:
-    met_museum (1.3.3)
+    met_museum (1.4.0)
       faraday
       oj
 
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.1)
     coderay (1.1.2)
     diff-lcs (1.3)
-    faraday (0.15.4)
+    faraday (1.2.0)
       multipart-post (>= 1.2, < 3)
+      ruby2_keywords
     method_source (0.9.2)
     multipart-post (2.1.1)
-    oj (3.9.0)
+    oj (3.10.6)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    rake (10.5.0)
+    rainbow (3.0.0)
+    rake (13.0.1)
+    regexp_parser (1.7.1)
+    rexml (3.2.4)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -34,6 +42,20 @@ GEM
     rspec-retry (0.6.1)
       rspec-core (> 3.3)
     rspec-support (3.8.0)
+    rubocop (0.86.0)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
+      rexml
+      rubocop-ast (>= 0.0.3, < 1.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.1.0)
+      parser (>= 2.7.0.1)
+    ruby-progressbar (1.10.1)
+    ruby2_keywords (0.0.2)
+    unicode-display_width (1.7.0)
 
 PLATFORMS
   ruby
@@ -42,9 +64,10 @@ DEPENDENCIES
   bundler (~> 2.0)
   met_museum!
   pry
-  rake (~> 10.0)
+  rake (~> 13.0)
   rspec (~> 3.0)
   rspec-retry
+  rubocop
 
 BUNDLED WITH
    2.0.2

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019 hyuraku
+Copyright (c) 2020 hyuraku
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -322,4 +322,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the MetMuseum project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/met_museum/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the MetMuseum project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/hyuraku/met_museum/blob/master/CODE_OF_CONDUCT.md).

data/Rakefile

@@ -3,4 +3,4 @@ require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/lib/met_museum/api_expections.rb

@@ -3,7 +3,6 @@ module MetMuseum
   BadRequestError = Class.new(MetMuseumError)
   UnauthorizedError = Class.new(MetMuseumError)
   ForbiddenError = Class.new(MetMuseumError)
-  ApiRequestsQuotaReachedError = Class.new(MetMuseumError)
   NotFoundError = Class.new(MetMuseumError)
   UnprocessableEntityError = Class.new(MetMuseumError)
   ApiError = Class.new(MetMuseumError)

data/lib/met_museum/collection.rb

@@ -6,16 +6,18 @@ module MetMuseum
   class Collection
     # Return a listing of all valid Object IDs available to use
     # @param [Date] metadataDate Returns any objects with updated data after this date
+    # @param [DateTime] metadataDate Returns any objects with updated data after this date
     # @params [Integer] departmentIds Returns any objects in a specific department
     # @return [Hash<total, Integer>] The total number of publicly-available objects
     # @return [Hash<objectIDs, Array<Integer>>] An array containing the object ID of publicly-available object
-    def objects(options = {})
+    def objects(**args)
       options = {
         metadataDate: nil,
         departmentIds: nil
-      }.merge(options)
+      }.merge(args)
       options[:metadataDate] = check_date(options[:metadataDate])
-      response = Faraday.new(:url => API_ENDPOINT).get PUBLIC_URI, {:metadataDate => options[:metadataDate], :departmentIds => options[:departmentIds]}
+      query = { metadataDate: options[:metadataDate], departmentIds: options[:departmentIds] }
+      response = new_faraday(API_ENDPOINT, PUBLIC_URI, query)
       return_response(response)
     end
 
@@ -52,6 +54,8 @@ module MetMuseum
     # @return [Hash<objectEndDate, string>] Machine readable date indicating the year the artwork was completed (may be the same year or different year than the objectBeginDate)
     # @return [Hash<medium, string>] Refers to the materials that were used to create the artwork
     # @return [Hash<dimensions, string>] Size of the artwork or object
+    # @return [Hash<dimensionsParsed, Array<Hash>>] 	Size of the artwork or object in centimeters, parsed
+    # @return [Hash<measurements, Array<Hash>>] 	Array of elements, each with a name, description, and set of measurements. Spatial measurements are in centimeters; weights are in kg.
     # @return [Hash<creditLine, String>] 	Text acknowledging the source or origin of the artwork and the year the object was acquired by the museum.
     # @return [Hash<geographyType, String>] 	Qualifying information that describes the relationship of the place catalogued in the geography fields to the object that is being catalogued
     # @return [Hash<city, String>] City where the artwork was created
@@ -71,8 +75,12 @@ module MetMuseum
     # @return [Hash<repository, String>]
     # @return [Hash<objectURL, String>] URL to object's page on metmuseum.org
     # @return [Hash<tags,  Array<String>>] An array of subject keyword tags associated with the object
-    def object(objectID)
-      response = Faraday.get "#{API_ENDPOINT}#{PUBLIC_URI}/#{objectID}"
+    # @return [Hash<objectWikidata_URL, string>] Wikidata URL for the object
+    # @return [Hash<isTimelineWork, boolean>] Whether the object is on the Timeline of Art History website
+    # @return [Hash<GalleryNumber, string>] Gallery number, where available
+
+    def object(object_id)
+      response = new_faraday(API_ENDPOINT, "#{PUBLIC_URI}/#{object_id}")
       return_response(response)
     end
 
@@ -81,7 +89,7 @@ module MetMuseum
     # @return [Integer] departments Department ID as an integer. The departmentId is to be used as a query parameter on the `/objects` endpoint
     # @return [String] departments Display name for a department
     def department
-      response = Faraday.get "#{API_ENDPOINT}#{DEPARTMENTS_URI}"
+      response = new_faraday(API_ENDPOINT, DEPARTMENTS_URI)
       return_response(response)
     end
 
@@ -92,54 +100,20 @@ module MetMuseum
     # @return [Integer] total The total number of publicly-available objects
     # @return [Array<Integer>] objectIDs An array containing the object ID of publicly-available object
     # @return [Array<Object>] objects An array containing the objects that contain the search query within the object’s data
-    def search(query, options = {})
-      options = {
-        limit: 0,
-        isHighlight: false,
-        departmentId: nil,
-        isOnView: nil,
-        artistOrCulture: nil,
-        medium: nil,
-        hasImages: nil,
-        geoLocation: nil,
-        dateBegin: 0,
-        dateEnd: 2000
-      }.merge(options)
-      response = Faraday.new(:url => API_ENDPOINT).get SEARCH_URI, {
-        :q => query, 
-        :isHighlight => options[:isHighlight], 
-        :departmentId => options[:departmentId],
-        :isOnView => options[:isOnView],
-        :artistOrCulture => options[:artistOrCulture],
-        :medium => options[:medium],
-        :hasImages => options[:hasImages],
-        :geoLocation => options[:geoLocation],
-        :dateBegin => options[:dateBegin],
-        :dateEnd => options[:dateEnd]
-      }
+    def search(query, **args)
+      args.merge!({q: query})
+      response = new_faraday(API_ENDPOINT, SEARCH_URI, args)
       origin_response = return_response(response)
-      return origin_response if options[:limit] <= 0
-      origin_response["objectIDs"][0..options[:limit] - 1].map{|id| MetMuseum::Collection.new.object(id)}
+      limit = args[:limit].to_i
+      return origin_response if limit <= 0
+
+      origin_response["objectIDs"][0..limit - 1].map { |id| MetMuseum::Collection.new.object(id) }
     end
 
     private
 
-    def error_class(response)
-      case response.status
-      when HTTP_BAD_REQUEST_CODE
-        BadRequestError
-      when HTTP_UNAUTHORIZED_CODE
-        UnauthorizedError
-      when HTTP_FORBIDDEN_CODE
-        return ApiRequestsQuotaReachedError if api_requests_quota_reached?
-        ForbiddenError
-      when HTTP_NOT_FOUND_CODE
-        NotFoundError
-      when HTTP_UNPROCESSABLE_ENTITY_CODE
-        UnprocessableEntityError
-      else
-        ApiError
-      end
+    def new_faraday(url, dir, params = nil)
+      Faraday.new(url: url).get dir, params
     end
 
     def response_successful?(response)
@@ -148,7 +122,7 @@ module MetMuseum
 
     def check_date(date)
       return nil if date.nil?
-      return date.to_s if date.class == Date
+      return date.to_date.to_s if date.is_a? Date
 
       raise TypeError, "Write certain date"
     end
@@ -156,7 +130,14 @@ module MetMuseum
     def return_response(response)
       return Oj.load(response.body) if response_successful?(response)
 
-      raise error_class(response), "Code: #{response.status}, response: #{response.body}"
+      raise MetMuseum.error_class(response), "Code: #{response.status}, response: #{response.body}"
+    end
+
+    def multi_option
+      return self if is_a? String
+      return join("|") if is_a? Array
+
+      raise TypeError, "Write String or Array type"
     end
   end
 end

data/lib/met_museum/http_status_code.rb

@@ -1,8 +1,25 @@
 module MetMuseum
-  HTTP_OK_CODE = 200.freeze
-  HTTP_BAD_REQUEST_CODE = 400.freeze
-  HTTP_UNAUTHORIZED_CODE = 401.freeze
-  HTTP_FORBIDDEN_CODE = 403.freeze
-  HTTP_NOT_FOUND_CODE = 404.freeze
-  HTTP_UNPROCESSABLE_ENTITY_CODE = 429.freeze
+  HTTP_OK_CODE = 200
+  HTTP_BAD_REQUEST_CODE = 400
+  HTTP_UNAUTHORIZED_CODE = 401
+  HTTP_FORBIDDEN_CODE = 403
+  HTTP_NOT_FOUND_CODE = 404
+  HTTP_UNPROCESSABLE_ENTITY_CODE = 429
+
+  def self.error_class(response)
+    case response.status
+    when HTTP_BAD_REQUEST_CODE
+      BadRequestError
+    when HTTP_UNAUTHORIZED_CODE
+      UnauthorizedError
+    when HTTP_FORBIDDEN_CODE
+      ForbiddenError
+    when HTTP_NOT_FOUND_CODE
+      NotFoundError
+    when HTTP_UNPROCESSABLE_ENTITY_CODE
+      UnprocessableEntityError
+    else
+      ApiError
+    end
+  end
 end

data/lib/met_museum/version.rb

@@ -1,3 +1,3 @@
 module MetMuseum
-  VERSION = "1.3.4"
+  VERSION = "1.4.0".freeze
 end

data/met_museum.gemspec

@@ -1,5 +1,4 @@
-
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "met_museum/version"
 
@@ -9,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ["hyuraku"]
   spec.email         = ["calenthird@gamil.com"]
 
-  spec.summary       = %q{MET museum api wrapper}
-  spec.description   = %q{The Metropolitan Museum of Art Collection API wrapper }
+  spec.summary       = "MET museum api wrapper"
+  spec.description   = "The Metropolitan Museum of Art Collection API wrapper "
   spec.homepage      = "https://github.com/hyuraku/met_museum"
   spec.license       = "MIT"
 
@@ -27,7 +26,7 @@ Gem::Specification.new do |spec|
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
   spec.bindir        = "exe"
@@ -35,9 +34,10 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "rspec-retry"
+  spec.add_development_dependency "rubocop"
 
   spec.add_dependency "faraday"
   spec.add_dependency "oj"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: met_museum
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.4.0
 platform: ruby
 authors:
 - hyuraku
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-08 00:00:00.000000000 Z
+date: 2020-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -101,8 +115,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -139,7 +155,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: MET museum api wrapper