messagebird 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f5884d21d68ea0f75197081e449a185b223de84c
-  data.tar.gz: 08c4d01e03dc0a66ecf52546faa44be8269995d9
+  metadata.gz: cdf8c0f25e17948ac7a654fec62921c47b53a113
+  data.tar.gz: c524dba34f1ca0b23e94f756c6855167d15889d4
 SHA512:
-  metadata.gz: 88c3936162b49a6c835abfa08a5f733e12ed4b95311a364ceec1979fd730851444a8c948921f6922e20400ee8ec96d9d7ffde9ed2a71b64d66800845e6a70ad0
-  data.tar.gz: a03a8b13286a27194aed77f4556d9657caa6cfccc9bf6fe418d79f54bca27619e69a0cc498831ea4c1a7e7d5cf7063ff6d89ac4a7a2df6f8f53f9598e3f0d0a4
+  metadata.gz: c7ea06262d1e743ffd96b5bc47ef35b337d1bac02a7799748d3c59e1719f5190f5111e64ea249a9c3444e59c84998df0cb2e3e8e9a166b71a1104477e6a7c865
+  data.tar.gz: 20201d522b0c8249fd80521eeb2842af4d84b95889e6570ecea74502321e523e5f9579a30464b1e0390aab2e141cdc3a21505a2155b318e43568a791dad9d9d0

data/CHANGES.md

@@ -1,3 +1,16 @@
+0.1.4
+-----------
+- Introduces a new config option :enabled, which is set to false by default.
+  This was added to prevent test and development enviroments from establishing actual connections
+  to the MessageBird servers. Connections may be enabled by setting:
+
+  ```ruby
+  MessageBird.configure do
+    enabled true
+  end
+  ```
+
+
 0.1.3
 -----------
 - Sender_ID is now validated. Valid formats are:

data/VERSION

@@ -1 +1 @@
-0.1.3
+0.1.4

data/lib/messagebird.rb

@@ -8,6 +8,7 @@ require 'messagebird/config'
 require 'messagebird/deliverable'
 require 'messagebird/helpers'
 require 'messagebird/sms'
+require 'messagebird/http/local_connection'
 require 'messagebird/http/sender'
 require 'messagebird/http/sms'
 require 'messagebird/http/response_code'

data/lib/messagebird/config.rb

@@ -13,7 +13,8 @@ module MessageBird
           :username =>    'replace_me',
           :password =>    'replace_me',
           :sender_name => 'replace_me',
-          :test_mode =>   true
+          :test_mode =>   true,
+          :enabled =>     false
         }
       end
 

data/lib/messagebird/http/local_connection.rb

@@ -0,0 +1,15 @@
+require 'ostruct'
+
+module MessageBird::HTTP
+  class LocalConnection
+
+    attr_writer :use_ssl
+
+    def initialize(host, port)
+    end
+
+    def request(obj)
+      OpenStruct.new(:body => '01')
+    end
+  end
+end

data/lib/messagebird/http/sender.rb

@@ -3,6 +3,7 @@ module MessageBird::HTTP
     class << self
 
       attr_writer :response_factory
+      attr_writer :enabled
 
       def deliver(sms, &block)
         ensure_valid_sms!(sms)
@@ -27,7 +28,7 @@ module MessageBird::HTTP
       end
 
       def create_connection(uri)
-        Net::HTTP.new(uri.host, uri.port).tap do |http|
+        connection_factory.call(uri.host, uri.port).tap do |http|
           http.use_ssl = true
           # http.verify_mode = OpenSSL::SSL::VERIFY_NONE
         end
@@ -41,8 +42,27 @@ module MessageBird::HTTP
         raise ArgumentError unless obj.is_a? MessageBird::HTTP::SMS
       end
 
+      def connection_factory
+        @connection_factory ||= connection_class.method(:new)
+      end
+
       def response_factory
-        @response_factory ||= Response.public_method(:new)
+        @response_factory ||= Response.method(:new)
+      end
+
+      def enabled
+        if @enabled.nil?
+          @enabled = MessageBird::Config.enabled
+        end
+        @enabled
+      end
+
+      def connection_class
+        if enabled
+          Net::HTTP
+        else
+          LocalConnection
+        end
       end
 
     end

data/messagebird.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: messagebird 0.1.3 ruby lib
+# stub: messagebird 0.1.4 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "messagebird"
-  s.version = "0.1.3"
+  s.version = "0.1.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Bram de Vries"]
-  s.date = "2014-01-30"
+  s.date = "2014-02-11"
   s.description = "Implementation of the MessageBird SMS API for Ruby"
   s.email = "dev@blaet.net"
   s.executables = ["messagebird_test_connection"]
@@ -32,6 +32,7 @@ Gem::Specification.new do |s|
     "lib/messagebird/config.rb",
     "lib/messagebird/deliverable.rb",
     "lib/messagebird/helpers.rb",
+    "lib/messagebird/http/local_connection.rb",
     "lib/messagebird/http/response.rb",
     "lib/messagebird/http/response_code.rb",
     "lib/messagebird/http/sender.rb",
@@ -42,6 +43,7 @@ Gem::Specification.new do |s|
     "test/messagebird/config_test.rb",
     "test/messagebird/deliverable_test.rb",
     "test/messagebird/helpers_test.rb",
+    "test/messagebird/http/local_connection_test.rb",
     "test/messagebird/http/response_code_test.rb",
     "test/messagebird/http/response_test.rb",
     "test/messagebird/http/sender_test.rb",

data/test/messagebird/http/local_connection_test.rb

@@ -0,0 +1,29 @@
+require 'helper'
+
+describe MessageBird::HTTP::LocalConnection do
+
+  let(:klass){ MessageBird::HTTP::LocalConnection }
+
+  subject{ klass.new("host", "port") }
+
+  describe '#initialize' do
+    it 'takes two arguments' do
+      klass.new("host", "port")
+    end
+  end
+
+  describe '#request' do
+    it 'responds to #request' do
+      assert subject.respond_to?(:request)
+    end
+
+    it 'takes one argument' do
+      subject.request("")
+    end
+
+    it 'always returns an object that responds with the :success response body' do
+      subject.request("").body.must_equal "01"
+    end
+  end
+
+end

data/test/messagebird/http/sender_test.rb

@@ -15,39 +15,32 @@ describe MessageBird::HTTP::Sender do
     stub(mock_connection).request{:bar}
   end
 
-  describe '#deliver' do
-    it 'sends the given sms' do
-      stub(subject).ensure_valid_sms!
-      mock(subject).send_sms(:foo)
-      subject.deliver(:foo)
-    end
+  after do
+    subject.enabled = false
+  end
 
-    it 'takes an optional block' do
-      stub(subject).ensure_valid_sms!
-      stub(subject).create_connection.with_any_args
-      stub(subject).create_request.with_any_args
-      stub(subject).send_request.with_any_args{'FooBat'}
-      subject.send(:send_sms, sms) do |response|
-        response.must_equal 'FooBat'
-      end
+  describe '#connection_class' do
+    it 'returns a Net::HTTP class' do
+      subject.enabled = true
+      subject.send(:connection_class).must_equal Net::HTTP
     end
 
-    it 'raises an ArgumentError when given object is not a valid SMS' do
-      assert_raises(ArgumentError){
-        subject.deliver('string')
-      }
+    describe 'local_loop variable set to true' do
+      it 'returns a LocalConnection class' do
+        subject.send(:connection_class).must_equal MessageBird::HTTP::LocalConnection
+      end
     end
   end
 
   describe '#create_connection' do
     it 'creates a new connection' do
-      mock(Net::HTTP).new.with_any_args{mock_connection}
+      mock(MessageBird::HTTP::LocalConnection).new.with_any_args{mock_connection}
       subject.send :create_connection, uri
     end
 
     it 'sets the connection to SSL' do
       mock(mock_connection).use_ssl=(true)
-      stub(Net::HTTP).new.with_any_args{mock_connection}
+      stub(MessageBird::HTTP::LocalConnection).new.with_any_args{mock_connection}
       subject.send :create_connection, uri
     end
   end
@@ -59,9 +52,33 @@ describe MessageBird::HTTP::Sender do
     end
   end
 
+  describe '#deliver' do
+    it 'sends the given sms' do
+      stub(subject).ensure_valid_sms!
+      mock(subject).send_sms(:foo)
+      subject.deliver(:foo)
+    end
+
+    it 'takes an optional block' do
+      stub(subject).ensure_valid_sms!
+      stub(subject).create_connection.with_any_args
+      stub(subject).create_request.with_any_args
+      stub(subject).send_request.with_any_args{'FooBat'}
+      subject.send(:send_sms, sms) do |response|
+        response.must_equal 'FooBat'
+      end
+    end
+
+    it 'raises an ArgumentError when given object is not a valid SMS' do
+      assert_raises(ArgumentError){
+        subject.deliver('string')
+      }
+    end
+  end
+
   describe '#response_factory' do
     it 'works' do
-      assert subject.send(:response_factory).is_a?(Proc)
+      subject.send(:response_factory).is_a?(Method)
     end
   end
 
@@ -87,11 +104,12 @@ describe MessageBird::HTTP::Sender do
       subject.send :send_sms, sms
     end
 
-    it 'creates sends the request over the connection' do
+    it 'sends the request over the connection' do
       stub(subject).create_connection.with_any_args{:foo}
       stub(subject).create_request.with_any_args{:bar}
       mock(subject).send_request(:foo, :bar){:bat}
       subject.send :send_sms, sms
     end
   end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: messagebird
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Bram de Vries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-30 00:00:00.000000000 Z
+date: 2014-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jeweler
@@ -45,6 +45,7 @@ files:
 - lib/messagebird/config.rb
 - lib/messagebird/deliverable.rb
 - lib/messagebird/helpers.rb
+- lib/messagebird/http/local_connection.rb
 - lib/messagebird/http/response.rb
 - lib/messagebird/http/response_code.rb
 - lib/messagebird/http/sender.rb
@@ -55,6 +56,7 @@ files:
 - test/messagebird/config_test.rb
 - test/messagebird/deliverable_test.rb
 - test/messagebird/helpers_test.rb
+- test/messagebird/http/local_connection_test.rb
 - test/messagebird/http/response_code_test.rb
 - test/messagebird/http/response_test.rb
 - test/messagebird/http/sender_test.rb