message_train 0.7.5 → 1.0.0

data/.ruby-version

@@ -1 +1 @@
-2.2.3
+4.0.6

data/.simplecov

@@ -1,8 +1,6 @@
 require 'simplecov'
-require 'coveralls'
 
-SimpleCov.formatter = Coveralls::SimpleCov::Formatter
 SimpleCov.start do
-   add_filter 'lib/message_train/localization.rb'
-   add_filter 'spec'
+  add_filter 'lib/message_train/localization.rb'
+  add_filter '/spec/'
 end

data/CHANGELOG.md

@@ -0,0 +1,128 @@
+# Changelog
+
+## 1.0.0
+
+**Breaking change.** This is a from-the-ground-up modernization: Rails
+4/5 support is dropped in favor of Rails >= 7.1, < 9, and several
+dependencies that no longer exist or no longer matter are removed.
+There is no automated migration path from a 0.7.x installation with
+real data — see "Upgrading to 1.0.0" in the README before adopting this
+version.
+
+### Breaking
+
+- **Ruby >= 3.2, Rails >= 7.1, < 9** required (was Rails 4/5).
+- **Paperclip replaced with ActiveStorage.** `MessageTrain::Attachment`
+  now uses `has_one_attached :attachment` with named `:thumb`/`:large`
+  variants instead of Paperclip styles. Host apps must run
+  `bin/rails active_storage:install` (if not already using
+  ActiveStorage) and `bin/rails db:migrate` before upgrading. **There is
+  no backfill for existing Paperclip-stored files** - this version
+  assumes a fresh attachments table. If you have production attachment
+  data on 0.7.x, either stay on 0.7.x or write your own backfill before
+  upgrading (walk `public/system/...`, attach each file via
+  `ActiveStorage::Attached::One#attach`, then run the paperclip-column
+  removal migration).
+- **CKEditor replaced with plain markdown, not Action Text.** Action
+  Text was evaluated and dropped in favor of markdown: message_train's
+  file attachments are already a separate `Attachment` model/list, not
+  embedded inline in the body, so Action Text's real differentiator
+  (drag-and-drop embeds baked into rich text) had no use here - it would
+  only have been a fancier textarea, at the cost of a real dependency
+  (Trix JS, `action_text_rich_texts` table, ActiveStorage's `main_app`
+  route-proxy requirement). `Message#body` is a plain `text` column,
+  rendered with `redcarpet` and sanitized through Rails' own `sanitize`
+  helper. No `action_text:install` step, no `has_rich_text`.
+- **Bootstrap and jQuery removed entirely** - not just the app-specific
+  vendor JS (cocoon, typeahead, tokenfield), but `bootstrap-sass`,
+  `bootstrap_form`, `bootstrap_leather`, and `jquery-rails` themselves.
+  Views are now semantic HTML styled by `message_train.scss` (still a
+  real stylesheet, now vanilla CSS) with Turbo Frames and hand-written
+  Stimulus controllers. If your host app's layout/theme assumed
+  MessageTrain's views were Bootstrap markup, expect visual changes.
+- **`importmap-rails`, `turbo-rails`, `stimulus-rails` are now runtime
+  dependencies.** The engine ships its own Stimulus controllers and
+  registers its own importmap pins and asset paths automatically via an
+  engine initializer - no manual pin-in wiring needed in the host app,
+  but the host app does need those three gems' own install generators
+  already run (i.e. be a normal Hotwire-based Rails 7+ app).
+- **Propshaft/`dartsass-rails` replace Sprockets.** If your host app is
+  still on Sprockets, either migrate it to Propshaft or vendor
+  `message_train.scss` yourself.
+- Dead `'Fixnum'` keys in `Box::MARK_METHODS` and
+  `Ignore::(UN)IGNORE_METHODS` fixed to `'Integer'` - these had been
+  silently no-oping since Ruby 2.4 on any installation using bare
+  integer IDs to mark/ignore.
+- **CSS classes are now scoped/prefixed** (`.icon` -> `.message-train-icon`,
+  `.badge` -> `.message-train-badge`, and similarly for
+  `.attachment-thumbnails`, `.box-actions`, `.conversation-actions`,
+  `.date-column`, `.btn-compose`, `.dropdown-nav-item`, `.message-actions`)
+  so a host app's own broad selectors (e.g. a bare `.badge` or `ul`
+  rule) can't reach into the engine's markup and override its styling.
+  Classes with no engine-defined rule (`btn`, `dropdown-menu`, etc. -
+  now `.message-train-button` where the engine does style them) were
+  left alone. If your host app styled MessageTrain by targeting the
+  old unprefixed class names, update those selectors.
+- **The install generator's example mount point changed from `/` to
+  `/messages`** (`mount MessageTrain::Engine => '/messages', as:
+  'message_train'`) - mounting an engine at the host app's root is
+  unusually collision-prone. This only affects fresh installs using
+  the generator's suggested route; if you already mounted at a
+  specific path, nothing changes for you.
+- **The box bulk-actions toolbar was redesigned**: the standalone
+  "Check All" checkbox is gone (the "Check Some" group's "All" button
+  does the same thing); the "Mark" actions are always-visible icon+text
+  buttons instead of hidden behind a dropdown. If your host app
+  customized this toolbar's markup or CSS, expect to redo that
+  customization.
+
+### Fixed
+
+- `Message#create_conversation_if_blank` now runs `before_validation`
+  instead of `before_create`, fixing conversation-presence validation
+  under Rails 5+'s default-required `belongs_to`.
+- `Role#resource`, `Unsubscribe#from`, `Receipt#received_through` marked
+  `optional: true` where they're intentionally nullable (global roles,
+  unsubscribe-from-everything, direct receipts), matching Rails 5+'s
+  default-required `belongs_to`.
+- `Receipt.mark`/`Message.mark` now bulk-update instead of looping a
+  per-row save, while still touching the affected messages/conversations
+  so inbox ordering and fragment-cache keys (which depend on
+  `Conversation#updated_at` bumping on mark) keep working.
+- Several N+1 query sites addressed: box/conversation listing now
+  preloads what its views actually walk per row, `Box#unread_count` and
+  `collective_boxes` are memoized per-instance, and
+  `Conversation#participant_ignored?` filters in-memory instead of
+  querying on every call. (`Conversation#includes_*_for?`'s receipt-flag
+  N+1 is a known, documented remaining case - see the comment at
+  `Conversation#includes_matching_receipts?`.)
+- New indexes on `message_train_receipts.marked_read/marked_trash/
+  marked_deleted`, `message_train_conversations.updated_at`, and
+  `message_train_messages.draft`.
+- `Conversation#new_reply` no longer builds the reply body as
+  `<blockquote>...</blockquote>` HTML, stale from the Action Text era -
+  since `Message#body` is plain markdown text now, replies were being
+  pre-filled with literal HTML tags as visible text. Replies now quote
+  the previous message as proper markdown (`> ` per line).
+- Attaching a file and submitting a message that then fails validation
+  (e.g. a blank subject) no longer crashes on re-render. The nested
+  attachment-fields partial checked `attachment.attached?`, which is
+  true as soon as a file is chosen in-memory even before its
+  ActiveStorage blob is persisted; it now also checks
+  `attachment.blob.persisted?` before building a thumbnail/link URL.
+- The conversations listing table (box/collective show pages) now
+  actually fills its container (`width: 100%`, real cell padding/
+  borders) instead of shrinking to its content width.
+
+### Tooling (shouldn't affect host apps)
+
+- Juwelier replaced with a hand-written gemspec; `Rakefile` no longer
+  depends on it.
+- Travis CI replaced with GitHub Actions.
+- factory_girl -> factory_bot, poltergeist -> Cuprite, coveralls dropped,
+  `should` -> `expect` syntax throughout the spec suite, rubocop bumped
+  with rubocop-rails/rubocop-rspec.
+
+## 0.7.6 and earlier
+
+See git history - no changelog was kept before 1.0.0.

data/CLAUDE.md

@@ -0,0 +1,5 @@
+# message_train
+
+## Client
+
+Fiendish Labs, via GemVein (owns all gems, owned by Fiendish Labs). Fiendish Labs (Calendula and Martusjaav's household company). See `Office/projects/TYPES.md`'s Ownership section for the full taxonomy.

data/Gemfile

@@ -1,58 +1,56 @@
 source 'https://rubygems.org'
 # Add dependencies required to use your gem here.
 # Example:
-gem 'haml-rails', '>= 1', '< 2'
-gem 'jquery-rails', '~> 4'
-gem 'paperclip', '>= 4.2', '< 6'
-gem 'rails', '>= 4', '< 6'
-gem 'rails-i18n', '>= 4', '< 6'
-gem 'uglifier', '>= 2.7', '< 4'
+gem 'haml-rails', '>= 2'
+gem 'rails', '>= 7.1', '< 9'
+gem 'rails-i18n', '>= 7', '< 9'
+gem 'image_processing', '~> 1.2'
+gem 'mini_magick', '~> 4.12'
+gem 'benchmark' # mini_magick requires it; no longer a Ruby default gem as of 4.0
 
 # Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
 gem 'jbuilder', '~> 2.0'
 
-gem 'bootstrap-sass', '~> 3.3'
-gem 'bootstrap_form', '~> 2.3'
-gem 'bootstrap_leather', '>= 0.10.11', '< 1'
+gem 'dartsass-rails', '~> 0.5'
+gem 'importmap-rails', '~> 2.0'
 gem 'kaminari', '~> 1.0'
-gem 'bootstrap_tokenfield_rails', '~> 0.12'
-gem 'ckeditor'
-gem 'cocoon', '~> 1.2'
-gem 'jquery-ui-bootstrap-rails'
-gem 'sass-rails', '~> 5'
-gem 'twitter-typeahead-rails'
+gem 'propshaft', '~> 1.1'
+gem 'redcarpet', '~> 3.6'
+gem 'stimulus-rails', '~> 1.3'
+gem 'turbo-rails', '~> 2.0'
 
 # Add dependencies to develop your gem here.
 # Include everything needed to run rake, tests, features, etc.
 group :development do
-  gem 'bundler', '~> 1.0'
-  gem 'juwelier', '~> 2'
-  gem 'rubocop', '~> 0.47.1', require: false
-  gem 'scss_lint', '~> 0.52', require: false
+  gem 'rubocop', '~> 1.6', require: false
+  gem 'rubocop-rails', '~> 2.25', require: false
+  gem 'rubocop-rake', '~> 0.7', require: false
+  gem 'rubocop-rspec', '~> 3.0', require: false
 end
 
 group :development, :test do
-  gem 'byebug', '~> 9'
+  gem 'byebug', '~> 11'
   gem 'devise', '~> 4'
-  gem 'factory_girl_rails', '~> 4.5'
-  gem 'faker', '~> 1.4'
+  gem 'factory_bot_rails', '~> 6.4'
+  gem 'faker', '~> 3'
   gem 'friendly_id', '~> 5'
   gem 'high_voltage', '~> 3'
-  gem 'rolify', '>= 4', '< 5.2'
-  gem 'rspec-its', '>= 1'
-  gem 'rspec-rails', '>= 3', '< 4'
+  gem 'rolify', '>= 4'
+  gem 'rspec-its', '>= 1', '< 2'
+  gem 'rspec-rails', '~> 7.0'
   gem 'seedbank', '~> 0.3'
-  gem 'sqlite3', '~> 1.3'
+  gem 'sqlite3', '~> 2.1'
 end
 
 group :test do
-  gem 'capybara', '~> 2.4'
-  gem 'coveralls', '~> 0.8', require: false
-  gem 'database_cleaner', '~> 1.4'
+  gem 'capybara', '~> 3.40'
+  gem 'cuprite', '~> 0.15'
+  gem 'database_cleaner-active_record', '~> 2.1'
   gem 'launchy', '~> 2', require: false
-  gem 'poltergeist', '~> 1.14'
+  gem 'puma', '~> 6.0'
   gem 'rails-controller-testing', '~> 1.0'
   gem 'rspec-collection_matchers', '>= 1'
-  gem 'rspec-html-matchers', '~> 0.7'
-  gem 'shoulda-matchers', '>= 2.8', '< 3.2'
+  gem 'rspec-html-matchers', '~> 0.10'
+  gem 'shoulda-matchers', '~> 6.0'
+  gem 'simplecov', '~> 0.22', require: false
 end

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2015 Gem Vein
+Copyright (c) 2015-2026 Gem Vein
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,16 +1,30 @@
 # MessageTrain
-[![Build Status](https://travis-ci.org/gemvein/message_train.svg)](https://travis-ci.org/gemvein/message_train) 
-[![Coverage Status](https://coveralls.io/repos/gemvein/message_train/badge.svg?branch=master&service=github)](https://coveralls.io/github/gemvein/message_train?branch=master) 
-[![Gem Version](https://badge.fury.io/rb/message_train.svg)](http://badge.fury.io/rb/message_train)
-
-MessageTrain is a Rails 4 and 5 Private Messaging Gem that uses bootstrap to send
-and display private messages from one user to another. It can also be
-configured to send messages to a user collective (such as a certain Role or
-Group of users).
+[![CI](https://github.com/gemvein/message_train/actions/workflows/ci.yml/badge.svg)](https://github.com/gemvein/message_train/actions/workflows/ci.yml)
+[![Gem Version](https://img.shields.io/gem/v/message_train)](https://rubygems.org/gems/message_train)
+[![Coverage](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/gemvein/message_train/HEAD/badges/coverage.json)](https://github.com/gemvein/message_train/actions/workflows/ci.yml)
+[![License: MIT](https://img.shields.io/badge/license-MIT-blue)](http://opensource.org/licenses/MIT)
+
+<!--
+  MessageTrain ships real views/CSS/JS, so it's a candidate for these once
+  each has a real automated check backing it - add whichever apply as that
+  check is actually wired up and passing. Don't add a badge for a check
+  that isn't actually running; an unbacked badge is worse than none. None
+  of these checks exist yet as of 2026-08-28.
+
+  [![Semantic HTML](https://img.shields.io/badge/html-semantic-blueviolet)](#)
+  [![CSS: clean](https://img.shields.io/badge/css-clean-blueviolet)](#)
+  [![JS: vanilla & minimal](https://img.shields.io/badge/js-vanilla%20%26%20minimal-blueviolet)](#)
+  [![Accessibility: checked](https://img.shields.io/badge/a11y-checked-blueviolet)](#)
+-->
+
+MessageTrain is a Rails Engine for private messaging, built on Turbo
+Frames and Stimulus, that lets users send and display private messages
+to one another. It can also be configured to send messages to a user
+collective (such as a certain Role or Group of users).
 
 Messages can be saved as drafts instead of sending. Message composition
-features type-ahead completion for recipients, wysiwyg html bodies, and an
-arbitrary number of attachments. Messages are grouped together into
+features type-ahead completion for recipients, markdown-formatted bodies,
+and an arbitrary number of attachments. Messages are grouped together into
 conversations, and allow valid senders to reply to a given message. Any given
 conversation can be ignored if it is no longer of interest to the user, at
 which point no further messages will be received in that conversation. The
@@ -26,24 +40,47 @@ through a collective (unless they have unsubscribed from those notifications
 or all notifications).
 
 ### Inbox Page
-![Inbox Screenshot](http://gemvein.com/assets/screenshots/message_train-box-in.png)   
+<p>
+  <img src="docs/screenshots/inbox-desktop.png" alt="Inbox on desktop" width="70%">
+  <img src="docs/screenshots/inbox-mobile.png" alt="Inbox on mobile" width="25%">
+</p>
 
 ## Installation
 
-First, install the gem:
-    
+MessageTrain is a normal Hotwire-based Rails 7.1+ app dependency - it
+expects your host app already has `importmap-rails`, `turbo-rails`, and
+`stimulus-rails` installed (their own install generators already run),
+and is on Propshaft rather than Sprockets. It uses ActiveStorage for
+attachments, so run its installer too if you haven't already:
+
 ```bash
-gem 'ckeditor'
-gem 'message_train'
+bin/rails active_storage:install
 ```
 
-Then, run the install generator:
+**Watch the file-conflict prompt carefully** if your app has customized
+`spec/spec_helper.rb` or `spec/rails_helper.rb` - answering (or missing)
+the overwrite prompt wrong can silently replace your project's own spec
+config. Diff after running the installer if you're not sure what
+changed.
+
+Message bodies are plain markdown text, rendered with `redcarpet` and
+sanitized through Rails' own `sanitize` helper - no Action
+Text/Trix dependency, and no separate install step needed for it.
+
+Then add the gem and run the install generator:
+
+```ruby
+gem 'message_train'
+```
 
 ```bash
 rails g message_train:install
+bin/rails db:migrate
 ```
 
-And then run `rake db:migrate`.
+The engine registers its own Stimulus controllers and importmap pins
+automatically (via an engine initializer) - no manual pin-in wiring
+needed in the host app.
 
 Next, add to your models, each of which will need some kind of display
 name column and some kind of slug (could be the same). See below for the
@@ -62,35 +99,30 @@ To include Message Train variables and helpers in your controllers, add
 this concern to your controller or application controller:
 
 ```ruby
-include MessageTrain::MessageTrainSupport
+include MessageTrainSupport
 ```
 
-Add to your application.css.scss:
+Add to your application.css (or application.scss, if you're using
+dartsass-rails as message_train itself does):
 
 ```scss
 @import 'message_train';
 ```
 
-And in your application.js:
-
-```js
-//= require message_train
-```
-
 In your layout, supposing you use haml:
 
 ```haml
 #alert_area
-  = alert_flash_messages
+  - flash.each do |type, message|
+    .alert{ class: flash_alert_class(type) }= message
 ```
 
-If you use bootstrap, you can use the built-in bootstrap sidebar menu
-(makes use of bootstrap_leather, which is a dependency of this gem)
+If you'd like the built-in boxes dropdown/widget for navigation:
 
 ```haml
 - if user_signed_in?
+  = boxes_dropdown_list(current_user)
   = message_train_widget
-= render_widgets 'md', 3
 ```
 
 ### Required helper methods
@@ -155,13 +187,13 @@ config.address_book_methods[:users] = :valid_recipients_for
 ### Boxes
 <dl>
 <dt>boxes_dropdown_list</dt>
-<dd>Bootstrap navigation dropdown list of boxes. (Be sure to check thatuser is signed in before calling, or you'll get errors.)</dd>
+<dd>Navigation dropdown list of boxes. (Be sure to check that user is signed in before calling, or you'll get errors.)</dd>
 <dt>boxes_widget</dt>
-<dd>Bootstrap widget with list of boxes</dd>
+<dd>Widget with list of boxes</dd>
 <dt>box_nav_item(box)</dt>
-<dd>Bootstrap list item for one box</dd>
+<dd>List item for one box</dd>
 <dt>box_list_item(box)</dt>
-<dd>Bootstrap list item for one box</dd>
+<dd>List item for one box</dd>
 <dt>box_participant_name(participant)</dt>
 <dd>Name of the participant, according to the method specified in yourconfiguration or model.</dd>
 <dt>box_participant_slug(participant)</dt>
@@ -237,6 +269,45 @@ config.address_book_methods[:users] = :valid_recipients_for
 
 ## Upgrading
 
+### 1.0.0
+
+This is a breaking change - see CHANGELOG.md for the full list. The
+short version:
+
+* Rails must be >= 7.1, < 9, and Ruby >= 3.2.
+* Run `bin/rails active_storage:install` (if you haven't already) before
+  running MessageTrain's own migrations. **There is no automated
+  backfill for existing Paperclip-stored attachment data** - this
+  version assumes a fresh attachments table. If you have real attachment
+  data on 0.7.x in production, stay on 0.7.x until you've written your
+  own backfill (walk your existing `public/system/...` files, attach
+  each one via `ActiveStorage::Attached::One#attach`), or accept
+  starting fresh.
+* `Message#body` is now a plain markdown text column instead of a
+  CKEditor-edited HTML column - rendered with `redcarpet` and sanitized
+  through Rails' `sanitize` helper. If you were on a pre-1.0 build of
+  this branch that used Action Text, there's no automated conversion
+  from stored rich-text HTML to markdown source; either write your own
+  conversion or start fresh.
+* Bootstrap and jQuery are gone. If your host app's own layout/CSS
+  assumed MessageTrain's views were Bootstrap markup, expect visual
+  changes - views are now semantic HTML you can restyle directly.
+* Your host app needs `importmap-rails`, `turbo-rails`, and
+  `stimulus-rails` already installed (a normal Rails 7+ Hotwire app) and
+  Propshaft instead of Sprockets.
+* `alert_flash_messages` (a `bootstrap_leather` helper) no longer
+  exists - render `flash` yourself in `#alert_area`, using the new
+  `flash_alert_class(type)` helper to map Rails' flash keys to CSS
+  classes. See the Installation section above.
+* MessageTrain's CSS classes are now prefixed (`.icon` ->
+  `.message-train-icon`, `.badge` -> `.message-train-badge`, etc.) so
+  the engine's markup can't be reached by a host app's own broad
+  selectors. If you styled MessageTrain by targeting the old
+  unprefixed class names, update those selectors.
+* The install generator's example route now mounts at `/messages`
+  instead of `/` - only relevant if you re-run the generator or are
+  copying its suggested route for a fresh install.
+
 ### 0.7.1
 
 Renamed `subscription` to `message_train_subscription` and `subscriptions` to `message_train_subscription`.
@@ -280,9 +351,9 @@ they will simply be skipped.
     it.
 
 ## Contributors
-*   [Karen Lundgren](https://github.com/nerakdon)
+*   [Loren Lundgren](https://github.com/nerakdon)
 *   [Chad Lundgren](https://github.com/chadlundgren)
 
 ## Copyright
 
-Copyright (c) 2015-2017 Gem Vein. See LICENSE.txt for further details.
+Copyright (c) 2015-2026 Gem Vein. See LICENSE.txt for further details.

data/Rakefile

@@ -8,23 +8,9 @@ rescue Bundler::BundlerError => e
   $stderr.puts 'Run `bundle install` to install missing gems'
   exit e.status_code
 end
+require 'bundler/gem_tasks'
 require 'rake'
 
-require 'juwelier'
-Juwelier::Tasks.new do |gem|
-  # gem is a Gem::Specification...
-  # see http://guides.rubygems.org/specification-reference/ for more options
-  gem.name = 'message_train'
-  gem.homepage = 'http://www.gemvein.com/museum/cases/message_train'
-  gem.license = 'MIT'
-  gem.summary = 'Rails 4 & 5 Engine providing messaging for any object'
-  gem.description = 'Rails 4 & 5 Engine providing private and public messaging'\
-                    ' for any object, such as Users or Groups'
-  gem.email = 'karen.e.lundgren@gmail.com'
-  gem.authors = ['Karen Lundgren']
-end
-Juwelier::RubygemsDotOrgTasks.new
-
 require 'rspec/core'
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec) do |spec|
@@ -40,7 +26,7 @@ end
 task default: :spec
 
 require 'rdoc/task'
-Rake::RDocTask.new do |rdoc|
+RDoc::Task.new do |rdoc|
   version = File.exist?('VERSION') ? File.read('VERSION') : ''
 
   rdoc.rdoc_dir = 'rdoc'
@@ -55,9 +41,9 @@ load 'rails/tasks/engine.rake'
 # load 'rails/tasks/statistics.rake'
 
 namespace :message_train do
-  desc 'Clean out development system files'
+  desc 'Clean out development ActiveStorage files'
   task files: :environment do
-    FileUtils.rm_rf(Dir["#{Rails.root}/public/system/development/*/*"])
+    FileUtils.rm_rf(Dir["#{Rails.root}/storage/*"])
   end
   desc 'Recreate database from seeds and clean out all system files'
   task clean: :environment do