message_bus 4.3.9 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 258a314e3749265bd7fbaa9fadcaba10a3e4fdb46d204787ccc96effecdcbc7c
-  data.tar.gz: b14add0ef9b398c2adf721adb725d7dbeb2719066f694e753fde7073a06da502
+  metadata.gz: 357d1643581a819f8b51412902cf1e3c666d87f8971b1e56ae2d1d822a60c984
+  data.tar.gz: 86fe067d70065dab59e4a8a739fd040d858af8b4e7658a4e4bcb36c79d41514a
 SHA512:
-  metadata.gz: ebc4a907f665282f748fef892398b203b71888c98800350d7061ee870d7848a8a3f1034d501ccb162c5d099dee9edbc411a950921ce063ccac7a7ac58e60e995
-  data.tar.gz: 9b454a1f78c88351865bb277c2831b4f9772113ad865793f7d05ef531816600f828a4cc18f461a969db002038a30b5ae2d472bdd4128b7a0ccf8d2bfab6e6067
+  metadata.gz: ef5368939b9c41b4a9faf41ac10f621a07d26d15760d6a5ab5dcc3eb6cc9f845923fc1400761fe2911fcb85f9eab8016778c20127228112618f67c0ccb77c238
+  data.tar.gz: f2cfded03670efd4d8f3098002a4709781b4f59e98c6f19102f462f5965aa51cfd6a11b4dcacd4b82470305cd85d04a6ce623029e2c0dde2ad7cbad1ca8b3fc8

data/.github/workflows/ci.yml

@@ -36,7 +36,7 @@ jobs:
 
   test:
     runs-on: ubuntu-latest
-    name: Ruby ${{ matrix.ruby }} (redis ${{ matrix.redis }})
+    name: Ruby ${{ matrix.ruby }} (${{ matrix.redis }})
     timeout-minutes: 10
 
     env:
@@ -47,8 +47,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ["2.6", "2.7", "3.0", "3.1"]
-        redis: [5, 6]
+        ruby: ["3.2", "3.3", "3.4"]
+        redis: ["redis:5", "redis:6", "valkey/valkey"]
 
     services:
       postgres:
@@ -60,7 +60,7 @@ jobs:
           - 5432:5432
         options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
       redis:
-        image: ${{ format('redis:{0}', matrix.redis) }}
+        image: ${{ matrix.redis }}
         ports:
           - 6379:6379
         options: >-

data/CHANGELOG

@@ -1,3 +1,9 @@
+14-03-2025
+
+- Version 4.4.0
+
+  - Add compatibility with the redis gem version 5+.
+
 18-02-2025
 
 - Version 4.3.9

data/README.md

@@ -12,7 +12,7 @@ Read the generated docs: <https://www.rubydoc.info/gems/message_bus>
 
 ## Ruby version support
 
-MessageBus only support officially supported versions of Ruby; as of [2021-03-31](https://www.ruby-lang.org/en/downloads/branches/) this means we only support Ruby version 2.6 and up.
+MessageBus only support officially supported versions of Ruby; as of [2025-03-14](https://www.ruby-lang.org/en/downloads/branches/) this means we only support Ruby version 3.2 and up.
 
 ## Can you handle concurrent requests?
 

data/lib/message_bus/backends/redis.rb

@@ -40,16 +40,18 @@ module MessageBus
         end
       end
 
-      # @param [Hash] redis_config in addition to the options listed, see https://github.com/redis/redis-rb for other available options
-      # @option redis_config [Logger] :logger a logger to which logs will be output
-      # @option redis_config [Boolean] :enable_redis_logger (false) whether or not to enable logging by the underlying Redis library
-      # @option redis_config [Integer] :clear_every (1) the interval of publications between which the backlog will not be cleared
+      # @param [Hash] config
+      # @option config [Hash] :redis_config options for the redis connection (see https://github.com/redis/redis-rb)
+      # @option config [Logger] :logger a logger to which logs will be output
+      # @option config [Boolean] :enable_redis_logger (false) whether or not to enable logging by the underlying Redis library
+      # @option config [Integer] :clear_every (1) the interval of publications between which the backlog will not be cleared
       # @param [Integer] max_backlog_size the largest permitted size (number of messages) for per-channel backlogs; beyond this capacity, old messages will be dropped.
-      def initialize(redis_config = {}, max_backlog_size = 1000)
-        @redis_config = redis_config.dup
-        @clear_every = redis_config.delete(:clear_every) || 1
-        @logger = @redis_config[:logger]
-        @redis_config[:logger] = nil unless @redis_config[:enable_redis_logger]
+      def initialize(config = {}, max_backlog_size = 1000)
+        @config = config.dup
+        @redis_config = config[:redis_config].dup || {}
+        @clear_every = config[:clear_every] || 1
+        @logger = @config[:logger]
+        @config[:logger] = nil unless @config[:enable_redis_logger]
         @max_backlog_size = max_backlog_size
         @max_global_backlog_size = 2000
         @max_in_memory_publish_backlog = 1000
@@ -331,31 +333,7 @@ LUA
       private
 
       def new_redis_connection
-        config =
-          @redis_config.filter do |k, v|
-            # This is not ideal, required for Redis gem version 5
-            # redis-client no longer accepts arbitrary params
-            # anything unknown will error out.
-            # https://github.com/redis-rb/redis-client/blob/4c8e05acfb3477c1651138a4924616e79e6116f2/lib/redis_client/config.rb#L21-L39
-            #
-            #
-            # We should be doing the opposite and allowlisting params
-            # or splitting the object up. Starting with the smallest change that is backwards compatible
-            !%i[
-              backend
-              logger
-              long_polling_enabled
-              long_polling_interval
-              backend_options
-              base_route
-              client_message_filters
-              site_id_lookup
-              group_ids_lookup
-              user_id_lookup
-              transport_codec
-            ].include?(k)
-          end
-        ::Redis.new(config)
+        ::Redis.new(@redis_config)
       end
 
       # redis connection used for publishing messages

data/lib/message_bus/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MessageBus
-  VERSION = "4.3.9"
+  VERSION = "4.4.0"
 end

data/lib/message_bus.rb

@@ -184,10 +184,12 @@ module MessageBus::Implementation
   # @param [Hash<Symbol => Object>] config values to merge into existing config
   # @return [void]
   def redis_config=(config)
-    configure(config.merge(backend: :redis))
+    configure(backend: :redis, redis_config: config)
   end
 
-  alias redis_config config
+  def redis_config
+    @config[:redis_config] || {}
+  end
 
   # @yield [env] a routine to determine the site ID for a subscriber
   # @yieldparam [optional, Rack::Request::Env] env the subscriber request environment

data/spec/integration/http_client_spec.rb

@@ -16,14 +16,8 @@ describe MessageBus::HTTPClient do
     assert_equal("200", response.code)
   end
 
-  before do
-    @threads = Thread.list
-  end
-
   after do
-    new_threads = Thread.list - @threads
     client.stop
-    new_threads.each(&:join)
   end
 
   describe '#start and #stop' do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: message_bus
 version: !ruby/object:Gem::Version
-  version: 4.3.9
+  version: 4.4.0
 platform: ruby
 authors:
 - Sam Saffron
 bindir: bin
 cert_chain: []
-date: 2025-02-18 00:00:00.000000000 Z
+date: 2025-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack