message_bus 4.3.1 → 4.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15a820bf3ce7658e466132cbc2dd41c4f71b5c68db2e993437698192922377b9
-  data.tar.gz: 2c698b0e82d3d17dc3c0aa682e34ffaf32713f47fe207c1e8b1d55d2fb7cbe48
+  metadata.gz: 1b692999acb957ed29356cbe5611bc0e1227bf13af613523aea54782aea2983f
+  data.tar.gz: 14ac3f99c3155428caa990e40cc50d1a1ed35fafced96d8de88d6d982acb8dc0
 SHA512:
-  metadata.gz: 0ea1a5c7a8c80bdddb487eed1442e6364b37518407c1809b0fe76bc3bf5fcba96bb66df04d02d4e491350d415abbae1cd0ecc91ef1079838d6455b6063c0459f
-  data.tar.gz: 981cc3d93b7ca7a3af50179c9450033f4e4566edca5d1269c73d3fd94952f5a77d5ce14b87aa58bc5845e377a2c5c6cbe64cd1dc7905dd7689dfe1295f0668cf
+  metadata.gz: 5391f6c888f343f0d383745e0ac60390ad82b1666426ffbe6b8bac924e959ddb585bbc118a9cfdb713683b7ec1d38c2a7b3fbb53a7de9abf9e6a4b92e67b372d
+  data.tar.gz: c50d50cf2e443eb25d68e858b20a023c735b8c155231805d7cddea40fc4039c9be0a1e3704bcfe6adf1368de2a0760905329d1632b37e13636e990c79c4bcf1c

data/CHANGELOG

@@ -1,4 +1,15 @@
-FUTURE
+19-06-2023
+
+- Version 4.3.3
+
+  - FIX: Use lowercase header names in `MessageBus::Rack::Middleware` for compatibility with Rack 3.x.
+  - FIX: Don't error when trying to write a message to a closed client
+
+13-01-2023
+
+- Version 4.3.2
+
+  - FIX: Do not disable chunking on cancel/error
 
 06-01-2023
 
@@ -27,7 +38,7 @@ FUTURE
 
   - PERF: Optimize Client#backlog for up-to-date clients
 
-    Also introduces a new MessageBus#last_ids(*channels) api for fetching the last_ids of
+    Also introduces a new MessageBus#last_ids(\*channels) api for fetching the last_ids of
     multiple channels simultaneously
 
 11-01-2022

data/README.md

@@ -416,7 +416,7 @@ message_bus also supports PostgreSQL as a backend, and can be configured like so
 MessageBus.configure(backend: :postgres, backend_options: {user: 'message_bus', dbname: 'message_bus'})
 ```
 
-The PostgreSQL client message_bus uses is [ruby-pg](https://bitbucket.org/ged/ruby-pg), so you can visit it's repo to see what options you can include in `:backend_options`.
+The PostgreSQL client message_bus uses is [ruby-pg](https://github.com/ged/ruby-pg), so you can visit it's repo to see what options you can include in `:backend_options`.
 
 A `:clear_every` option is also supported, which limits backlog trimming frequency to the specified number of publications. If you set `clear_every: 100`, the backlog will only be cleared every 100 publications. This can improve performance in cases where exact backlog length limiting is not required.
 
@@ -526,16 +526,11 @@ Rails.application.config do |config|
 end
 ```
 
-Specifically, if you use a Rack middleware-based authentication solution (such as Warden) in a Rails application and wish to use it for authenticating message_bus requests, you must ensure that the MessageBus middleware comes after it in the stack. Unfortunately, this can be difficult, but the following solution is known to work:
+Specifically, if you use a Rack middleware-based authentication solution (such as Warden) in a Rails application and wish to use it for authenticating message_bus requests, you must ensure that the MessageBus middleware comes after it in the stack.
 
 ```ruby
 # config/initializers/message_bus.rb
-Rails.application.config do |config|
-  # See https://github.com/rails/rails/issues/26303#issuecomment-442894832
-  MyAppMessageBusMiddleware = Class.new(MessageBus::Rack::Middleware)
-  config.middleware.delete(MessageBus::Rack::Middleware)
-  config.middleware.insert_after(Warden::Manager, MyAppMessageBusMiddleware)
-end
+Rails.application.config.middleware.move_after(Warden::Manager, MessageBus::Rack::Middleware)
 ```
 
 ### A Distributed Cache

data/assets/message-bus.js

@@ -205,10 +205,11 @@
       return handle_progress(payload, endChunk + separator.length);
     };
 
+    var chunkedTimeout;
     var disableChunked = function () {
       if (me.longPoll) {
         me.longPoll.abort();
-        chunkedBackoff = 30;
+        chunkedBackoff = me.retryChunkedAfterRequests;
       }
     };
 
@@ -235,9 +236,9 @@
         chunked: chunked,
         onProgressListener: function (xhr) {
           var position = 0;
-          // if it takes longer than 3000 ms to get first chunk, we have some proxy
-          // this is messing with us, so just backoff from using chunked for now
-          var chunkedTimeout = setTimeout(disableChunked, 3000);
+          // if it takes longer than firstChunkTimeout to get first chunk, there may be a proxy
+          // buffering the response. Switch to non-chunked long-polling mode.
+          chunkedTimeout = setTimeout(disableChunked, me.firstChunkTimeout);
           return (xhr.onprogress = function () {
             clearTimeout(chunkedTimeout);
             if (
@@ -269,6 +270,7 @@
         }
       },
       error: function (xhr, textStatus) {
+        clearTimeout(chunkedTimeout);
         if (xhr.status === 429) {
           var tryAfter =
             parseInt(
@@ -364,6 +366,8 @@
     clientId: clientId,
     alwaysLongPoll: false,
     shouldLongPollCallback: undefined,
+    firstChunkTimeout: 3000,
+    retryChunkedAfterRequests: 30,
     baseUrl: baseUrl,
     headers: {},
     ajax: typeof jQuery !== "undefined" && jQuery.ajax,

data/lib/message_bus/client.rb

@@ -278,7 +278,7 @@ class MessageBus::Client
       @async_response << data
       @async_response << postfix
       @async_response << NEWLINE
-    else
+    elsif @io
       @io.write(chunk_length.to_s(16) << NEWLINE << data << postfix << NEWLINE)
     end
   end

data/lib/message_bus/rack/middleware.rb

@@ -82,10 +82,10 @@ class MessageBus::Rack::Middleware
     return [404, {}, ["not found"]] unless client_id
 
     headers = {}
-    headers["Cache-Control"] = "must-revalidate, private, max-age=0"
-    headers["Content-Type"] = "application/json; charset=utf-8"
-    headers["Pragma"] = "no-cache"
-    headers["Expires"] = "0"
+    headers["cache-control"] = "must-revalidate, private, max-age=0"
+    headers["content-type"] = "application/json; charset=utf-8"
+    headers["pragma"] = "no-cache"
+    headers["expires"] = "0"
 
     if @bus.extra_response_headers_lookup
       @bus.extra_response_headers_lookup.call(env).each do |k, v|

data/lib/message_bus/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MessageBus
-  VERSION = "4.3.1"
+  VERSION = "4.3.3"
 end