message_bus 3.3.8 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b45c0d65f5a82c9465f620059d2125ebca09ee5619a9094fcbc309a0e179a983
-  data.tar.gz: b691c40ae2360ae661aa83f83e9647cb0223a70a6ca536f285db21ce791a3ae3
+  metadata.gz: bb9967cb1c20e9a7c2f02ea36bfd54a3a13dac00ef44dcd0f27f7f878504ee2c
+  data.tar.gz: 6ad58769e032468f20411b507aab0c7eaf72e09ab904641f1f635a5061c42c3c
 SHA512:
-  metadata.gz: 2bb5db140d0fc8bbee5df6e00f57560b1e399c7cac86d825f9841c4c9d8bc805ec8f9ab2ea8ba0ad066c53039a44b5044ecef7299a74f942b3a52cd426ecbef6
-  data.tar.gz: 66fdc2a3c483d1b775b3963b71bdc422edcdf16233cb47aa2ec99d3a6946e6e0f6f6ca917db12e5d528de6dfb39cc494923e2abe380ca0c75d64d92f6f167d7e
+  metadata.gz: e6f3ab3af97533e26cf7fc91eb529dd5bd90f7e3b7a818b6c86636bbd4cbfb5b8f38479ee81ca1230da1ec5d6101d59a56273186f46c8d3b52807a467c40abdb
+  data.tar.gz: ab4a57f673a4cb99c1a00225a041dfe69dfbc6f9c7213774a6e4f64e6250241d3c69148fc14cf900409e15f1574d0a6b41be43b9b3c5819f2313d25ab0713418

data/.github/workflows/ci.yml

@@ -60,6 +60,8 @@ jobs:
         run: npm install
 
       - name: Tests
+        env:
+          TESTOPTS: --verbose
         run: bundle exec rake
         timeout-minutes: 3
 

data/CHANGELOG

@@ -1,3 +1,17 @@
+31-12-2021
+
+- Version 3.4.0
+
+   - FEATURE: remove "suicide" feature from message_bus - (message_bus used to terminate process when keepalive exceeded)
+
+20-12-2021
+
+- Version 3.3.8
+
+  - FIX: Restore dist js files to fix a regression in 3.3.7
+  - FIX: Stop various thread/pg connection leaks
+  - DEV: Fix ruby warnings
+
 15-12-2021
 
 - Version 3.3.7
@@ -63,14 +77,14 @@
 
 - Version 3.3.0
 
-   - FEATURE: `MessageBus.base_route=` to alter the route that message bus will listen on.
+  - FEATURE: `MessageBus.base_route=` to alter the route that message bus will listen on.
 
 07-05-2020
 
 - Version 3.2.0
 
-   - FIX: compatibility with Rails 6.0.3, note: apps without ActionDispatch::Flash may stop working after this upgrade
-   to correct this disable middleware injection with `config.skip_message_bus_middleware = true` and configure middleware by hand with `app.middleware.use(MessageBus::Rack::Middleware)`
+  - FIX: compatibility with Rails 6.0.3, note: apps without ActionDispatch::Flash may stop working after this upgrade
+    to correct this disable middleware injection with `config.skip_message_bus_middleware = true` and configure middleware by hand with `app.middleware.use(MessageBus::Rack::Middleware)`
 
 28-04-2020
 
@@ -105,7 +119,6 @@
 
   - FIX: In the redis backend make the `is_readonly?` method compatible with the redis gem both pre and post v4.0 when the `client` attribute was removed
 
-
 30-04-2019
 
 - Version 2.2.1
@@ -136,7 +149,7 @@
 - Version 2.2.0.pre
 
 - FIX: In redis backend we now expire the key used to track channel id this can cause a redis key leak
-    with large amounts of subscriptions that go away
+  with large amounts of subscriptions that go away
 - FEATURE: Much extra implementation documentation, and some improvements to usage documentation.
 - FEATURE: Improvements to development workflow:
   - Fully docker-based development and testing, with no other dependencies.
@@ -153,44 +166,47 @@
   - Supports setting backlog size on publication for memory/postgres
 - FEATURE: `MessageBus.off` now prevents the server subscription from starting up.
 - FEATURE: Trims unused parts of the public API:
+
   - Methods removed:
-    * ConnectionManager#stats (never used and the ConnectionManager is not exposed to application code)
-    * Client#cancel (effectively duplicate of Client#close and the Client is only available via the ConnectionManager, thus not available to application code)
+
+    - ConnectionManager#stats (never used and the ConnectionManager is not exposed to application code)
+    - Client#cancel (effectively duplicate of Client#close and the Client is only available via the ConnectionManager, thus not available to application code)
 
   - Methods made private:
-    * MessageBus::Implementation#encode_channel_name
-    * MessageBus::Implementation#decode_channel_name
-    * Client#in_async?
-    * Client#ensure_closed!
-    * ConnectionManager#subscribe_client
-    * Diagnostics.full_process_path
-    * Diagnostics.hostname
-    * MessageBus::Rack::Diagnostics#js_asset
-    * MessageBus::Rack::Diagnostics#generate_script_tag
-    * MessageBus::Rack::Diagnostics#file_hash
-    * MessageBus::Rack::Diagnostics#asset_contents
-    * MessageBus::Rack::Diagnostics#asset_path
-    * MessageBus::Rack::Diagnostics#index
-    * MessageBus::Rack::Diagnostics#translate_handlebars
-    * MessageBus::Rack::Diagnostics#indent
-    * MessageBus::Rack::Middleware#start_listener
-    * MessageBus::Rack::Middleware#close_db_connection!
-    * MessageBus::Rack::Middleware#add_client_with_timeout
+
+    - MessageBus::Implementation#encode_channel_name
+    - MessageBus::Implementation#decode_channel_name
+    - Client#in_async?
+    - Client#ensure_closed!
+    - ConnectionManager#subscribe_client
+    - Diagnostics.full_process_path
+    - Diagnostics.hostname
+    - MessageBus::Rack::Diagnostics#js_asset
+    - MessageBus::Rack::Diagnostics#generate_script_tag
+    - MessageBus::Rack::Diagnostics#file_hash
+    - MessageBus::Rack::Diagnostics#asset_contents
+    - MessageBus::Rack::Diagnostics#asset_path
+    - MessageBus::Rack::Diagnostics#index
+    - MessageBus::Rack::Diagnostics#translate_handlebars
+    - MessageBus::Rack::Diagnostics#indent
+    - MessageBus::Rack::Middleware#start_listener
+    - MessageBus::Rack::Middleware#close_db_connection!
+    - MessageBus::Rack::Middleware#add_client_with_timeout
 
   - Methods switched from protected to private:
-    * MessageBus::Implementation#global?
-    * MessageBus::Implementation#decode_message!
-    * MessageBus::Implementation#replay_backlog
-    * MessageBus::Implementation#subscribe_impl
-    * MessageBus::Implementation#unsubscribe_impl
-    * MessageBus::Implementation#ensure_subscriber_thread
-    * MessageBus::Implementation#new_subscriber_thread
-    * MessageBus::Implementation#global_subscribe_thread
-    * MessageBus::Implementation#multi_each
-    * Client#write_headers
-    * Client#write_chunk
-    * Client#write_and_close
-    * Client#messages_to_json
+    - MessageBus::Implementation#global?
+    - MessageBus::Implementation#decode_message!
+    - MessageBus::Implementation#replay_backlog
+    - MessageBus::Implementation#subscribe_impl
+    - MessageBus::Implementation#unsubscribe_impl
+    - MessageBus::Implementation#ensure_subscriber_thread
+    - MessageBus::Implementation#new_subscriber_thread
+    - MessageBus::Implementation#global_subscribe_thread
+    - MessageBus::Implementation#multi_each
+    - Client#write_headers
+    - Client#write_chunk
+    - Client#write_and_close
+    - Client#messages_to_json
 
 15-10-2018
 
@@ -219,7 +235,7 @@
 - Version 2.1.2
 
 - FEATURE: minHiddenPollInterval set to 1500ms out of the box, ensures we never do hidden tab
-   polls at a high rate if tons of tabs are open
+  polls at a high rate if tons of tabs are open
 - FEATURE: added random 500ms to delayed polls to increase tab entropy
 
 18-12-2017
@@ -233,7 +249,7 @@
 - Version 2.1.0
 
 - FEATURE: you can now lookup last N messages on channel on subscribe from JavaScript
-   Subscribe at position (-1 - numberOfMessages) from the client
+  Subscribe at position (-1 - numberOfMessages) from the client
 
 24-11-2017
 
@@ -253,8 +269,7 @@
 - Version 2.0.7
 
 - Fix/Feature: use LUA script for publishing to bus, this eliminates a race condition
-   and ensures that we are never stuck in a multi transaction by mistake
-
+  and ensures that we are never stuck in a multi transaction by mistake
 
 29-09-2017
 
@@ -282,12 +297,10 @@
 - Version 2.0.2
 - Feature: Add on_middleware_error callback for remapping middleware errors to HTTP results
 
-
 25-07-2016
 
 - Feature: Add JavaScript MessageBus.status() function
 
-
 21-06-2016
 
 - Version 2.0.1
@@ -368,8 +381,8 @@
 
 - Version 1.1.1
 - Fix: In multisite config there was no way to specify site for last_id or backlog
-   to resolve overrides were added to #last_id and #backlog, MessageBus::Client now
-   uses the new overrides
+  to resolve overrides were added to #last_id and #backlog, MessageBus::Client now
+  uses the new overrides
 
 07-12-2015
 
@@ -379,86 +392,105 @@
 - Feature: remove most jQuery dependency from message-bus.js
 
 09-07-2015
+
 - Version 1.0.16
 - Fix: correct edge cases around keepalive checks on bus
 
 09-07-2015
+
 - Version 1.0.15
 - Feature: MessageBus.reliable_pub_sub.max_backlog_age (in secs) configurable (default to 7 days)
 - Fix: API for MessageBus.backlog("/bla") was returning global backlog by mistake
 - Change: Max global backlog size reduced to 2000 elements
 
 08-06-2015
+
 - Version 1.0.14
 - Fix: we can not use Thread#kill best keepalive can do is terminate process cleanly
 - Feature: you can opt-out of keepalive with MessageBus.keepalive_timeout = 0
 
 08-06-2015
+
 - Version 1.0.13
 - Fix: on global subscribe reconnect replay missed messages
 - Feature: keepalive tests for global subscribe, catches hung redis connections
 
 28-05-2015
+
 - Version 1.0.12
 - Feature: Support client_id targeted message
 
 06-05-2015
+
 - Version 1.0.11
 - Fix: race condition in TimerThread
 
 01-05-2015
+
 - Version: 1.0.10
 - Feature: no longer depends on EventMachine (only used for Thin backend)
 - Feature: reliable pub sub will queue messages in memory if redis is readonly, configurable
 - Fix: if redis is flushed we will continue to deliver messages
 
 23-03-2015
+
 - Version 1.0.9
 - Fix: inherit off StandardError not Exception for all exceptions raised
 
 20-03-2015
+
 - Version 1.0.8
 - Fix: aggressive short polling in background
 
 16-03-2015
+
 - Version 1.0.7
 - Feature: added pause and resume methods
 
 03-02-2015
+
 - Version 1.0.6
 - Fix: global backlog not truncating correctly
 
 23-09-2014
+
 - Version 1.0.5
 - Fix: missing custom headers from long polls
 
 23-09-2014
+
 - Version 1.0.4
 - Change: MessageBus.access_control_allow_origin_lookup to extra_response_headers_lookup
 
 23-09-2014
+
 - Version 1.0.3
 - Change: MessageBus.access_control_allow_origin to MessageBus.access_control_allow_origin_lookup
 
 23-09-2014
+
 - Version 1.0.2
 - Feature: MessageBus.access_control_allow_origin to control origin header
 
 23-09-2014
+
 - Version 1.0.1
 - Feature: $.ajax dependency can be passed in.
 - Feature: unsubscribe accepts a second param for the function to unsubscribe.
 
 22-09-2014
+
 - Version 1.0.0
 - Feature: add backgroundCallbackInterval - interval to send polls when page is in the background
 - Feature: issue a long poll as soon as page moves into the foreground
 
 11-08-2014
+
 - Version 0.9.5
 - Fix: release db connection a lot earlier for long polling (rails defer closes)
 
 13-01-2014
+
 - Version 0.9.4
 - Added support for /global/ channel to publish messages across a multisite
 - Cleaned up test harness so it uses local bus as opposed to global
@@ -467,19 +499,23 @@
 - ensure_reactor could say the reactor is running, but it was not, on first call
 
 06-12-2013
+
 - Version 0.9.3.2
 - Fix permissions in gem
 
 05-12-2013
+
 - Version 0.9.3.1
 - Add MessageBus.diagnostics() for diagnosing bus issues client side
 - Add more robustness to JavaScript, if callbacks used to fail they would halt the chain
 
 03-12-2013
+
 - Version 0.9.3
 - Remove thin dependency
 - Improve robustness under failure conditions
 
 30-09-2013
+
 - Fix failures in Ruby 1.9
 - Set up rack hijack by default in light of passengers new setting

data/README.md

@@ -26,15 +26,21 @@ MessageBus only support officially supported versions of Ruby; as of [2021-03-31
 
 Add this line to your application's Gemfile:
 
-    gem 'message_bus'
+```ruby
+gem 'message_bus'
+```
 
 And then execute:
 
-    $ bundle
+```shell
+$ bundle
+```
 
 Or install it yourself as:
 
-    $ gem install message_bus
+```shell
+$ gem install message_bus
+```
 
 ## Usage
 
@@ -109,7 +115,7 @@ MessageBus.user_id_lookup do |env|
 end
 ```
 
-If both `user_ids` and `group_ids` options are supplied when publishing a message, the message will be targeted at clients with lookup return values that  matches on either the `user_ids` **or** the `group_ids` options.
+If both `user_ids` and `group_ids` options are supplied when publishing a message, the message will be targeted at clients with lookup return values that matches on either the `user_ids` **or** the `group_ids` options.
 
 ```ruby
 MessageBus.publish "/channel", "hello", user_ids: [1, 2, 3], group_ids: [1, 2, 3]
@@ -129,7 +135,7 @@ Custom client message filters can be registered via `MessageBus#register_client_
 
 For example, ensuring that only messages seen by the server in the last 20 seconds are published to the client:
 
-```
+```ruby
 MessageBus.register_client_message_filter('/test') do |message|
   (Time.now.to_i - message.data[:published_at]) <= 20
 end
@@ -280,7 +286,7 @@ MessageBus.start(); // call once at startup
 MessageBus.callbackInterval = 500;
 
 // you will get all new messages sent to channel
-MessageBus.subscribe("/channel", function(data){
+MessageBus.subscribe("/channel", function (data) {
   // data shipped from server
 });
 
@@ -386,6 +392,16 @@ headers|{}|Extra headers to be include with requests. Properties and values of o
 
 message_bus can be configured to use one of several available storage backends, and each has its own configuration options.
 
+### Keepalive
+
+To ensure correct operation of message_bus, every 60 seconds a message is broadcast to itself. If for any reason the message is not consumed by the same process within 3 keepalive intervals a warning log message is raised.
+
+To control keepalive interval use
+
+```ruby
+MessageBus.configure(keepalive_interval: 60)
+```
+
 ### Redis
 
 message_bus supports using Redis as a storage backend, and you can configure message_bus to use redis in `config/initializers/message_bus.rb`, like so:
@@ -435,7 +451,6 @@ MessageBus.configure(backend: :memory)
 
 The `:clear_every` option supported by the PostgreSQL backend is also supported by the in-memory backend.
 
-
 ### Transport codecs
 
 By default MessageBus serializes messages to the backend using JSON. Under most situation this performs extremely well.
@@ -456,7 +471,7 @@ Keep in mind, much of MessageBus internals and supporting tools expect data to b
 
 Another example may be very large and complicated messages where Oj in compatibility mode outperforms JSON. To opt for the Oj codec use:
 
-```
+```ruby
 MessageBus.configure(transport_codec: MessageBus::Codec::Oj.new)
 ```
 
@@ -503,7 +518,6 @@ For more information see the [Passenger documentation](https://www.phusionpassen
 
 ```ruby
 # path/to/your/config/puma.rb
-require 'message_bus' # omit this line for Rails 5
 on_worker_boot do
   MessageBus.after_fork
 end
@@ -513,7 +527,6 @@ end
 
 ```ruby
 # path/to/your/config/unicorn.rb
-require 'message_bus'
 after_fork do |server, worker|
   MessageBus.after_fork
 end
@@ -554,26 +567,21 @@ MessageBus ships with an optional `DistributedCache` API which provides a simple
 require 'message_bus/distributed_cache'
 
 # process 1
-
 cache = MessageBus::DistributedCache.new("animals")
 
 # process 2
-
 cache = MessageBus::DistributedCache.new("animals")
 
 # process 1
-
 cache["frogs"] = 5
 
 # process 2
-
 puts cache["frogs"]
 # => 5
 
 cache["frogs"] = nil
 
 # process 1
-
 puts cache["frogs"]
 # => nil
 ```
@@ -631,7 +639,7 @@ In e.g. `config/initializers/message_bus.rb`:
 ```ruby
 MessageBus.extra_response_headers_lookup do |env|
   [
-      ["Access-Control-Allow-Origin", "http://example.com:3000"],
+    ["Access-Control-Allow-Origin", "http://example.com:3000"],
   ]
 end
 ```
@@ -692,8 +700,8 @@ In certain conditions, a status message will be delivered and look like this:
   "message_id": -1,
   "channel": "/__status",
   "data": {
-    "/some/channel":5,
-    "/other/channel":9
+    "/some/channel": 5,
+    "/other/channel": 9
   }
 }
 ```
@@ -727,7 +735,7 @@ When submitting a PR, please be sure to include notes on it in the `Unreleased`
 
 To run tests you need both Postgres and Redis installed. By default on Redis the tests connect to `localhost:6379` and on Postgres connect the database `localhost:5432/message_bus_test` with the system username; if you wish to override this, you can set alternative values:
 
-```
+```shell
 PGUSER=some_user PGDATABASE=some_db bundle exec rake
 ```
 

data/Rakefile

@@ -5,18 +5,16 @@ require 'bundler'
 require 'bundler/gem_tasks'
 require 'bundler/setup'
 require 'rubocop/rake_task'
+require 'yard'
 
-RuboCop::RakeTask.new
+Bundler.require(:default, :test)
 
-require 'yard'
+RuboCop::RakeTask.new
 YARD::Rake::YardocTask.new
 
-desc "Generate documentation for Yard, and fail if there are any warnings"
-task :test_doc do
-  sh "yard --fail-on-warning #{'--no-progress' if ENV['CI']}"
-end
-
-Bundler.require(:default, :test)
+BACKENDS = Dir["lib/message_bus/backends/*.rb"].map { |file| file.match(%r{backends/(?<backend>.*).rb})[:backend] } - ["base"]
+SPEC_FILES = Dir['spec/**/*_spec.rb']
+INTEGRATION_FILES = Dir['spec/integration/**/*_spec.rb']
 
 module CustomBuild
   def build_gem
@@ -31,6 +29,11 @@ module Bundler
   end
 end
 
+desc "Generate documentation for Yard, and fail if there are any warnings"
+task :test_doc do
+  sh "yard --fail-on-warning #{'--no-progress' if ENV['CI']}"
+end
+
 namespace :jasmine do
   desc "Run Jasmine tests in headless mode"
   task 'ci' do
@@ -40,18 +43,16 @@ namespace :jasmine do
   end
 end
 
-backends = Dir["lib/message_bus/backends/*.rb"].map { |file| file.match(%r{backends/(?<backend>.*).rb})[:backend] } - ["base"]
-
 namespace :spec do
-  spec_files = Dir['spec/**/*_spec.rb']
-  integration_files = Dir['spec/integration/**/*_spec.rb']
-
-  backends.each do |backend|
+  BACKENDS.each do |backend|
     desc "Run tests on the #{backend} backend"
     task backend do
       begin
         ENV['MESSAGE_BUS_BACKEND'] = backend
-        sh "#{FileUtils::RUBY} -e \"ARGV.each{|f| load f}\" #{(spec_files - integration_files).to_a.join(' ')}"
+        Rake::TestTask.new(backend) do |t|
+          t.test_files = SPEC_FILES - INTEGRATION_FILES
+        end
+        Rake::Task[backend].invoke
       ensure
         ENV.delete('MESSAGE_BUS_BACKEND')
       end
@@ -74,7 +75,10 @@ namespace :spec do
       ENV['MESSAGE_BUS_BACKEND'] = 'memory'
       pid = spawn("bundle exec puma -p 9292 spec/fixtures/test/config.ru")
       sleep 1 while port_available?(9292)
-      sh "#{FileUtils::RUBY} -e \"ARGV.each{|f| load f}\" #{integration_files.to_a.join(' ')}"
+      Rake::TestTask.new(:integration) do |t|
+        t.test_files = INTEGRATION_FILES
+      end
+      Rake::Task[:integration].invoke
     ensure
       ENV.delete('MESSAGE_BUS_BACKEND')
       Process.kill('TERM', pid) if pid
@@ -83,12 +87,12 @@ namespace :spec do
 end
 
 desc "Run tests on all backends, plus client JS tests"
-task spec: backends.map { |backend| "spec:#{backend}" } + ["jasmine:ci", "spec:integration"]
+task spec: BACKENDS.map { |backend| "spec:#{backend}" } + ["jasmine:ci", "spec:integration"]
 
 desc "Run performance benchmarks on all backends"
 task :performance do
   begin
-    ENV['MESSAGE_BUS_BACKENDS'] = backends.join(",")
+    ENV['MESSAGE_BUS_BACKENDS'] = BACKENDS.join(",")
     sh "#{FileUtils::RUBY} -e \"ARGV.each{|f| load f}\" #{Dir['spec/performance/*.rb'].to_a.join(' ')}"
   ensure
     ENV.delete('MESSAGE_BUS_BACKENDS')
@@ -97,7 +101,3 @@ end
 
 desc "Run all tests, link checks and confirms documentation compiles without error"
 task default: [:spec, :rubocop, :test_doc]
-
-Rake::Task['release'].enhance do
-  sh "yarn publish"
-end

data/lib/message_bus/backends/postgres.rb

@@ -259,6 +259,7 @@ module MessageBus
         @max_backlog_age = 604800
         @clear_every = config[:clear_every] || 1
         @mutex = Mutex.new
+        @client = nil
       end
 
       # Reconnects to Postgres; used after a process fork, typically triggered by a forking webserver

data/lib/message_bus/backends/redis.rb

@@ -58,6 +58,7 @@ module MessageBus
         @in_memory_backlog = []
         @lock = Mutex.new
         @flush_backlog_thread = nil
+        @pub_redis = nil
         # after 7 days inactive backlogs will be removed
         @max_backlog_age = 604800
       end

data/lib/message_bus/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MessageBus
-  VERSION = "3.3.8"
+  VERSION = "3.4.0"
 end

data/lib/message_bus.rb

@@ -744,34 +744,11 @@ module MessageBus::Implementation
       if !@destroyed && thread.alive? && keepalive_interval > MIN_KEEPALIVE
 
         publish("/__mb_keepalive__/", Process.pid, user_ids: [-1])
-        # going for x3 keepalives missed for a restart, need to ensure this only very rarely happens
-        # note: after_fork will sort out a bad @last_message date, but thread will be dead anyway
         if (Time.now - (@last_message || Time.now)) > keepalive_interval * 3
-          logger.warn "Global messages on #{Process.pid} timed out, restarting process"
-          # No other clean way to remove this thread, its listening on a socket
-          #   no data is arriving
-          #
-          # In production we see this kind of situation ... sometimes ... when there is
-          # a VRRP failover, or weird networking condition
-          pid = Process.pid
-
-          # do the best we can to terminate self cleanly
-          fork do
-            Process.kill('TERM', pid)
-            sleep 10
-            begin
-              Process.kill('KILL', pid)
-            rescue Errno::ESRCH
-              logger.warn "#{Process.pid} successfully terminated by `TERM` signal."
-            end
-          end
-
-          sleep 10
-          Process.kill('KILL', pid)
-
-        else
-          timer.queue(keepalive_interval, &blk) if keepalive_interval > MIN_KEEPALIVE
+          logger.warn "Global messages on #{Process.pid} timed out, message bus is no longer functioning correctly"
         end
+
+        timer.queue(keepalive_interval, &blk) if keepalive_interval > MIN_KEEPALIVE
       end
     end
 

data/spec/lib/message_bus/multi_process_spec.rb

@@ -91,6 +91,7 @@ describe PUB_SUB_CLASS do
         end
 
         bus.global_unsubscribe
+        bus.reset!
         bus.destroy
       end
     end

data/spec/lib/message_bus/timer_thread_spec.rb

@@ -52,10 +52,6 @@ describe MessageBus::TimerThread do
   it "should call the error callback if something goes wrong" do
     error = nil
 
-    @timer.queue do
-      boom
-    end
-
     @timer.on_error do |e|
       error = e
     end
@@ -64,7 +60,7 @@ describe MessageBus::TimerThread do
       boom
     end
 
-    wait_for(10) do
+    wait_for(100) do
       error
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: message_bus
 version: !ruby/object:Gem::Version
-  version: 3.3.8
+  version: 3.4.0
 platform: ruby
 authors:
 - Sam Saffron
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-20 00:00:00.000000000 Z
+date: 2021-12-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -362,7 +362,7 @@ homepage: https://github.com/discourse/message_bus
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -377,8 +377,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.3
+signing_key:
 specification_version: 4
 summary: ''
 test_files: