message_bus 3.3.1 → 3.3.6

data/package.json

@@ -1,10 +1,12 @@
 {
   "name": "message-bus-client",
-  "version": "3.3.0",
+  "version": "3.3.5",
   "description": "A message bus client in Javascript",
   "main": "assets/message-bus.js",
   "keywords": "es6, modules",
-  "files": ["assets/message-bus.js"],
+  "files": [
+    "assets/message-bus.js"
+  ],
   "jsnext:main": "assets/message-bus.js",
   "module": "assets/message-bus.js",
   "repository": {
@@ -16,5 +18,8 @@
   "bugs": {
     "url": "https://github.com/discourse/message_bus/issues"
   },
-  "homepage": "https://github.com/discourse/message_bus#readme"
+  "homepage": "https://github.com/discourse/message_bus#readme",
+  "devDependencies": {
+    "eslint": "^7.27.0"
+  }
 }

data/spec/lib/message_bus_spec.rb

@@ -162,7 +162,7 @@ describe MessageBus do
     data.must_equal 'norris'
     site_id.must_equal 'magic'
     channel.must_equal '/chuck'
-    user_ids.must_equal [1, 2, 3]
+    user_ids.to_a.must_equal [1, 2, 3]
   end
 
   it "should get global messages if it subscribes to them" do
@@ -201,6 +201,13 @@ describe MessageBus do
     @bus.backlog("/chuck").map { |i| i.data }.to_a.must_equal ['norris', 'foo']
   end
 
+  it "should correctly restrict the backlog size of a channel" do
+    @bus.publish("/chuck", "norris")
+    @bus.publish("/chuck", "foo", max_backlog_size: 1)
+
+    @bus.backlog("/chuck").map { |i| i.data }.to_a.must_equal ['foo']
+  end
+
   it "allows you to look up last_message" do
     @bus.publish("/bob", "dylan")
     @bus.publish("/bob", "marley")
@@ -266,15 +273,37 @@ describe MessageBus do
     end
 
     it "should exception if publishing restricted messages to user" do
-      lambda do
+      assert_raises(MessageBus::InvalidMessage) do
         @bus.publish("/global/test", "test", user_ids: [1])
-      end.must_raise(MessageBus::InvalidMessage)
+      end
     end
 
     it "should exception if publishing restricted messages to group" do
-      lambda do
+      assert_raises(MessageBus::InvalidMessage) do
         @bus.publish("/global/test", "test", user_ids: [1])
-      end.must_raise(MessageBus::InvalidMessage)
+      end
+    end
+
+    it "should raise if we publish to an empty group or user list" do
+      assert_raises(MessageBus::InvalidMessageTarget) do
+        @bus.publish "/foo", "bar", user_ids: []
+      end
+
+      assert_raises(MessageBus::InvalidMessageTarget) do
+        @bus.publish "/foo", "bar", group_ids: []
+      end
+
+      assert_raises(MessageBus::InvalidMessageTarget) do
+        @bus.publish "/foo", "bar", client_ids: []
+      end
+
+      assert_raises(MessageBus::InvalidMessageTarget) do
+        @bus.publish "/foo", "bar", group_ids: [], user_ids: [1]
+      end
+
+      assert_raises(MessageBus::InvalidMessageTarget) do
+        @bus.publish "/foo", "bar", group_ids: [1], user_ids: []
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: message_bus
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.3.6
 platform: ruby
 authors:
 - Sam Saffron
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-06-09 00:00:00.000000000 Z
+date: 2021-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -59,10 +59,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".eslintrc.js"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG
+- DEV.md
 - Dockerfile
 - Gemfile
 - Guardfile
@@ -76,6 +78,12 @@ files:
 - assets/message-bus.js
 - assets/react-dom.js
 - assets/react.js
+- bench/codecs/all_codecs.rb
+- bench/codecs/marshal.rb
+- bench/codecs/packed_string.rb
+- bench/codecs/string_hack.rb
+- bench/codecs_large_user_list.rb
+- bench/codecs_standard_message.rb
 - docker-compose.yml
 - examples/bench/bench.lua
 - examples/bench/config.ru
@@ -98,10 +106,12 @@ files:
 - lib/message_bus/backends/postgres.rb
 - lib/message_bus/backends/redis.rb
 - lib/message_bus/client.rb
+- lib/message_bus/codec/base.rb
+- lib/message_bus/codec/json.rb
+- lib/message_bus/codec/oj.rb
 - lib/message_bus/connection_manager.rb
 - lib/message_bus/diagnostics.rb
 - lib/message_bus/distributed_cache.rb
-- lib/message_bus/em_ext.rb
 - lib/message_bus/http_client.rb
 - lib/message_bus/http_client/channel.rb
 - lib/message_bus/http_client/version.rb
@@ -113,6 +123,7 @@ files:
 - lib/message_bus/timer_thread.rb
 - lib/message_bus/version.rb
 - message_bus.gemspec
+- package-lock.json
 - package.json
 - spec/assets/SpecHelper.js
 - spec/assets/message-bus.spec.js
@@ -141,7 +152,7 @@ homepage: https://github.com/SamSaffron/message_bus
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -149,15 +160,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: ''
 test_files:

data/.travis.yml

@@ -1,17 +0,0 @@
-before_install: gem install bundler
-language: ruby
-rvm:
-  - 2.4
-  - 2.5
-  - 2.6
-gemfile:
-  - Gemfile
-addons:
-  postgresql: "9.4"
-env:
-  - PGUSER=postgres
-before_script:
-  - psql -c 'create database message_bus_test;' -U postgres
-services:
-  - redis-server
-  - postgresql

data/lib/message_bus/em_ext.rb

@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-module EM
-  def self.reactor_pid
-    @reactor_pid
-  end
-end