message_bus 2.0.0.beta.7 → 2.0.0.beta.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 765d5f2c439f0bcc0ca030a838d93510ed638916
-  data.tar.gz: 23a0428b2f62625e4063c066828d9fb5925a0a86
+  metadata.gz: 36e783040a809c36cf22fa4240a6c563c0b77445
+  data.tar.gz: 4c1912ddfd8af23adcab074d340094e32721528d
 SHA512:
-  metadata.gz: 19127a42396bebe0d047fc7a3c41d7be908072711ef294e71d4f6546acd260b93520a4d0eb391d39b63253b5d6e057ee43aebaf7e032dd8f6cc6531352131001
-  data.tar.gz: e863e48441974a73d3f956b9ba2cf01622bbc173ac5db435d3b0c1d38db0dab9b2b884d230cf50ab463ec225d323a73f4a7fd0299a033940074b5aaf29bb6583
+  metadata.gz: 7e4343488e590e4eb1270e2ba8c22b02d2e9b282be80fe79d606a8dce375ff90317abaccea16cf6f90350569a5be1e0daa1b9345f21253d522d42660091ff95c
+  data.tar.gz: 821d8f2fe45aef0dd014cc0315761e4b9bbc4eb47a0f8d67f5e323c8ebf302d7b8fc996bb01ad443f6f16ba1c1d5b421c92216eca85e31e8755618b645b889ce

data/CHANGELOG

@@ -1,3 +1,8 @@
+27-04-2016
+
+- Version 2.0.0.beta.7
+- Fix: exception raised sometimes when subscribing at a particular position
+
 26-04-2016
 
 - Version 2.0.0.beta.7

data/Gemfile

@@ -9,4 +9,5 @@ group :test do
   gem 'http_parser.rb'
   gem 'thin'
   gem 'rack-test', require: 'rack/test'
+  gem 'jasmine'
 end

data/README.md

@@ -176,7 +176,7 @@ that of the JavaScript client.
 
 All client settings are settable via `MessageBus.OPTION`
 
-Setting|Default|
+Setting|Default|Info
 ----|---|---|
 enableLongPolling|true|Allow long-polling (provided it is enable by the server)
 callbackInterval|15000|Safeguard to ensure background polling does not exceed this interval (in milliseconds)

data/examples/bench/bench.lua

@@ -1,7 +1,23 @@
+-- wrk returns lots of read errors, this is unavoidable cause
+--
+-- 1. There is no internal implmentation of chunked encoding in wrk (which would be ideal)
+--
+-- 2. MessageBus gem does not provide http keepalive (by design), and can not provide content length
+--   if MessageBus provided keepalive it would have to be able to redispatch the reqs to rack, something
+--   that is not supported by the underlying rack hijack protocol, once a req is hijacked it can not be
+--   returned
+--
+-- This leads to certain read errors while the bench runs cause wrk can not figure out cleanly that
+-- MessageBus is done with a request
+--
+
 wrk.method = "POST"
 wrk.body = ""
 wrk.headers["Content-Type"] = "application/x-www-form-urlencoded"
-wrk.headers["Connection"] = "keep-alive"
+
+-- chunking is not supported internally to wrk
+wrk.headers["Dont-Chunk"] = "true"
+wrk.headers["Connection"] = "Close"
 
 request = function()
   local hexdict = {48,49,50,51,52,53,54,55,56,57,97,98,99,100,101,102}

data/examples/bench/config.ru

@@ -1,3 +1,5 @@
+$LOAD_PATH.unshift File.expand_path('../../../lib', __FILE__)
+
 require 'message_bus'
 require 'stackprof'
 

data/lib/message_bus.rb

@@ -403,7 +403,7 @@ module MessageBus::Implementation
             just_yield = true
           else
             current_id = replay_backlog(channel, current_id, site_id, &original_blk)
-            if (current_id == m.id)
+            if (current_id == m.message_id)
               just_yield = true
             end
           end

data/lib/message_bus/version.rb

@@ -1,3 +1,3 @@
 module MessageBus
-  VERSION = "2.0.0.beta.7"
+  VERSION = "2.0.0.beta.8"
 end

data/message_bus.gemspec

@@ -19,5 +19,4 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'rack', '>= 1.1.3'
   gem.add_development_dependency 'redis'
   gem.add_development_dependency 'pg'
-  gem.add_development_dependency 'jasmine'
 end

data/spec/assets/support/jasmine.yml

@@ -77,17 +77,7 @@ src_dir:
 #
 spec_dir: spec/assets
 
-# spec_helper
-#
-# Ruby file that Jasmine server will require before starting.
-# Returned relative to your root path
-# Default spec/javascripts/support/jasmine_helper.rb
-#
-# EXAMPLE:
-#
-# spec_helper: spec/javascripts/support/jasmine_helper.rb
-#
-# spec_helper: spec/javascripts/support/jasmine_helper.rb
+spec_helper: spec/assets/support/jasmine_helper.rb
 
 # boot_dir
 #

data/spec/assets/support/jasmine_helper.rb

@@ -0,0 +1,10 @@
+Jasmine.configure do |config|
+  # patch for travis
+  if ENV['TRAVIS']
+    module ::Phantomjs
+      def self.version
+        @phantom_version ||= `phantomjs --version`.strip
+      end
+    end
+  end
+end

data/spec/lib/message_bus_spec.rb

@@ -23,6 +23,7 @@ describe MessageBus do
 
     data1 = []
     data2 = []
+    data3 = []
 
     @bus.subscribe("/minion") do |msg|
       data1 << msg.data
@@ -32,12 +33,20 @@ describe MessageBus do
       data2 << msg.data
     end
 
+    @bus.subscribe("/minion", 1) do |msg|
+      data3 << msg.data
+    end
+
     @bus.publish("/minion", "bananana")
+    @bus.publish("/minion", "it's so fluffy")
 
-    wait_for(2000){ data2.length == 2 && data1.length == 1}
+    wait_for(2000) do
+      data3.length == 3 && data2.length == 3 && data1.length == 2
+    end
 
-    data1.must_equal ['bananana']
-    data2.must_equal ['banana', 'bananana']
+    data1.must_equal ['bananana', "it's so fluffy"]
+    data2.must_equal ['banana', 'bananana', "it's so fluffy"]
+    data3.must_equal ['banana', 'bananana', "it's so fluffy"]
   end
 
   it "can transmit client_ids" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: message_bus
 version: !ruby/object:Gem::Version
-  version: 2.0.0.beta.7
+  version: 2.0.0.beta.8
 platform: ruby
 authors:
 - Sam Saffron
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-26 00:00:00.000000000 Z
+date: 2016-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: jasmine
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: A message bus for rack
 email:
 - sam.saffron@gmail.com
@@ -120,6 +106,7 @@ files:
 - spec/assets/SpecHelper.js
 - spec/assets/message-bus.spec.js
 - spec/assets/support/jasmine.yml
+- spec/assets/support/jasmine_helper.rb
 - spec/lib/fake_async_middleware.rb
 - spec/lib/message_bus/assets/asset_encoding_spec.rb
 - spec/lib/message_bus/backends/postgres_spec.rb
@@ -161,6 +148,7 @@ test_files:
 - spec/assets/SpecHelper.js
 - spec/assets/message-bus.spec.js
 - spec/assets/support/jasmine.yml
+- spec/assets/support/jasmine_helper.rb
 - spec/lib/fake_async_middleware.rb
 - spec/lib/message_bus/assets/asset_encoding_spec.rb
 - spec/lib/message_bus/backends/postgres_spec.rb