message-driver 0.6.1 → 0.7.0

data/spec/integration/bunny/bunny_adapter_spec.rb

@@ -129,7 +129,6 @@ module MessageDriver
         end
 
         describe '#create_destination' do
-
           context 'with defaults' do
             context 'the resulting destination' do
               let(:dest_name) { 'my_dest' }
@@ -327,7 +326,6 @@ module MessageDriver
                   adapter_context.create_destination(dest_name, type: :exchange, declare: { auto_delete: true })
                 end.to raise_error MessageDriver::Error, /you must provide a valid exchange type/
               end
-
             end
 
             context 'and bindings are provided' do
@@ -363,7 +361,7 @@ module MessageDriver
             it 'raises in an error' do
               expect do
                 adapter_context.create_destination('my_dest', type: :foo_bar)
-              end.to raise_error MessageDriver::Error, "invalid destination type #{:foo_bar}"
+              end.to raise_error MessageDriver::Error, 'invalid destination type foo_bar'
             end
           end
         end

data/spec/integration/in_memory/in_memory_adapter_spec.rb

@@ -5,8 +5,10 @@ require 'message_driver/adapters/in_memory_adapter'
 module MessageDriver
   module Adapters
     RSpec.describe InMemoryAdapter, :in_memory, type: :integration do
-      let(:broker) { double(Broker) }
-      subject(:adapter) { described_class.new(broker) }
+      let(:broker) { Broker.configure(adapter: :in_memory) }
+      subject(:adapter) { broker.adapter }
+
+      it { is_expected.to be_a InMemoryAdapter }
 
       describe '#new_context' do
         it 'returns a InMemoryAdapter::InMemoryContext' do
@@ -70,9 +72,8 @@ module MessageDriver
           adapter.reset_after_tests
 
           destinations.each do |destination|
-            expect(destination.subscription).to be_nil
+            expect(destination.subscriptions).to be_empty
           end
-
         end
       end
 
@@ -87,7 +88,7 @@ module MessageDriver
             dest1.subscribe(&consumer)
           end
           it 'is the same consumer on the other destination' do
-            expect(dest2.subscription.consumer).to be(consumer)
+            expect(dest2.subscriptions.first.consumer).to be(consumer)
           end
         end
 
@@ -123,7 +124,46 @@ module MessageDriver
       describe 'subscribing a consumer' do
         let(:destination) { adapter.create_destination(:my_queue) }
 
-        let(:subscription_type) { MessageDriver::Adapters::InMemoryAdapter::Subscription }
+        context 'when there are already messages on the queue' do
+          it 'sends those initial messages to the first subscription created' do
+            4.times { destination.publish('a message') }
+            msgs1 = []
+            msgs2 = []
+
+            destination.subscribe do |msg|
+              msgs1 << msg
+            end
+
+            destination.subscribe do |msg|
+              msgs2 << msg
+            end
+
+            aggregate_failures do
+              expect(msgs1.size).to eq(4)
+              expect(msgs2.size).to eq(0)
+            end
+          end
+        end
+
+        it 'supports multiple subscriptions on a given destination and distributes the messages between them' do
+          msgs1 = []
+          msgs2 = []
+
+          destination.subscribe do |msg|
+            msgs1 << msg
+          end
+
+          destination.subscribe do |msg|
+            msgs2 << msg
+          end
+
+          4.times { destination.publish('a message') }
+
+          aggregate_failures do
+            expect(msgs1.size).to eq(2)
+            expect(msgs2.size).to eq(2)
+          end
+        end
       end
     end
   end

data/spec/integration/stomp/stomp_adapter_spec.rb

@@ -5,7 +5,6 @@ require 'message_driver/adapters/stomp_adapter'
 module MessageDriver
   module Adapters
     RSpec.describe StompAdapter, :stomp, type: :integration do
-
       let(:valid_connection_attrs) { BrokerConfig.config }
 
       describe '#initialize' do
@@ -113,7 +112,6 @@ module MessageDriver
         it_behaves_like 'subscriptions are not supported'
 
         describe '#create_destination' do
-
           context 'the resulting destination' do
             let(:dest_name) { '/queue/stomp_destination_spec' }
             subject(:destination) { adapter_context.create_destination(dest_name) }

data/spec/spec_helper.rb

@@ -1,3 +1,9 @@
+begin
+  require 'pry'
+rescue LoadError
+  puts 'pry not loaded'
+end
+
 ENV['COMMAND_NAME'] = 'specs'
 require File.join(File.dirname(__FILE__), '..', 'test_lib', 'coverage')
 require File.join(File.dirname(__FILE__), '..', 'test_lib', 'broker_config')

data/spec/support/matchers/override_method_matcher.rb

@@ -0,0 +1,7 @@
+RSpec::Matchers.define :override_method do |expected|
+  match do |actual|
+    klass = actual.is_a?(Class) ? actual : actual.class
+    method = klass.instance_method(expected)
+    method.owner == klass
+  end
+end

data/spec/support/shared/adapter_examples.rb

@@ -20,4 +20,7 @@ RSpec.shared_examples 'an adapter' do
       expect(subject.broker).to be(broker)
     end
   end
+
+  it { expect(subject.class).to respond_to(:new).with(1..2).arguments }
+  it { is_expected.to respond_to(:build_context).with(0).arguments }
 end

data/spec/support/shared/client_ack_examples.rb

@@ -1,18 +1,40 @@
 RSpec.shared_examples 'client acks are supported' do
-  describe '#supports_client_acks' do
+  describe '#supports_client_acks?' do
     it 'returns true' do
       expect(subject.supports_client_acks?).to eq(true)
     end
   end
 
-  it { is_expected.to respond_to :ack_message }
-  it { is_expected.to respond_to :nack_message }
+  it { is_expected.to override_method :handle_ack_message }
+  it { is_expected.not_to override_method :ack_message }
+  it { is_expected.to override_method :handle_nack_message }
+  it { is_expected.not_to override_method :nack_message }
 end
 
 RSpec.shared_examples 'client acks are not supported' do
-  describe '#supports_client_acks' do
+  it { is_expected.not_to override_method :handle_ack_message }
+  it { is_expected.not_to override_method :handle_nack_message }
+  describe '#supports_client_acks?' do
     it 'returns false' do
       expect(subject.supports_client_acks?).to eq(false)
     end
   end
+
+  describe '#ack_message' do
+    it 'raises an error' do
+      message = double('message')
+      expect do
+        subject.ack_message(message)
+      end.to raise_error "#ack_message is not supported by #{subject.adapter.class}"
+    end
+  end
+
+  describe '#nack_message' do
+    it 'raises an error' do
+      message = double('message')
+      expect do
+        subject.nack_message(message)
+      end.to raise_error "#nack_message is not supported by #{subject.adapter.class}"
+    end
+  end
 end

data/spec/support/shared/context_examples.rb

@@ -5,6 +5,52 @@ RSpec.shared_examples 'an adapter context' do
     it { expect(subject.adapter).to be adapter }
   end
 
+  describe 'interface' do
+    it { is_expected.to respond_to(:create_destination).with(1..3).arguments }
+    it { is_expected.to respond_to(:handle_create_destination).with(1..3).arguments }
+
+    it { is_expected.to respond_to(:publish).with(2..4).arguments }
+    it { is_expected.to respond_to(:handle_publish).with(2..4).arguments }
+
+    it { is_expected.to respond_to(:pop_message).with(1..2).arguments }
+    it { is_expected.to respond_to(:handle_pop_message).with(1..2).arguments }
+
+    it { is_expected.to respond_to(:subscribe).with(1..2).arguments }
+    it { is_expected.to respond_to(:handle_subscribe).with(1..2).arguments }
+
+    it { is_expected.to respond_to(:ack_message).with(1..2).arguments }
+    it { is_expected.to respond_to(:handle_ack_message).with(1..2).arguments }
+    it { is_expected.to respond_to(:nack_message).with(1..2).arguments }
+    it { is_expected.to respond_to(:handle_nack_message).with(1..2).arguments }
+
+    it { is_expected.to respond_to(:begin_transaction).with(0..1).arguments }
+    it { is_expected.to respond_to(:handle_begin_transaction).with(0..1).arguments }
+    it { is_expected.to respond_to(:commit_transaction).with(0..1).arguments }
+    it { is_expected.to respond_to(:handle_commit_transaction).with(0..1).arguments }
+    it { is_expected.to respond_to(:rollback_transaction).with(0..1).arguments }
+    it { is_expected.to respond_to(:handle_rollback_transaction).with(0..1).arguments }
+    it { is_expected.to respond_to(:in_transaction?).with(0).arguments }
+
+    it { is_expected.to respond_to(:message_count).with(1).arguments }
+    it { is_expected.to respond_to(:handle_message_count).with(1).arguments }
+    it { is_expected.to respond_to(:consumer_count).with(1).arguments }
+    it { is_expected.to respond_to(:handle_consumer_count).with(1).arguments }
+
+    describe 'overrides' do
+      it { expect(subject.class).not_to override_method(:create_destination) }
+      it { expect(subject.class).to override_method(:handle_create_destination) }
+
+      it { expect(subject.class).not_to override_method(:publish) }
+      it { expect(subject.class).to override_method(:handle_publish) }
+
+      it { expect(subject.class).not_to override_method(:pop_message) }
+      it { expect(subject.class).to override_method(:handle_pop_message) }
+
+      it { expect(subject.class).not_to override_method(:message_count) }
+      it { expect(subject.class).not_to override_method(:consumer_count) }
+    end
+  end
+
   it 'is initially valid' do
     is_expected.to be_valid
   end

data/spec/support/shared/destination_examples.rb

@@ -17,6 +17,14 @@ RSpec.shared_examples 'a destination' do
 
       it { is_expected.to be_a MessageDriver::Message::Base }
 
+      it 'has a reference to the context that fetched it' do
+        expect(message.ctx).to be_a MessageDriver::Adapters::ContextBase
+      end
+
+      it 'has a reference to the destination that it was fetched from' do
+        expect(message.destination).to be_a MessageDriver::Destination::Base
+      end
+
       describe '#body' do
         it { expect(subject.body).to eq(body) }
       end
@@ -30,6 +38,14 @@ RSpec.shared_examples 'a destination' do
       end
     end
   end
+
+  context 'interface' do
+    it { is_expected.to respond_to(:publish).with(1..3).arguments }
+    it { is_expected.to respond_to(:pop_message).with(0..1).arguments }
+    it { is_expected.to respond_to(:message_count).with(0).arguments }
+    it { is_expected.to respond_to(:subscribe).with(0..1).arguments }
+    it { is_expected.to respond_to(:consumer_count).with(0).arguments }
+  end
 end
 
 RSpec.shared_examples "doesn't support #message_count" do
@@ -50,6 +66,12 @@ RSpec.shared_examples 'supports #message_count' do
       pause_if_needed
     end.to change { destination.message_count }.by(2)
   end
+
+  it { is_expected.not_to override_method :message_count }
+
+  it 'the adapter context overrides #handle_message_count' do
+    expect(subject.adapter.broker.client.current_adapter_context).to override_method :handle_message_count
+  end
 end
 
 RSpec.shared_examples "doesn't support #consumer_count" do
@@ -79,4 +101,10 @@ RSpec.shared_examples 'supports #consumer_count' do
       end.to change { destination.consumer_count }.by(-2)
     end
   end
+
+  it { is_expected.not_to override_method :consumer_count }
+
+  it 'the adapter context overrides #handle_consumer_count' do
+    expect(subject.adapter.broker.client.current_adapter_context).to override_method :handle_message_count
+  end
 end

data/spec/support/shared/subscription_examples.rb

@@ -5,6 +5,8 @@ RSpec.shared_examples 'subscriptions are not supported' do
     end
   end
 
+  it { is_expected.not_to override_method(:handle_subscribe) }
+
   describe '#subscribe' do
     it 'raises an error' do
       destination = double('destination')
@@ -23,6 +25,8 @@ RSpec.shared_examples 'subscriptions are supported' do |subscription_type|
     end
   end
 
+  it { is_expected.to override_method(:handle_subscribe) }
+
   let(:destination) { adapter_context.create_destination('subscriptions_example_queue') }
 
   let(:message1) { 'message 1' }
@@ -87,6 +91,7 @@ RSpec.shared_examples 'subscriptions are supported' do |subscription_type|
           subscription
           pause_if_needed
         end.to change { messages.size }.from(0).to(2)
+        expect(messages.map(&:destination)).to all(be_a(MessageDriver::Destination::Base))
         bodies = messages.map(&:body)
         expect(bodies).to include(message1)
         expect(bodies).to include(message2)
@@ -121,7 +126,7 @@ RSpec.shared_examples 'subscriptions are supported' do |subscription_type|
       let(:error) { RuntimeError.new('oh nos!') }
       let(:consumer) do
         lambda do |_|
-          fail error
+          raise error
         end
       end
 

data/spec/support/shared/transaction_examples.rb

@@ -4,6 +4,34 @@ RSpec.shared_examples 'transactions are not supported' do
       expect(subject.supports_transactions?).to eq(false)
     end
   end
+
+  describe '#begin_transaction' do
+    it 'raises an error' do
+      expect do
+        subject.begin_transaction
+      end.to raise_error "transactions are not supported by #{subject.adapter.class}"
+    end
+  end
+
+  describe '#commit_transaction' do
+    it 'raises an error' do
+      expect do
+        subject.commit_transaction
+      end.to raise_error "transactions are not supported by #{subject.adapter.class}"
+    end
+  end
+
+  describe '#rollback_transaction' do
+    it 'raises an error' do
+      expect do
+        subject.rollback_transaction
+      end.to raise_error "transactions are not supported by #{subject.adapter.class}"
+    end
+  end
+
+  it { is_expected.not_to override_method :handle_begin_transaction }
+  it { is_expected.not_to override_method :handle_commit_transaction }
+  it { is_expected.not_to override_method :handle_rollback_transaction }
 end
 
 RSpec.shared_examples 'transactions are supported' do
@@ -13,10 +41,13 @@ RSpec.shared_examples 'transactions are supported' do
     end
   end
 
-  it { is_expected.to respond_to :begin_transaction }
-  it { is_expected.to respond_to :commit_transaction }
-  it { is_expected.to respond_to :rollback_transaction }
-  it { is_expected.to respond_to :in_transaction? }
+  it { is_expected.to override_method :handle_begin_transaction }
+  it { is_expected.not_to override_method :begin_transaction }
+  it { is_expected.to override_method :handle_commit_transaction }
+  it { is_expected.not_to override_method :commit_transaction }
+  it { is_expected.to override_method :handle_rollback_transaction }
+  it { is_expected.not_to override_method :rollback_transaction }
+  it { is_expected.to override_method :in_transaction? }
 
   describe '#in_transaction?' do
     it "returns false if you aren't in a transaction" do

data/spec/support/test_adapter.rb

@@ -0,0 +1,19 @@
+module MessageDriver
+  class TestAdapter < Adapters::Base
+    def initialize(broker, _config)
+      @broker = broker
+    end
+
+    def build_context
+      TestContext.new(self)
+    end
+  end
+
+  class TestContext < Adapters::ContextBase
+    def handle_create_destination(_name, _dest_options = nil, _message_props = nil); end
+
+    def handle_publish(_destination, _body, _dest_options = nil, _message_props = nil); end
+
+    def handle_pop_message(_destination, _options = nil); end
+  end
+end

data/spec/support/utils.rb

@@ -1,11 +1,7 @@
 module Utils
   def pause_if_needed(seconds = 0.1)
     seconds *= 10 if ENV['CI'] == 'true'
-    case BrokerConfig.current_adapter
-    when :in_memory
-    else
-      sleep seconds
-    end
+    sleep seconds unless BrokerConfig.current_adapter == :in_memory
   end
 end
 

data/spec/units/message_driver/adapters/base_spec.rb

@@ -3,11 +3,12 @@ require 'spec_helper'
 module MessageDriver
   module Adapters
     RSpec.describe Base do
-      class TestAdapter < Base
-        def initialize(_configuration)
+      let(:spec_adapter_class) do
+        Class.new(described_class) do
+          def initialize; end
         end
       end
-      subject(:adapter) { TestAdapter.new({}) }
+      subject(:adapter) { spec_adapter_class.new }
 
       describe '#new_context' do
         it 'raises an error' do
@@ -17,40 +18,45 @@ module MessageDriver
         end
       end
 
-      describe ContextBase do
-        class TestContext < ContextBase
-        end
-        subject(:adapter_context) { TestContext.new(adapter) }
-
-        it_behaves_like 'an adapter context'
-        it_behaves_like 'transactions are not supported'
-        it_behaves_like 'client acks are not supported'
-        it_behaves_like 'subscriptions are not supported'
-
-        describe '#create_destination' do
-          it 'raises an error' do
-            expect do
-              subject.create_destination('foo')
-            end.to raise_error 'Must be implemented in subclass'
+      context 'with a test adapter' do
+        subject(:adapter) { TestAdapter.new(nil, {}) }
+
+        describe ContextBase do
+          context 'with a test context subclass' do
+            subject(:adapter_context) { TestContext.new(adapter) }
+
+            it_behaves_like 'an adapter context'
+            it_behaves_like 'transactions are not supported'
+            it_behaves_like 'client acks are not supported'
+            it_behaves_like 'subscriptions are not supported'
           end
-        end
 
-        describe '#publish' do
-          it 'raises an error' do
-            expect do
-              subject.publish(:destination, foo: 'bar')
-            end.to raise_error 'Must be implemented in subclass'
+          subject(:adapter_context) { ContextBase.new(adapter) }
+
+          describe '#create_destination' do
+            it 'raises an error' do
+              expect do
+                subject.create_destination('foo')
+              end.to raise_error 'Must be implemented in subclass'
+            end
           end
-        end
 
-        describe '#pop_message' do
-          it 'raises an error' do
-            expect do
-              subject.pop_message(:destination)
-            end.to raise_error 'Must be implemented in subclass'
+          describe '#publish' do
+            it 'raises an error' do
+              expect do
+                subject.publish(:destination, foo: 'bar')
+              end.to raise_error 'Must be implemented in subclass'
+            end
           end
-        end
 
+          describe '#pop_message' do
+            it 'raises an error' do
+              expect do
+                subject.pop_message(:destination)
+              end.to raise_error 'Must be implemented in subclass'
+            end
+          end
+        end
       end
     end
   end