message-driver 0.4.0 → 0.5.0

data/spec/spec_helper.rb

@@ -1,29 +1,29 @@
-require 'coveralls'
-Coveralls.wear!
+ENV['COMMAND_NAME'] = 'specs'
+require File.join(File.dirname(__FILE__), '..', 'test_lib', 'coverage')
+require File.join(File.dirname(__FILE__), '..', 'test_lib', 'broker_config')
 
 require 'message_driver'
 
-require File.join(File.dirname(__FILE__), '..', 'test_lib', 'broker_config')
+BrokerConfig.setup_provider
 
-Dir['./spec/support/**/*.rb'].sort.each {|f| require f}
+Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
 
 RSpec.configure do |c|
-  c.treat_symbols_as_metadata_keys_with_true_values = true
-  c.order = 'random'
+  c.order = :random
   c.filter_run :focus
 
   c.reporter.message("Acceptance Tests running with broker config: #{BrokerConfig.config}")
 
   spec_logger = Logger.new(STDOUT).tap { |l| l.level = Logger::FATAL }
-  c.before(:each) do
+  c.before(:example) do
     MessageDriver.logger = spec_logger
   end
 
-  c.after(:each) do
+  c.after(:example) do
     MessageDriver::Broker.reset
   end
 
-  c.filter_run_excluding :no_ci if ENV['CI']=='true' && ENV['ADAPTER'] && ENV['ADAPTER'].start_with?('bunny')
+  c.filter_run_excluding :no_ci if ENV['CI'] == 'true' && ENV['ADAPTER'] && ENV['ADAPTER'].start_with?('bunny')
   if c.inclusion_filter[:all_adapters] == true
     BrokerConfig.unconfigured_adapters.each do |a|
       c.filter_run_excluding a
@@ -32,4 +32,6 @@ RSpec.configure do |c|
   else
     c.run_all_when_everything_filtered = true
   end
+
+  c.expose_dsl_globally = false
 end

data/spec/support/shared/adapter_examples.rb

@@ -1,4 +1,4 @@
-shared_examples 'an adapter' do
+RSpec.shared_examples 'an adapter' do
   describe '#new_context' do
     it 'returns a MessageDriver::Adapters::ContextBase' do
       expect(subject.new_context).to be_a MessageDriver::Adapters::ContextBase

data/spec/support/shared/client_ack_examples.rb

@@ -1,15 +1,15 @@
-shared_examples 'client acks are supported' do
+RSpec.shared_examples 'client acks are supported' do
   describe '#supports_client_acks' do
     it 'returns true' do
       expect(subject.supports_client_acks?).to eq(true)
     end
   end
 
-  it { should respond_to :ack_message }
-  it { should respond_to :nack_message }
+  it { is_expected.to respond_to :ack_message }
+  it { is_expected.to respond_to :nack_message }
 end
 
-shared_examples 'client acks are not supported' do
+RSpec.shared_examples 'client acks are not supported' do
   describe '#supports_client_acks' do
     it 'returns false' do
       expect(subject.supports_client_acks?).to eq(false)

data/spec/support/shared/context_examples.rb

@@ -1,10 +1,12 @@
-shared_examples 'an adapter context' do
-  it { should be_a MessageDriver::Adapters::ContextBase }
+RSpec.shared_examples 'an adapter context' do
+  it { is_expected.to be_a MessageDriver::Adapters::ContextBase }
 
-  its(:adapter) { should be adapter }
+  describe '#adapter' do
+    it { expect(subject.adapter).to be adapter }
+  end
 
   it 'is initially valid' do
-    should be_valid
+    is_expected.to be_valid
   end
 
   describe '#invalidate' do

data/spec/support/shared/destination_examples.rb

@@ -1,10 +1,12 @@
-shared_examples 'a destination' do
-  its(:adapter) { should be adapter }
+RSpec.shared_examples 'a destination' do
+  describe '#adapter' do
+    it { expect(subject.adapter).to be adapter }
+  end
 
   describe '#pop_message' do
     let(:body) { 'The message body' }
-    let(:headers) { { 'foo' => 'bar', 'bar' => 'baz'} }
-    let(:properties) { {persistent: true, client_ack: true} }
+    let(:headers) { { 'foo' => 'bar', 'bar' => 'baz' } }
+    let(:properties) { { persistent: true, client_ack: true } }
 
     before do
       destination.publish(body, headers, properties)
@@ -13,30 +15,68 @@ shared_examples 'a destination' do
     context 'the result' do
       subject(:message) { destination.pop_message }
 
-      it { should be_a MessageDriver::Message::Base }
-      its(:body) { should eq(body) }
-      its(:headers) { should include(headers) }
-      its(:properties) { should_not be_nil }
+      it { is_expected.to be_a MessageDriver::Message::Base }
+
+      describe '#body' do
+        it { expect(subject.body).to eq(body) }
+      end
+
+      describe '#headers' do
+        it { expect(subject.headers).to include(headers) }
+      end
+
+      describe '#properties' do
+        it { expect(subject.properties).not_to be_nil }
+      end
     end
   end
 end
 
-shared_examples "doesn't support #message_count" do
+RSpec.shared_examples "doesn't support #message_count" do
   describe '#message_count' do
     it 'raises an error' do
-      expect {
+      expect do
         destination.message_count
-      }.to raise_error "#message_count is not supported by #{destination.class}"
+      end.to raise_error "#message_count is not supported by #{destination.class}"
     end
   end
 end
 
-shared_examples 'supports #message_count' do
+RSpec.shared_examples 'supports #message_count' do
   it "reports it's message_count" do
-    expect {
+    expect do
       destination.publish('msg1')
       destination.publish('msg2')
       pause_if_needed
-    }.to change{destination.message_count}.by(2)
+    end.to change { destination.message_count }.by(2)
+  end
+end
+
+RSpec.shared_examples "doesn't support #consumer_count" do
+  describe '#consumer_count' do
+    it 'raises an error' do
+      expect do
+        destination.consumer_count
+      end.to raise_error "#consumer_count is not supported by #{destination.class}"
+    end
+  end
+end
+
+RSpec.shared_examples 'supports #consumer_count' do
+  describe '#consumer_count' do
+    it "reports it's consumer count" do
+      consumer1 = ->(_) {}
+      consumer2 = ->(_) {}
+      sub1 = nil
+      sub2 = nil
+      expect do
+        sub1 = destination.subscribe(&consumer1)
+        sub2 = destination.subscribe(&consumer2)
+      end.to change { destination.consumer_count }.by(2)
+      expect do
+        sub1.unsubscribe
+        sub2.unsubscribe
+      end.to change { destination.consumer_count }.by(-2)
+    end
   end
 end

data/spec/support/shared/subscription_examples.rb

@@ -1,4 +1,4 @@
-shared_examples 'subscriptions are not supported' do
+RSpec.shared_examples 'subscriptions are not supported' do
   describe '#supports_subscriptions?' do
     it 'returns false' do
       expect(subject.supports_subscriptions?).to eq(false)
@@ -8,15 +8,15 @@ shared_examples 'subscriptions are not supported' do
   describe '#subscribe' do
     it 'raises an error' do
       destination = double('destination')
-      consumer = lambda do |_| end
-      expect {
+      consumer = ->(_) {}
+      expect do
         subject.subscribe(destination, &consumer)
-      }.to raise_error "#subscribe is not supported by #{subject.adapter.class}"
+      end.to raise_error "#subscribe is not supported by #{subject.adapter.class}"
     end
   end
 end
 
-shared_examples 'subscriptions are supported' do |subscription_type|
+RSpec.shared_examples 'subscriptions are supported' do |subscription_type|
   describe '#supports_subscriptions?' do
     it 'returns true' do
       expect(subject.supports_subscriptions?).to eq(true)
@@ -36,9 +36,7 @@ shared_examples 'subscriptions are supported' do |subscription_type|
 
   describe '#subscribe' do
     before do
-      if destination.respond_to? :purge
-        destination.purge
-      end
+      destination.purge if destination.respond_to? :purge
     end
 
     let(:subscription) { adapter_context.subscribe(destination, &consumer) }
@@ -53,18 +51,27 @@ shared_examples 'subscriptions are supported' do |subscription_type|
     context 'the subscription' do
       subject { subscription }
 
-      it { should be_a MessageDriver::Subscription::Base }
-      it { should be_a subscription_type }
-      its(:adapter) { should be adapter }
-      its(:destination) { should be destination }
-      its(:consumer) { should be consumer }
+      it { is_expected.to be_a MessageDriver::Subscription::Base }
+      it { is_expected.to be_a subscription_type }
+
+      describe '#adapter' do
+        it { expect(subject.adapter).to be adapter }
+      end
+
+      describe '#destination' do
+        it { expect(subject.destination).to be destination }
+      end
+
+      describe '#consumer' do
+        it { expect(subject.consumer).to be consumer }
+      end
 
       describe '#unsubscribe' do
         it "makes it so messages don't go to the consumer any more" do
           subscription.unsubscribe
-          expect {
+          expect do
             destination.publish('should not be consumed')
-          }.to_not change{messages.size}
+          end.to_not change { messages.size }
         end
       end
     end
@@ -76,10 +83,10 @@ shared_examples 'subscriptions are supported' do |subscription_type|
       end
 
       it 'plays the messages into the consumer' do
-        expect {
+        expect do
           subscription
           pause_if_needed
-        }.to change{messages.size}.from(0).to(2)
+        end.to change { messages.size }.from(0).to(2)
         bodies = messages.map(&:body)
         expect(bodies).to include(message1)
         expect(bodies).to include(message2)
@@ -87,10 +94,10 @@ shared_examples 'subscriptions are supported' do |subscription_type|
 
       it 'removes the messages from the queue' do
         pause_if_needed
-        expect {
+        expect do
           subscription
           pause_if_needed
-        }.to change{destination.message_count}.from(2).to(0)
+        end.to change { destination.message_count }.from(2).to(0)
       end
     end
 
@@ -100,12 +107,12 @@ shared_examples 'subscriptions are supported' do |subscription_type|
       end
 
       it 'consumers the message into the consumer instead of putting them on the queue' do
-        expect {
-          expect {
+        expect do
+          expect do
             subject.publish(destination, message1)
             pause_if_needed
-          }.to change{messages.length}.from(0).to(1)
-        }.to_not change{destination.message_count}
+          end.to change { messages.length }.from(0).to(1)
+        end.to_not change { destination.message_count }
         expect(messages[0].body).to eq(message1)
       end
     end
@@ -114,7 +121,7 @@ shared_examples 'subscriptions are supported' do |subscription_type|
       let(:error) { RuntimeError.new('oh nos!') }
       let(:consumer) do
         lambda do |_|
-          raise error
+          fail error
         end
       end
 
@@ -125,10 +132,10 @@ shared_examples 'subscriptions are supported' do |subscription_type|
 
       it 'keeps processing the messages' do
         pause_if_needed
-        expect {
+        expect do
           subscription
           pause_if_needed
-        }.to change{destination.message_count}.from(2).to(0)
+        end.to change { destination.message_count }.from(2).to(0)
       end
 
       context 'an error_handler is provided' do

data/spec/support/shared/transaction_examples.rb

@@ -1,4 +1,4 @@
-shared_examples 'transactions are not supported' do
+RSpec.shared_examples 'transactions are not supported' do
   describe '#supports_transactions?' do
     it 'returns false' do
       expect(subject.supports_transactions?).to eq(false)
@@ -6,17 +6,17 @@ shared_examples 'transactions are not supported' do
   end
 end
 
-shared_examples 'transactions are supported' do
+RSpec.shared_examples 'transactions are supported' do
   describe '#supports_transactions?' do
     it 'returns true' do
       expect(subject.supports_transactions?).to eq(true)
     end
   end
 
-  it { should respond_to :begin_transaction }
-  it { should respond_to :commit_transaction }
-  it { should respond_to :rollback_transaction }
-  it { should respond_to :in_transaction? }
+  it { is_expected.to respond_to :begin_transaction }
+  it { is_expected.to respond_to :commit_transaction }
+  it { is_expected.to respond_to :rollback_transaction }
+  it { is_expected.to respond_to :in_transaction? }
 
   describe '#in_transaction?' do
     it "returns false if you aren't in a transaction" do
@@ -26,18 +26,18 @@ shared_examples 'transactions are supported' do
 
   it 'raises a MessageDriver::TransactionError error if you begin two transactions' do
     subject.begin_transaction
-    expect {
+    expect do
       subject.begin_transaction
-    }.to raise_error MessageDriver::TransactionError
+    end.to raise_error MessageDriver::TransactionError
   end
   it 'raises a MessageDriver::TransactionError error if you commit outside of a transaction' do
-    expect {
+    expect do
       subject.commit_transaction
-    }.to raise_error MessageDriver::TransactionError
+    end.to raise_error MessageDriver::TransactionError
   end
   it 'raises a MessageDriver::TransactionError error if you rollback outside of a transaction' do
-    expect {
+    expect do
       subject.rollback_transaction
-    }.to raise_error MessageDriver::TransactionError
+    end.to raise_error MessageDriver::TransactionError
   end
 end

data/spec/support/utils.rb

@@ -1,5 +1,5 @@
 module Utils
-  def pause_if_needed(seconds=0.1)
+  def pause_if_needed(seconds = 0.1)
     seconds *= 10 if ENV['CI'] == 'true'
     case BrokerConfig.current_adapter
     when :in_memory

data/spec/units/message_driver/adapters/base_spec.rb

@@ -1,55 +1,57 @@
 require 'spec_helper'
 
-module MessageDriver::Adapters
-  describe Base do
-    class TestAdapter < Base
-      def initialize(_configuration)
-      end
-    end
-    subject(:adapter) { TestAdapter.new({}) }
-
-    describe '#new_context' do
-      it 'raises an error' do
-        expect {
-          subject.new_context
-        }.to raise_error 'Must be implemented in subclass'
-      end
-    end
-
-    describe ContextBase do
-      class TestContext < ContextBase
+module MessageDriver
+  module Adapters
+    RSpec.describe Base do
+      class TestAdapter < Base
+        def initialize(_configuration)
+        end
       end
-      subject(:adapter_context) { TestContext.new(adapter) }
-
-      it_behaves_like 'an adapter context'
-      it_behaves_like 'transactions are not supported'
-      it_behaves_like 'client acks are not supported'
-      it_behaves_like 'subscriptions are not supported'
+      subject(:adapter) { TestAdapter.new({}) }
 
-      describe '#create_destination' do
+      describe '#new_context' do
         it 'raises an error' do
-          expect {
-            subject.create_destination('foo')
-          }.to raise_error 'Must be implemented in subclass'
+          expect do
+            subject.new_context
+          end.to raise_error 'Must be implemented in subclass'
         end
       end
 
-      describe '#publish' do
-        it 'raises an error' do
-          expect {
-            subject.publish(:destination, foo: 'bar')
-          }.to raise_error 'Must be implemented in subclass'
+      describe ContextBase do
+        class TestContext < ContextBase
+        end
+        subject(:adapter_context) { TestContext.new(adapter) }
+
+        it_behaves_like 'an adapter context'
+        it_behaves_like 'transactions are not supported'
+        it_behaves_like 'client acks are not supported'
+        it_behaves_like 'subscriptions are not supported'
+
+        describe '#create_destination' do
+          it 'raises an error' do
+            expect do
+              subject.create_destination('foo')
+            end.to raise_error 'Must be implemented in subclass'
+          end
         end
-      end
 
-      describe '#pop_message' do
-        it 'raises an error' do
-          expect {
-            subject.pop_message(:destination)
-          }.to raise_error 'Must be implemented in subclass'
+        describe '#publish' do
+          it 'raises an error' do
+            expect do
+              subject.publish(:destination, foo: 'bar')
+            end.to raise_error 'Must be implemented in subclass'
+          end
+        end
+
+        describe '#pop_message' do
+          it 'raises an error' do
+            expect do
+              subject.pop_message(:destination)
+            end.to raise_error 'Must be implemented in subclass'
+          end
         end
-      end
 
+      end
     end
   end
 end