message-driver 0.1.0 → 0.2.0.rc1

data/features/client_acks.feature

@@ -0,0 +1,92 @@
+@bunny
+Feature: Client Acks
+  Support for doing client acks on messages
+
+  Background:
+    Given I am connected to the broker
+    And I have a destination :source_queue
+    And I have the following messages on :source_queue
+      | body         |
+      | Test Message |
+
+
+  Scenario: Calling ack on the message to acknowledge it
+    When I execute the following code
+    """ruby
+    message = MessageDriver::Client.pop_message(:source_queue, client_ack: true)
+    message.ack
+    """
+
+    Then I expect to find no messages on :source_queue
+
+
+  Scenario: Calling nack on the message to put it back on the queue
+    When I execute the following code
+    """ruby
+    message = MessageDriver::Client.pop_message(:source_queue, client_ack: true)
+    message.nack
+    """
+
+    Then I expect to find the following message on :source_queue
+      | body         |
+      | Test Message |
+
+
+  Scenario: Acking in a transaction that commits
+    When I execute the following code
+    """ruby
+    MessageDriver::Client.with_message_transaction do
+      message = MessageDriver::Client.pop_message(:source_queue, client_ack: true)
+      message.ack
+    end
+    """
+
+    Then I expect to find no messages on :source_queue
+
+
+  Scenario: Nacking in a transaction that commits
+    When I execute the following code
+    """ruby
+    MessageDriver::Client.with_message_transaction do
+      message = MessageDriver::Client.pop_message(:source_queue, client_ack: true)
+      message.nack
+    end
+    """
+
+    Then I expect to find the following message on :source_queue
+      | body         |
+      | Test Message |
+
+
+  Scenario: Acking in a transaction that rolls back
+    When I execute the following code
+    """ruby
+    MessageDriver::Client.with_message_transaction do
+      message = MessageDriver::Client.pop_message(:source_queue, client_ack: true)
+      message.ack
+      raise "rollback the transaction"
+    end
+    """
+    And I reset the context
+
+    Then I expect it to raise "rollback the transaction"
+    And I expect to find the following message on :source_queue
+      | body         |
+      | Test Message |
+
+
+  Scenario: Nacking in a transaction that rolls back
+    When I execute the following code
+    """ruby
+    MessageDriver::Client.with_message_transaction do
+      message = MessageDriver::Client.pop_message(:source_queue, client_ack: true)
+      message.nack
+      raise "rollback the transaction"
+    end
+    """
+    And I reset the context
+
+    Then I expect it to raise "rollback the transaction"
+    And I expect to find the following message on :source_queue
+      | body         |
+      | Test Message |

data/features/destination_metadata.feature

@@ -2,15 +2,11 @@
 @in_memory
 Feature: Destination Metadata
   Background:
-    Given the following broker configuration:
-    """ruby
-    MessageDriver::Broker.define do |b|
-      b.destination :my_queue, "my_queue", exclusive: true
-    end
-    """
+    Given I am connected to the broker
+    And I have a destination :my_queue with no messages on it
 
   Scenario: Checking the message count when the queue is empty
-    When I execute the following code:
+    When I execute the following code
     """ruby
     destination = MessageDriver::Broker.find_destination(:my_queue)
     expect(destination.message_count).to eq(0)
@@ -19,12 +15,14 @@ Feature: Destination Metadata
     Then I expect to have no errors
     And I expect to find no messages on :my_queue
 
-  @no_travis
   Scenario: Checking the message count when the queue has messages
-    When I execute the following code:
+    When I send the following messages to :my_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I allow for processing
+    And I execute the following code
     """ruby
-    publish(:my_queue, "test message 1")
-    publish(:my_queue, "test message 2")
     destination = MessageDriver::Broker.find_destination(:my_queue)
     expect(destination.message_count).to eq(2)
     """

data/features/dynamic_destinations.feature

@@ -1,6 +1,6 @@
 @all_adapters
 Feature: Dynamic Destinations
-  Sometime you want to connect to a queue that has some of it's characteristics
+  Sometimes you want to connect to a queue that has some of it's characteristics
   determined at runtime. Dynamic destinations allow you to do with without
   leaking tons of destination definitions.
 
@@ -8,25 +8,25 @@ Feature: Dynamic Destinations
     Given I am connected to the broker
 
   Scenario: Sending to a dynamic destination
-    When I execute the following code:
+    When I execute the following code
     """ruby
-    my_new_destination = MessageDriver::Broker.dynamic_destination("temp_queue", exclusive: true)
+    my_new_destination = MessageDriver::Broker.dynamic_destination("temp_queue")
     my_new_destination.publish("Test Message")
     """
 
-    Then I expect to find 1 message on the dynamic destination "temp_queue" with:
+    Then I expect to find 1 message on the dynamic destination "temp_queue" with
       | body         |
       | Test Message |
 
   Scenario: Poping messages off a dynamic destination
-    Given I have a dynamic destination "temp_queue" with the following messages on it:
+    Given I have a dynamic destination "temp_queue" with the following messages on it
       | body           |
       | Test Message 1 |
       | Test Message 2 |
 
-    When I execute the following code:
+    When I execute the following code
     """ruby
-    my_new_destination = MessageDriver::Broker.dynamic_destination("temp_queue", exclusive: true)
+    my_new_destination = MessageDriver::Broker.dynamic_destination("temp_queue")
 
     msg1 = my_new_destination.pop_message
     expect(msg1.body).to eq("Test Message 1")

data/features/error_handling.feature

@@ -5,42 +5,44 @@ Feature: Error Handling
 
   @bunny
   Scenario: Queue isn't found on the broker
-    When I execute the following code:
+    When I execute the following code
     """ruby
     MessageDriver::Broker.dynamic_destination("missing_queue", passive: true)
     """
 
     Then I expect it to raise a MessageDriver::QueueNotFound error
 
-  @no_travis
+  @no_ci
   @bunny
+  @slow
   Scenario: The broker goes down
-    Given the following broker configuration:
+    Given the following broker configuration
     """ruby
     MessageDriver::Broker.define do |b|
-      b.destination :my_queue, "broker_down_queue", arguments: {:'x-expires' => 10000 }
+      b.destination :my_queue, "broker_down_queue", durable: true, arguments: {:'x-expires' => 1000*60*10 } #expires in 10 minutes
     end
     """
+    And I have no messages on :my_queue
 
-    When I execute the following code:
+    When I execute the following code
     """ruby
     publish(:my_queue, "Test Message 1")
     """
     And the broker goes down
-    And I execute the following code:
+    And I execute the following code
     """ruby
     publish(:my_queue, "Test Message 2")
     """
-    Then I expect it to raise a MessageDriver::ConnectionException error
+    Then I expect it to raise a MessageDriver::ConnectionError error
 
     When the broker comes up
-    And I execute the following code:
+    And I execute the following code
     """ruby
     publish(:my_queue, "Test Message 3")
     """
 
     Then I expect to have no errors
-    And I expect to find 2 messages on :my_queue with:
+    And I expect to find the following 2 messages on :my_queue
       | body           |
       | Test Message 1 |
       | Test Message 3 |

data/features/logging.feature

@@ -0,0 +1,14 @@
+@all_adapters
+Feature: Stuff gets logged if you set a logger
+
+  You can configure the logger by add a logger to the hash passed to `MessageDriver::Broker.configure`.
+  If you don't provide a logger, then an info level logger will be created and sent to `STDOUT`.
+
+  Scenario: Starting the broker
+    Given I am logging to a log file at the debug level
+    And I am connected to the broker
+
+    Then the log file should contain:
+    """
+    MessageDriver configured successfully!
+    """

data/features/message_consumers/auto_ack_consumers.feature

@@ -0,0 +1,79 @@
+@bunny
+Feature: Message Consumers auto-acknowledgement
+  This mode will ack the message if the consumer completes successfully.
+  It will nack the message if the consumer raises an error.
+
+  Background:
+    Given I am connected to the broker
+    And I have a destination :dest_queue with no messages on it
+    And I have a destination :source_queue with no messages on it
+
+  Scenario: Consuming Messages
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      MessageDriver::Client.publish(:dest_queue, message.body)
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :auto)
+    """
+
+    When I send the following messages to :source_queue
+      | body       |
+      | Auto Ack 1 |
+      | Auto Ack 2 |
+    And I let the subscription process
+
+    Then I expect to find no messages on :source_queue
+    And I expect to find the following 2 messages on :dest_queue
+      | body       |
+      | Auto Ack 1 |
+      | Auto Ack 2 |
+
+
+  Scenario: An error occurs during processing
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      raise "oh nos!"
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :auto)
+    """
+
+    When I send the following messages to :source_queue
+      | body             |
+      | Auto Ack Error 1 |
+      | Auto Ack Error 2 |
+    And I let the subscription process
+
+    Then I expect to find no messages on :dest_queue
+    And I expect to find the following 2 messages on :source_queue
+      | body             |
+      | Auto Ack Error 1 |
+      | Auto Ack Error 2 |
+
+  Scenario: A DontRequeue error occurs during processing
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      raise MessageDriver::DontRequeueError, "don't requeue me"
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :auto)
+    """
+
+    When I send the following messages to :source_queue
+      | body             |
+      | Auto Ack Error 1 |
+      | Auto Ack Error 2 |
+    And I let the subscription process
+
+    Then I expect to find no messages on :dest_queue
+    And I expect to find no messages on :source_queue

data/features/message_consumers/manual_ack_consumers.feature

@@ -0,0 +1,95 @@
+@bunny
+Feature: Message Consumers with manual acknowledgement
+  This mode requires the consumer to call ack on the message in order to acknowledge it
+
+  Background:
+    Given I am connected to the broker
+    And I have a destination :source_queue with no messages on it
+
+  Scenario: Consuming Messages
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      message.ack
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :manual)
+    """
+
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I let the subscription process
+
+    Then I expect to find no messages on :source_queue
+
+  Scenario: When a message is nack'ed
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      message.nack(requeue: true)
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :manual)
+    """
+
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I let the subscription process
+
+    Then I expect to find the following 2 messages on :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+
+  Scenario: When an occurs before the message is ack'ed
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      raise "oh nos!"
+      message.ack
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :manual)
+    """
+
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I let the subscription process
+
+    Then I expect to find the following 2 messages on :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+
+  Scenario: When an error occurs after the message is ack'ed
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      message.ack
+      raise "oh nos!"
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :manual)
+    """
+
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I let the subscription process
+
+    Then I expect to find no messages on :source_queue

data/features/message_consumers/transactional_ack_consumers.feature

@@ -0,0 +1,77 @@
+@bunny
+Feature: Transactional Message Consumers
+  Background:
+    Given I am connected to the broker
+    And I have a destination :dest_queue with no messages on it
+    And I have a destination :source_queue with no messages on it
+
+  Scenario: Consuming Messages within a transaction
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      MessageDriver::Client.publish(:dest_queue, message.body)
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :transactional)
+    """
+
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I let the subscription process
+
+    Then I expect to find no messages on :source_queue
+    And I expect to find the following 2 messages on :dest_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+
+  Scenario: When an error occurs
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      MessageDriver::Client.publish(:dest_queue, message.body)
+      raise "oh nos!"
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :transactional)
+    """
+
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I let the subscription process
+
+    Then I expect to find the following 2 messages on :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I expect to find no messages on :dest_queue
+
+  Scenario: When a DontRequeue error occurs
+    Given I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      MessageDriver::Client.publish(:dest_queue, message.body)
+      raise MessageDriver::DontRequeueError, "don't requeue me"
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer, ack: :transactional)
+    """
+
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I let the subscription process
+
+    Then I expect to find no messages on :source_queue
+    And I expect to find no messages on :dest_queue

data/features/message_consumers.feature

@@ -0,0 +1,54 @@
+@in_memory
+@bunny
+Feature: Message Consumers
+  Background:
+    Given I am connected to the broker
+    And I have a destination :dest_queue with no messages on it
+    And I have a destination :source_queue with no messages on it
+    And I have a message consumer
+    """ruby
+    MessageDriver::Broker.consumer(:my_consumer) do |message|
+      MessageDriver::Client.publish(:dest_queue, message.body)
+    end
+    """
+    And I create a subscription
+    """ruby
+    MessageDriver::Client.subscribe(:source_queue, :my_consumer)
+    """
+
+
+  Scenario: Consuming Messages
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I let the subscription process
+
+    Then I expect to find no messages on :source_queue
+    And I expect to find the following 2 messages on :dest_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+
+
+  Scenario: Ending a subscription
+    When I send the following messages to :source_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+    And I allow for processing
+    And I cancel the subscription
+    And I send the following messages to :source_queue
+      | body           |
+      | Test Message 3 |
+      | Test Message 4 |
+
+    Then I expect to find the following 2 messages on :dest_queue
+      | body           |
+      | Test Message 1 |
+      | Test Message 2 |
+
+    And I expect to find the following 2 messages on :source_queue
+      | body           |
+      | Test Message 3 |
+      | Test Message 4 |

data/features/publishing_a_message.feature

@@ -1,19 +1,15 @@
 @all_adapters
 Feature: Publishing A Message
   Background:
-    Given the following broker configuration:
-    """ruby
-    MessageDriver::Broker.define do |b|
-      b.destination :my_queue, "my_queue", exclusive: true
-    end
-    """
+    Given I am connected to the broker
+    And I have a destination :publish_test with no messages on it
 
-  Scenario: Running within a with_message_transaction block
-    When I execute the following code:
+  Scenario: Publishing a message
+    When I execute the following code
     """ruby
-    publish(:my_queue, "Test Message")
+    publish(:publish_test, "Test Message")
     """
 
-    Then I expect to find 1 message on :my_queue with:
+    Then I expect to find the following message on :publish_test
       | body         |
       | Test Message |

data/features/publishing_with_transactions.feature

@@ -1,36 +1,32 @@
 @bunny
 Feature: Publishing a Message within a Transaction
   Background:
-    Given the following broker configuration:
-    """ruby
-    MessageDriver::Broker.define do |b|
-      b.destination :my_queue, "my_queue", exclusive: true
-    end
-    """
+    Given I am connected to the broker
+    And I have a destination :publish_transaction with no messages on it
 
   Scenario: The block completes successfully
-    When I execute the following code:
+    When I execute the following code
     """ruby
     with_message_transaction do
-      publish(:my_queue, "Transacted Message 1")
-      publish(:my_queue, "Transacted Message 2")
+      publish(:publish_transaction, "Transacted Message 1")
+      publish(:publish_transaction, "Transacted Message 2")
     end
     """
 
-    Then I expect to find 2 messages on :my_queue with:
+    Then I expect to find the following 2 messages on :publish_transaction
       | body                 |
       | Transacted Message 1 |
       | Transacted Message 2 |
 
   Scenario: An error is raised inside the block
-    When I execute the following code:
+    When I execute the following code
     """ruby
     with_message_transaction do
-      publish(:my_queue, "Transacted Message 1")
+      publish(:publish_transaction, "Transacted Message 1")
       raise "an error that causes a rollback"
-      publish(:my_queue, "Transacted Message 2")
+      publish(:publish_transaction, "Transacted Message 2")
     end
     """
 
     Then I expect it to raise "an error that causes a rollback"
-    And I expect to find no messages on :my_queue
+    And I expect to find no messages on :publish_transaction