mercury-rails 0.6.0 → 0.7.0

data/spec/javascripts/mercury/modals/insertlink_spec.js.coffee

@@ -8,12 +8,13 @@ describe "Mercury.modalHandlers.insertLink", ->
       element: $('#test')
       hide: ->
       resize: ->
+    @insertLink = $.extend(@modal, Mercury.modalHandlers.insertLink)
     window.mercuryInstance = {document: $(document)}
 
   describe "initializing", ->
 
     beforeEach ->
-      Mercury.modalHandlers.insertLink.call(@modal)
+      @insertLink.initialize()
 
     it "loads all links with a name into the existing bookmarks pulldown", ->
       options = $('#link_existing_bookmark').html()
@@ -25,28 +26,35 @@ describe "Mercury.modalHandlers.insertLink", ->
   describe "clicking on a radio button (in a label)", ->
 
     beforeEach ->
-      Mercury.modalHandlers.insertLink.call(@modal)
+      @insertLink.initialize()
 
     it "focuses the next input with a selectable class", ->
       spy = spyOn($.fn, 'focus').andCallFake(=>)
-      jasmine.simulate.click($('#checkbox1').get(0))
+      jasmine.simulate.click($('input[value=external_url]').get(0))
       expect(spy.callCount).toEqual(1)
 
 
   describe "focusing an input", ->
 
     beforeEach ->
-      Mercury.modalHandlers.insertLink.call(@modal)
+      @insertLink.initialize()
 
     it "checks the corresponding checkbox", ->
       $('#link_existing_bookmark').focus()
-      expect($('#checkbox2').get(0).checked).toEqual(true)
+      expect($('input[value=existing_bookmark]').get(0).checked).toEqual(true)
 
 
   describe "changing the link target", ->
 
     it "shows options for whatever was selected", ->
+      $('#link_target').val('popup')
+      @insertLink.onChangeTarget()
+      expect($('#popup_options').is(':visible')).toEqual(true)
+
     it "calls resize", ->
+      spy = spyOn(@modal, 'resize')
+      @insertLink.onChangeTarget()
+      expect(spy.callCount).toEqual(1)
 
 
   describe "when editing", ->
@@ -56,12 +64,11 @@ describe "Mercury.modalHandlers.insertLink", ->
       beforeEach ->
         Mercury.region = selection: => {
           commonAncestor: -> $('<a>', {href: 'http://cnn.com', target: '_top'}).html('foo'),
-          textContent: -> 'content'
-          }
-        Mercury.modalHandlers.insertLink.call(@modal)
+        }
+        @insertLink.initialize()
 
       it "hides the link text input", ->
-        expect($('#link_text_container').css('display')).toEqual('none')
+        expect($('#link_text_container').is(':visible')).toEqual(false)
 
       it "pre-fills the link url input", ->
         expect($('#link_external_url').val()).toEqual('http://cnn.com')
@@ -69,17 +76,16 @@ describe "Mercury.modalHandlers.insertLink", ->
       it "selects the target if one's available", ->
         expect($('#link_target').val()).toEqual('_top')
 
-      it "fills the content", ->
-        expect($('#link_text').val()).toEqual('content')
-
     describe "a javascript popup link", ->
 
       beforeEach ->
-        Mercury.region = selection: => {commonAncestor: -> $('<a>', {href: "javascript:void(window.open('http://cnn.com', 'popup_window', 'width=100,height=42,menubar=no,toolbar=no'))"}).html('foo')}
-        Mercury.modalHandlers.insertLink.call(@modal)
+        Mercury.region = selection: => {
+          commonAncestor: -> $('<a>', {href: "javascript:void(window.open('http://cnn.com', 'popup_window', 'width=100,height=42,menubar=no,toolbar=no'))"}).html('foo')
+        }
+        @insertLink.initialize()
 
       it "hides the link text input", ->
-        expect($('#link_text_container').css('display')).toEqual('none')
+        expect($('#link_text_container').is(':visible')).toEqual(false)
 
       it "pre-fills the link url input", ->
         expect($('#link_external_url').val()).toEqual('http://cnn.com')
@@ -94,11 +100,13 @@ describe "Mercury.modalHandlers.insertLink", ->
     describe "a bookmark link", ->
 
       beforeEach ->
-        Mercury.region = selection: => {commonAncestor: -> $('<a>', {href: '#link2'}).html('foo')}
-        Mercury.modalHandlers.insertLink.call(@modal)
+        Mercury.region = selection: => {
+          commonAncestor: -> $('<a>', {href: '#link2'}).html('foo')
+        }
+        @insertLink.initialize()
 
       it "hides the link text input", ->
-        expect($('#link_text_container').css('display')).toEqual('none')
+        expect($('#link_text_container').is(':visible')).toEqual(false)
 
       it "checks the existing bookmark radio", ->
         expect($('input[value=existing_bookmark]').get(0).checked).toEqual(true)
@@ -109,8 +117,10 @@ describe "Mercury.modalHandlers.insertLink", ->
     describe "a bookmark target", ->
 
       beforeEach ->
-        Mercury.region = selection: => {commonAncestor: -> $('<a>', {name: 'link3'}).html('foo')}
-        Mercury.modalHandlers.insertLink.call(@modal)
+        Mercury.region = selection: => {
+          commonAncestor: -> $('<a>', {name: 'link3'}).html('foo')
+        }
+        @insertLink.initialize()
 
       it "hides the link text input", ->
         expect($('#link_text_container').css('display')).toEqual('none')
@@ -122,18 +132,80 @@ describe "Mercury.modalHandlers.insertLink", ->
         expect($('#link_new_bookmark').val()).toEqual('link3')
 
 
+  describe "validating", ->
+
+    beforeEach ->
+      @insertLink.initialize()
+      @triggerSpy = spyOn(Mercury, 'trigger').andCallFake(=>)
+      $('#link_text').val('foo')
+
+    it "displays an error if there's no content", ->
+      $('#link_text').val('')
+      @insertLink.validateForm()
+      expect(@insertLink.valid).toEqual(false)
+      expect($('#link_text').closest('.control-group').find('.error-message').html()).toEqual("can't be blank")
+
+    describe "a standard link", ->
+
+      it "displays an error", ->
+        @insertLink.validateForm()
+        expect(@insertLink.valid).toEqual(false)
+        expect($('#link_external_url').closest('.control-group').find('.error-message').html()).toEqual("can't be blank")
+
+      it "doesn't submit", ->
+        @insertLink.validateForm()
+        expect(@triggerSpy.callCount).toEqual(0)
+
+    describe "a bookmark link", ->
+
+      beforeEach ->
+        jasmine.simulate.click($('input[value=existing_bookmark]').get(0))
+        $('#link_existing_bookmark').html('').val('')
+
+      it "displays an error", ->
+        @insertLink.validateForm()
+        expect(@insertLink.valid).toEqual(false)
+        expect($('#link_existing_bookmark').closest('.control-group').find('.error-message').html()).toEqual("can't be blank")
+
+      it "doesn't submit", ->
+        @insertLink.validateForm()
+        expect(@triggerSpy.callCount).toEqual(0)
+
+    describe "a bookmark target", ->
+
+      beforeEach ->
+        jasmine.simulate.click($('input[value=new_bookmark]').get(0))
+
+      it "displays an error", ->
+        @insertLink.validateForm()
+        expect(@insertLink.valid).toEqual(false)
+        expect($('#link_new_bookmark').closest('.control-group').find('.error-message').html()).toEqual("can't be blank")
+
+      it "doesn't submit", ->
+        @insertLink.validateForm()
+        expect(@triggerSpy.callCount).toEqual(0)
+
+
   describe "submitting", ->
 
     describe "a new link", ->
 
       beforeEach ->
-        Mercury.modalHandlers.insertLink.call(@modal)
+        @insertLink.initialize()
         @triggerSpy = spyOn(Mercury, 'trigger').andCallFake(=>)
         $('#link_text').val('foo')
 
+      it "doesn't submit unless it's valid", ->
+        $('#link_text').val('')
+        spy = spyOn(@modal, 'hide')
+        jasmine.simulate.click($('input[type=submit]').get(0))
+        expect(spy.callCount).toEqual(0)
+        expect(@insertLink.valid).toEqual(false)
+
       it "hides the modal", ->
-        spy = spyOn(@modal, 'hide').andCallFake(=>)
-        jasmine.simulate.click($('#submit').get(0))
+        $('#link_external_url').val('http://cnn.com')
+        spy = spyOn(@modal, 'hide')
+        jasmine.simulate.click($('input[type=submit]').get(0))
         expect(spy.callCount).toEqual(1)
 
       describe "as a standard link", ->
@@ -143,7 +215,7 @@ describe "Mercury.modalHandlers.insertLink", ->
           $('#link_target').val('_top')
 
         it "triggers an action with the proper values", ->
-          jasmine.simulate.click($('#submit').get(0))
+          jasmine.simulate.click($('input[type=submit]').get(0))
           expect(@triggerSpy.callCount).toEqual(1)
           expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
           expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertLink')
@@ -158,7 +230,7 @@ describe "Mercury.modalHandlers.insertLink", ->
           $('#link_popup_height').val('42')
 
         it "triggers an action with the proper values", ->
-          jasmine.simulate.click($('#submit').get(0))
+          jasmine.simulate.click($('input[type=submit]').get(0))
           expect(@triggerSpy.callCount).toEqual(1)
           expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
           expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertLink')
@@ -171,7 +243,7 @@ describe "Mercury.modalHandlers.insertLink", ->
           $('input[value=existing_bookmark]').prop('checked', true)
 
         it "triggers an action with the proper values", ->
-          jasmine.simulate.click($('#submit').get(0))
+          jasmine.simulate.click($('input[type=submit]').get(0))
           expect(@triggerSpy.callCount).toEqual(1)
           expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
           expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertLink')
@@ -184,7 +256,7 @@ describe "Mercury.modalHandlers.insertLink", ->
           $('input[value=new_bookmark]').prop('checked', true)
 
         it "triggers an action with the proper values", ->
-          jasmine.simulate.click($('#submit').get(0))
+          jasmine.simulate.click($('input[type=submit]').get(0))
           expect(@triggerSpy.callCount).toEqual(1)
           expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
           expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertLink')
@@ -194,14 +266,16 @@ describe "Mercury.modalHandlers.insertLink", ->
 
       beforeEach ->
         @existingLink = $('<a>', {name: 'link3'}).html('foo')
-        Mercury.region = selection: => {commonAncestor: => @existingLink}
-        Mercury.modalHandlers.insertLink.call(@modal)
+        Mercury.region = selection: => {
+          commonAncestor: => @existingLink
+        }
+        @insertLink.initialize()
         @triggerSpy = spyOn(Mercury, 'trigger').andCallFake(=>)
         $('#link_text').val('foo')
 
       it "hides the modal", ->
         spy = spyOn(@modal, 'hide').andCallFake(=>)
-        jasmine.simulate.click($('#submit').get(0))
+        jasmine.simulate.click($('input[type=submit]').get(0))
         expect(spy.callCount).toEqual(1)
 
       describe "as a standard link", ->
@@ -212,7 +286,7 @@ describe "Mercury.modalHandlers.insertLink", ->
           $('input[value=external_url]').prop('checked', true)
 
         it "triggers an action with the proper values", ->
-          jasmine.simulate.click($('#submit').get(0))
+          jasmine.simulate.click($('input[type=submit]').get(0))
           expect(@triggerSpy.callCount).toEqual(1)
           expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
           expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('replaceLink')

data/spec/javascripts/mercury/modals/insertmedia_spec.js.coffee

@@ -9,35 +9,37 @@ describe "Mercury.modalHandlers.insertMedia", ->
       element: $('#test')
       hide: ->
       resize: ->
+    @insertMedia = $.extend(@modal, Mercury.modalHandlers.insertMedia)
+    window.mercuryInstance = {document: $(document)}
 
   describe "clicking on a radio button (in a label)", ->
 
     beforeEach ->
-      Mercury.modalHandlers.insertMedia.call(@modal)
+      @insertMedia.initialize()
 
     it "focuses the next input with a selectable class", ->
       spy = spyOn($.fn, 'focus').andCallFake(=>)
-      jasmine.simulate.click($('#checkbox1').get(0))
+      jasmine.simulate.click($('input[value=image_url]').get(0))
       expect(spy.callCount).toEqual(1)
 
 
   describe "focusing an input", ->
 
     beforeEach ->
-      Mercury.modalHandlers.insertMedia.call(@modal)
+      @insertMedia.initialize()
 
     it "checks the corresponding checkbox", ->
       $('#media_youtube_url').focus()
-      expect($('#checkbox2').get(0).checked).toEqual(true)
+      expect($('input[value=youtube_url]').get(0).checked).toEqual(true)
 
     it "hides all the option divs", ->
       $('#media_youtube_url').focus()
-      expect($('#image_url').css('display')).toEqual('none')
-      expect($('#vimeo_url').css('display')).toEqual('none')
+      expect($('#image_url_options').css('display')).toEqual('none')
+      expect($('#vimeo_url_options').css('display')).toEqual('none')
 
     it "shows the options for the item that was focused", ->
       $('#media_youtube_url').focus()
-      expect($('#youtube_url').css('display')).toNotEqual('none')
+      expect($('#youtube_url_options').css('display')).toNotEqual('none')
 
     it "calls resize", ->
       spy = spyOn(@modal, 'resize').andCallFake(=>)
@@ -53,13 +55,13 @@ describe "Mercury.modalHandlers.insertMedia", ->
         @focusSpy = spyOn($.fn, 'focus').andCallThrough()
         @selection = {is: -> $('<img>', {src: '/foo.gif', align: 'right'})}
         Mercury.region = selection: => @selection
-        Mercury.modalHandlers.insertMedia.call(@modal)
+        @insertMedia.initialize()
 
       it "pre-fills the image url", ->
         expect($('#media_image_url').val()).toEqual('/foo.gif')
 
       it "focuses the url input", ->
-        expect(@focusSpy.callCount).toEqual(1)
+        expect(@focusSpy.callCount).toEqual(2)
         expect($('input[value=image_url]').get(0).checked).toEqual(true)
 
       it "sets the image alignment option", ->
@@ -69,12 +71,12 @@ describe "Mercury.modalHandlers.insertMedia", ->
 
       beforeEach ->
         @focusSpy = spyOn($.fn, 'focus').andCallThrough()
-        @selection = {is: -> $('<iframe>', {src: 'http://www.youtube.com/embed/foo?wmode=transparent', style: 'width:100px;height:42px'})}
+        @selection = {is: -> $('<iframe>', {src: 'https://www.youtube.com/embed/foo?wmode=transparent', style: 'width:100px;height:42px'})}
         Mercury.region = selection: => @selection
-        Mercury.modalHandlers.insertMedia.call(@modal)
+        @insertMedia.initialize()
 
       it "pre-fills the url", ->
-        expect($('#media_youtube_url').val()).toEqual('http://youtu.be/foo')
+        expect($('#media_youtube_url').val()).toEqual('https://youtu.be/foo')
 
       it "focuses the url input", ->
         expect($('input[value=youtube_url]').get(0).checked).toEqual(true)
@@ -91,7 +93,7 @@ describe "Mercury.modalHandlers.insertMedia", ->
         @focusSpy = spyOn($.fn, 'focus').andCallThrough()
         @selection = {is: -> $('<iframe>', {src: 'http://player.vimeo.com/video/foo?title=1&byline=1&portrait=0&color=ffffff', style: 'width:100px;height:42px'})}
         Mercury.region = selection: => @selection
-        Mercury.modalHandlers.insertMedia.call(@modal)
+        @insertMedia.initialize()
 
       it "pre-fills the url", ->
         expect($('#media_vimeo_url').val()).toEqual('http://vimeo.com/foo')
@@ -106,15 +108,67 @@ describe "Mercury.modalHandlers.insertMedia", ->
         expect($('#media_vimeo_height').val()).toEqual('42')
 
 
+  describe "validating", ->
+
+    beforeEach ->
+      @insertMedia.initialize()
+      @triggerSpy = spyOn(Mercury, 'trigger').andCallFake(=>)
+
+    describe "an image", ->
+
+      it "displays an error", ->
+        @insertMedia.validateForm()
+        expect(@insertMedia.valid).toEqual(false)
+        expect($('#media_image_url').closest('.control-group').find('.error-message').html()).toEqual("can't be blank")
+
+      it "doesn't submit", ->
+        @insertMedia.validateForm()
+        expect(@triggerSpy.callCount).toEqual(0)
+
+    describe "a youtube video", ->
+
+      beforeEach ->
+        $('input[value=youtube_url]').prop('checked', true)
+
+      it "displays an error", ->
+        @insertMedia.validateForm()
+        expect(@insertMedia.valid).toEqual(false)
+        expect($('#media_youtube_url').closest('.control-group').find('.error-message').html()).toEqual("is invalid")
+
+      it "doesn't submit", ->
+        @insertMedia.validateForm()
+        expect(@triggerSpy.callCount).toEqual(0)
+
+    describe "a vimeo video", ->
+      beforeEach ->
+        $('input[value=vimeo_url]').prop('checked', true)
+
+      it "displays an error", ->
+        @insertMedia.validateForm()
+        expect(@insertMedia.valid).toEqual(false)
+        expect($('#media_vimeo_url').closest('.control-group').find('.error-message').html()).toEqual("is invalid")
+
+      it "doesn't submit", ->
+        @insertMedia.validateForm()
+        expect(@triggerSpy.callCount).toEqual(0)
+
+
   describe "submitting", ->
 
     beforeEach ->
-      Mercury.modalHandlers.insertMedia.call(@modal)
+      @insertMedia.initialize()
       @triggerSpy = spyOn(Mercury, 'trigger').andCallFake(=>)
 
+    it "doesn't submit unless it's valid", ->
+      spy = spyOn(@modal, 'hide')
+      jasmine.simulate.click($('input[type=submit]').get(0))
+      expect(spy.callCount).toEqual(0)
+      expect(@insertMedia.valid).toEqual(false)
+
     it "hides the modal", ->
-      spy = spyOn(@modal, 'hide').andCallFake(=>)
-      jasmine.simulate.click($('#submit').get(0))
+      $('#media_image_url').val('foo.gif')
+      spy = spyOn(@modal, 'hide')
+      jasmine.simulate.click($('input[type=submit]').get(0))
       expect(spy.callCount).toEqual(1)
 
     describe "an image", ->
@@ -124,7 +178,7 @@ describe "Mercury.modalHandlers.insertMedia", ->
         $('#media_image_alignment').val('right')
 
       it "triggers an action with the proper values", ->
-        jasmine.simulate.click($('#submit').get(0))
+        jasmine.simulate.click($('input[type=submit]').get(0))
         expect(@triggerSpy.callCount).toEqual(1)
         expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
         expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertImage')
@@ -133,21 +187,14 @@ describe "Mercury.modalHandlers.insertMedia", ->
     describe "a youtube video", ->
 
       beforeEach ->
+        $('#media_youtube_url').val('http://youtu.be/foo')
         $('#media_youtube_width').val(100)
         $('#media_youtube_height').val('42')
         $('input[value=youtube_url]').prop('checked', true)
 
-      it "doesn't allow bogus urls", ->
-        $('#media_youtube_url').val('http://example.com')
-        lastAlert = ''
-        spy = spyOn(window, 'alert').andCallFake((msg) -> lastAlert = msg)
-        jasmine.simulate.click($('#submit').get(0))
-        expect(spy.callCount).toEqual(1)
-        expect(lastAlert).toEqual('Error: The provided youtube share url was invalid.')
-
       it "triggers an action with the proper values", ->
         $('#media_youtube_url').val('http://youtu.be/foo')
-        jasmine.simulate.click($('#submit').get(0))
+        jasmine.simulate.click($('input[type=submit]').get(0))
         expect(@triggerSpy.callCount).toEqual(1)
         expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
         expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertHTML')
@@ -158,7 +205,7 @@ describe "Mercury.modalHandlers.insertMedia", ->
 
       it "triggers an action with the proper values using https", ->
         $('#media_youtube_url').val('https://youtu.be/foo')
-        jasmine.simulate.click($('#submit').get(0))
+        jasmine.simulate.click($('input[type=submit]').get(0))
         expect(@triggerSpy.callCount).toEqual(1)
         expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
         expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertHTML')
@@ -170,22 +217,13 @@ describe "Mercury.modalHandlers.insertMedia", ->
     describe "a vimeo video", ->
 
       beforeEach ->
-        $('#media_vimeo_url').val('http://vimeo.com/foo')
         $('#media_vimeo_width').val(100)
         $('#media_vimeo_height').val('42')
         $('input[value=vimeo_url]').prop('checked', true)
 
-      it "doesn't allow bogus urls", ->
-        $('#media_vimeo_url').val('http://example.com')
-        lastAlert = ''
-        spy = spyOn(window, 'alert').andCallFake((msg) -> lastAlert = msg)
-        jasmine.simulate.click($('#submit').get(0))
-        expect(spy.callCount).toEqual(1)
-        expect(lastAlert).toEqual('Error: The provided vimeo url was invalid.')
-
       it "triggers an action with the proper values", ->
         $('#media_vimeo_url').val('http://vimeo.com/foo')
-        jasmine.simulate.click($('#submit').get(0))
+        jasmine.simulate.click($('input[type=submit]').get(0))
         expect(@triggerSpy.callCount).toEqual(1)
         expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
         expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertHTML')
@@ -196,7 +234,7 @@ describe "Mercury.modalHandlers.insertMedia", ->
 
       it "triggers an action with the proper values using https", ->
         $('#media_vimeo_url').val('https://vimeo.com/foo')
-        jasmine.simulate.click($('#submit').get(0))
+        jasmine.simulate.click($('input[type=submit]').get(0))
         expect(@triggerSpy.callCount).toEqual(1)
         expect(@triggerSpy.argsForCall[0][0]).toEqual('action')
         expect(@triggerSpy.argsForCall[0][1]['action']).toEqual('insertHTML')