merb-core 1.0.15 → 1.1.0.pre

data/spec10/public/controller/base_spec.rb

@@ -0,0 +1,96 @@
+require File.join(File.dirname(__FILE__), "spec_helper")
+
+Controllers = Merb::Test::Fixtures::Controllers
+
+describe Merb::Controller, "callable actions" do
+  
+  before do
+    Merb.push_path(:layout, File.dirname(__FILE__) / "controllers" / "views" / "layouts")    
+    Merb::Router.prepare do |r|
+      r.default_routes
+    end
+  end
+  
+  it "has no any callable actions by default" do
+    Merb::Controller.callable_actions.should be_empty
+  end
+  
+  it "sets body on dispatch to callable action" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::Base, :index)
+    controller.body.should == "index"
+  end
+
+  it "sets status on dispatch to callable action" do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::Base, :index)
+    controller.status.should == 200
+  end
+
+  it "should not dispatch to hidden actions" do
+    calling { dispatch_to(Merb::Test::Fixtures::Controllers::Base, :hidden) }.
+      should raise_error(Merb::ControllerExceptions::ActionNotFound)
+  end
+  
+  it "should dispatch to included methods with show_action called" do
+    dispatch_to(Merb::Test::Fixtures::Controllers::Base, :baz).body.should == "baz"
+  end
+
+  it "should not dispatch to included methods with show_action not called" do
+    calling { dispatch_to(Merb::Test::Fixtures::Controllers::Base, :bat) }.
+      should raise_error(Merb::ControllerExceptions::ActionNotFound)
+  end
+ 
+end
+
+describe Merb::Controller, "filtered params" do  
+  it "removes filtered parameters from the log" do
+    out = with_level(:info) do
+      dispatch_to(Controllers::FilteredParams, :index, :username => "Awesome", :password => "sekrit")
+    end
+    out.should include_log(/Params:.*"username"\s*=>\s*"Awesome"/)
+    out.should_not include_log(/"password"/)
+  end
+  
+  it "doesn't put the parameters in the log in levels higher than info" do
+    out = with_level(:warn) do
+      dispatch_to(Controllers::FilteredParams, :index, :username => "Awesome", :password => "sekrit")
+    end
+    out.should_not include_log(/Params/)
+  end
+end
+
+describe Merb::Controller, "records benchmarks" do
+  it "collects benchmarks for the amount of time the action took" do
+    controller = dispatch_to(Controllers::Base, :index)
+    controller._benchmarks[:action_time].should be_kind_of(Numeric)
+  end
+end
+
+describe Merb::Controller, "handles invalid actions" do
+  it "raises if an action was not found" do
+    calling { controller = dispatch_to(Controllers::Base, :awesome) }.
+      should raise_error(Merb::ControllerExceptions::ActionNotFound,
+      /Action.*awesome.*was not found in.*Base/)
+  end
+end
+
+describe Merb::Controller, "handles invalid status codes" do
+  it "raises if an invalid status is set" do
+    calling { dispatch_to(Controllers::SetStatus, :index) }.
+      should raise_error(ArgumentError, /was.*String/)
+  end
+end
+
+describe Merb::Controller, "before/after dispatch callbacks" do
+  it "are used for internal purposes" do
+    controller = dispatch_to(Controllers::DispatchCallbacks, :index)
+    controller.called_before.should be_true
+    controller.called_after.should be_true
+  end
+
+  it 'has access to action name' do
+    controller = dispatch_to(Controllers::DispatchCallbacks, :index)
+    controller.called_before.should be_true
+    controller.called_after.should be_true
+    controller.observed_action.should == 'index'
+  end
+end

data/spec10/public/controller/conditional_get_spec.rb

@@ -0,0 +1,101 @@
+require File.join(File.dirname(__FILE__), "spec_helper")
+
+Controllers = Merb::Test::Fixtures::Controllers
+
+describe Merb::Controller, "#etag=" do
+  
+  before do
+    Merb.push_path(:layout, File.dirname(__FILE__) / "controllers" / "views" / "layouts")    
+    Merb::Router.prepare do |r|
+      r.default_routes
+    end
+  end
+
+  it 'sets ETag header' do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet, :sets_etag)
+    controller.headers['ETag'].should == '"39791e6fb09"'
+  end
+end
+
+
+
+describe Merb::Controller, "#last_modified=" do
+  before do
+    Merb.push_path(:layout, File.dirname(__FILE__) / "controllers" / "views" / "layouts")    
+    Merb::Router.prepare do |r|
+      r.default_routes
+    end
+  end
+
+  it 'sets Last-Modified header' do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet, :sets_last_modified)
+    controller.headers['Last-Modified'].should == Time.at(7000).httpdate
+  end
+end
+
+
+describe Merb::Controller, "#etag_matches?" do
+  it 'returns true when response ETag header equals to request If-None-Match header' do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet, :sets_etag, {}, { Merb::Const::HTTP_IF_NONE_MATCH => '"39791e6fb09"' } )
+    controller.etag_matches?('"39791e6fb09"').should be(true)
+  end
+
+  it 'returns false when response ETag header DOES NOT equal to request If-None-Match header' do
+    controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet, :sets_etag, {}, { Merb::Const::HTTP_IF_NONE_MATCH => '"6fb91e09793"' } )
+    controller.etag_matches?('"55789a6fb09"').should be(false)
+  end
+end
+
+
+
+describe Merb::Controller, "#modified_since?" do
+  before(:each) do
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet,
+                              :sets_last_modified, {}, { Merb::Const::HTTP_IF_MODIFIED_SINCE => Time.at(7000).httpdate })
+  end
+  
+  it 'return true when response Last-Modified header value <= request If-Modified-Since header' do
+    @controller.not_modified?(Time.at(5000)).should be(true)
+    @controller.not_modified?(Time.at(6999)).should be(true)
+  end
+
+  it 'return false when response Last-Modified header value > request If-Modified-Since header' do
+    @controller.not_modified?(Time.at(7003)).should be(false)
+    @controller.not_modified?(Time.at(16999)).should be(false)
+  end
+end
+
+
+describe Merb::Controller, "#request_fresh?" do
+  it 'return true when ETag matches' do
+    env = { 'HTTP_IF_MODIFIED_SINCE' => Time.at(8000).httpdate, Merb::Const::HTTP_IF_NONE_MATCH => '"39791e6fb09"' }
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet,
+                              :sets_etag, {}, env)
+
+    @controller.request_fresh?.should be(true)
+  end
+
+  it 'return true when entity is not modified since date given in request header' do
+    env = { Merb::Const::HTTP_IF_MODIFIED_SINCE => Time.at(7000).httpdate }
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet,
+                              :sets_last_modified, {}, env)
+    
+    @controller.request_fresh?.should be(true)
+  end
+
+  it 'return true when both etag and last modification date satisfy request freshness' do
+    env = { 'HTTP_IF_MODIFIED_SINCE' => Time.at(7000).httpdate, Merb::Const::HTTP_IF_NONE_MATCH => '"39791e6fb09"' }    
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet,
+                              :superfresh, {}, env)
+    
+    @controller.request_fresh?.should be(true)
+  end
+
+  it 'return false when neither etag nor last modification date satisfy request freshness' do
+    env = { 'HTTP_IF_MODIFIED_SINCE' => Time.at(7000).httpdate, Merb::Const::HTTP_IF_NONE_MATCH => '"39791e6fb09"' }    
+    @controller = dispatch_to(Merb::Test::Fixtures::Controllers::ConditionalGet,
+                              :stale, {}, env)
+    
+    @controller.request_fresh?.should be(false)
+  end  
+end

data/spec10/public/controller/config/init.rb

@@ -0,0 +1,6 @@
+Merb::Config.use do |c|
+  c[:default_cookie_domain] = "specs.merbivore.com"
+  c[:session_id_key]        = "some_meaningless_id_key"
+  c[:session_secret_key]    = "some_super_hyper_secret_key"
+  c[:session_expiry]        = Merb::Const::WEEK * 4
+end

data/spec10/public/controller/controllers/authentication.rb

@@ -0,0 +1,74 @@
+module Merb::Test::Fixtures::Controllers
+
+  class Testing < Merb::Controller
+    self._template_root = File.dirname(__FILE__) / "views"
+  end
+
+  class BasicAuthentication < Testing
+    before :authenticate, :only => :index
+
+    def index
+      "authenticated"
+    end
+
+    protected
+
+    def authenticate
+      basic_authentication { |u, p| u == "Fred" && p == "secret" }
+    end
+  end
+
+  class BasicAuthenticationWithRealm < BasicAuthentication
+    def authenticate
+      basic_authentication("My Super App") { |u, p| u == "Fred" && p == "secret" }
+    end
+  end
+
+  class AuthenticateBasicAuthentication < Testing
+    def index
+      basic_authentication.authenticate { |u, p| "Fred:secret" }
+    end
+  end
+
+  class RequestBasicAuthentication < BasicAuthentication
+    def authenticate
+      basic_authentication.request
+    end
+  end
+
+  class RequestBasicAuthenticationWithRealm < BasicAuthentication
+    def authenticate
+      basic_authentication("My SuperApp").request
+    end
+  end
+  
+  class PassiveBasicAuthentication < BasicAuthentication
+        
+    def index
+      "My Output"
+    end
+    
+    def authenticate
+      basic_authentication.request!
+    end
+  end
+  
+  class PassiveBasicAuthenticationWithRealm < BasicAuthentication
+    def authenticate
+      basic_authentication("My Super App").request!
+    end
+  end
+  
+  class PassiveBasicAuthenticationInAction < BasicAuthentication
+    
+    def index
+      basic_authentication.request!
+      "In Action"
+    end
+    
+    def authenticate
+      true
+    end
+  end
+
+end

data/spec10/public/controller/controllers/base.rb

@@ -0,0 +1,71 @@
+module Merb::Test::Fixtures
+  module Controllers
+    class Testing < Merb::Controller
+      self._template_root = File.dirname(__FILE__) / "views"
+    end
+
+    module Inclusion
+      def self.included(base)
+        base.show_action(:baz)
+      end
+
+      def baz
+        "baz"
+      end
+
+      def bat
+        "bat"
+      end
+    end
+
+    class Base < Testing
+      include Inclusion
+
+      def index
+        self.status = :ok
+        "index"
+      end
+
+      def hidden
+        "Bar"
+      end
+      hide_action :hidden
+    end
+    
+    class FilteredParams < Testing
+      def index
+        "Index"
+      end
+      
+      def self._filter_params(params)
+        params.reject {|k,v| k == "password" }
+      end
+    end
+
+    class SetStatus < Testing
+      def index
+        self.status = "awesome"
+      end
+    end
+
+    class DispatchCallbacks < Testing
+
+      attr_accessor :called_before, :called_after, :observed_action
+
+      self._before_dispatch_callbacks << lambda do |c|
+        c.called_before = true
+        c.observed_action = c.action_name
+      end
+
+      self._after_dispatch_callbacks  << lambda do |c|
+         c.called_after  = true
+      end
+
+      def index
+        "index"
+      end
+
+    end
+
+  end
+end

data/spec10/public/controller/controllers/conditional_get.rb

@@ -0,0 +1,35 @@
+require "time"
+
+module Merb::Test::Fixtures
+  module Controllers
+    class Testing < Merb::Controller
+      self._template_root = File.dirname(__FILE__) / "views"
+    end
+
+    class ConditionalGet < Testing
+      def sets_etag
+        self.etag = "39791e6fb09"
+        "can has etag"
+      end
+
+      def sets_last_modified
+        self.last_modified = Time.at(7000)
+        "can has last-modified"
+      end
+
+      def superfresh
+        self.etag          = "39791e6fb09"
+        self.last_modified = Time.at(7000)
+        
+        "can has fresh request"
+      end
+
+      def stale
+        self.etag          = "1234567678"
+        self.last_modified = Time.at(9000)
+        
+        "can has stale request"
+      end
+    end
+  end
+end

data/spec10/public/controller/controllers/cookies.rb

@@ -0,0 +1,36 @@
+module Merb::Test::Fixtures::Controllers
+
+  class Testing < Merb::Controller
+    self._template_root = File.dirname(__FILE__) / "views"
+  end
+
+  class CookiesController < Testing
+    
+    def store_cookies
+      cookies.set_cookie(:awesome,   'super-cookie', :domain  => 'blog.merbivore.com')
+      cookies[:foo] = 'bar'
+      cookies.set_cookie(:oldcookie, 'this is really old', :expires => Time.utc(2020))
+      cookies.set_cookie(:safecook,  'no-hackers-here', :secure => true)
+    end
+    
+    def destroy_cookies
+      cookies.delete(:foo)
+    end
+    
+    def retrieve_cookies
+    end
+    
+  end
+  
+  class OverridingDefaultCookieDomain < CookiesController
+    self._default_cookie_domain = "overridden.merbivore.com"
+  end
+
+  class NotOverridingDefaultCookieDomain < CookiesController
+  end
+  
+  class EmptyDefaultCookieDomain < CookiesController
+    self._default_cookie_domain = ''
+  end
+  
+end

data/spec10/public/controller/controllers/dispatcher.rb

@@ -0,0 +1,35 @@
+class Application < Merb::Controller
+end
+
+module Merb::Test::Fixtures
+  module Controllers
+    class Testing < Merb::Controller
+      self._template_root = File.dirname(__FILE__) / "views"
+    end
+
+    class DispatchTo < Testing
+      def index
+        "Dispatched"
+      end
+    end
+    
+    class NotAController
+      def index
+        "Dispatched"
+      end
+    end
+    
+    class RaiseGone < Testing
+      def index
+        raise Gone
+      end
+    end
+
+    class RaiseLoadError < Merb::Controller
+      def index
+        raise LoadError, "In the controller"
+      end
+    end
+
+  end
+end

data/spec10/public/controller/controllers/display.rb

@@ -0,0 +1,118 @@
+module Merb::Test::Fixtures::Controllers
+  class SomeModel
+    def to_xml; "<XML:Model />" end
+    def to_json(options = {})
+      includes = options[:include].join(', ') rescue ""
+      excludes = options[:except].first rescue ""
+      "{ 'include': '#{includes}', 'exclude': '#{excludes}' }"
+    end
+    def to_param
+      "1"
+    end
+  end
+
+
+  class Testing < Merb::Controller
+    self._template_root = File.dirname(__FILE__) / "views"
+  end
+
+
+  class Display < Testing
+    def index
+      @obj = SomeModel.new
+      display @obj
+    end    
+  end
+
+  class DisplayWithLayout < Testing
+    provides :json
+    
+    def index
+      @obj = SomeModel.new
+      display @obj, :layout => :custom_arg
+    end    
+  end
+
+  class DisplayHtmlDefault < Display; end
+
+  class DisplayClassProvides < Display
+    provides :xml
+  end
+
+
+  class DisplayLocalProvides < Display
+    def index
+      @obj = SomeModel.new
+      provides :xml
+      display @obj
+    end
+  end
+
+
+  class DisplayWithTemplate < Display
+    layout :custom
+
+    def no_layout
+      render :layout => false
+    end
+    
+    def absolute_without_mime
+      render :template => File.expand_path(self._template_root) / "merb/test/fixtures/controllers/html_default/index"
+    end
+    
+    def absolute_with_mime
+      render :template => File.expand_path(self._template_root) / "merb/test/fixtures/controllers/html_default/index.html"
+    end
+    
+    def relative_without_mime
+      render :template => "merb/test/fixtures/controllers/html_default/index"
+    end
+    
+    def relative_with_mime
+      render :template => "merb/test/fixtures/controllers/html_default/index.html"
+    end
+    
+  end
+  
+  class DisplayWithTemplateArgument < Display
+    def index
+      @obj = SomeModel.new
+      display @obj, :layout => :custom_arg
+    end
+
+    def index_by_arg
+      @obj = SomeModel.new
+      display @obj, "merb/test/fixtures/controllers/display_with_template_argument/index.html"
+    end
+  end
+
+  class DisplayWithStringLocation < Display
+    provides :json
+    def index
+      @obj = SomeModel.new
+      display @obj, :location => "/some_resources/#{@obj.to_param}"
+    end
+  end
+
+  class DisplayWithStatus < Display
+    provides :json
+    def index
+      @obj = SomeModel.new
+      display @obj, :status => 500
+    end
+  end
+
+  class DisplayWithSerializationOptions < Display
+    provides :json
+
+    def index
+      @obj = SomeModel.new
+      display @obj, :include => [:beer, :jazz], :except => [:idiots]
+    end
+
+    def index_that_passes_empty_hash
+      @obj = SomeModel.new
+      display @obj, {}
+    end
+  end
+end

data/spec10/public/controller/controllers/redirect.rb

@@ -0,0 +1,36 @@
+module Merb::Test::Fixtures::Controllers
+  class Testing < Merb::Controller
+    self._template_root = File.dirname(__FILE__) / "views"
+  end
+
+  class SimpleRedirect < Testing
+    def index
+      redirect("/")
+    end
+  end
+
+  class PermanentRedirect < Testing
+    def index
+      redirect("/", :permanent => true)
+    end
+  end
+
+  class RedirectWithMessage < Testing
+    def index
+      redirect("/", :message => { :notice => "what?" })
+    end
+  end
+  
+  class ConsumesMessage < Testing
+    def index
+      message[:notice].inspect
+    end
+  end
+  
+  class SetsMessage < Testing
+    def index
+      message[:notice] = "Hello"
+      message[:notice]
+    end
+  end
+end

data/spec10/public/controller/controllers/responder.rb

@@ -0,0 +1,93 @@
+module Merb::Test::Fixtures::Controllers
+  class Testing < Merb::Controller
+    self._template_root = File.dirname(__FILE__) / "views"
+  end
+
+
+  class Responder < Testing
+    def index
+      render
+    end
+  end
+
+
+  class HtmlDefault < Responder; end
+
+
+  class ClassProvides < Responder
+    provides :xml
+  end
+
+
+  class LocalProvides < Responder
+    def index
+      provides :xml
+      render
+    end
+  end
+
+
+  class MultiProvides < Responder
+    def index
+      provides :html, :js
+      render
+    end
+  end
+
+  class ClassAndLocalProvides < Responder
+    provides :html    
+    def index
+      provides :xml
+      render
+    end
+  end
+
+  class ClassOnlyProvides < Responder
+    only_provides :text, :xml
+
+    def index
+      "nothing"
+    end
+  end
+
+
+  class OnlyProvides < Responder
+    def index
+      only_provides :text, :xml
+      "nothing"
+    end
+  end
+
+  class ClassDoesntProvides < Responder
+    provides :xml
+    does_not_provide :html
+
+    def index
+      "nothing"
+    end
+  end
+
+
+  class DoesntProvide < Responder
+    def index
+      provides :xml
+      does_not_provide :html
+      "nothing"
+    end
+  end
+
+
+  class FooFormatProvides < Responder
+    only_provides :foo
+
+    def index
+      render "nothing"
+    end
+
+    def show
+      headers["Content-Language"] = 'nl'
+      headers["Biz"] = "buzz"
+      render "nothing"
+    end
+  end
+end