merb-core 0.9.3 → 0.9.4

data/spec/public/controller/controllers/display.rb

@@ -1,7 +1,4 @@
-
-
 module Merb::Test::Fixtures::Controllers
-  
   class SomeModel
     def to_xml; "<XML:Model />" end
     def to_json(options = {})
@@ -9,18 +6,31 @@ module Merb::Test::Fixtures::Controllers
       excludes = options[:except].first rescue ""
       "{ 'include': '#{includes}', 'exclude': '#{excludes}' }"
     end
+    def to_param
+      "1"
+    end
   end
-  
+
+
   class Testing < Merb::Controller
     self._template_root = File.dirname(__FILE__) / "views"
   end
-  
+
+
   class Display < Testing
-    
     def index
       @obj = SomeModel.new
       display @obj
-    end
+    end    
+  end
+
+  class DisplayWithLayout < Testing
+    provides :json
+    
+    def index
+      @obj = SomeModel.new
+      display @obj, :layout => :custom_arg
+    end    
   end
 
   class DisplayHtmlDefault < Display; end
@@ -29,17 +39,39 @@ module Merb::Test::Fixtures::Controllers
     provides :xml
   end
 
+
   class DisplayLocalProvides < Display
-    
     def index
       @obj = SomeModel.new
       provides :xml
       display @obj
     end
   end
-  
+
+
   class DisplayWithTemplate < Display
     layout :custom
+
+    def no_layout
+      render :layout => false
+    end
+    
+    def absolute_without_mime
+      render :template => File.expand_path(self._template_root) / "merb/test/fixtures/controllers/html_default/index"
+    end
+    
+    def absolute_with_mime
+      render :template => File.expand_path(self._template_root) / "merb/test/fixtures/controllers/html_default/index.html"
+    end
+    
+    def relative_without_mime
+      render :template => "merb/test/fixtures/controllers/html_default/index"
+    end
+    
+    def relative_with_mime
+      render :template => "merb/test/fixtures/controllers/html_default/index.html"
+    end
+    
   end
   
   class DisplayWithTemplateArgument < Display
@@ -47,24 +79,40 @@ module Merb::Test::Fixtures::Controllers
       @obj = SomeModel.new
       display @obj, :layout => :custom_arg
     end
-    
+
     def index_by_arg
       @obj = SomeModel.new
       display @obj, "merb/test/fixtures/controllers/display_with_template_argument/index.html"
     end
   end
-  
+
+  class DisplayWithStringLocation < Display
+    provides :json
+    def index
+      @obj = SomeModel.new
+      display @obj, :location => "/some_resources/#{@obj.to_param}"
+    end
+  end
+
+  class DisplayWithStatus < Display
+    provides :json
+    def index
+      @obj = SomeModel.new
+      display @obj, :status => 500
+    end
+  end
+
   class DisplayWithSerializationOptions < Display
     provides :json
-    
+
     def index
       @obj = SomeModel.new
       display @obj, :include => [:beer, :jazz], :except => [:idiots]
     end
-    
+
     def index_that_passes_empty_hash
       @obj = SomeModel.new
       display @obj, {}
     end
   end
-end
+end

data/spec/public/controller/controllers/redirect.rb

@@ -0,0 +1,36 @@
+module Merb::Test::Fixtures::Controllers
+  class Testing < Merb::Controller
+    self._template_root = File.dirname(__FILE__) / "views"
+  end
+
+  class SimpleRedirect < Testing
+    def index
+      redirect("/")
+    end
+  end
+
+  class PermanentRedirect < Testing
+    def index
+      redirect("/", :permanent => true)
+    end
+  end
+
+  class RedirectWithMessage < Testing
+    def index
+      redirect("/", :message => { :notice => "what?" })
+    end
+  end
+  
+  class ConsumesMessage < Testing
+    def index
+      message[:notice].inspect
+    end
+  end
+  
+  class SetsMessage < Testing
+    def index
+      message[:notice] = "Hello"
+      message[:notice]
+    end
+  end
+end

data/spec/public/controller/controllers/responder.rb

@@ -1,24 +1,24 @@
-
-
 module Merb::Test::Fixtures::Controllers
-
   class Testing < Merb::Controller
     self._template_root = File.dirname(__FILE__) / "views"
   end
 
+
   class Responder < Testing
-    
     def index
       render
     end
   end
 
+
   class HtmlDefault < Responder; end
 
+
   class ClassProvides < Responder
     provides :xml
   end
 
+
   class LocalProvides < Responder
     def index
       provides :xml
@@ -26,37 +26,48 @@ module Merb::Test::Fixtures::Controllers
     end
   end
 
+
   class MultiProvides < Responder
     def index
       provides :html, :js
       render
     end
   end
-  
+
+  class ClassAndLocalProvides < Responder
+    provides :html    
+    def index
+      provides :xml
+      render
+    end
+  end
+
   class ClassOnlyProvides < Responder
     only_provides :text, :xml
-    
+
     def index
       "nothing"
     end
   end
-  
+
+
   class OnlyProvides < Responder
     def index
       only_provides :text, :xml
       "nothing"
     end
   end
-    
+
   class ClassDoesntProvides < Responder
     provides :xml
     does_not_provide :html
-    
+
     def index
       "nothing"
     end
   end
-  
+
+
   class DoesntProvide < Responder
     def index
       provides :xml
@@ -64,4 +75,19 @@ module Merb::Test::Fixtures::Controllers
       "nothing"
     end
   end
-end
+
+
+  class FooFormatProvides < Responder
+    only_provides :foo
+
+    def index
+      render "nothing"
+    end
+
+    def show
+      headers["Content-Language"] = 'nl'
+      headers["Biz"] = "buzz"
+      render "nothing"
+    end
+  end
+end

data/spec/public/controller/controllers/views/layout/custom_arg.json.erb

@@ -0,0 +1 @@
+{custom_arg: <%= catch_content(:for_layout) %>}

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/class_and_local_provides/index.html.erb

@@ -0,0 +1 @@
+HTML: Class and Local

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/class_and_local_provides/index.xml.erb

@@ -0,0 +1 @@
+<XML:ClassAndLocalProvides provides='true' />

data/spec/public/controller/controllers/views/merb/test/fixtures/controllers/display_with_template/no_layout.html.erb

@@ -0,0 +1 @@
+No layoutz eva!

data/spec/public/controller/cookies_spec.rb

@@ -0,0 +1,23 @@
+require File.join(File.dirname(__FILE__), "spec_helper")
+
+describe Merb::Controller, "._session_cookie_domain" do
+  before(:each) do
+    Merb::Config[:session_cookie_domain].should_not be(nil)
+  end
+  
+  it 'is set to Merb::Config[:session_cookie_domain] by default' do
+    Merb::Controller._session_cookie_domain.should == Merb::Config[:session_cookie_domain]
+    Merb::Test::Fixtures::Controllers::CookiesController._session_cookie_domain.should ==
+      Merb::Config[:session_cookie_domain]
+  end
+
+  it "can be overridden for particular controller" do
+    Merb::Test::Fixtures::Controllers::OverridingSessionCookieDomain._session_cookie_domain.should ==
+      "overridden.merbivore.com"
+  end
+
+  it 'is inherited by subclasses unless overriden' do
+    Merb::Test::Fixtures::Controllers::NotOverridingSessionCookieDomain._session_cookie_domain.should ==
+      Merb::Config[:session_cookie_domain]
+  end
+end

data/spec/public/controller/dispatcher_spec.rb

@@ -0,0 +1,411 @@
+require File.join(File.dirname(__FILE__), "spec_helper")
+require File.join(File.dirname(__FILE__), "controllers", "dispatcher")
+
+include Merb::Test::Fixtures::Controllers
+
+describe Merb::Dispatcher do
+  include Merb::Test::Rspec::ControllerMatchers
+  include Merb::Test::Rspec::ViewMatchers
+  
+  def with_level(level)
+    Merb.logger = Merb::Logger.new(StringIO.new, level)
+    yield
+    Merb.logger
+  end
+
+  def dispatch(url)
+    Merb::Dispatcher.handle(request_for(url))
+  end
+
+  def request_for(url)
+    Merb::Request.new(Rack::MockRequest.env_for(url))
+  end
+
+  before(:each) do
+    Merb::Config[:exception_details] = true
+  end
+
+  describe "with a regular route, " do
+    before(:each) do
+      Merb::Router.prepare do |r|
+        r.default_routes
+      end
+      @url = "/dispatch_to/index"
+    end
+  
+    it "dispatches to the right controller and action" do
+      controller = dispatch(@url)
+      controller.body.should == "Dispatched"
+    end
+    
+    it "sets the Request#params to include the route params" do
+      controller = dispatch(@url)
+      controller.request.params.should == 
+        {"controller" => "dispatch_to", "action" => "index", 
+         "id" => nil, "format" => nil}
+    end
+    
+    it "provides the time for start of request handling via Logger#info" do
+      with_level(:info) do
+        dispatch(@url)
+      end.should include_log("Started request handling")
+      
+      with_level(:warn) do
+        dispatch(@url)
+      end.should_not include_log("Started request handling")
+    end
+    
+    it "provides the routed params via Logger#debug" do
+      with_level(:debug) do
+        dispatch(@url)
+      end.should include_log("Routed to:")
+      
+      with_level(:info) do
+        dispatch(@url)
+      end.should_not include_log("Routed to:")
+    end
+    
+    it "provides the benchmarks via Logger#info" do
+      with_level(:info) do
+        dispatch(@url)
+      end.should include_log(":after_filters_time")
+      
+      with_level(:warn) do
+        dispatch(@url)
+      end.should_not include_log(":after_filters_time")
+    end
+  end
+  
+  describe "with a route that redirects" do
+    before(:each) do
+      Merb::Router.prepare do |r|
+        r.match("/redirect/to/foo").redirect("/foo")
+        r.default_routes
+      end
+      @url = "/redirect/to/foo"
+      @controller = dispatch(@url)
+    end
+    
+    it "redirects" do
+      @controller.body.should =~ %r{You are being <a href="/foo">redirected}
+    end
+    
+    it "reports that it is redirecting via Logger#info" do
+      with_level(:info) do
+        dispatch(@url)
+      end.should include_log("Dispatcher redirecting to: /foo")
+      
+      with_level(:warn) do
+        dispatch(@url)
+      end.should_not include_log("Dispatcher redirecting to: /foo")
+    end
+    
+    it "sets the status correctly" do
+      @controller.status.should == 301
+    end
+    
+    it "sets the location correctly" do
+      @controller.headers["Location"].should == "/foo"
+    end
+  end
+  
+  describe "with a route that points to a class that is not a Controller, " do
+    before(:each) do
+      Merb::Router.prepare do |r|
+        r.default_routes
+      end
+      @url = "/not_a_controller/index"
+      @controller = dispatch(@url)
+    end
+    
+    describe "with exception details showing" do
+      it "raises a NotFound" do
+        @controller.should be_error(Merb::ControllerExceptions::NotFound)
+      end
+    
+      it "returns a 404 status" do
+        @controller.status.should == 404
+      end
+      
+      it "returns useful info in the body" do
+        @controller.body.should =~
+          %r{<h2>Controller 'Merb::Test::Fixtures::Controllers::NotAController' not found.</h2>}
+      end
+    end
+    
+    describe "when the action raises an Exception" do
+      before(:each) do
+        Object.class_eval <<-RUBY
+          class Exceptions < Application
+            def gone
+              "Gone"
+            end
+          end
+        RUBY
+      end
+      
+      after(:each) do
+        Object.send(:remove_const, :Exceptions)
+      end
+      
+      before(:each) do
+        Merb::Router.prepare do |r|
+          r.default_routes
+        end
+        @url = "/raise_gone/index"
+        @controller = dispatch(@url)
+      end
+      
+      it "remembers that the Exception is Gone" do
+        @controller.should be_error(Merb::ControllerExceptions::Gone)
+      end
+      
+      it "renders the action Exception#gone" do
+        @controller.body.should == "Gone"
+      end
+      
+      it "returns the status 410" do
+        @controller.status.should == 410
+      end
+    end
+    
+    describe "when the action raises an Exception that has a superclass Exception available" do
+      before(:each) do
+        Object.class_eval <<-RUBY
+          class Exceptions < Application
+            def client_error
+              "ClientError"
+            end
+          end
+        RUBY
+      end
+      
+      after(:each) do
+        Object.send(:remove_const, :Exceptions)
+      end
+      
+      before(:each) do
+        Merb::Router.prepare do |r|
+          r.default_routes
+        end
+        @url = "/raise_gone/index"
+        @controller = dispatch(@url)
+      end
+      
+      it "renders the Exception from the Exceptions controller" do
+        @controller.should be_error(Merb::ControllerExceptions::Gone)
+      end
+      
+      it "renders the action Exceptions#client_error since #gone is not defined" do
+        @controller.body.should == "ClientError"
+      end
+      
+      it "returns the status 410 (Gone) even though we rendered #client_error" do
+        @controller.status.should == 410
+      end
+    end
+  end
+  
+  describe "when the action raises an Error that is not a ControllerError" do
+    before(:each) do
+      Object.class_eval <<-RUBY
+        class Exceptions < Application
+          def load_error
+            "LoadError"
+          end
+        end
+      RUBY
+    end
+    
+    after(:each) do
+      Object.send(:remove_const, :Exceptions)
+    end
+    
+    before(:each) do
+      Merb::Router.prepare do |r|
+        r.default_routes
+      end
+      @url = "/raise_load_error/index"
+      @controller = dispatch(@url)
+    end
+    
+    it "knows that the error is a LoadError" do
+      @controller.should be_error(LoadError)
+    end
+    
+    it "renders Exceptions#load_error" do
+      @controller.body.should == "LoadError"
+    end
+    
+    it "returns a 500 status code" do
+      @controller.status.should == 500
+    end
+  end
+
+  describe "when the Exception action raises" do
+    before(:each) do
+      Object.class_eval <<-RUBY
+        class Exceptions < Application
+          def load_error
+            raise StandardError, "Big error"
+          end
+        end
+      RUBY
+    end
+    
+    after(:each) do
+      Object.send(:remove_const, :Exceptions)
+    end
+    
+    before(:each) do
+      Merb::Router.prepare do |r|
+        r.default_routes
+      end
+      @url = "/raise_load_error/index"
+      @controller = dispatch(@url)
+    end
+    
+    it "knows that the error is a StandardError" do
+      @controller.should be_error(StandardError)
+    end
+    
+    it "renders the default exception template" do
+      @controller.body.should have_selector("h1:contains(Standard Error)")
+      @controller.body.should have_selector("h2:contains(Big Error)")
+      
+      @controller.body.should have_selector("h1:contains(Load Error)")
+      @controller.body.should have_selector("h2:contains(Big Error)")
+    end
+    
+    it "returns a 500 status code" do
+      @controller.status.should == 500
+    end
+  end
+
+
+  describe "when the Exception action raises a NotFound" do
+    before(:each) do
+      Object.class_eval <<-RUBY
+        class Exceptions < Application
+          def not_found
+            raise NotFound, "Somehow, the thing you were looking for was not found."
+          end
+        end
+      RUBY
+    end
+    
+    after(:each) do
+      Object.send(:remove_const, :Exceptions)
+    end
+    
+    before(:each) do
+      Merb::Router.prepare do |r|
+        r.default_routes
+      end
+      @url = "/page/not/found"
+      @controller = dispatch(@url)
+    end
+    
+    it "knows that the error is a NotFound" do
+      @controller.should be_error(Merb::ControllerExceptions::NotFound)
+    end
+    
+    it "renders the default exception template" do
+      @controller.body.should have_selector("h1:contains(Not Found)")
+      @controller.body.should have_selector("h2:contains(Somehow, the thing)")
+    end
+    
+    it "returns a 404 status code" do
+      @controller.status.should == 404
+    end
+  end
+
+  describe "when the Exception action raises the same thing as the original failure" do
+    before(:each) do
+      Object.class_eval <<-RUBY
+        class Exceptions < Application
+          def load_error
+            raise LoadError, "Something failed here"
+          end          
+        end
+      RUBY
+    end
+    
+    after(:each) do
+      Object.send(:remove_const, :Exceptions)
+    end
+    
+    before(:each) do
+      Merb::Router.prepare do |r|
+        r.default_routes
+      end
+      @url = "/raise_load_error/index"
+      @controller = dispatch(@url)
+    end
+    
+    it "knows that the error is a NotFound" do
+      @controller.should be_error(LoadError)
+    end
+    
+    it "renders the default exception template" do
+      @controller.body.should have_selector("h1:contains(Something failed here)")
+    end
+    
+    it "returns a 500 status code" do
+      @controller.status.should == 500
+    end
+  end
+
+  describe "when more than one Exceptions methods raises an Error" do
+    before(:each) do
+      Object.class_eval <<-RUBY
+        class Exceptions < Application
+          def load_error
+            raise StandardError, "StandardError"
+          end
+          
+          def standard_error
+            raise Exception, "Exception"
+          end
+        end
+      RUBY
+    end
+    
+    after(:each) do
+      Object.send(:remove_const, :Exceptions)
+    end
+    
+    before(:each) do
+      Merb::Router.prepare do |r|
+        r.default_routes
+      end
+      @url = "/raise_load_error/index"
+      @controller = dispatch(@url)
+      @body = @controller.body
+    end
+    
+    it "knows that the error is a NotFound" do
+      @controller.should be_error(Exception)
+    end
+    
+    it "renders a list of links to the traces" do
+      @body.should have_selector("li a[@href=#exception_0]")
+      @body.should have_selector("li a[@href=#exception_1]")
+      @body.should have_selector("li a[@href=#exception_2]")
+    end
+    
+    it "renders the default exception template" do
+      @body.should have_selector("h1:contains(Load Error)")
+      @body.should have_selector("h2:contains(In the controller)")
+      @body.should have_selector("h1:contains(Standard Error)")
+      @body.should have_selector("h2:contains(StandardError)")
+      @body.should have_selector("h1:contains(Exception)")
+      @body.should have_selector("h2:contains(Exception)")
+    end
+    
+    it "returns a 500 status code" do
+      @controller.status.should == 500
+    end
+  end
+  
+end