mensa 0.9.3 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4dc7c940f4eff95458542c2ac2d54a71df5735105019fb09d2fc4b70f588124
-  data.tar.gz: 6f43f89a33e27295b268b6c45c4a018599e313418b1aeb4b3ae758de63180211
+  metadata.gz: 63364b3ef1004b6f44cb7188209c0924553d7e141f52062df2c4e06bf55cca41
+  data.tar.gz: d213f088d9a5f07af9f3502318f23095a0654fb7ea0738a7012c520b0fe5ad21
 SHA512:
-  metadata.gz: 0a038582389be24ec077d6234974d30700bcef87ca6d3524abdecfed97bcb09280fcbbb46095af18fac2339243ebcf3f39e3cc54adad0e96519183e6e5435a67
-  data.tar.gz: 2803b2f1fa2e42b19ca2ed2aff842e7bdd2bc1315f2fef13b590010105725746f832113fec55861e8ea911eeaf18e2454b9798822d0330ad73068b472f6b7dce
+  metadata.gz: 7a0aa6a1675642a482b9d616370755f0cd46b315997d3082ac4ecf4d510116f32d235909cf28a3f7e123b427f88dc3f68c3ccd04a2a09dd5f8515fae7d4e4bca
+  data.tar.gz: c89e70746c216146cbaceb589e485dc43a63c37d98f92ad8c420e021eae40f2c04af90130bacd9c90a68b698b0cb57386ff993ce75285638b31361db5dbdb141

data/.shipkit.yml

@@ -1,2 +1,2 @@
 ---
-previous_version: 0.9.2
+previous_version: 0.9.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mensa (0.9.2)
+    mensa (0.9.3)
       csv
       importmap-rails
       pagy (>= 43)

data/app/components/mensa/filter_pill_list/component_controller.js

@@ -592,9 +592,7 @@ export default class FilterPillListComponentController extends ApplicationContro
                 `[data-mensa-views-target="view"][data-view-id="${view}"]`,
             );
             if (viewEl) {
-                const name =
-                    viewEl.dataset.viewName ||
-                    viewEl.querySelector("span")?.textContent?.trim();
+                const name = viewEl.dataset.viewName;
                 if (name) triggerLabel.textContent = name;
             }
         }

data/app/components/mensa/views/component.css

@@ -23,7 +23,7 @@
 }
 
 .mensa-table__views__option-check {
-    @apply text-primary-600 text-xs w-4;
+    @apply inline-flex justify-center shrink-0 text-primary-600 text-xs w-4;
 }
 
 .mensa-table__views__option-menu {

data/app/components/mensa/views/component.html.erb

@@ -22,7 +22,8 @@
         <% is_user_view = view.is_a?(Mensa::TableView) %>
         <li class="mensa-table__views__option" role="option" data-view-id="<%= view.id %>" data-view-name="<%= view.name %>" data-mensa-views-target="view">
           <button class="mensa-table__views__option-btn" type="button" data-action="mensa-views#select" data-view-id="<%= view.id %>">
-            <i class="mensa-table__views__option-check <%= Mensa.config.icons[:views_option_selected] %><%= " invisible" unless is_selected %>"></i>
+            <%# The state is on the span: FontAwesome swaps the <i> for an <svg> asynchronously, copying classes that may be stale by then %>
+            <span class="mensa-table__views__option-check<%= " invisible" unless is_selected %>"><i class="<%= Mensa.config.icons[:views_option_selected] %>"></i></span>
             <span><%= view.name %></span>
           </button>
           <% if is_user_view %>

data/app/components/mensa/views/component_controller.js

@@ -42,7 +42,7 @@ export default class ViewsComponentController extends ApplicationController {
             check?.classList.toggle("invisible", !isThis);
         });
 
-        const viewName = event.currentTarget.querySelector("span")?.textContent?.trim() || "";
+        const viewName = selected.closest("[data-mensa-views-target='view']")?.dataset.viewName || "";
         if (this.hasTriggerLabelTarget) {
             this.triggerLabelTarget.textContent = viewName;
         }

data/lib/mensa/version.rb

@@ -1,3 +1,3 @@
 module Mensa
-  VERSION = "0.9.3"
+  VERSION = "0.9.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mensa
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.4
 platform: ruby
 authors:
 - Tom de Grunt