mensa 0.9.2 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 651651e83e9d9140b6c5b0f63cc193afd84399ec3af2d511da59be36d56dae44
-  data.tar.gz: 443c135b4e673f6334db2b99690c60a2b8c7323d81a8c31b2d36f3e132856cff
+  metadata.gz: 63364b3ef1004b6f44cb7188209c0924553d7e141f52062df2c4e06bf55cca41
+  data.tar.gz: d213f088d9a5f07af9f3502318f23095a0654fb7ea0738a7012c520b0fe5ad21
 SHA512:
-  metadata.gz: ec46ba8fcc59ab4c193d4d912de77bdc9ebec4aac87c93983be02c1422d979a1558d9368a6f816d9ba9579b6c56fd928b412d73b39b9924838d62aff8a259467
-  data.tar.gz: '0491edbee70617b3293afcc8564f5fdb22379563bada952d74bcac0e40212fdf16a76e5e63c8d77258441779348c22147067c28b8fc222c938e45a5f29396dde'
+  metadata.gz: 7a0aa6a1675642a482b9d616370755f0cd46b315997d3082ac4ecf4d510116f32d235909cf28a3f7e123b427f88dc3f68c3ccd04a2a09dd5f8515fae7d4e4bca
+  data.tar.gz: c89e70746c216146cbaceb589e485dc43a63c37d98f92ad8c420e021eae40f2c04af90130bacd9c90a68b698b0cb57386ff993ce75285638b31361db5dbdb141

data/.shipkit.yml

@@ -1,2 +1,2 @@
 ---
-previous_version: 0.9.1
+previous_version: 0.9.3

data/CHANGELOG.md

@@ -1,5 +1,41 @@
 # Changelog
 
+## 0.9.3
+
+- A Mensa table can be rendered inside a host `<form>`, such as a tab on an
+  edit page. Before, the save-view, rename-view and export dialogs (and the
+  delete button of each export) rendered their own `<form>`s. HTML has no
+  nested forms, so the outer form was closed early, its submit was silently
+  blocked by Mensa's empty `required` inputs, and the export options were
+  sent along with it. Mensa now renders no `<form>` elements, no `required`
+  attributes and no controls that a host form submits.
+- The save-view and rename-view dialogs confirm with their button or Enter in
+  the name field. An empty name still shows the browser's validation message,
+  now from the translatable `mensa.search.component.view_name_required` and
+  `mensa.views.component.view_name_required` keys.
+- **Behaviour change:** the export dialog's controls have a `form` attribute
+  that matches no element and names that include the table id (e.g.
+  `mensa-export-users-scope`), so they never belong to a host form and don't
+  group with radios elsewhere on the page. Select them with
+  `data-mensa-export-field="scope"` (or `export_format`, `repeat_mode`,
+  `repeat`) instead of `name`.
+- **Behaviour change:** the search input no longer has `name="search_query"`,
+  and the `.mensa-table__export-dialog__delete-form` class is gone: an export
+  is deleted with a plain `button.mensa-table__export-dialog__delete`.
+- Group header aggregates of `bigint` columns no longer show a trailing `.0`
+  (`3,000` instead of `3,000.0`). Postgres returns their SUM as `numeric`;
+  whole numbers are now shown without decimals.
+- A selected view survives a page reload when the default view has filters.
+  Before, the table showed the selected view's rows, but the views dropdown
+  and the filter pills still showed the default view.
+- A view filter that the user changes (another value or operator) becomes a
+  user filter: it's always shown, and the eye button disappears when no
+  unchanged view filters remain. Before, a pill was a view filter as long as
+  the view filtered on its column, so a changed filter could still be hidden.
+- The views dropdown is positioned `fixed`, like the other popovers, so a
+  table with few rows (or a host element with `overflow: hidden`) no longer
+  clips it.
+
 ## 0.9.2
 
 - The table tour no longer needs the `driver.js` npm package. Mensa now ships

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mensa (0.9.2)
+    mensa (0.9.3)
       csv
       importmap-rails
       pagy (>= 43)

data/app/components/mensa/control_bar/component.css

@@ -63,12 +63,8 @@
     @apply flex shrink-0 items-center gap-3 px-3 py-2.5;
 }
 
-.mensa-table__export-dialog__delete-form {
-    @apply shrink-0;
-}
-
 .mensa-table__export-dialog__delete {
-    @apply inline-flex h-9 w-9 items-center justify-center rounded-md text-gray-400 dark:text-gray-500 hover:bg-gray-100 dark:hover:bg-gray-700 hover:text-red-600 dark:hover:text-red-400 focus:outline-none focus:ring-2 focus:ring-red-500/30 transition-colors cursor-pointer;
+    @apply shrink-0 inline-flex h-9 w-9 items-center justify-center rounded-md text-gray-400 dark:text-gray-500 hover:bg-gray-100 dark:hover:bg-gray-700 hover:text-red-600 dark:hover:text-red-400 focus:outline-none focus:ring-2 focus:ring-red-500/30 transition-colors cursor-pointer;
 }
 
 .mensa-table__export-dialog__item-info {

data/app/components/mensa/filter_pill/component.rb

@@ -11,13 +11,27 @@ module Mensa
         @filter = filter
       end
 
+      # A pill is a view filter only while it still filters like the view does,
+      # once the user changes it, it's their own filter.
       def view_filter?
         view = filter.table.table_view
         return false unless view
 
         view_filters = view.config&.dig(:filters) || view.config&.dig("filters") || {}
         col = filter.column.name.to_s
-        view_filters.key?(col) || view_filters.key?(col.to_sym)
+        view_filter = view_filters[col] || view_filters[col.to_sym]
+        return false unless view_filter
+
+        view_filter = view_filter.to_h.with_indifferent_access
+        return false if view_filter[:operator].present? && view_filter[:operator].to_sym != filter.operator
+
+        comparable(view_filter[:value]) == comparable(filter.value)
+      end
+
+      private
+
+      def comparable(value)
+        Array(value).map(&:to_s).reject(&:blank?).sort
       end
     end
   end

data/app/components/mensa/filter_pill_list/component.html.erb

@@ -18,7 +18,6 @@
     <div class="mensa-table__search-bar__input-wrapper">
       <input class="mensa-table__search-bar__input"
              type="text"
-             name="search_query"
              autocomplete="off"
              placeholder="<%= t(has_filterable_columns ? ".search" : ".search_only") %>"
              data-mensa-filter-pill-list-target="searchInput"

data/app/components/mensa/filter_pill_list/component_controller.js

@@ -319,8 +319,11 @@ export default class FilterPillListComponentController extends ApplicationContro
         const filtersDiffer =
             filtersProvided &&
             JSON.stringify(rendered) !== JSON.stringify(filters);
+        // The pills belong to the view the server rendered, so they only count
+        // when the stored view is that same view.
+        const viewDiffers = view.length > 0 && view !== this.renderedView();
         const alreadyRendered =
-            Object.keys(rendered).length > 0 && !filtersDiffer;
+            Object.keys(rendered).length > 0 && !filtersDiffer && !viewDiffers;
 
         if (!hasState || alreadyRendered || table.frameLoadHandled) {
             if (typeof table.loadFrame === "function") {
@@ -546,6 +549,18 @@ export default class FilterPillListComponentController extends ApplicationContro
         this._monitorResetButton();
     }
 
+    // The id of the view checked in the views dropdown, "" without views.
+    renderedView() {
+        const root = this.element.closest(".mensa-table");
+        const check = root?.querySelector(
+            '[data-mensa-views-target="view"] .mensa-table__views__option-check:not(.invisible)',
+        );
+        return (
+            check?.closest('[data-mensa-views-target="view"]')?.dataset
+                .viewId || ""
+        );
+    }
+
     setViewHighlight(view) {
         if (!view) return;
 
@@ -577,9 +592,7 @@ export default class FilterPillListComponentController extends ApplicationContro
                 `[data-mensa-views-target="view"][data-view-id="${view}"]`,
             );
             if (viewEl) {
-                const name =
-                    viewEl.dataset.viewName ||
-                    viewEl.querySelector("span")?.textContent?.trim();
+                const name = viewEl.dataset.viewName;
                 if (name) triggerLabel.textContent = name;
             }
         }

data/app/components/mensa/search/component.html.erb

@@ -1,13 +1,13 @@
 <% if table.current_user %>
   <dialog class="mensa-table__save-view-dialog" data-mensa-table-target="saveViewDialog" data-action="click->mensa-table#saveViewDialogBackdrop">
-    <form class="mensa-table__save-view-dialog__form" data-action="submit->mensa-table#confirmSaveView">
+    <div class="mensa-table__save-view-dialog__form">
       <header class="mensa-table__save-view-dialog__header">
         <h2 class="mensa-table__save-view-dialog__title"><%= t(".save_view_title", default: "Save view") %></h2>
         <p class="mensa-table__save-view-dialog__subtitle"><%= t(".save_view_subtitle", default: "Save the current filters, ordering and search as a reusable view.") %></p>
       </header>
       <label class="mensa-table__save-view-dialog__field">
         <span class="mensa-table__save-view-dialog__label"><%= t(".view_name", default: "Name") %></span>
-        <input class="mensa-table__save-view-dialog__input" type="text" required placeholder="<%= t(".view_name_placeholder", default: "e.g. Active customers") %>" data-mensa-table-target="saveViewName">
+        <input class="mensa-table__save-view-dialog__input" type="text" aria-required="true" placeholder="<%= t(".view_name_placeholder", default: "e.g. Active customers") %>" data-required-message="<%= t(".view_name_required", default: "Please enter a name for this view.") %>" data-mensa-table-target="saveViewName" data-action="keydown.enter->mensa-table#confirmSaveView input->mensa-table#clearValidity">
       </label>
       <label class="mensa-table__save-view-dialog__field">
         <span class="mensa-table__save-view-dialog__label"><%= t(".view_description", default: "Description") %></span>
@@ -17,10 +17,10 @@
         <button class="mensa-table__save-view-dialog__button mensa-table__save-view-dialog__button--secondary" type="button" data-action="mensa-table#cancelSaveView">
           <%= t(".cancel") %>
         </button>
-        <button class="mensa-table__save-view-dialog__button mensa-table__save-view-dialog__button--primary" type="submit">
+        <button class="mensa-table__save-view-dialog__button mensa-table__save-view-dialog__button--primary" type="button" data-action="mensa-table#confirmSaveView">
           <%= t(".save") %>
         </button>
       </div>
-    </form>
+    </div>
   </dialog>
 <% end %>

data/app/components/mensa/table/component_controller.js

@@ -1,5 +1,5 @@
 import ApplicationController from "mensa/controllers/application_controller";
-import { get, post, patch } from "@rails/request.js";
+import { get, post, patch, destroy } from "@rails/request.js";
 
 export default class TableComponentController extends ApplicationController {
     static targets = [
@@ -300,6 +300,8 @@ export default class TableComponentController extends ApplicationController {
     }
 
     async confirmSaveView(event) {
+        // Called from a button click or Enter in the name input. The table may
+        // sit inside a host <form>; this stops Enter from submitting it.
         event.preventDefault();
 
         const name = this.hasSaveViewNameTarget
@@ -307,7 +309,7 @@ export default class TableComponentController extends ApplicationController {
             : "";
         if (!name) {
             if (this.hasSaveViewNameTarget)
-                this.saveViewNameTarget.reportValidity();
+                this.reportMissing(this.saveViewNameTarget);
             return;
         }
 
@@ -560,28 +562,18 @@ export default class TableComponentController extends ApplicationController {
         );
         if (!options) return;
 
-        const mode = dialog.querySelector(
-            'input[name="repeat_mode"]:checked',
-        )?.value;
-        options.hidden = mode !== "repeating";
+        options.hidden = this._exportField("repeat_mode") !== "repeating";
     }
 
     confirmExport(event) {
-        event.preventDefault();
+        if (event) event.preventDefault();
         if (!this.hasExportsUrlValue) return;
 
-        const dialog = this.exportDialogTarget;
-        const scope =
-            dialog.querySelector('input[name="scope"]:checked')?.value || "all";
-        const exportFormat =
-            dialog.querySelector('input[name="export_format"]:checked')
-                ?.value || "csv_excel";
-        const repeatMode = dialog.querySelector(
-            'input[name="repeat_mode"]:checked',
-        )?.value;
+        const scope = this._exportField("scope") || "all";
+        const exportFormat = this._exportField("export_format") || "csv_excel";
         const repeat =
-            repeatMode === "repeating"
-                ? dialog.querySelector('select[name="repeat"]')?.value || ""
+            this._exportField("repeat_mode") === "repeating"
+                ? this._exportField("repeat") || ""
                 : "";
 
         const state = this.currentViewState();
@@ -611,6 +603,27 @@ export default class TableComponentController extends ApplicationController {
         });
     }
 
+    deleteExport(event) {
+        if (event) event.preventDefault();
+        const url = event.currentTarget.dataset.url;
+        if (!url) return;
+
+        destroy(url, { responseKind: "turbo-stream" });
+    }
+
+    // Shows the browser's validation bubble for an empty text input. The
+    // inputs aren't `required` (that would block a host <form> around the
+    // table), so the message is set by hand and cleared again on input.
+    reportMissing(input) {
+        input.setCustomValidity(input.dataset.requiredMessage || "");
+        input.reportValidity();
+        input.focus();
+    }
+
+    clearValidity(event) {
+        event.currentTarget.setCustomValidity("");
+    }
+
     get ourUrl() {
         if (
             this.hasTurboFrameTarget &&
@@ -629,6 +642,17 @@ export default class TableComponentController extends ApplicationController {
 
     // --- Private ---
 
+    // Export controls are found by data attribute: their names carry the
+    // table id so they don't group with radios elsewhere on the page.
+    _exportField(field) {
+        const dialog = this.exportDialogTarget;
+        const selector = `[data-mensa-export-field="${field}"]`;
+        const control =
+            dialog.querySelector(`input${selector}:checked`) ||
+            dialog.querySelector(`select${selector}`);
+        return control?.value;
+    }
+
     // Reads the currently-selected view ID from the DOM (after Turbo re-renders
     // the views component) and persists it to localStorage.
     _persistSelectedViewId() {
@@ -674,7 +698,10 @@ export default class TableComponentController extends ApplicationController {
 
     _openSaveDialog() {
         if (!this.hasSaveViewDialogTarget) return;
-        if (this.hasSaveViewNameTarget) this.saveViewNameTarget.value = "";
+        if (this.hasSaveViewNameTarget) {
+            this.saveViewNameTarget.value = "";
+            this.saveViewNameTarget.setCustomValidity("");
+        }
         if (this.hasSaveViewDescriptionTarget)
             this.saveViewDescriptionTarget.value = "";
         if (typeof this.saveViewDialogTarget.showModal === "function") {

data/app/components/mensa/views/component.css

@@ -11,7 +11,7 @@
 }
 
 .mensa-table__views__dropdown {
-    @apply absolute left-0 top-full z-20 mt-1 min-w-[12rem] rounded-lg bg-white dark:bg-gray-800 shadow-lg ring-1 ring-black/5 dark:ring-white/10 py-1;
+    @apply fixed z-50 min-w-[12rem] rounded-lg bg-white dark:bg-gray-800 shadow-lg ring-1 ring-black/5 dark:ring-white/10 py-1;
 }
 
 .mensa-table__views__option {
@@ -23,7 +23,7 @@
 }
 
 .mensa-table__views__option-check {
-    @apply text-primary-600 text-xs w-4;
+    @apply inline-flex justify-center shrink-0 text-primary-600 text-xs w-4;
 }
 
 .mensa-table__views__option-menu {

data/app/components/mensa/views/component.html.erb

@@ -22,7 +22,8 @@
         <% is_user_view = view.is_a?(Mensa::TableView) %>
         <li class="mensa-table__views__option" role="option" data-view-id="<%= view.id %>" data-view-name="<%= view.name %>" data-mensa-views-target="view">
           <button class="mensa-table__views__option-btn" type="button" data-action="mensa-views#select" data-view-id="<%= view.id %>">
-            <i class="mensa-table__views__option-check <%= Mensa.config.icons[:views_option_selected] %><%= " invisible" unless is_selected %>"></i>
+            <%# The state is on the span: FontAwesome swaps the <i> for an <svg> asynchronously, copying classes that may be stale by then %>
+            <span class="mensa-table__views__option-check<%= " invisible" unless is_selected %>"><i class="<%= Mensa.config.icons[:views_option_selected] %>"></i></span>
             <span><%= view.name %></span>
           </button>
           <% if is_user_view %>
@@ -55,21 +56,21 @@
   </div>
 
   <dialog class="mensa-table__views__rename-dialog" data-mensa-views-target="renameDialog" data-action="click->mensa-views#renameDialogBackdrop">
-    <form class="mensa-table__views__rename-form" data-action="submit->mensa-views#confirmRename">
+    <div class="mensa-table__views__rename-form">
       <input type="hidden" data-mensa-views-target="renameViewId">
       <h3 class="mensa-table__views__rename-title"><%= t(".rename_view", default: "Rename view") %></h3>
       <label class="mensa-table__views__rename-label">
         <%= t(".view_name", default: "Name") %>
-        <input class="mensa-table__views__rename-input" type="text" required placeholder="<%= t(".view_name_placeholder", default: "View name") %>" data-mensa-views-target="renameInput">
+        <input class="mensa-table__views__rename-input" type="text" aria-required="true" placeholder="<%= t(".view_name_placeholder", default: "View name") %>" data-required-message="<%= t(".view_name_required", default: "Please enter a name for this view.") %>" data-mensa-views-target="renameInput" data-action="keydown.enter->mensa-views#confirmRename input->mensa-views#clearRenameValidity">
       </label>
       <div class="mensa-table__views__rename-actions">
         <button class="mensa-table__views__rename-btn mensa-table__views__rename-btn--secondary" type="button" data-action="mensa-views#cancelRename">
           <%= t(".cancel", default: "Cancel") %>
         </button>
-        <button class="mensa-table__views__rename-btn mensa-table__views__rename-btn--primary" type="submit">
+        <button class="mensa-table__views__rename-btn mensa-table__views__rename-btn--primary" type="button" data-action="mensa-views#confirmRename">
           <%= t(".rename", default: "Rename") %>
         </button>
       </div>
-    </form>
+    </div>
   </dialog>
 </div>

data/app/components/mensa/views/component_controller.js

@@ -42,7 +42,7 @@ export default class ViewsComponentController extends ApplicationController {
             check?.classList.toggle("invisible", !isThis);
         });
 
-        const viewName = event.currentTarget.querySelector("span")?.textContent?.trim() || "";
+        const viewName = selected.closest("[data-mensa-views-target='view']")?.dataset.viewName || "";
         if (this.hasTriggerLabelTarget) {
             this.triggerLabelTarget.textContent = viewName;
         }
@@ -90,6 +90,7 @@ export default class ViewsComponentController extends ApplicationController {
         if (this.hasRenameDialogTarget) {
             this.renameViewIdTarget.value = viewId;
             this.renameInputTarget.value = viewName;
+            this.renameInputTarget.setCustomValidity("");
             if (typeof this.renameDialogTarget.showModal === "function") {
                 this.renameDialogTarget.showModal();
             } else {
@@ -111,11 +112,18 @@ export default class ViewsComponentController extends ApplicationController {
     }
 
     async confirmRename(event) {
+        // Called from a button click or Enter in the name input. The table may
+        // sit inside a host <form>; this stops Enter from submitting it.
         event.preventDefault();
         const viewId = this.renameViewIdTarget.value;
         const newName = this.renameInputTarget.value.trim();
         if (!newName) {
-            this.renameInputTarget.reportValidity();
+            // The input isn't `required` (that would block a host <form>), so
+            // the browser's message is set by hand and cleared on input.
+            const input = this.renameInputTarget;
+            input.setCustomValidity(input.dataset.requiredMessage || "");
+            input.reportValidity();
+            input.focus();
             return;
         }
 
@@ -131,6 +139,10 @@ export default class ViewsComponentController extends ApplicationController {
         }
     }
 
+    clearRenameValidity() {
+        this.renameInputTarget.setCustomValidity("");
+    }
+
     async duplicateView(event) {
         event.preventDefault();
         const viewId = this.submenuTarget.dataset.viewId;
@@ -198,10 +210,19 @@ export default class ViewsComponentController extends ApplicationController {
     // --- private ---
 
     _openDropdown() {
+        this._positionDropdown();
         this.dropdownTarget.classList.remove("hidden");
         this._bindOutsideClick();
     }
 
+    // Fixed positioning with viewport coordinates, so a small table (or a host
+    // element with overflow hidden) doesn't clip the dropdown.
+    _positionDropdown() {
+        const rect = this.triggerTarget.getBoundingClientRect();
+        this.dropdownTarget.style.top = `${rect.bottom + 4}px`;
+        this.dropdownTarget.style.left = `${rect.left}px`;
+    }
+
     _closeDropdown() {
         this.dropdownTarget.classList.add("hidden");
         this._closeSubmenu();

data/app/tables/mensa/group.rb

@@ -34,6 +34,9 @@ module Mensa
       return unless aggregates.key?(column.name)
 
       value = aggregates[column.name]
+      # SUM of a bigint column comes back as a BigDecimal, which would show as
+      # "3,000.0". Whole numbers are shown without decimals.
+      value = value.to_i if value.is_a?(BigDecimal) && value.frac.zero?
       return ActiveSupport::NumberHelper.number_to_delimited(value) if value.is_a?(Numeric)
 
       Mensa::Cell.new(row: nil, column: column, value: value).formatted

data/app/views/mensa/exports/_dialog.html.erb

@@ -14,15 +14,20 @@
         <%= render partial: "mensa/exports/list", locals: {table_name: table.name, user: user, table_params: table.params, exports: exports} %>
       </div>
 
-      <form class="mensa-table__export-dialog__form" data-action="submit->mensa-table#confirmExport">
+      <%# These controls belong to no form: form= names an element that doesn't
+          exist, so a host <form> around the table neither submits nor
+          validates them. Radios without a form owner group by name across
+          the whole document, so the names carry the table id. %>
+      <% form_id = "mensa-export-#{table.table_id}" %>
+      <div class="mensa-table__export-dialog__form">
         <fieldset class="mensa-table__export-dialog__fieldset" data-mensa-tour="export_scope">
           <legend class="mensa-table__export-dialog__section-title"><%= t("mensa.exports.new_export", default: "New export") %></legend>
           <label class="mensa-table__export-dialog__option">
-            <input type="radio" name="scope" value="all" checked>
+            <input type="radio" form="<%= form_id %>" name="<%= form_id %>-scope" data-mensa-export-field="scope" value="all" checked>
             <span><%= t("mensa.exports.scope_all", default: "All records (matching current filters)") %></span>
           </label>
           <label class="mensa-table__export-dialog__option">
-            <input type="radio" name="scope" value="current_page">
+            <input type="radio" form="<%= form_id %>" name="<%= form_id %>-scope" data-mensa-export-field="scope" value="current_page">
             <span><%= t("mensa.exports.scope_current_page", default: "Current page") %></span>
           </label>
         </fieldset>
@@ -30,11 +35,11 @@
         <fieldset class="mensa-table__export-dialog__fieldset" data-mensa-tour="export_format">
           <legend class="mensa-table__export-dialog__section-title"><%= t("mensa.exports.export_as", default: "Export as") %></legend>
           <label class="mensa-table__export-dialog__option">
-            <input type="radio" name="export_format" value="csv_excel" checked>
+            <input type="radio" form="<%= form_id %>" name="<%= form_id %>-export_format" data-mensa-export-field="export_format" value="csv_excel" checked>
             <span><%= t("mensa.exports.format_excel", default: "CSV for Excel, Numbers, or other spreadsheet programs") %></span>
           </label>
           <label class="mensa-table__export-dialog__option">
-            <input type="radio" name="export_format" value="plain_csv">
+            <input type="radio" form="<%= form_id %>" name="<%= form_id %>-export_format" data-mensa-export-field="export_format" value="plain_csv">
             <span><%= t("mensa.exports.format_plain", default: "Plain CSV file") %></span>
           </label>
         </fieldset>
@@ -42,16 +47,16 @@
         <fieldset class="mensa-table__export-dialog__fieldset" data-mensa-tour="export_repeat">
           <legend class="mensa-table__export-dialog__section-title"><%= t("mensa.exports.repeat_section", default: "Repeat") %></legend>
           <label class="mensa-table__export-dialog__option">
-            <input type="radio" name="repeat_mode" value="once" checked data-action="change->mensa-table#toggleExportRepeat">
+            <input type="radio" form="<%= form_id %>" name="<%= form_id %>-repeat_mode" data-mensa-export-field="repeat_mode" value="once" checked data-action="change->mensa-table#toggleExportRepeat">
             <span><%= t("mensa.exports.repeat_once", default: "Only once") %></span>
           </label>
           <label class="mensa-table__export-dialog__option">
-            <input type="radio" name="repeat_mode" value="repeating" data-action="change->mensa-table#toggleExportRepeat">
+            <input type="radio" form="<%= form_id %>" name="<%= form_id %>-repeat_mode" data-mensa-export-field="repeat_mode" value="repeating" data-action="change->mensa-table#toggleExportRepeat">
             <span><%= t("mensa.exports.repeat_repeating", default: "Repeating") %></span>
           </label>
 
           <div class="mensa-table__export-dialog__repeat-options" hidden data-mensa-table-repeat-options>
-            <select name="repeat" class="mensa-table__export-dialog__select">
+            <select form="<%= form_id %>" name="<%= form_id %>-repeat" data-mensa-export-field="repeat" class="mensa-table__export-dialog__select">
               <option value="daily"><%= t("mensa.exports.repeat_intervals.daily", default: "daily") %></option>
               <option value="weekly"><%= t("mensa.exports.repeat_intervals.weekly", default: "weekly") %></option>
               <option value="monthly"><%= t("mensa.exports.repeat_intervals.monthly", default: "monthly") %></option>
@@ -66,12 +71,12 @@
           <button class="mensa-table__export-dialog__button mensa-table__export-dialog__button--secondary" type="button" data-action="mensa-table#cancelExport">
             <%= t("mensa.exports.cancel", default: "Cancel") %>
           </button>
-          <button class="mensa-table__export-dialog__button mensa-table__export-dialog__button--primary" type="submit">
+          <button class="mensa-table__export-dialog__button mensa-table__export-dialog__button--primary" type="button" data-action="mensa-table#confirmExport">
             <i class="<%= Mensa.config.icons[:exports_dialog_submit] %>"></i>
             <%= t("mensa.exports.submit", default: "Export") %>
           </button>
         </div>
-      </form>
+      </div>
     </div>
   </div>
 </dialog>

data/app/views/mensa/exports/_list.html.erb

@@ -6,13 +6,13 @@
     <ul class="mensa-table__export-dialog__list">
       <% exports.each do |export| %>
         <li class="mensa-table__export-dialog__item">
-          <%= button_to mensa.table_export_path(export.table_name, export),
-            method: :delete,
-            class: "mensa-table__export-dialog__delete",
-            form_class: "mensa-table__export-dialog__delete-form",
-            aria: {label: t("mensa.exports.delete", default: "Delete export") } do %>
+          <button class="mensa-table__export-dialog__delete"
+                  type="button"
+                  data-action="mensa-table#deleteExport"
+                  data-url="<%= mensa.table_export_path(export.table_name, export) %>"
+                  aria-label="<%= t("mensa.exports.delete", default: "Delete export") %>">
             <i class="<%= Mensa.config.icons[:exports_list_delete] %>"></i>
-          <% end %>
+          </button>
 
           <div class="mensa-table__export-dialog__item-info">
             <span class="mensa-table__export-dialog__item-name"><%= export.filename.presence || t("mensa.exports.item_name", default: "%{table} export", table: export.table_name.to_s.humanize) %></span>

data/config/locales/en.yml

@@ -93,6 +93,7 @@ en:
         view_name_placeholder: e.g. Active customers
         view_description: Description
         view_description_placeholder: Optional notes about this view
+        view_name_required: Please enter a name for this view.
     exports:
       title: "Export %{table}"
       close: Close
@@ -132,3 +133,5 @@ en:
       clear_button: Clear search and filters
     views:
       default: All
+      component:
+        view_name_required: Please enter a name for this view.

data/config/locales/nl.yml

@@ -93,6 +93,7 @@ nl:
         view_name_placeholder: bijv. Actieve klanten
         view_description: Omschrijving
         view_description_placeholder: Optionele notities over deze weergave
+        view_name_required: Vul een naam in voor deze weergave.
     exports:
       title: "%{table} exporteren"
       close: Sluiten
@@ -132,3 +133,5 @@ nl:
       clear_button: Zoekopdracht en filters wissen
     views:
       default: Alles
+      component:
+        view_name_required: Vul een naam in voor deze weergave.

data/lib/mensa/version.rb

@@ -1,3 +1,3 @@
 module Mensa
-  VERSION = "0.9.2"
+  VERSION = "0.9.4"
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: mensa
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.4
 platform: ruby
 authors:
 - Tom de Grunt
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-10-16 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -374,8 +373,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Fast and awesome tables
 test_files: []