mensa 0.7.4 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab3722840d818b5e39cac9b51fe13230d93fc1bcc3cfa61ecebedbff2f1fdc52
-  data.tar.gz: cb5a23038d098bcde99caf7db0764288c82e882c31416a18875ffda4916dc12f
+  metadata.gz: 9a9f69de3ec6ea7a204552adbe5182451252b6bcb6029cb0ed05502d461ccd28
+  data.tar.gz: b94a39e616e35d1fc24b6cfdb288e85be31ea639a10b34a26aa8c797aac406cf
 SHA512:
-  metadata.gz: 32c0a1ada80a403d35e9400e10273f6122c445e7c71ee2cdd4bc4492f9c11881de46f1020bd4db7591f97a3ec8a16c89012458f89a77e1a65e223800298c95f0
-  data.tar.gz: 0a5532668ef39a57ff4b9118d2940fb63566bd41d287d28e579f4b729c0e811eff494e95a9035f53c97f6f4f12d7758295ba7d6ff7ffbf1956a238e201737273
+  metadata.gz: ce4fed3fa64aaf100014b275281c3639c220d98c651504f0e62a43c9be7532027d4fcf1d03cd0741a7057e247b6e2abfd80517da69f07f4d6b19781fd47f0dbc
+  data.tar.gz: 532df7e4b842659ae92ec9189fab594c8cf96bbe2456878e8bd0e732666167e73a147ec18900203822f8a7e9ea736ae2fb641944c4b2350df2e997a0899538c2

data/.shipkit.yml

@@ -1,2 +1,2 @@
 ---
-previous_version: 0.7.3
+previous_version: 0.7.4

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 0.8.0
+
+- **Behaviour change:** a column shows what was selected in SQL under its name
+  (a database column, its `attribute` or an alias in the `scope`), and only
+  calls a model method when it asks for one with `method`. Before, a model
+  method with the same name as the column took its place, so
+  `column(:contact) { attribute "concat_ws(...)" }` on a model with a
+  `#contact` method showed the method's result. Columns that relied on a
+  model method of their name need `method true`.
+- `method true` calls the model method named after the column.
+- The verifier warns about columns that are always empty: nothing is selected
+  under their name and they have no `method` or `render`. When the model has a
+  method of that name, it suggests `method true`.
+
 ## 0.7.4
 
 - **Behaviour change:** the `matches` and `does_not_match` filters now do a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mensa (0.7.3)
+    mensa (0.7.4)
       csv
       importmap-rails
       pagy (>= 43)

data/README.md

@@ -119,6 +119,28 @@ You can show your tables on the page using the following:
 Custom views are views not defined by the developer (SystemViews) but by the end-user by adding/removing filters.
 When you enable these, they are stored in the database and can be used across sessions, by the user who created them.
 
+### Column values
+
+A column shows what was selected in SQL under its name: the database column of
+the model, its `attribute`, or an alias your table's `scope` selects. Methods of
+the model are never called, unless the column asks for one with `method`, so a
+model method with the same name as the column doesn't take its place:
+
+```ruby
+column(:contact) do                 # shows the concat_ws, even if the model has a #contact method
+  attribute "concat_ws(', ', contacts.last_name, contacts.first_name)"
+end
+column(:full_name) do               # calls user.to_s
+  method :to_s
+end
+column(:customer) do                # calls user.customer
+  method true
+end
+```
+
+Calling methods is slow, it happens for each row, and select what those methods
+need with `internal` columns, as Mensa only selects the table's columns.
+
 ### Sortable and filterable columns
 
 Sorting and filtering happen in SQL, so whether a column can be sorted or filtered

data/app/tables/mensa/column.rb

@@ -22,6 +22,12 @@ module Mensa
 
     AGGREGATE_FUNCTIONS = %i[count sum min max].freeze
 
+    # The record method that gives the value: `method :to_s` names one,
+    # `method true` uses the column's name
+    def value_method
+      config[:method] == true ? name : config[:method].presence
+    end
+
     def sort_direction
       value = table.config.dig(:order, name)
       value.presence&.to_sym

data/app/tables/mensa/row.rb

@@ -9,17 +9,14 @@ module Mensa
       @record = record
     end
 
+    # A model method is only called when the column asks for one with
+    # `method`, otherwise the value is what was selected under the column's
+    # name, so a model method with the same name doesn't shadow it
     def value(column)
-      if column.attribute && record.respond_to?(column.attribute)
-        record.public_send(column.attribute)
-      elsif column.method && record.respond_to?(column.method)
-        record.public_send(column.method)
-      elsif record.respond_to?(column.name)
-        record.public_send(column.name)
-      elsif record.respond_to?(:[])
+      if column.value_method
+        record.public_send(column.value_method)
+      elsif record.has_attribute?(column.name)
         record[column.name]
-      else
-        "-"
       end
     end
 

data/lib/mensa/verifier.rb

@@ -453,6 +453,7 @@ module Mensa
     def verify_columns
       @table.columns.each do |column|
         verify_column_select(column)
+        warn_empty_column(column) unless column.internal?
         verify_column_sort(column) if column.sortable? && !column.internal?
         verify_column_render(column) unless column.internal?
       end
@@ -460,7 +461,7 @@ module Mensa
 
     def verify_column_select(column)
       check(:columns, column.name, "select") do |c|
-        skip!("no SQL attribute, the value comes from #{column.method ? "method :#{column.method}" : "the record"}") if column.attribute.blank?
+        skip!("no SQL attribute, the value comes from #{column.value_method ? "method :#{column.value_method}" : "the scope"}") if column.attribute.blank?
 
         # What Mensa selects besides the column: the id and internal columns,
         # which preloads in the scope need
@@ -473,6 +474,25 @@ module Mensa
       end
     end
 
+    # A column only calls a model method when it asks for one with `method`,
+    # without one its value is what the scope selects under its name. When
+    # nothing is selected under it, and no render block shows something else,
+    # the column is always empty.
+    def warn_empty_column(column)
+      return if column.value_method || column.config[:render].present?
+
+      record = @rows&.first&.record
+      return if record.nil? || record.has_attribute?(column.name)
+
+      fix = if record.respond_to?(column.name)
+        "Fix: add `method true` to the column to show the model's ##{column.name}, or give it an `attribute`."
+      else
+        "Fix: give the column an `attribute`, select #{column.name} in the table's scope, or add a `method`."
+      end
+      warn!(:columns, column.name, "empty column",
+        "nothing is selected as #{column.name} and it has no `method` or `render`, so it is always empty.\n#{fix}")
+    end
+
     # The SQL type of an `attribute` decides which filter operators and values
     # fit it. Without `type`, Mensa treats it as text: it offers LIKE and
     # compares with text, which fails for e.g. a boolean expression.

data/lib/mensa/version.rb

@@ -1,3 +1,3 @@
 module Mensa
-  VERSION = "0.7.4"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mensa
 version: !ruby/object:Gem::Version
-  version: 0.7.4
+  version: 0.8.0
 platform: ruby
 authors:
 - Tom de Grunt
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-10-14 00:00:00.000000000 Z
+date: 2026-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails