mensa 0.4.0 → 0.6.0

data/app/components/mensa/table/component_controller.js

@@ -43,7 +43,10 @@ export default class TableComponentController extends ApplicationController {
 
         // Close save dropdown when clicking outside
         this._saveDropdownOutsideHandler = (e) => {
-            if (this.hasSaveDropdownTarget && !this.saveDropdownTarget.classList.contains("hidden")) {
+            if (
+                this.hasSaveDropdownTarget &&
+                !this.saveDropdownTarget.classList.contains("hidden")
+            ) {
                 const saveArea = this.saveDropdownTarget.closest(".relative");
                 if (saveArea && !saveArea.contains(e.target)) {
                     this.saveDropdownTarget.classList.add("hidden");
@@ -98,12 +101,15 @@ export default class TableComponentController extends ApplicationController {
             const outlet = this.mensaFilterPillListOutlet;
             const state = {
                 filters: outlet.loadFilters(),
-                query:   outlet.loadQuery(),
-                view:    outlet.loadView(),
-                order:   outlet.loadOrder(),
-                page:    outlet.loadPage(),
+                query: outlet.loadQuery(),
+                view: outlet.loadView(),
+                order: outlet.loadOrder(),
+                page: outlet.loadPage(),
             };
-            this.turboFrameTarget.setAttribute("src", outlet.buildUrl(state).toString());
+            this.turboFrameTarget.setAttribute(
+                "src",
+                outlet.buildUrl(state).toString(),
+            );
         } else if (this.hasTableUrlValue) {
             this.turboFrameTarget.setAttribute("src", this.tableUrlValue);
         }
@@ -135,7 +141,8 @@ export default class TableComponentController extends ApplicationController {
     cancelFiltersAndSearch(event) {
         if (event) event.preventDefault();
         this.hideSaveReset();
-        if (this.hasSaveDropdownTarget) this.saveDropdownTarget.classList.add("hidden");
+        if (this.hasSaveDropdownTarget)
+            this.saveDropdownTarget.classList.add("hidden");
 
         if (this.hasMensaFilterPillListOutlet) {
             this.mensaFilterPillListOutlet.clearFiltersAndSearch();
@@ -164,14 +171,16 @@ export default class TableComponentController extends ApplicationController {
     // "Save as new view" — always opens the name dialog
     saveAsNewView(event) {
         if (event) event.preventDefault();
-        if (this.hasSaveDropdownTarget) this.saveDropdownTarget.classList.add("hidden");
+        if (this.hasSaveDropdownTarget)
+            this.saveDropdownTarget.classList.add("hidden");
         this._openSaveDialog();
     }
 
     // "Update view" — updates the currently selected user-owned view in place
     async updateCurrentViewAction(event) {
         if (event) event.preventDefault();
-        if (this.hasSaveDropdownTarget) this.saveDropdownTarget.classList.add("hidden");
+        if (this.hasSaveDropdownTarget)
+            this.saveDropdownTarget.classList.add("hidden");
 
         const viewId = this._selectedUserViewId();
         if (!viewId) {
@@ -204,7 +213,9 @@ export default class TableComponentController extends ApplicationController {
                 order: state.order,
                 column_order: state.column_order,
                 hidden_columns: state.hidden_columns,
-                turbo_frame_id: this.hasTurboFrameTarget ? this.turboFrameTarget.id : null,
+                turbo_frame_id: this.hasTurboFrameTarget
+                    ? this.turboFrameTarget.id
+                    : null,
             }),
             contentType: "application/json",
             responseKind: "turbo-stream",
@@ -239,9 +250,12 @@ export default class TableComponentController extends ApplicationController {
     async confirmSaveView(event) {
         event.preventDefault();
 
-        const name = this.hasSaveViewNameTarget ? this.saveViewNameTarget.value.trim() : "";
+        const name = this.hasSaveViewNameTarget
+            ? this.saveViewNameTarget.value.trim()
+            : "";
         if (!name) {
-            if (this.hasSaveViewNameTarget) this.saveViewNameTarget.reportValidity();
+            if (this.hasSaveViewNameTarget)
+                this.saveViewNameTarget.reportValidity();
             return;
         }
 
@@ -260,7 +274,9 @@ export default class TableComponentController extends ApplicationController {
                 order: state.order,
                 column_order: state.column_order,
                 hidden_columns: state.hidden_columns,
-                turbo_frame_id: this.hasTurboFrameTarget ? this.turboFrameTarget.id : null,
+                turbo_frame_id: this.hasTurboFrameTarget
+                    ? this.turboFrameTarget.id
+                    : null,
             }),
             contentType: "application/json",
             responseKind: "turbo-stream",
@@ -307,7 +323,10 @@ export default class TableComponentController extends ApplicationController {
         const hasViewFilters = this._hasViewFilterPills();
         if (hasViewFilters) {
             const visible = this._loadViewFiltersVisible();
-            this.element.classList.toggle("mensa-table--view-filters-hidden", !visible);
+            this.element.classList.toggle(
+                "mensa-table--view-filters-hidden",
+                !visible,
+            );
         } else {
             this.element.classList.remove("mensa-table--view-filters-hidden");
         }
@@ -328,13 +347,18 @@ export default class TableComponentController extends ApplicationController {
 
     toggleViewFilters(event) {
         if (event) event.preventDefault();
-        const nowHidden = this.element.classList.toggle("mensa-table--view-filters-hidden");
+        const nowHidden = this.element.classList.toggle(
+            "mensa-table--view-filters-hidden",
+        );
         this._saveViewFiltersVisible(!nowHidden);
         this._updateEyeButton();
     }
 
     _hasViewFilterPills() {
-        return this.element.querySelectorAll('[data-view-filter="true"]').length > 0;
+        return (
+            this.element.querySelectorAll('[data-view-filter="true"]').length >
+            0
+        );
     }
 
     // Only updates button visibility and icon — never touches the hidden class.
@@ -348,11 +372,18 @@ export default class TableComponentController extends ApplicationController {
         this.eyeButtonTarget.classList.toggle("hidden", !hasViewFilters);
 
         if (hasViewFilters) {
-            const hidden = this.element.classList.contains("mensa-table--view-filters-hidden");
+            const hidden = this.element.classList.contains(
+                "mensa-table--view-filters-hidden",
+            );
+            const visibleIconClass =
+                this.eyeButtonTarget.dataset.iconVisibleClass || "";
+            const hiddenIconClass =
+                this.eyeButtonTarget.dataset.iconHiddenClass || "";
+
             // Replace innerHTML so FontAwesome's MutationObserver re-processes the new <i>
             this.eyeButtonTarget.innerHTML = hidden
-                ? '<i class="fa-solid fa-eye"></i>'
-                : '<i class="fa-solid fa-eye-slash"></i>';
+                ? `<i class="${visibleIconClass}"></i>`
+                : `<i class="${hiddenIconClass}"></i>`;
         }
     }
 
@@ -366,13 +397,18 @@ export default class TableComponentController extends ApplicationController {
         if (this.hasMensaFilterPillListOutlet) {
             return this.mensaFilterPillListOutlet.tableNameValue;
         }
-        const el = this.element.querySelector("[data-mensa-filter-pill-list-table-name-value]");
+        const el = this.element.querySelector(
+            "[data-mensa-filter-pill-list-table-name-value]",
+        );
         return el?.dataset?.mensaFilterPillListTableNameValue || "";
     }
 
     _loadViewFiltersVisible() {
         try {
-            return window.localStorage.getItem(this._viewFiltersStorageKey()) === "true";
+            return (
+                window.localStorage.getItem(this._viewFiltersStorageKey()) ===
+                "true"
+            );
         } catch (e) {
             return false;
         }
@@ -381,7 +417,10 @@ export default class TableComponentController extends ApplicationController {
     _saveViewFiltersVisible(visible) {
         try {
             if (visible) {
-                window.localStorage.setItem(this._viewFiltersStorageKey(), "true");
+                window.localStorage.setItem(
+                    this._viewFiltersStorageKey(),
+                    "true",
+                );
             } else {
                 window.localStorage.removeItem(this._viewFiltersStorageKey());
             }
@@ -432,13 +471,36 @@ export default class TableComponentController extends ApplicationController {
         }
     }
 
+    toggleExportRepeat() {
+        const dialog = this.exportDialogTarget;
+        const options = dialog.querySelector(
+            "[data-mensa-table-repeat-options]",
+        );
+        if (!options) return;
+
+        const mode = dialog.querySelector(
+            'input[name="repeat_mode"]:checked',
+        )?.value;
+        options.hidden = mode !== "repeating";
+    }
+
     confirmExport(event) {
         event.preventDefault();
         if (!this.hasExportsUrlValue) return;
 
         const dialog = this.exportDialogTarget;
-        const scope = dialog.querySelector('input[name="scope"]:checked')?.value || "all";
-        const exportFormat = dialog.querySelector('input[name="export_format"]:checked')?.value || "csv_excel";
+        const scope =
+            dialog.querySelector('input[name="scope"]:checked')?.value || "all";
+        const exportFormat =
+            dialog.querySelector('input[name="export_format"]:checked')
+                ?.value || "csv_excel";
+        const repeatMode = dialog.querySelector(
+            'input[name="repeat_mode"]:checked',
+        )?.value;
+        const repeat =
+            repeatMode === "repeating"
+                ? dialog.querySelector('select[name="repeat"]')?.value || ""
+                : "";
 
         const state = this.currentViewState();
         const nav = this.hasMensaFilterPillListOutlet
@@ -452,6 +514,7 @@ export default class TableComponentController extends ApplicationController {
             body: JSON.stringify({
                 scope,
                 export_format: exportFormat,
+                repeat,
                 table_view_id: view,
                 page: nav.page,
                 query: state.query || nav.query,
@@ -464,11 +527,17 @@ export default class TableComponentController extends ApplicationController {
     }
 
     get ourUrl() {
-        if (this.hasTurboFrameTarget && this.turboFrameTarget.getAttribute("src")) {
-            return new URL(this.turboFrameTarget.getAttribute("src"));
+        if (
+            this.hasTurboFrameTarget &&
+            this.turboFrameTarget.getAttribute("src")
+        ) {
+            return new URL(
+                this.turboFrameTarget.getAttribute("src"),
+                window.location.origin,
+            );
         }
         if (this.hasTableUrlValue && this.tableUrlValue) {
-            return new URL(this.tableUrlValue);
+            return new URL(this.tableUrlValue, window.location.origin);
         }
         return new URL(window.location.href);
     }
@@ -494,8 +563,12 @@ export default class TableComponentController extends ApplicationController {
     _updateSaveButtonMode() {
         if (!this.hasSaveSimpleTarget && !this.hasSaveSplitTarget) return;
         const isUserView = !!this._selectedUserViewId();
-        this.saveSimpleTargets.forEach((t) => t.classList.toggle("hidden", isUserView));
-        this.saveSplitTargets.forEach((t) => t.classList.toggle("hidden", !isUserView));
+        this.saveSimpleTargets.forEach((t) =>
+            t.classList.toggle("hidden", isUserView),
+        );
+        this.saveSplitTargets.forEach((t) =>
+            t.classList.toggle("hidden", !isUserView),
+        );
     }
 
     _selectedUserViewId() {
@@ -517,7 +590,8 @@ export default class TableComponentController extends ApplicationController {
     _openSaveDialog() {
         if (!this.hasSaveViewDialogTarget) return;
         if (this.hasSaveViewNameTarget) this.saveViewNameTarget.value = "";
-        if (this.hasSaveViewDescriptionTarget) this.saveViewDescriptionTarget.value = "";
+        if (this.hasSaveViewDescriptionTarget)
+            this.saveViewDescriptionTarget.value = "";
         if (typeof this.saveViewDialogTarget.showModal === "function") {
             this.saveViewDialogTarget.showModal();
         } else {

data/app/components/mensa/view/component.html.erb

@@ -27,7 +27,7 @@
             </th>
           <% end %>
           <% if table.actions? && Mensa.config.row_actions_position == :front %>
-            <th>Actions</th>
+            <th><%= t("mensa.actions") %></th>
           <% end %>
           <%= render(Mensa::Header::Component.with_collection(table.display_columns, table: table)) %>
           <% if table.actions? && Mensa.config.row_actions_position == :back %>

data/app/components/mensa/view/component.rb

@@ -14,7 +14,7 @@ module Mensa
 
       # "orders", "users", etc. — used in the paging info line.
       def model_name_plural
-        table.model.model_name.human.pluralize.downcase
+        table.model.model_name.human(count: 2)
       end
     end
   end

data/app/components/mensa/views/component.html.erb

@@ -11,26 +11,26 @@
      data-mensa-views-views-url-value="<%= helpers.mensa.table_views_path(table.name) %>">
   <button class="mensa-table__views__trigger" type="button" data-action="mensa-views#toggleDropdown" data-mensa-views-target="trigger" aria-haspopup="listbox">
     <span class="mensa-table__views__trigger-label" data-mensa-views-target="triggerLabel"><%= current_view_name %></span>
-    <i class="fa-solid fa-sort mensa-table__views__trigger-icon"></i>
+    <i class="<%= Mensa.config.icons[:views_trigger] %> mensa-table__views__trigger-icon"></i>
   </button>
 
   <div class="mensa-table__views__dropdown hidden" data-mensa-views-target="dropdown">
     <ul role="listbox">
       <% table.all_views.each do |view| %>
         <% is_selected = view.id == table.table_view&.id || (view.id == :default && table.table_view.blank?) %>
-        <% is_user_view = view.id.is_a?(String) && view.id.match?(/\A[0-9a-f-]{32,}\z/i) %>
+        <% is_user_view = view.is_a?(Mensa::TableView) %>
         <li class="mensa-table__views__option" role="option" data-view-id="<%= view.id %>" data-view-name="<%= view.name %>" data-mensa-views-target="view">
           <button class="mensa-table__views__option-btn" type="button" data-action="mensa-views#select" data-view-id="<%= view.id %>">
-            <i class="mensa-table__views__option-check fa-solid fa-check<%= " invisible" unless is_selected %>"></i>
+            <i class="mensa-table__views__option-check <%= Mensa.config.icons[:views_option_selected] %><%= " invisible" unless is_selected %>"></i>
             <span><%= view.name %></span>
           </button>
           <% if is_user_view %>
             <button class="mensa-table__views__option-menu" type="button" data-action="mensa-views#toggleSubmenu" data-view-id="<%= view.id %>" title="View options">
-              <i class="fa-solid fa-ellipsis"></i>
+              <i class="<%= Mensa.config.icons[:views_option_menu] %>"></i>
             </button>
           <% else %>
             <div class="mensa-table__views__option-system">
-              <i class="fa-solid fa-ban"></i>
+              <i class="<%= Mensa.config.icons[:views_option_system] %>"></i>
             </div>
           <% end %>
         </li>
@@ -39,15 +39,15 @@
 
     <div class="mensa-table__views__submenu hidden" data-mensa-views-target="submenu">
       <button class="mensa-table__views__submenu-item" type="button" data-action="mensa-views#renameView">
-        <i class="fa-solid fa-pencil"></i>
+        <i class="<%= Mensa.config.icons[:views_rename] %>"></i>
         <%= t(".rename_view", default: "Rename view") %>
       </button>
       <button class="mensa-table__views__submenu-item" type="button" data-action="mensa-views#duplicateView">
-        <i class="fa-solid fa-copy"></i>
+        <i class="<%= Mensa.config.icons[:views_duplicate] %>"></i>
         <%= t(".duplicate_view", default: "Duplicate view") %>
       </button>
       <button class="mensa-table__views__submenu-item mensa-table__views__submenu-item--danger" type="button" data-action="mensa-views#deleteView">
-        <i class="fa-solid fa-trash"></i>
+        <i class="<%= Mensa.config.icons[:views_delete] %>"></i>
         <%= t(".delete_view", default: "Delete view") %>
       </button>
     </div>

data/app/controllers/mensa/tables/exports_controller.rb

@@ -23,6 +23,7 @@ module Mensa
           user: current_mensa_user,
           format: params[:export_format].to_s.presence_in(Mensa::Export::FORMATS) || "csv_excel",
           scope: params[:scope].to_s.presence_in(Mensa::Export::SCOPES) || "all",
+          repeat: params[:repeat].to_s.presence_in(Mensa::Export::REPEATS) || "",
           config: params.permit(:query, :page, order: {}, filters: {}).to_h,
           status: "pending"
         )
@@ -42,6 +43,20 @@ module Mensa
         end
       end
 
+      # Deletes an export from the current user's download list. The attached
+      # asset is purged automatically when the record is destroyed.
+      def destroy
+        export = exports.find(params[:id])
+        export.destroy
+        Mensa::Export.broadcast_refresh(export.table_name, export.user)
+
+        respond_to do |format|
+          format.turbo_stream { render turbo_stream: [list_stream, badge_stream] }
+          format.json { head :no_content }
+          format.html { redirect_back fallback_location: mensa.table_exports_path(params[:table_id]) }
+        end
+      end
+
       # Streams the generated CSV and then removes the export, purging the
       # attached asset. Downloads are single-use: routing them through the
       # controller (instead of a direct Active Storage link) gives us a hook to
@@ -56,12 +71,17 @@ module Mensa
 
         send_data data, filename: filename, type: content_type, disposition: "attachment"
 
-        # Clean up after a successful send. `has_one_attached :asset` purges the
-        # blob when the record is destroyed (dependent: :purge_later). Never let
-        # cleanup failures break the download itself.
+        # One-off exports are single-use and are deleted after download.
+        # Repeating exports stay in place and can be removed explicitly via the
+        # trash action.
         begin
-          export.destroy
-          Mensa::Export.broadcast_refresh(export.table_name, export.user)
+          if export.repeating?
+            export.asset.purge_later
+            Mensa::Export.broadcast_refresh(export.table_name, export.user)
+          else
+            export.destroy
+            Mensa::Export.broadcast_refresh(export.table_name, export.user)
+          end
         rescue => e
           Mensa.config.logger&.warn("Mensa::Export cleanup failed for #{export.id}: #{e.class}: #{e.message}")
         end

data/app/controllers/mensa/tables_controller.rb

@@ -1,27 +1,25 @@
 module Mensa
   class TablesController < ApplicationController
     def show
-      @table = Mensa.for_name(params[:id])
+      config = params.permit(:format, :query, :id, :page, :table_view_id, :turbo_frame_id, order: {}, column_order: [], hidden_columns: [], params: {}).to_h
+      config[:filters] = params[:filters].to_unsafe_h if params.key?(:filters)
+      config[:params] = params[:params]&.to_unsafe_h || {}
 
-      config = {}
       if params[:table_view_id]
+        view_lookup_table = Mensa.for_name(params[:id], config)
         @view = Mensa::TableView.find_by(table_name: params[:id], id: params[:table_view_id])
-        @view ||= @table.system_views.find { |v| v.id == params[:table_view_id].to_sym }
-        config = @view&.config&.deep_transform_keys(&:to_sym) if @view
+        @view ||= view_lookup_table.system_views.find { |v| v.id == params[:table_view_id].to_sym }
+        config = (@view&.config&.deep_transform_keys(&:to_sym) || {}).merge(config)
       end
 
-      config = config.merge(params.permit!.to_h)
-      config = config.merge(params.permit(:format, :query, :id, :page, :table_view_id, :turbo_frame_id, order: {}, column_order: [], hidden_columns: []).to_h)
-      config[:filters] = params[:filters]&.to_unsafe_h || config[:filters] || {}
-
       @table = Mensa.for_name(params[:id], config)
       @table.request = request
       @table.table_view = @view
       @table.original_view_context = helpers
 
       respond_to do |format|
-        format.turbo_stream # Used for filterering
-        format.html # You shouldn't get here
+        format.turbo_stream # Used for filtering
+        format.html
       end
     end
   end

data/app/helpers/mensa/application_helper.rb

@@ -1,7 +1,7 @@
 module Mensa
   module ApplicationHelper
-    def table(name, config = {}, **options)
-      component = ::Mensa::Table::Component.new(name, config, **options)
+    def table(name, params: {}, **options)
+      component = ::Mensa::Table::Component.new(name, params: params, **options)
       component.original_view_context = self
       render(component)
     end

data/app/jobs/mensa/export_job.rb

@@ -23,6 +23,7 @@ module Mensa
 
       data, filename, content_type = generate(table, export)
 
+      export.asset.purge if export.asset.attached?
       export.asset.attach(io: StringIO.new(data), filename: filename, content_type: content_type)
       finalize(export, status: "completed", filename: filename)
 
@@ -94,6 +95,9 @@ module Mensa
     def finalize(export, status:, filename: nil)
       attributes = {status: status}
       attributes[:filename] = filename if filename
+
+      attributes[:last_repeat_run_at] = Time.current if status == "completed" && export.repeat.present?
+
       export.update(attributes)
       # Refresh the export button badge (download count) and the downloads list
       # inside the export dialog for everyone viewing this table.

data/app/jobs/mensa/recurring_exports_job.rb

@@ -0,0 +1,17 @@
+module Mensa
+  # Sweeps recurring exports and re-enqueues any whose next scheduled run is due.
+  # This job is intended to be invoked by a daily cron entry or scheduler.
+  class RecurringExportsJob < ApplicationJob
+    queue_as :default
+
+    def perform(reference_time = Time.current)
+      reference_time = reference_time.in_time_zone if reference_time.respond_to?(:in_time_zone)
+
+      Mensa::Export.repeating.find_each do |export|
+        next unless export.repeat_due?(reference_time)
+
+        Mensa::ExportJob.perform_later(export)
+      end
+    end
+  end
+end

data/app/models/mensa/export.rb

@@ -7,17 +7,21 @@ module Mensa
     STATUSES = %w[pending processing completed failed].freeze
     FORMATS = %w[csv_excel plain_csv].freeze
     SCOPES = %w[all current_page].freeze
+    REPEATS = ["", "daily", "weekly", "monthly", "quarterly", "bi-yearly", "yearly"].freeze
 
     belongs_to :user, optional: true
     has_one_attached :asset
 
     validates :table_name, presence: true
     validates :status, inclusion: {in: STATUSES}
+    validates :repeat, inclusion: {in: REPEATS}
 
     scope :for_table, ->(table_name) { where(table_name: table_name.to_s) }
     scope :for_user, ->(user) { where(user_id: user.respond_to?(:id) ? user&.id : user) }
     scope :completed, -> { where(status: "completed") }
     scope :recent, -> { order(created_at: :desc) }
+    scope :repeating, -> { where.not(repeat: [nil, ""]) }
+    scope :with_downloadable_asset, -> { completed.joins(:asset_attachment).distinct }
 
     def completed?
       status == "completed"
@@ -35,15 +39,63 @@ module Mensa
       status == "pending"
     end
 
+    def next_repeat_run_at(from: nil)
+      return if repeat.blank?
+
+      anchor = from || last_repeat_run_at || created_at
+
+      case repeat
+      when "daily"
+        anchor + 1.day
+      when "weekly"
+        anchor + 1.week
+      when "monthly"
+        anchor.advance(months: 1)
+      when "quarterly"
+        anchor.advance(months: 3)
+      when "bi-yearly"
+        anchor.advance(months: 6)
+      when "yearly"
+        anchor.advance(years: 1)
+      end
+    end
+
+    def repeat_due?(reference_time = Time.current)
+      return false if repeat.blank? || pending? || processing?
+
+      next_run_at = next_repeat_run_at
+      next_run_at.present? && next_run_at <= reference_time
+    end
+
+    def repeating?
+      repeat.present?
+    end
+
+    def repeat_label
+      return if repeat.blank?
+
+      I18n.t(
+        "mensa.exports.repeats_with_interval",
+        default: "Repeats %{interval}",
+        interval: repeat_interval_label
+      )
+    end
+
+    def repeat_interval_label
+      return if repeat.blank?
+
+      I18n.t("mensa.exports.repeat_intervals.#{repeat}", default: repeat)
+    end
+
     # True once the asset is ready to be downloaded by the user.
     def downloadable?
       completed? && asset.attached?
     end
 
-    # Number of completed (downloadable) exports for a table/user combination.
+    # Number of currently-downloadable exports for a table/user combination.
     # This is the number rendered in the export button badge.
     def self.completed_count(table_name, user)
-      for_table(table_name).for_user(user).completed.count
+      for_table(table_name).for_user(user).with_downloadable_asset.count
     end
 
     # A stable, page-independent key identifying the exports of a table/user