memory_test_fix 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbbaf46755ac3025b3caa67313dfdd3f84e749faedd7e381fa21c12d7a1202da
-  data.tar.gz: 5265b0c883df03deb39a391713a1f085c2edb33c406c9d5ed1516b614db3198b
+  metadata.gz: b7b24810e0c8880d8ad864f5300722d79486e460ed6c1d2d9ad0156d65b3057e
+  data.tar.gz: 3aa965eecb3bb172bb352c2638ed5be9dee440a61c6590e806f90837e7ca9d7f
 SHA512:
-  metadata.gz: 8f95e587b55511535076f7edb1a061b9b0cd287cd04d315604e53601ff77c54519dd1c6f26c21fd2ac326ddcf523a40e9c8efd29ec6c76d0972c2a9cc83dac35
-  data.tar.gz: 5e9d1c624e2852dbb8f387de415061bbca5635bad6b9dc0d5f263b170b243683520d27cc61540a986c6f886ffa035d84809e265e2a6197af6bbfcd27597c5ed4
+  metadata.gz: 012e71481dabdd56e456d2f1620715ab681083ff0329ff0d7a647b8f6adc22601ed14f45c9776685447b49b39400e350f10701f8bc4f49018d20ba3a01f54c8b
+  data.tar.gz: f4e428be5627a989ffd99935e92788884f41aee0ccc015114e12b0f14a11a1a2f0f274a37ff56535f0d8d760739bff7164043ef5bdfd02dcf93757ae1a5d8d3d

data/Changelog.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 1.5.1 / 2018-02-14
+
+* Fix support for Rails 5.2: Handle Rails 5.2's repeated connection
+  establishment.
+
 ## 1.5.0 / 2018-02-14
 
 * Add support for Rails 5.2

data/fixtures/rails52_app/db/schema.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 # This file is auto-generated from the current state of the database. Instead
 # of editing this file, please use the migrations feature of Active Record to
 # incrementally modify your database, and then regenerate this schema definition.
@@ -11,10 +10,10 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20140830065127) do
+ActiveRecord::Schema.define(version: 2014_08_30_065127) do
 
   create_table "foos", force: :cascade do |t|
-    t.string   "name"
+    t.string "name"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
   end

data/lib/memory_test_fix.rb

@@ -3,7 +3,7 @@ require 'memory_test_fix/schema_loader'
 if defined?(Rails)
   require 'memory_test_fix/railtie.rb'
 
-  if Rails.version =~ /^4\.0\./
+  if Rails.version =~ /^5\.2\./
     ActiveRecord::Base.class_eval do
       def self.establish_connection(*_)
         super.tap do

data/lib/memory_test_fix/schema_file_loader.rb

@@ -4,7 +4,6 @@ module MemoryTestFix
   module SchemaFileLoader
     # Load the Rails schema file.
     def self.load_schema
-      # TODO: Use tooling provided by rails once support for Rails 3 is dropped.
       load "#{Rails.root}/db/schema.rb"
     end
   end

data/lib/memory_test_fix/schema_loader.rb

@@ -56,11 +56,11 @@ module MemoryTestFix
     end
 
     def silent?
-      verbosity == "silent"
+      verbosity == 'silent'
     end
 
     def quiet?
-      verbosity == "quiet"
+      verbosity == 'quiet'
     end
 
     def migrate
@@ -68,7 +68,7 @@ module MemoryTestFix
     end
 
     def inform_using_in_memory
-      puts "Creating sqlite :memory: database"
+      puts 'Creating sqlite :memory: database'
     end
 
     def load_schema

data/memory_test_fix.gemspec

@@ -1,38 +1,38 @@
 Gem::Specification.new do |spec|
-  spec.name = "memory_test_fix"
-  spec.version = "1.5.0"
+  spec.name = 'memory_test_fix'
+  spec.version = '1.5.1'
 
-  spec.authors = ["Matijs van Zuijlen",
-                  "Chris Roos",
-                  "Geoffrey Grosenbach",
-                  "Kakutani Shintaro",
-                  "Erik Hanson and Matt Scilipoti",
-                  "Greg Weber",
-                  "Stephan Zalewski"]
-  spec.email = "matijs@matijs.net"
-  spec.homepage = "http://wiki.github.com/mvz/memory_test_fix"
+  spec.authors = ['Matijs van Zuijlen',
+                  'Chris Roos',
+                  'Geoffrey Grosenbach',
+                  'Kakutani Shintaro',
+                  'Erik Hanson and Matt Scilipoti',
+                  'Greg Weber',
+                  'Stephan Zalewski']
+  spec.email = 'matijs@matijs.net'
+  spec.homepage = 'http://wiki.github.com/mvz/memory_test_fix'
 
-  spec.license = "MIT"
+  spec.license = 'MIT'
 
-  spec.summary = "Use SQLite3 in-memory database for Rails tests."
+  spec.summary = 'Use SQLite3 in-memory database for Rails tests.'
   spec.description = <<-TEXT
     Makes use of SQLite3 in-memory database possible for your
     Rails tests by preloading the schema.
   TEXT
   spec.required_ruby_version = '>= 2.2.0'
 
-  spec.files = Dir["{lib,test,spec,fixtures}/**/*",
-                   "*.md",
-                   "*.gemspec",
-                   "Rakefile",
-                   "Gemfile"] & `git ls-files -z`.split("\0")
+  spec.files = Dir['{lib,test,spec,fixtures}/**/*',
+                   '*.md',
+                   '*.gemspec',
+                   'Rakefile',
+                   'Gemfile'] & `git ls-files -z`.split("\0")
 
-  spec.rdoc_options = ["--main", "README.md"]
-  spec.extra_rdoc_files = ["README.md"]
+  spec.rdoc_options = ['--main', 'README.md']
+  spec.extra_rdoc_files = ['README.md']
 
-  spec.add_runtime_dependency("activerecord", "~> 5.0")
-  spec.add_runtime_dependency("railties", "~> 5.0")
-  spec.add_development_dependency("minitest", "~> 5.2")
-  spec.add_development_dependency("rake", "~> 12.0")
-  spec.add_development_dependency("rspec", "~> 3.1")
+  spec.add_runtime_dependency('activerecord', '~> 5.0')
+  spec.add_runtime_dependency('railties', '~> 5.0')
+  spec.add_development_dependency('minitest', '~> 5.2')
+  spec.add_development_dependency('rake', '~> 12.0')
+  spec.add_development_dependency('rspec', '~> 3.1')
 end

data/spec/unit/memory_test_fix/schema_loader_spec.rb

@@ -29,11 +29,11 @@ RSpec.describe MemoryTestFix::SchemaLoader do
     context 'when no in-memory database is configured' do
       let(:config) { { database: 'some/file.sqlite3', adapter: 'sqlite3' } }
 
-      it "outputs nothing" do
+      it 'outputs nothing' do
         expect { schema_loader.init_schema }.not_to output.to_stdout
       end
 
-      it "does not load anything" do
+      it 'does not load anything' do
         schema_loader.init_schema
         expect(loader).not_to have_received :load_schema
       end
@@ -42,26 +42,26 @@ RSpec.describe MemoryTestFix::SchemaLoader do
     context 'when configured not to use migrations' do
       let(:config) { base_config }
 
-      it "informs the user it is creating an in-memory database" do
+      it 'informs the user it is creating an in-memory database' do
         expect { schema_loader.init_schema }.
           to output(/Creating sqlite :memory: database/).to_stdout
       end
 
-      it "prints the output from the loader" do
+      it 'prints the output from the loader' do
         expect { schema_loader.init_schema }.
           to output(/loading schema/).to_stdout
       end
 
-      it "tells the loader to load the schema" do
+      it 'tells the loader to load the schema' do
         silently { schema_loader.init_schema }
         expect(loader).to have_received :load_schema
       end
     end
 
-    context "when configured to use migrations" do
+    context 'when configured to use migrations' do
       let(:config) { base_config.merge(migrate: true) }
 
-      it "informs the user it is creating an in-memory database" do
+      it 'informs the user it is creating an in-memory database' do
         expect { schema_loader.init_schema }.
           to output(/Creating sqlite :memory: database/).to_stdout
       end
@@ -71,30 +71,30 @@ RSpec.describe MemoryTestFix::SchemaLoader do
           not_to output(/loading schema/).to_stdout
       end
 
-      it "tells the migrator to run the migrations" do
+      it 'tells the migrator to run the migrations' do
         silently { schema_loader.init_schema }
         expect(migrator).to have_received :up
       end
     end
 
-    context "when running in quietly" do
+    context 'when running in quietly' do
       let(:config) { base_config.merge(verbosity: 'quiet') }
 
-      it "informs the user it is creating an in-memory database" do
+      it 'informs the user it is creating an in-memory database' do
         expect { schema_loader.init_schema }.
           to output(/Creating sqlite :memory: database/).to_stdout
       end
 
-      it "does not print the output from the loader" do
+      it 'does not print the output from the loader' do
         expect { schema_loader.init_schema }.
           not_to output(/loading schema/).to_stdout
       end
     end
 
-    context "when running in silence" do
+    context 'when running in silence' do
       let(:config) { base_config.merge(verbosity: 'silent') }
 
-      it "outputs nothing" do
+      it 'outputs nothing' do
         expect { schema_loader.init_schema }.not_to output.to_stdout
       end
     end

data/test/integration/integration_test.rb

@@ -18,7 +18,7 @@ def run_tests(command_array = %w(bundle exec rake))
     result = in_clean_bundler_environment(*command_array)
   end
   # If the command failed, make it print any error messages
-  err.must_equal "" unless result
+  err.must_equal '' unless result
   out
 end
 
@@ -29,20 +29,20 @@ def stop_spring
 end
 
 BASE_CONFIG = {
-  "development" =>  {
-    "adapter" =>  'sqlite3',
-    "pool" =>  5,
-    "timeout" =>  5000,
-    "database" =>  'db/development.sqlite3'
+  'development' =>  {
+    'adapter' =>  'sqlite3',
+    'pool' =>  5,
+    'timeout' =>  5000,
+    'database' =>  'db/development.sqlite3'
   },
-  "test" =>  {
-    "adapter" =>  'sqlite3',
-    "database" =>  ':memory:'
+  'test' =>  {
+    'adapter' =>  'sqlite3',
+    'database' =>  ':memory:'
   }
 }.freeze
 
 MIGRATING_CONFIG = BASE_CONFIG.dup.tap do |config|
-  config["test"] = config["test"].merge("migrate" => true)
+  config['test'] = config['test'].merge('migrate' => true)
 end
 
 def create_db_config_without_migrations
@@ -58,9 +58,9 @@ def create_db_config_with_migrations
 end
 
 VERSIONS = [
-  ["Rails 5.0", 'rails50_app'],
-  ["Rails 5.1", 'rails51_app'],
-  ["Rails 5.2", 'rails52_app'],
+  ['Rails 5.0', 'rails50_app'],
+  ['Rails 5.1', 'rails51_app'],
+  ['Rails 5.2', 'rails52_app']
 ].freeze
 
 VERSIONS.each do |label, appdir|
@@ -69,43 +69,47 @@ VERSIONS.each do |label, appdir|
   end
 
   describe "A #{label} app using memory_test_fix" do
-    it "can run its tests in-memory without migrations" do
+    it 'can run its tests in-memory without migrations' do
       Dir.chdir "fixtures/#{appdir}" do
         create_db_config_without_migrations
         out = run_tests
         out.must_match(/Creating sqlite :memory: database/)
         out.wont_match(/migrating/)
+        out.must_match(/2 runs, 2 assertions, 0 failures, 0 errors, 0 skips/)
       end
     end
 
-    it "can run its tests in-memory with migrations" do
+    it 'can run its tests in-memory with migrations' do
       Dir.chdir "fixtures/#{appdir}" do
         create_db_config_with_migrations
         out = run_tests
         out.must_match(/Creating sqlite :memory: database/)
         out.must_match(/migrating/)
+        out.must_match(/2 runs, 2 assertions, 0 failures, 0 errors, 0 skips/)
       end
     end
 
     describe 'when using spring' do
       let(:command_array) { %w(bin/rake) }
-      it "can run its tests in-memory without migrations" do
+      it 'can run its tests in-memory without migrations' do
         Dir.chdir "fixtures/#{appdir}" do
           stop_spring
           create_db_config_without_migrations
           out = run_tests command_array
           out.must_match(/Creating sqlite :memory: database/)
           out.wont_match(/migrating/)
+          out.must_match(/2 runs, 2 assertions, 0 failures, 0 errors, 0 skips/)
         end
       end
 
-      it "can run its tests in-memory with migrations" do
+      it 'can run its tests in-memory with migrations' do
         Dir.chdir "fixtures/#{appdir}" do
           stop_spring
           create_db_config_with_migrations
           out = run_tests command_array
           out.must_match(/Creating sqlite :memory: database/)
           out.must_match(/migrating/)
+          out.must_match(/2 runs, 2 assertions, 0 failures, 0 errors, 0 skips/)
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: memory_test_fix
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Matijs van Zuijlen