memory_test_fix 1.4.2 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e61644658f57f5842df48c9474e0b14af9e44b61
-  data.tar.gz: f336ed05d3fb0d75a8218b88b1da6ea4be11f73a
+SHA256:
+  metadata.gz: dbbaf46755ac3025b3caa67313dfdd3f84e749faedd7e381fa21c12d7a1202da
+  data.tar.gz: 5265b0c883df03deb39a391713a1f085c2edb33c406c9d5ed1516b614db3198b
 SHA512:
-  metadata.gz: c96f54b41ff3dfc9928d665debfad734bd7d4b1c1f50662d516e70c2998b401360188caf554fe420dc7d2495547b4dd421f33bf3215189cd1d2a0618da0b4a64
-  data.tar.gz: 7be2a625d38ee7baa03b293063225966ceb484dac3f3e4878d7043883c94970ff228ba6c4a093ae410df08d3bd329b6f8784ccadc6a24910d54cb2b593349cf5
+  metadata.gz: 8f95e587b55511535076f7edb1a061b9b0cd287cd04d315604e53601ff77c54519dd1c6f26c21fd2ac326ddcf523a40e9c8efd29ec6c76d0972c2a9cc83dac35
+  data.tar.gz: 5e9d1c624e2852dbb8f387de415061bbca5635bad6b9dc0d5f263b170b243683520d27cc61540a986c6f886ffa035d84809e265e2a6197af6bbfcd27597c5ed4

data/Changelog.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.5.0 / 2018-02-14
+
+* Add support for Rails 5.2
+
 ## 1.4.2 / 2017-04-28
 
 * Update dependencies to allow use with Rails 5.1

data/README.md

@@ -46,7 +46,8 @@ You can also use this with other (testing) environments, not just 'test'.
 In general, Bundler should pick a compatible version for you if you don't
 specify one in your `Gemfile`.
 
-That said, the latest version of this gem is compatible with Rails 5.0 and 5.1.
+That said, the latest version of this gem is compatible with Rails 5.0, 5.1 and
+upcoming 5.2.
 If you're still on Rails 4, you can use version 1.3.0. Unfortunately, the hard
 requirement of Ruby 2.2 or above for Rails 5 means `memory_test_fix` cannot
 support Rails 4 and 5 at the same time.

data/fixtures/rails52_app/Gemfile

@@ -0,0 +1,10 @@
+source 'https://rubygems.org'
+
+gem 'rails', '~> 5.2.0.rc1'
+gem 'sqlite3', platform: :ruby
+gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby
+gem 'memory_test_fix', path: '../..'
+
+group :development do
+  gem 'spring'
+end

data/fixtures/rails52_app/Rakefile

@@ -0,0 +1,6 @@
+# Add your own tasks in files placed in lib/tasks ending in .rake,
+# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
+
+require_relative 'config/application'
+
+Rails.application.load_tasks

data/fixtures/rails52_app/app/models/application_record.rb

@@ -0,0 +1,3 @@
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end

data/fixtures/rails52_app/app/models/foo.rb

@@ -0,0 +1,2 @@
+class Foo < ApplicationRecord
+end

data/fixtures/rails52_app/bin/rake

@@ -0,0 +1,9 @@
+#!/usr/bin/env ruby
+begin
+  load File.expand_path('../spring', __FILE__)
+rescue LoadError => e
+  raise unless e.message.include?('spring')
+end
+require_relative '../config/boot'
+require 'rake'
+Rake.application.run

data/fixtures/rails52_app/bin/spring

@@ -0,0 +1,17 @@
+#!/usr/bin/env ruby
+
+# This file loads spring without using Bundler, in order to be fast.
+# It gets overwritten when you run the `spring binstub` command.
+
+unless defined?(Spring)
+  require 'rubygems'
+  require 'bundler'
+
+  lockfile = Bundler::LockfileParser.new(Bundler.default_lockfile.read)
+  spring = lockfile.specs.detect { |spec| spec.name == "spring" }
+  if spring
+    Gem.use_paths Gem.dir, Bundler.bundle_path.to_s, *Gem.path
+    gem 'spring', spring.version
+    require 'spring/binstub'
+  end
+end

data/fixtures/rails52_app/config/application.rb

@@ -0,0 +1,13 @@
+require_relative 'boot'
+
+require 'rails'
+require 'active_record/railtie'
+require 'rails/test_unit/railtie'
+
+Bundler.require(*Rails.groups)
+
+module RailsTestApp
+  class Application < Rails::Application
+    config.load_defaults 5.2
+  end
+end

data/fixtures/rails52_app/config/boot.rb

@@ -0,0 +1,3 @@
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
+
+require 'bundler/setup' # Set up gems listed in the Gemfile.

data/fixtures/rails52_app/config/environment.rb

@@ -0,0 +1,5 @@
+# Load the Rails application.
+require_relative 'application'
+
+# Initialize the Rails application.
+Rails.application.initialize!

data/fixtures/rails52_app/config/environments/development.rb

@@ -0,0 +1,3 @@
+Rails.application.configure do
+  config.eager_load = false
+end

data/fixtures/rails52_app/config/environments/production.rb

@@ -0,0 +1,3 @@
+Rails.application.configure do
+  config.eager_load = true
+end

data/fixtures/rails52_app/config/environments/test.rb

@@ -0,0 +1,5 @@
+Rails.application.configure do
+  config.eager_load = false
+  config.active_support.test_order = :random
+  config.active_support.deprecation = :stderr
+end

data/fixtures/rails52_app/config/initializers/filter_parameter_logging.rb

@@ -0,0 +1 @@
+Rails.application.config.filter_parameters += [:password]

data/fixtures/rails52_app/db/migrate/20140830065127_create_foos.rb

@@ -0,0 +1,13 @@
+class CreateFoos < ActiveRecord::Migration[5.1]
+  def self.up
+    create_table :foos do |t|
+      t.string :name
+
+      t.timestamps null: false
+    end
+  end
+
+  def self.down
+    drop_table :foos
+  end
+end

data/fixtures/rails52_app/db/schema.rb

@@ -0,0 +1,22 @@
+# encoding: UTF-8
+# This file is auto-generated from the current state of the database. Instead
+# of editing this file, please use the migrations feature of Active Record to
+# incrementally modify your database, and then regenerate this schema definition.
+#
+# Note that this schema.rb definition is the authoritative source for your
+# database schema. If you need to create the application database on another
+# system, you should be using db:schema:load, not running all the migrations
+# from scratch. The latter is a flawed and unsustainable approach (the more migrations
+# you'll amass, the slower it'll run and the greater likelihood for issues).
+#
+# It's strongly recommended that you check this file into your version control system.
+
+ActiveRecord::Schema.define(version: 20140830065127) do
+
+  create_table "foos", force: :cascade do |t|
+    t.string   "name"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+
+end

data/fixtures/rails52_app/test/fixtures/foos.yml

@@ -0,0 +1,7 @@
+# Read about fixtures at http://ar.rubyonrails.org/classes/Fixtures.html
+
+one:
+  name: Foo one
+
+two:
+  name: Foo two

data/fixtures/rails52_app/test/models/foo_test.rb

@@ -0,0 +1,13 @@
+require 'test_helper'
+
+class FooTest < ActiveSupport::TestCase
+  test "Foos have names" do
+    assert_equal 'Foo one', foos(:one).name
+  end
+
+  test "Foos can be stored" do
+    foo = Foo.new(name: 'A third')
+    foo.save!
+    assert_equal 'A third', Foo.find(foo.id).name
+  end
+end

data/fixtures/rails52_app/test/test_helper.rb

@@ -0,0 +1,10 @@
+ENV['RAILS_ENV'] ||= 'test'
+require_relative '../config/environment'
+require 'rails/test_help'
+
+class ActiveSupport::TestCase
+  # Setup all fixtures in test/fixtures/*.yml for all tests in alphabetical order.
+  fixtures :all
+
+  # Add more helper methods to be used by all tests here...
+end

data/lib/memory_test_fix/schema_loader.rb

@@ -1,4 +1,5 @@
 require 'memory_test_fix/schema_file_loader'
+require 'active_record'
 
 module MemoryTestFix
   # Set up database schema into in-memory database.
@@ -72,7 +73,11 @@ module MemoryTestFix
 
     def load_schema
       if migrate
-        @migrator.up('db/migrate')
+        if @migrator.respond_to? :up
+          @migrator.up('db/migrate')
+        else
+          ActiveRecord::Base.connection.migration_context.up
+        end
       else
         @loader.load_schema
       end

data/memory_test_fix.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name = "memory_test_fix"
-  spec.version = "1.4.2"
+  spec.version = "1.5.0"
 
   spec.authors = ["Matijs van Zuijlen",
                   "Chris Roos",
@@ -15,10 +15,11 @@ Gem::Specification.new do |spec|
   spec.license = "MIT"
 
   spec.summary = "Use SQLite3 in-memory database for Rails tests."
-  spec.description = <<-END
+  spec.description = <<-TEXT
     Makes use of SQLite3 in-memory database possible for your
     Rails tests by preloading the schema.
-  END
+  TEXT
+  spec.required_ruby_version = '>= 2.2.0'
 
   spec.files = Dir["{lib,test,spec,fixtures}/**/*",
                    "*.md",
@@ -29,9 +30,9 @@ Gem::Specification.new do |spec|
   spec.rdoc_options = ["--main", "README.md"]
   spec.extra_rdoc_files = ["README.md"]
 
-  spec.add_runtime_dependency("railties", "~> 5.0")
   spec.add_runtime_dependency("activerecord", "~> 5.0")
-  spec.add_development_dependency("rake", "~> 12.0")
+  spec.add_runtime_dependency("railties", "~> 5.0")
   spec.add_development_dependency("minitest", "~> 5.2")
+  spec.add_development_dependency("rake", "~> 12.0")
   spec.add_development_dependency("rspec", "~> 3.1")
 end

data/spec/unit/memory_test_fix/schema_loader_spec.rb

@@ -15,10 +15,11 @@ RSpec.describe MemoryTestFix::SchemaLoader do
   end
 
   describe '#init_schema' do
-    let(:migrator) { double(:migrator) }
-    let(:loader) { double(:loader) }
+    let(:migrator) { class_double(ActiveRecord::Migrator) }
+    let(:loader) { class_double(MemoryTestFix::SchemaFileLoader) }
     let(:options) { { configuration: config, migrator: migrator, loader: loader } }
-    let(:schema_loader) { MemoryTestFix::SchemaLoader.new options }
+    let(:schema_loader) { described_class.new options }
+    let(:base_config) { { database: ':memory:', adapter: 'sqlite3' } }
 
     before do
       allow(loader).to receive(:load_schema) { puts 'loading schema' }
@@ -29,17 +30,16 @@ RSpec.describe MemoryTestFix::SchemaLoader do
       let(:config) { { database: 'some/file.sqlite3', adapter: 'sqlite3' } }
 
       it "outputs nothing" do
-        expect { schema_loader.init_schema }.to_not output.to_stdout
+        expect { schema_loader.init_schema }.not_to output.to_stdout
       end
 
       it "does not load anything" do
         schema_loader.init_schema
-        expect(loader).to_not have_received :load_schema
+        expect(loader).not_to have_received :load_schema
       end
     end
 
-    context 'when an in-memory database is configured' do
-      let(:base_config) { { database: ':memory:', adapter: 'sqlite3' } }
+    context 'when configured not to use migrations' do
       let(:config) { base_config }
 
       it "informs the user it is creating an in-memory database" do
@@ -56,36 +56,46 @@ RSpec.describe MemoryTestFix::SchemaLoader do
         silently { schema_loader.init_schema }
         expect(loader).to have_received :load_schema
       end
+    end
+
+    context "when configured to use migrations" do
+      let(:config) { base_config.merge(migrate: true) }
 
-      context "when configured to use migrations" do
-        let(:config) { base_config.merge(migrate: true) }
+      it "informs the user it is creating an in-memory database" do
+        expect { schema_loader.init_schema }.
+          to output(/Creating sqlite :memory: database/).to_stdout
+      end
+
+      it "does not print 'loading schema'" do
+        expect { schema_loader.init_schema }.
+          not_to output(/loading schema/).to_stdout
+      end
 
-        it "tells the migrator to run the migrations" do
-          silently { schema_loader.init_schema }
-          expect(migrator).to have_received :up
-        end
+      it "tells the migrator to run the migrations" do
+        silently { schema_loader.init_schema }
+        expect(migrator).to have_received :up
       end
+    end
 
-      context "when running in quietly" do
-        let(:config) { base_config.merge(verbosity: 'quiet') }
+    context "when running in quietly" do
+      let(:config) { base_config.merge(verbosity: 'quiet') }
 
-        it "informs the user it is creating an in-memory database" do
-          expect { schema_loader.init_schema }.
-            to output(/Creating sqlite :memory: database/).to_stdout
-        end
+      it "informs the user it is creating an in-memory database" do
+        expect { schema_loader.init_schema }.
+          to output(/Creating sqlite :memory: database/).to_stdout
+      end
 
-        it "does not print the output from the loader" do
-          expect { schema_loader.init_schema }.
-            not_to output(/loading schema/).to_stdout
-        end
+      it "does not print the output from the loader" do
+        expect { schema_loader.init_schema }.
+          not_to output(/loading schema/).to_stdout
       end
+    end
 
-      context "when running in silence" do
-        let(:config) { base_config.merge(verbosity: 'silent') }
+    context "when running in silence" do
+      let(:config) { base_config.merge(verbosity: 'silent') }
 
-        it "outputs nothing" do
-          expect { schema_loader.init_schema }.to_not output.to_stdout
-        end
+      it "outputs nothing" do
+        expect { schema_loader.init_schema }.not_to output.to_stdout
       end
     end
   end

data/test/integration/integration_test.rb

@@ -6,9 +6,9 @@ def in_clean_bundler_environment(*args)
 end
 
 def update_bundle(label)
-  return if in_clean_bundler_environment(*%w(bundle update --quiet --local))
+  return if in_clean_bundler_environment('bundle', 'update', '--quiet', '--local')
   puts "Starting remote update of the bundle for #{label}"
-  return if in_clean_bundler_environment(*%w(bundle update))
+  return if in_clean_bundler_environment('bundle', 'update')
   raise "Unable to initialize test environment for #{label}"
 end
 
@@ -24,7 +24,7 @@ end
 
 def stop_spring
   capture_subprocess_io do
-    in_clean_bundler_environment(*%w(bin/spring stop))
+    in_clean_bundler_environment('bin/spring', 'stop')
   end
 end
 
@@ -39,7 +39,7 @@ BASE_CONFIG = {
     "adapter" =>  'sqlite3',
     "database" =>  ':memory:'
   }
-}
+}.freeze
 
 MIGRATING_CONFIG = BASE_CONFIG.dup.tap do |config|
   config["test"] = config["test"].merge("migrate" => true)
@@ -60,7 +60,8 @@ end
 VERSIONS = [
   ["Rails 5.0", 'rails50_app'],
   ["Rails 5.1", 'rails51_app'],
-]
+  ["Rails 5.2", 'rails52_app'],
+].freeze
 
 VERSIONS.each do |label, appdir|
   Dir.chdir "fixtures/#{appdir}" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: memory_test_fix
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.5.0
 platform: ruby
 authors:
 - Matijs van Zuijlen
@@ -14,10 +14,10 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-28 00:00:00.000000000 Z
+date: 2018-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -31,7 +31,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -45,33 +45,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '5.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -135,6 +135,24 @@ files:
 - fixtures/rails51_app/test/fixtures/foos.yml
 - fixtures/rails51_app/test/test_helper.rb
 - fixtures/rails51_app/test/unit/foo_test.rb
+- fixtures/rails52_app/Gemfile
+- fixtures/rails52_app/Rakefile
+- fixtures/rails52_app/app/models/application_record.rb
+- fixtures/rails52_app/app/models/foo.rb
+- fixtures/rails52_app/bin/rake
+- fixtures/rails52_app/bin/spring
+- fixtures/rails52_app/config/application.rb
+- fixtures/rails52_app/config/boot.rb
+- fixtures/rails52_app/config/environment.rb
+- fixtures/rails52_app/config/environments/development.rb
+- fixtures/rails52_app/config/environments/production.rb
+- fixtures/rails52_app/config/environments/test.rb
+- fixtures/rails52_app/config/initializers/filter_parameter_logging.rb
+- fixtures/rails52_app/db/migrate/20140830065127_create_foos.rb
+- fixtures/rails52_app/db/schema.rb
+- fixtures/rails52_app/test/fixtures/foos.yml
+- fixtures/rails52_app/test/models/foo_test.rb
+- fixtures/rails52_app/test/test_helper.rb
 - lib/memory_test_fix.rb
 - lib/memory_test_fix/railtie.rb
 - lib/memory_test_fix/schema_file_loader.rb
@@ -158,7 +176,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -166,7 +184,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Use SQLite3 in-memory database for Rails tests.