memory-profiler 1.1.11 → 1.1.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1237585b03f1c87b2c4cafb01668200bc33d518c35f832539315a7f6f37dc4f2
-  data.tar.gz: 13a79c36183a794df061076e3e09dd2a8a1e14eadfcdb0dc5e3317a6902f622c
+  metadata.gz: 2cc3a03e3b76e232615954217c88c54d2077da267793f79c9b5dc5d8463398f6
+  data.tar.gz: 29466a48c28857d7093156c80072dc3cba66420275b307cb2fea64102ece2624
 SHA512:
-  metadata.gz: 98c104bac6001ec5cde21d984a80a69ac992a113677ea672a81d1d1e468e754331f1170ea58c3a6ba8f1fe4a453ec669d143f7af71ab797e0d206a50bd8bbe8a
-  data.tar.gz: 2bf799367a7cd59a760f52c89f8da0ab3ee252867bdcca431ca9340349172bcf0962f626f4cada76fcfd721084fb8de8dbe0d8692eb9593a5b4a56f625587436
+  metadata.gz: 9171990674d31df2af4daa7ed082b696ce1a093cb8f83ba6bab1d82ed1ef2704bb3cb4aef48758db7ba6b815e8729483d8b2124f3f687a77f3029400e1e3bb7b
+  data.tar.gz: 4f4845133c13fe67caa4641df912280983d05f4c6e0fca324b0827f0ffbbd040710670e9d3cd1ef6e6ab7d61bbbe22334f89ffbf4286652f4d4e361891f2dfb5

data/ext/memory/profiler/allocations.c

@@ -12,8 +12,9 @@ static VALUE Memory_Profiler_Allocations = Qnil;
 
 // Helper to mark states table (object => state)
 static int Memory_Profiler_Allocations_states_mark(st_data_t key, st_data_t value, st_data_t arg) {
-	// Don't mark the object key (weak reference - don't keep objects alive)
-	// Mark the state value
+	// We don't want the key to move - we can't rehash the table if it does.
+	rb_gc_mark((VALUE)key);
+	
 	VALUE state = (VALUE)value;
 	rb_gc_mark_movable(state);
 	return ST_CONTINUE;
@@ -27,19 +28,7 @@ static int Memory_Profiler_Allocations_states_foreach(st_data_t key, st_data_t v
 
 // Replace callback for st_foreach_with_replace to update states during compaction
 static int Memory_Profiler_Allocations_states_compact(st_data_t *key, st_data_t *value, st_data_t data, int existing) {
-	// Key is object (VALUE) - we can't update if it moved (would require rehashing/allocation)
-	VALUE old_state = (VALUE)*value;
-	VALUE new_state = rb_gc_location(old_state);
-	
-	// NOTE: We can't update object keys if they moved (would require rehashing/allocation).
-	// This means lookups may fail after compaction for moved objects.
-	// This is acceptable - FREEOBJ will simply not find the state and skip the callback.
-	// The state will be cleaned up when Allocations is freed/cleared.
-	
-	// Update state value if it moved (this is safe, doesn't rehash)
-	if (old_state != new_state) {
-		*value = (st_data_t)new_state;
-	}
+	*value = (st_data_t)rb_gc_location((VALUE)*value);
 	
 	return ST_CONTINUE;
 }

data/ext/memory/profiler/capture.c

@@ -302,10 +302,18 @@ static void Memory_Profiler_Capture_event_callback(VALUE data, void *ptr) {
 		// Skip NEWOBJ if disabled (during callback) to prevent infinite recursion
 		if (capture->paused) return;
 		
+		// It's safe to unconditionally call here:
+		object = rb_obj_id(object);
+
 		Memory_Profiler_Events_enqueue(MEMORY_PROFILER_EVENT_TYPE_NEWOBJ, data, klass, object);
 	} else if (event_flag == RUBY_INTERNAL_EVENT_FREEOBJ) {
-		// Always process FREEOBJ to ensure state cleanup
-		Memory_Profiler_Events_enqueue(MEMORY_PROFILER_EVENT_TYPE_FREEOBJ, data, klass, object);
+		// We only care about objects that have been seen before (i.e. have an object ID):
+		if (RB_FL_TEST(object, FL_SEEN_OBJ_ID)) {
+			// It's only safe to call here if the object already has an object ID.
+			object = rb_obj_id(object);
+			
+			Memory_Profiler_Events_enqueue(MEMORY_PROFILER_EVENT_TYPE_FREEOBJ, data, klass, object);
+		}
 	}
 }
 

data/ext/memory/profiler/events.c

@@ -136,12 +136,7 @@ static void Memory_Profiler_Events_compact_queue(struct Memory_Profiler_Queue *q
 		// Update all VALUEs if they moved during compaction:
 		event->capture = rb_gc_location(event->capture);
 		event->klass = rb_gc_location(event->klass);
-		
-		// For NEWOBJ: update object pointer if it moved
-		// For FREEOBJ: DON'T update (object is being freed, pointer is stale)
-		if (event->type == MEMORY_PROFILER_EVENT_TYPE_NEWOBJ) {
-			event->object = rb_gc_location(event->object);
-		}
+		event->object = rb_gc_location(event->object);
 	}
 }
 

data/lib/memory/profiler/sampler.rb

@@ -4,6 +4,7 @@
 # Copyright, 2025, by Samuel Williams.
 
 require "console"
+require "objspace"
 
 require_relative "capture"
 require_relative "call_tree"
@@ -146,15 +147,18 @@ module Memory
 			# @parameter interval [Numeric] Seconds between samples.
 			# @yields {|sample| ...} Called when a class shows significant growth.
 			def run(interval: 60, &block)
-				start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-				
 				while true
+					start_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+					
 					sample!(&block)
 					
+					# Log capture statistics to detect issues like missing FREEOBJ events:
+					Console.info(self, "Capture statistics:", statistics: @capture.statistics, object_space: ::ObjectSpace.count_objects)
+					
+					# Sleep for the remainder of the interval:
 					now = Process.clock_gettime(Process::CLOCK_MONOTONIC)
 					delta = interval - (now - start_time)
 					sleep(delta) if delta > 0
-					start_time = now
 				end
 			end
 			

data/lib/memory/profiler/version.rb

@@ -7,7 +7,7 @@
 module Memory
 	# @namespace
 	module Profiler
-		VERSION = "1.1.11"
+		VERSION = "1.1.13"
 	end
 end
 

data/readme.md

@@ -22,6 +22,15 @@ Please see the [project documentation](https://socketry.github.io/memory-profile
 
 Please see the [project releases](https://socketry.github.io/memory-profiler/releases/index) for all releases.
 
+### v1.1.13
+
+  - Fix sampler loop interval handling.
+  - Log capture statistics from sampler run loop.
+
+### v1.1.12
+
+  - Use `rb_obj_id` for tracking object states to avoid compaction issues.
+
 ### v1.1.11
 
   - Double buffer shared events queues to fix queue corruption.
@@ -61,10 +70,6 @@ Please see the [project releases](https://socketry.github.io/memory-profiler/rel
 
   - Fix handling of GC compaction (I hope).
 
-### v0.1.0
-
-  - Initial implementation.
-
 ## Contributing
 
 We welcome contributions to this project.

data/releases.md

@@ -1,5 +1,14 @@
 # Releases
 
+## v1.1.13
+
+  - Fix sampler loop interval handling.
+  - Log capture statistics from sampler run loop.
+
+## v1.1.12
+
+  - Use `rb_obj_id` for tracking object states to avoid compaction issues.
+
 ## v1.1.11
 
   - Double buffer shared events queues to fix queue corruption.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: memory-profiler
 version: !ruby/object:Gem::Version
-  version: 1.1.11
+  version: 1.1.13
 platform: ruby
 authors:
 - Samuel Williams