memoized_inflectors 1.0.0.pre.beta.2 → 1.0.0.pre.beta.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d8f52803c9ce34f7ba6240f090fb715457b09639
-  data.tar.gz: 492c4a7d13166a9cb3a36fd6419ac22a8b7e912b
+  metadata.gz: d75ec47e89b1a793c642361840b36abd715bc591
+  data.tar.gz: 71890ca96c1bb6cc8d268250fb1e289bbf162399
 SHA512:
-  metadata.gz: 4b60e5f073cc48607e21207138d6ac0f9c9f0e02cb94d4841bfc9f21528239a250e4e1f5d8c0ed512e7fadcf9a7e8f258d500fd3b68242afe41f7be349367328
-  data.tar.gz: 042e921b89e2ad34ca6cb3469fc4325d9acfdd05bc26e05e50c7ef6a9fcc10f2d554bb927afe15537665bd2245c35bc2940474f33dc7f95d3cfcd483199e07c1
+  metadata.gz: 872c46644d278547a6b51f1eab7be2869b488d80b280d3ed094a4270c7e697ed5a06ba266ea891153f4ea58b3c7756a35f1fdfa29d5b1bbca949f41473db2b81
+  data.tar.gz: d3ec9a2c722ad461483903b934a3b4d6871144786cf5288b71042458e6a2dc652144999575c6b8633f933e6138aac94a1874d34d417cf0d1352c9ab4a1eae528

data/lib/memoized_inflectors/string_methods.rb

@@ -8,24 +8,48 @@ module MemoizedInflectors
         pluralize  singularize tableize  titleize
         to_param   underscore
       ].freeze,
-      *DUP_UNSAFE_INFLECTORS = %i[constantize safe_constantize].freeze
+      *CLASS_INFLECTORS = %i[constantize safe_constantize].freeze  # Inflectors which return class objects need to be specially handled.
     ]
 
+    def self.sanitize_for_key(s, inflector)
+      # the class inflectors do not differentiate between names beginning with the
+      # root namespace prefix (::) and those without.
+      #
+      if CLASS_INFLECTORS.include?(inflector)
+        s.sub(/\A:*/, "")
+      else
+        s
+      end
+    end
+
+    # TODO: Create separate methods for class inflectors??? *
     # Define an instance method for each inflector, e.g. `signularize`, `constantize`, etc.
     (INFLECTORS | ::ActiveSupport::Inflector.instance_methods).each do |inflector|
       define_method(inflector) do |*args|
         return super(*args) if ::MemoizedInflectors.disabled
         cache = ::MemoizedInflectors.cache_for(inflector)
-        key = ::MemoizedInflectors.key_for(self, *args)
+        key = ::MemoizedInflectors.key_for(
+          ::MemoizedInflectors::StringMethods.sanitize_for_key(self, inflector),
+          *args
+        )
 
         result =
           if cache.has_key?(key)
             cache[key]
           else
-            cache[key] = super(*args)
+            # Result is not cached. First fetch the result by calling the super method.
+            result = super(*args)
+
+            # Cache the result unless the result is nil and the inflector result is
+            # expected to be a class. The reason for the exception is that return
+            # value of `safe_constantize` may change from `nil` to another value.
+            # If constants are removed then it is recommended that you clear the
+            # caches for `constantize` and `safe_constantize`
+            cache[key] = result unless result.nil? && CLASS_INFLECTORS.include?(inflector)
           end
 
-        (DUP_UNSAFE_INFLECTORS.include?(inflector) || result.nil?) ? result : result.dup
+        # It is not safe to dup classes and not possible to dup nil.
+        (CLASS_INFLECTORS.include?(inflector) || result.nil?) ? result : result.dup
       end
     end
   end

data/lib/memoized_inflectors/version.rb

@@ -1,3 +1,3 @@
 module MemoizedInflectors
-  VERSION = "1.0.0-beta.2"
+  VERSION = "1.0.0-beta.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: memoized_inflectors
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre.beta.2
+  version: 1.0.0.pre.beta.3
 platform: ruby
 authors:
 - WizardOfOgz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-18 00:00:00.000000000 Z
+date: 2016-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport