mememaster 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8a20b9bf0a78cc66a775814caa716fc736da9501
-  data.tar.gz: 2ec9a91b28d1b0e755b277ba9f180ee918e39d1f
+  metadata.gz: 2bcf13cc28b811ea862a086b245ba3afea86508a
+  data.tar.gz: 7d7d3978c858911c49f4e12d43c530f2f11113f9
 SHA512:
-  metadata.gz: d00fcef90e24154d2bd8866dbe3c6cbe92223830b66b98206ac8ef1d1d41a0bf2b80c353805cf098156f7520bfa31d9e3ec5b7bc3dda4055117ffabcbae86c09
-  data.tar.gz: aa75520401b9ecb110106268ad8eee777783cd18599a951e080c6f6372e188b98fce2fb03664bf7d63e0f2507efc95a4c612c221237a6bc1ceee475bd6b3a99b
+  metadata.gz: 9dc8905bb4337c2e32de615e9455a1bef0ce47956ca0797f5095a423c16d64366eaf60541d6393d1b9863588018b12786548280333bc78a8c9397ef116aa83e4
+  data.tar.gz: 67168fe1cff5a1be817cdbb45054874c20abe4e71714c9b6c42703543c7bb6193cb66d754f1c27a0b08169bc84743c127c869e606700e58b863ab7636e7fec76

data/README.md

@@ -23,6 +23,21 @@ A.new.call # => 42
 # Text will be printed only once.
 ```
 
+## Features
+Mememaster is very similar to [Memoist](https://github.com/matthewrudy/memoist). The difference is that it doesn't override methods, instead it uses Ruby 2 `Module.prepend` feature. This approach is cleaner and it allows subclasses' methods to work properly: by default, if you redefine a memoized method in a subclass, it's not memoized by default, but you can memoize it normally (without using awkward `identifier: ` argument) and it will just work.
+
+The other key difference is that it doesn't change method's signature (no extra `reload` param). If you need unmemoized version of method, just make it like this:
+
+```ruby
+memoize def users
+  get_users
+end
+
+def get_users
+  # ...
+end
+```
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/lib/mememaster.rb

@@ -3,6 +3,17 @@
 require "mememaster/version"
 
 module Mememaster
+  def self.method_visibility(klass, method_name)
+    case
+    when klass.private_method_defined?(method_name)
+      :private
+    when klass.protected_method_defined?(method_name)
+      :protected
+    else
+      :public
+    end
+  end
+
   def memoize(method_name)
     prepend_mememaster_module!
     define_memoized_method!(method_name)
@@ -17,13 +28,14 @@ module Mememaster
   end
 
   def define_memoized_method!(method_name)
-    mod = @_mememaster_module
+    mod_id = @_mememaster_module.object_id
+    visibility = Mememaster.method_visibility(self, method_name)
 
     @_mememaster_module.module_eval do
       define_method(method_name) do |*args|
         @_mememaster_memoized_values ||= {}
 
-        key = [method_name, mod.object_id].join("_").to_sym
+        key = [method_name, mod_id].join("_").to_sym
         store = @_mememaster_memoized_values[key] ||= {}
 
         if store.key?(args)
@@ -32,6 +44,8 @@ module Mememaster
           store[args] = super(*args)
         end
       end
+
+      send(visibility, method_name)
     end
   end
 end

data/lib/mememaster/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mememaster
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mememaster
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Yuri Smirnov