memcached_store 2.0.2 → 2.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 604df981c587ff19ef1bd833c79f95d0716051bd
-  data.tar.gz: cd75d95d121d1969b8ffe73d858b9699a51a3000
+SHA256:
+  metadata.gz: b0a184a4116f8347e79e8043dc0dc6cf84348a50b3b25fa446a0bbb7cd30f130
+  data.tar.gz: d4f927b0ba9d5990fae0959045be9e518bcbff598af0eb1eb35b1196a80e4aa5
 SHA512:
-  metadata.gz: 82bec692dca6c4e55e809ab7a413681e8d3737cc3a59a9cd20c8b505a1506eb6f7a1e3d0e6bb0c91a6da5b0e1c3e9f330692f04e729a6213fcec9a5375ff8adf
-  data.tar.gz: ba4c196fb7bbdc0cbae3e03568ef0d2dfea8577a5f66a7ecaa1c4afc52116f4f63ef3d0d2bc848e7bffd1eb735ad031ca00cbf504d94dc3d232caa669f632c37
+  metadata.gz: 40bd828913b63212bd06091725700f2b0ea4d4de98c46dbecbcab3d9562c8d1926971b2e87cf0408bb1c5894ae23d1903dcb59181b99a85f1789851e4064fead
+  data.tar.gz: afd215ae18c02bfa2d7aac757d5d991b1164577de5d80af9e677d78c08af605fecb5f9cf0778241949fc1f6e8af197004d1411ce904925df2878355ac070e524

data/lib/active_support/cache/memcached_store.rb

@@ -58,6 +58,8 @@ module ActiveSupport
 
       attr_accessor :read_only, :swallow_exceptions
 
+      prepend(Strategy::LocalCache)
+
       def initialize(*addresses, **options)
         addresses = addresses.flatten
         options[:codec] ||= Codec.new
@@ -67,17 +69,28 @@ module ActiveSupport
         super(options)
 
         if addresses.first.is_a?(Memcached)
-          @data = addresses.first
+          @connection = addresses.first
           raise "Memcached::Rails is no longer supported, "\
-                "use a Memcached instance instead" if @data.is_a?(Memcached::Rails)
+                "use a Memcached instance instead" if @connection.is_a?(Memcached::Rails)
         else
           mem_cache_options = options.dup
           servers = mem_cache_options.delete(:servers)
           UNIVERSAL_OPTIONS.each { |name| mem_cache_options.delete(name) }
-          @data = Memcached.new([*addresses, *servers], mem_cache_options)
+          @connection = Memcached.new([*addresses, *servers], mem_cache_options)
         end
+      end
+
+      def append(name, value, options = nil)
+        return true if read_only
+        options = merged_options(options)
+        normalized_key = normalize_key(name, options)
 
-        extend Strategy::LocalCache
+        handle_exceptions(return_value_on_error: nil, on_miss: false, miss_exceptions: [Memcached::NotStored]) do
+          instrument(:append, name) do
+            @connection.append(normalized_key, value)
+          end
+          true
+        end
       end
 
       def write(*)
@@ -100,7 +113,7 @@ module ActiveSupport
 
         handle_exceptions(return_value_on_error: {}) do
           instrument(:read_multi, names, options) do
-            if raw_values = @data.get(keys_to_names.keys)
+            if raw_values = @connection.get(keys_to_names.keys)
               raw_values.each do |key, value|
                 entry = deserialize_entry(value)
                 values[keys_to_names[key]] = entry.value unless entry.expired?
@@ -117,11 +130,11 @@ module ActiveSupport
 
         handle_exceptions(return_value_on_error: false) do
           instrument(:cas, name, options) do
-            @data.cas(key, expiration(options)) do |raw_value|
+            @connection.cas(key, expiration(options)) do |raw_value|
               entry = deserialize_entry(raw_value)
               value = yield entry.value
               break true if read_only
-              serialize_entry(Entry.new(value, options), options)
+              serialize_entry(Entry.new(value, **options), options)
             end
           end
           true
@@ -136,7 +149,7 @@ module ActiveSupport
 
         handle_exceptions(return_value_on_error: false) do
           instrument(:cas_multi, names, options) do
-            @data.cas(keys_to_names.keys, expiration(options)) do |raw_values|
+            @connection.cas(keys_to_names.keys, expiration(options)) do |raw_values|
               values = {}
 
               raw_values.each do |key, raw_value|
@@ -149,7 +162,7 @@ module ActiveSupport
               break true if read_only
 
               serialized_values = values.map do |name, value|
-                [normalize_key(name, options), serialize_entry(Entry.new(value, options), options)]
+                [normalize_key(name, options), serialize_entry(Entry.new(value, **options), options)]
               end
 
               Hash[serialized_values]
@@ -163,7 +176,7 @@ module ActiveSupport
         options = merged_options(options)
         handle_exceptions(return_value_on_error: nil) do
           instrument(:increment, name, amount: amount) do
-            @data.incr(normalize_key(name, options), amount)
+            @connection.incr(normalize_key(name, options), amount)
           end
         end
       end
@@ -172,20 +185,20 @@ module ActiveSupport
         options = merged_options(options)
         handle_exceptions(return_value_on_error: nil) do
           instrument(:decrement, name, amount: amount) do
-            @data.decr(normalize_key(name, options), amount)
+            @connection.decr(normalize_key(name, options), amount)
           end
         end
       end
 
       def clear(options = nil)
         ActiveSupport::Notifications.instrument("cache_clear.active_support", options || {}) do
-          @data.flush
+          @connection.flush
         end
       end
 
       def stats
         ActiveSupport::Notifications.instrument("cache_stats.active_support") do
-          @data.stats
+          @connection.stats
         end
       end
 
@@ -195,7 +208,7 @@ module ActiveSupport
 
       def reset #:nodoc:
         handle_exceptions(return_value_on_error: false) do
-          @data.reset
+          @connection.reset
         end
       end
 
@@ -203,7 +216,7 @@ module ActiveSupport
 
       def read_entry(key, _options) # :nodoc:
         handle_exceptions(return_value_on_error: nil) do
-          deserialize_entry(@data.get(escape_key(key)))
+          deserialize_entry(@connection.get(escape_key(key)))
         end
       end
 
@@ -213,7 +226,7 @@ module ActiveSupport
         expires_in = expiration(options)
         value = serialize_entry(entry, options)
         handle_exceptions(return_value_on_error: false) do
-          @data.send(method, escape_key(key), value, expires_in)
+          @connection.send(method, escape_key(key), value, expires_in)
           true
         end
       end
@@ -221,7 +234,7 @@ module ActiveSupport
       def delete_entry(key, _options) # :nodoc:
         return true if read_only
         handle_exceptions(return_value_on_error: false, on_miss: true) do
-          @data.delete(escape_key(key))
+          @connection.delete(escape_key(key))
           true
         end
       end
@@ -257,7 +270,7 @@ module ActiveSupport
 
       def deserialize_entry(value)
         if value
-          value.is_a?(Entry) ? value : Entry.new(value, compresss: false)
+          value.is_a?(Entry) ? value : Entry.new(value, compress: false)
         end
       end
 
@@ -271,16 +284,15 @@ module ActiveSupport
 
       def expiration(options)
         expires_in = options[:expires_in].to_i
-        if expires_in > 0 && !options[:raw]
-          # Set the memcache expire a few minutes in the future to support race condition ttls on read
-          expires_in += 5.minutes.to_i
+        if expires_in > 0 && options[:race_condition_ttl] && !options[:raw]
+          expires_in += options[:race_condition_ttl].to_i
         end
         expires_in
       end
 
-      def handle_exceptions(return_value_on_error:, on_miss: return_value_on_error)
+      def handle_exceptions(return_value_on_error:, on_miss: return_value_on_error, miss_exceptions: [])
         yield
-      rescue Memcached::NotFound, Memcached::ConnectionDataExists
+      rescue Memcached::NotFound, Memcached::ConnectionDataExists, *miss_exceptions
         on_miss
       rescue Memcached::Error => e
         log_warning(e)

data/lib/memcached_store/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module MemcachedStore
-  VERSION = "2.0.2"
+  VERSION = "2.1.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: memcached_store
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.6
 platform: ruby
 authors:
 - Camilo Lopez
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-25 00:00:00.000000000 Z
+date: 2020-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -75,7 +75,8 @@ files:
 homepage: https://github.com/Shopify/memcached_store/
 licenses:
 - MIT
-metadata: {}
+metadata:
+  allowed_push_host: https://rubygems.org
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -91,8 +92,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Plugin-able Memcached adapters to add features (compression, safety)