memcached_store 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b05b5adfbadd1297a6914f2227a649e1bcd0d178
-  data.tar.gz: 9d8aa9dcf3f9435b00f5e5dd07697beda9930ab1
+  metadata.gz: 94c9c56b828e44a78fda3428d2ab7640b2c616af
+  data.tar.gz: a28f4c4fe72e9eef468b21743d3057747a93656e
 SHA512:
-  metadata.gz: 51829aa977156ed9c8c06bdab489b1f4febfc3c4aedd2d96555996b3a750bd0e64d7d2a708ebadbf51a9baf443f8e97c74622251eac7093dd9d0a9e85b64e5c9
-  data.tar.gz: c35fac05d247a305443a4732f2daf375f66066e3befc3266f5a6d78348ee20328f1cf2ce3cfb2a386c5d59de4e990633780aa5dcaa93055a71f37270f091a2ad
+  metadata.gz: c7268f89eeb01a051ffe719209ba1cc00e6b4af33768dbe31ac7c4df0a85b5bcb9e356a84424ddce5da5cc6c2a4ed2973f2c09b18a67815c91862eea4df03285
+  data.tar.gz: a1a8d09654d37dfa0aae58868e58a6cb612024c5a902d6883894885909f6c43e8295c1784f4555e085d7999d19b242acc32b0b70c0153e7192074733a3e5fc61

data/lib/active_support/cache/memcached_store.rb

@@ -50,13 +50,18 @@ module ActiveSupport
         options = names.extract_options!
         options = merged_options(options)
         keys_to_names = Hash[names.map{|name| [escape_key(namespaced_key(name, options)), name]}]
-        raw_values = @data.get_multi(keys_to_names.keys, :raw => true)
         values = {}
-        raw_values.each do |key, value|
-          entry = deserialize_entry(value)
-          values[keys_to_names[key]] = entry.value unless entry.expired?
+
+        if raw_values = @data.get_multi(keys_to_names.keys, :raw => true)
+          raw_values.each do |key, value|
+            entry = deserialize_entry(value)
+            values[keys_to_names[key]] = entry.value unless entry.expired?
+          end
         end
         values
+      rescue *NONFATAL_EXCEPTIONS => e
+        @data.log_exception(e)
+        {}
       end
 
       def increment(name, amount = 1, options = nil) # :nodoc:

data/lib/memcached_store/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module MemcachedStore
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
 end

data/memcached_store.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |gem|
   gem.version       = MemcachedStore::VERSION
   gem.add_runtime_dependency "activesupport", ">=  3.2"
   gem.add_runtime_dependency "snappy", "0.0.4"
-  gem.add_runtime_dependency "memcached", "~> 1.5.0"
+  gem.add_runtime_dependency "memcached", "~> 1.7.2"
 
   gem.add_development_dependency "rake"
   gem.add_development_dependency "minitest"

data/test/test_memcached_store.rb

@@ -6,6 +6,16 @@ class TestMemcachedStore < ActiveSupport::TestCase
     @cache.clear
   end
 
+  def test_write_not_found
+    expect_not_found
+    assert_equal false, @cache.write('not_exist', 1)
+  end
+
+  def test_fetch_not_found
+    expect_not_found
+    assert_equal nil, @cache.fetch('not_exist')
+  end
+
   def test_should_read_and_write_strings
     assert @cache.write('foo', 'bar')
     assert_equal 'bar', @cache.read('foo')
@@ -84,6 +94,11 @@ class TestMemcachedStore < ActiveSupport::TestCase
     assert_equal({"foo" => "bar", "fu" => "baz"}, @cache.read_multi('foo', 'fu'))
   end
 
+  def test_read_multi_not_found
+    expect_not_found
+    assert_equal({}, @cache.read_multi('foe', 'fue'))
+  end
+
   def test_read_multi_with_expires
     @cache.write('foo', 'bar', :expires_in => 0.001)
     @cache.write('fu', 'baz')
@@ -250,6 +265,11 @@ class TestMemcachedStore < ActiveSupport::TestCase
     assert_nil @cache.increment('bar')
   end
 
+  def test_increment_not_found
+    expect_not_found
+    assert_equal nil, @cache.increment('not_exist')
+  end
+
   def test_decrement
     @cache.write('foo', 3, :raw => true)
     assert_equal 3, @cache.read('foo').to_i
@@ -260,6 +280,11 @@ class TestMemcachedStore < ActiveSupport::TestCase
     assert_nil @cache.decrement('bar')
   end
 
+  def test_decrement_not_found
+    expect_not_found
+    assert_equal nil, @cache.decrement('not_exist')
+  end
+
   def test_common_utf8_values
     key = "\xC3\xBCmlaut".force_encoding(Encoding::UTF_8)
     assert @cache.write(key, "1", :raw => true)
@@ -288,4 +313,10 @@ class TestMemcachedStore < ActiveSupport::TestCase
     cache = ActiveSupport::Cache.lookup_store(:memcached_store, options)
     assert_equal [21211, 11211], cache.instance_variable_get(:@data).servers.map(&:port)
   end
+
+  private
+
+  def expect_not_found
+    @cache.instance_variable_get(:@data).expects(:check_return_code).raises(Memcached::NotFound)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: memcached_store
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Camilo Lopez
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-10 00:00:00.000000000 Z
+date: 2014-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -46,14 +46,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.7.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 1.7.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement