mem 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f73463cfd8433821a0bcf5965e3723f5664108c
-  data.tar.gz: ef54399be1bd91d4e7c6e4578cb664a7b50a83e1
+  metadata.gz: 3dabbde891da1e6d7fdfbc10036bdf09dfc96c84
+  data.tar.gz: be92cb3a9996e6a958c9b7493ae6bbca3be6e2e5
 SHA512:
-  metadata.gz: afe455e5ff5efe99f0ebd6e80535fec3e2eff047aa1274caec7a601c10000767901554699c94dfbd96ef8560cc9b02ec63bf44574d8dc5906ec62e17226b6ba4
-  data.tar.gz: 225b1a658713bb109863af892609ed60ddf61463b671509745fe6c3d52a3b1664e47044b197e91e97cb774ad5c92915fa4600532c31da94f783c5b234ca7b26c
+  metadata.gz: 06414b62be4874cabbac535aef1864a858ff6d89d445c31bbba840396d2da508e8fff08933b06b96e6fac2db65289a1a209b696eb76e03188022a6903760d6d8
+  data.tar.gz: f7fe1c3e822e8718483d4bbd7e23490bf95b05bbca9ec99da3e74de7484476b5d90a9176dd99fcd8cb246d86e4ee97acf4a3982d69af2dad6a9b8cb933a08bf0

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.1.5
+* Fix method visibility
+
 ## 0.1.4
 * Add support for removing memoization
 

data/lib/mem.rb

@@ -27,6 +27,16 @@ module Mem
 
   module ClassMethods
     def memoize(method_name)
+      original_visibility =
+        case
+        when protected_instance_methods.include?(method_name)
+          :protected
+        when private_instance_methods.include?(method_name)
+          :private
+        else
+          :public
+        end
+
       define_method("#{method_name}_with_memoize") do |*args, &block|
         if has_memoized?(method_name)
           memoized(method_name)
@@ -34,15 +44,21 @@ module Mem
           memoize(method_name, send("#{method_name}_without_memoize", *args, &block))
         end
       end
+      send(original_visibility, "#{method_name}_with_memoize")
+
       alias_method "#{method_name}_without_memoize", method_name
       alias_method method_name, "#{method_name}_with_memoize"
 
       define_method("unmemoize_#{method_name}") do
         unmemoize(method_name)
       end
+      send(original_visibility, "unmemoize_#{method_name}")
 
-      define_method("#{method_name}=") do |value|
-        memoize(method_name, value)
+      if original_visibility != :private
+        define_method("#{method_name}=") do |value|
+          memoize(method_name, value)
+        end
+        send(original_visibility, "#{method_name}=")
       end
     end
   end

data/lib/mem/version.rb

@@ -1,3 +1,3 @@
 module Mem
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/spec/mem_spec.rb

@@ -65,5 +65,41 @@ describe Mem do
         object.memoized_table.should == { a!: [1, 2] }
       end
     end
+
+    context "with non-public method name" do
+      let(:klass) do
+        Class.new do
+          include Mem
+
+          def a
+          end
+          memoize :a
+
+          protected
+
+          def b
+          end
+          memoize :b
+
+          private
+
+          def c
+          end
+          memoize :c
+        end
+      end
+
+      it 'keeps method visibilities' do
+        expect(klass.public_instance_methods).to include(:a)
+        expect(klass.protected_instance_methods).to include(:b)
+        expect(klass.private_instance_methods).to include(:c)
+      end
+
+      it 'does not define setter of private method' do
+        expect(klass.instance_methods).to include(:a=)
+        expect(klass.instance_methods).to include(:b=)
+        expect(klass.instance_methods).not_to include(:c=)
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mem
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-27 00:00:00.000000000 Z
+date: 2014-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler