meibo 0.24.0 → 0.25.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00f82e2a36647d4e79e1bc9df6a1a69b0c3bbc9a09d77fe89fa05680d8cf2998
-  data.tar.gz: 5c363d7995a6e8c57afe83e6e77635ca7011c7c62528c486e5973b5c8a01ecbf
+  metadata.gz: 417a05d59791c055bc369d37c6090bf98415dc5eedeb30e4dc90ee599c281b5a
+  data.tar.gz: 0a85ffa046d4b09ceb65b8f610cc85496e6d4e00888e04c3c2bd75814d45d61b
 SHA512:
-  metadata.gz: c2960714575f4ea47e52851b183245e775d043a9a02bd5eed559843a98abbcc303c74496693c999fa0bc5dc3ac421b626983e1bc75b54510f805b4087826a899
-  data.tar.gz: f809d3d5e3149c35cd2f43af3bc4795664cd59a7d458f955e33d6ea00dd481ba3d9270365167ab1b27b48fd2f6b983a361915789109cc5c447c4753590b977d4
+  metadata.gz: 40f237fb1522c4dd583d6888f338010bf30baab627bc2b2627fe0e4434bf98c751e6b3b7ffc10a8828bd681ecf81a57bcb1f3687ffefc126031e980415101a9d
+  data.tar.gz: 0ea9ab746af1807bb28879a68bae54fbb7e074b533a0f76b127d8d5ad81d4a17d215f6c69ab1502e5451b87cfebd96d6a6fa36ca821df92c74fc2ecd061917e8

data/.rubocop_todo.yml

@@ -50,7 +50,7 @@ Metrics/MethodLength:
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 231
+  Max: 237
 
 # Offense count: 16
 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    meibo (0.24.0)
+    meibo (0.25.1)
       csv (>= 3.1.4)
       rubyzip
       zeitwerk

data/lib/meibo/converter.rb

@@ -38,8 +38,8 @@ module Meibo
 
       private
 
-      def build_converter(fields:, converters:, write_or_parser:)
-        converter_list = TYPES.filter_map do |converter_type|
+      def build_converter_list(fields:, converters:, write_or_parser:)
+        TYPES.filter_map do |converter_type|
           fields_to_be_converted = converters[converter_type]
           method_name = "build_#{converter_type}_field_#{write_or_parser}_converter"
           if fields_to_be_converted && respond_to?(method_name, true)
@@ -52,14 +52,22 @@ module Meibo
             end
           end
         end
+      end
+
+      def converter_list_to_convert_proc(converter_list)
         lambda do |field, field_info|
           # NOTE: convert blank sourcedId to nil
-          field = nil if field.respond_to?(:empty?) && field.empty?
+          field = nil if field == "NULL" || field == "" # rubocop:disable Style/MultipleComparison
           converter_list.each { |converter| field = converter[field, field_info] }
           field
         end
       end
 
+      def build_converter(fields:, converters:, write_or_parser:)
+        converter_list = build_converter_list(fields: fields, converters: converters, write_or_parser: write_or_parser).freeze
+        converter_list_to_convert_proc(converter_list)
+      end
+
       def build_boolean_field_parser_converter(boolean_field_indexes)
         boolean_field_indexes = boolean_field_indexes.dup.freeze
         lambda do |field, field_info|

data/lib/meibo/organization.rb

@@ -30,8 +30,7 @@ module Meibo
       }
     )
 
-    def initialize(sourced_id:, name:, type:, status: nil, date_last_modified: nil, identifier: nil,
-                   parent_sourced_id: (type == TYPES[:district] ? "NULL" : nil), **extension_fields)
+    def initialize(sourced_id:, name:, type:, status: nil, date_last_modified: nil, identifier: nil, parent_sourced_id: nil, **extension_fields)
       @sourced_id = sourced_id
       @status = status
       @date_last_modified = date_last_modified

data/lib/meibo/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Meibo
-  VERSION = "0.24.0"
+  VERSION = "0.25.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: meibo
 version: !ruby/object:Gem::Version
-  version: 0.24.0
+  version: 0.25.1
 platform: ruby
 authors:
 - Seiei Miyagi
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-03-01 00:00:00.000000000 Z
+date: 2023-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: csv
@@ -142,7 +142,7 @@ metadata:
   allowed_push_host: https://rubygems.org/
   homepage_uri: https://github.com/hanachin/meibo
   source_code_uri: https://github.com/hanachin/meibo
-  changelog_uri: https://github.com/hanachin/meibo/blob/meibo/v0.24.0/CHANGELOG.md
+  changelog_uri: https://github.com/hanachin/meibo/blob/meibo/v0.25.1/CHANGELOG.md
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []