meetup_client 0.0.6 → 0.0.7

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 57971f7039ddd4835366b049c60ea6cd1876ea7d
+  data.tar.gz: f79ab80c189b61e0738350bd6623485a1df58a87
+SHA512:
+  metadata.gz: cd8a8e3cba35e20dd34c93206bac037a5604131022fecfb7e26cf66973f9f773f8913b0f6536870f7b36866c2698038419e458f6d58f0f732e42dbb9588edf8d
+  data.tar.gz: f8a55c76c8118b58dee830a0c9f722363505557a3e5ca8a2f179a98485c13c5fa0c2152dc3d8d1e1859ba1723c356dc293a3b3168c8ff298f504dfecc859cc0c

data/lib/api_callers/http_request.rb

@@ -23,7 +23,7 @@ module ApiCallers
     end
 
     def class_to_call
-      "Net::HTTP::#{@method.capitalize}".constantize
+      Kernel.const_get("Net::HTTP::#{@method.capitalize}")
     end
 
   end

data/lib/api_callers/json_request.rb

@@ -1,15 +1,10 @@
 require 'api_callers/http_request'
+require 'json'
 
 module ApiCallers
   class JsonRequest < HttpRequest
     def format_response(response_body)
-      ActiveSupport::JSON.decode(clean_response_body(response_body))
-    end
-
-    private
-
-    def clean_response_body(response_body)
-      ActionController::Base.helpers.strip_tags(response_body.gsub('\"','').force_encoding(CHARSET))
+      JSON.parse(response_body)
     end
   end
 end

data/meetup_client.gemspec

@@ -12,7 +12,11 @@ Gem::Specification.new do |s|
   s.files       = %w(README.md Rakefile meetup_client.gemspec)
   s.files      += Dir.glob("lib/**/*.rb")
   s.files      += Dir.glob("spec/**/*")
-  s.version     = '0.0.6'
-  s.homepage    = 'https://rubygems.org/gems/meetup_client' 
+  s.version     = '0.0.7'
+  s.homepage    = 'https://rubygems.org/gems/meetup_client'
   s.license     = 'MIT'
+  s.add_development_dependency "bundler", "~> 1.5"
+  s.add_development_dependency "rake"
+  s.add_development_dependency "rspec"
+  s.add_development_dependency "pry"
 end

data/spec/api_callers/http_request_spec.rb

@@ -2,22 +2,36 @@ require 'spec_helper'
 require 'net/http'
 
 describe ::ApiCallers::HttpRequest do
-  subject { ::ApiCallers::HttpRequest.new('') }
+  subject { ::ApiCallers::HttpRequest.new('some_uri', http_verb) }
+  let(:http_verb) { 'get' }
 
-  describe "#headers" do
-    it "returns { 'Accept-Charset' => 'utf-8' }" do
-      expect(subject.send(:headers)).to eq({ 'Accept-Charset' => 'UTF-8' })
+  describe "#make_request" do
+    let(:http_obj) { double('http', request: request) }
+    let(:request) { double('request', body: { response: 'response'}) }
+    let(:url) { double('url', request_uri: 'request_uri', host: 'host', port: 'port') }
+
+    before do
+      allow(URI).to receive(:parse).and_return(url)
+      allow(Net::HTTP).to receive(:new).and_return(http_obj)
     end
-  end
 
-  describe "#class_to_call" do
-    it "returns Net::HTTP::Get by default" do
-      expect(subject.send(:class_to_call)).to eq Net::HTTP::Get
+    context 'get request' do
+      it 'make a request to the provided url' do
+        allow(Net::HTTP::Get).to receive(:new).with('request_uri', { 'Accept-Charset' => 'UTF-8' }).and_return(:get_request)
+        expect(Net::HTTP).to receive(:new)
+        expect(http_obj).to receive(:request).with(:get_request)
+        subject.make_request
+      end
     end
 
-    it "returns the class to call based on the request method, whether it is 'get', 'post', or 'delete'" do
-      json_request = ::ApiCallers::JsonRequest.new('', 'post')
-      expect(json_request.send(:class_to_call)).to eq Net::HTTP::Post
+    context 'post request' do
+      let(:http_verb) { 'post' }
+      it 'make a request to the provided url' do
+        allow(Net::HTTP::Post).to receive(:new).with('request_uri', { 'Accept-Charset' => 'UTF-8' }).and_return(:post_request)
+        expect(Net::HTTP).to receive(:new)
+        expect(http_obj).to receive(:request).with(:post_request)
+        subject.make_request
+      end
     end
   end
 end

data/spec/api_callers/json_request_spec.rb

@@ -2,18 +2,18 @@ require 'spec_helper'
 require 'net/http'
 
 describe ::ApiCallers::JsonRequest do
-  subject { ::ApiCallers::JsonRequest.new('') }
-
-  describe "#clean_response_body" do
-    let(:body_response) { 'I\'m the \"Best\"' }
+  subject { ::ApiCallers::JsonRequest.new(response_body) }
+  let(:response_body) do
+    '{ "response": "I\'m the \"Best\"" }'
+  end
 
-    it "removed \" from the passed text " do
-      expect(subject.send(:clean_response_body, body_response)).to eq 'I\'m the Best'
+  describe "#format_response" do
+    let(:expected_json) do
+      { "response" => 'I\'m the "Best"' }
     end
 
-    it "forces the encoding to utf-8" do
-      body_response.encode!('windows-1251')
-      expect(subject.send(:clean_response_body, body_response).encoding.to_s).to eq 'UTF-8'
+    it "formats the response from meetup" do
+      expect(subject.format_response(response_body)).to eq expected_json
     end
   end
 end

data/spec/spec_helper.rb

@@ -7,8 +7,6 @@ require 'api_callers/json_request'
 require 'meetup_api'
 require 'meetup_client'
 require 'net/http'
-require 'active_support'
-require 'action_controller'
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
 #Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f }

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: meetup_client
 version: !ruby/object:Gem::Version
-  version: 0.0.6
-  prerelease: 
+  version: 0.0.7
 platform: ruby
 authors:
 - Cosimo Ranieri
@@ -10,7 +9,63 @@ autorequire:
 bindir: bin
 cert_chain: []
 date: 2013-07-25 00:00:00.000000000 Z
-dependencies: []
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Easy way to access the Meetup.com API
 email: co.ranieri@gmail.com
 executables: []
@@ -34,26 +89,26 @@ files:
 homepage: https://rubygems.org/gems/meetup_client
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Easy way to access the Meetup.com API
 test_files: []
+has_rdoc: