meducation_sdk 1.6.5 → 1.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88b274bb643e4cd8f5b49a2320791031006b1725
-  data.tar.gz: 48542ce459f4b7b4c181d7c3ba3015a9244514e9
+  metadata.gz: fac66f47a5084d9fe4dd381d2764469aa15eaa8e
+  data.tar.gz: 855c4f242246eab96ac08fef50a5023f858a0f7d
 SHA512:
-  metadata.gz: 32776277566684a0b2e58ad7e51952b9b396e21194f11167d5376d27d6f57325a4cc6d7773816ea1e07396fcd5aace9185460cf507e137f1f0547ca0e759ef9f
-  data.tar.gz: d79509139ba22b70c044023877e73e4b7a84d5a27415a381f93212b6b39faf01062279988c0a83d83875e91fccb05596ec2b9a831d42f13adcb36745de0a30cd
+  metadata.gz: b5ef332c652eaeff2a7b5b3bfb83318ddf0fc72c47633827ebc55dfeeb0db7fcfa9e6120fe21c2c4f836c6de92f90bf31cfc283c1707df18ecef7c1b1591114d
+  data.tar.gz: c2f67243c3f55fd336c39a27ebe6d8b6d9ea0e81d12558cbaeb265339baa1e6c706a5c0e8d06114f2beb29fe73ef09e8912242214c668d02ea31666d768f6845

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 1.6.9 / 2014-03-14
+* [BUGFIX] Good resources padding recommendations should be safe for email.
+
 # 1.6.5 / 2014-03-14
 * [FEATURE] Allow recommendations of multiple items
 

data/lib/meducation_sdk/services/recommender.rb

@@ -17,7 +17,7 @@ module MeducationSDK
       recommendations = generate_recommendations
       if recommendations.size < @limit
         log "recommendations.size (#{recommendations.size}) is < limit of #{@limit}"
-        recommendations += MeducationSDK::MediaFile.where('rating > 2').per(@limit - recommendations.size).order(:random).to_a
+        recommendations += MeducationSDK::MediaFile.where('rating > 2').where(safe_for_email: true).per(@limit - recommendations.size).order(:random).to_a
       else
         log "recommendations.size (#{recommendations.size}) is >= limit of #{@limit}"
       end
@@ -26,7 +26,7 @@ module MeducationSDK
       log_error("!!Recommender Error!!")
       log_error(e.message)
       log_error(e.backtrace)
-      MeducationSDK::MediaFile.where('rating > 2').per(@limit).order(:random).to_a
+      MeducationSDK::MediaFile.where('rating > 2').where(safe_for_email: true).per(@limit).order(:random).to_a
     end
 
     def generate_recommendations

data/lib/meducation_sdk/version.rb

@@ -1,3 +1,3 @@
 module MeducationSDK
-  VERSION = "1.6.5"
+  VERSION = "1.6.6"
 end

data/test/services/recommender_test.rb

@@ -94,6 +94,7 @@ module MeducationSDK
       MediaFile.expects(:where).with({id: [item.id, item2.id]}).returns([item, item2])
       good_resources = mock
       MediaFile.expects(:where).with('rating > 2').returns(@per_result)
+      @per_result.expects(:where).with(safe_for_email: true).returns(@per_result)
       items = Recommender.new(item, limit: limit).recommend
       assert_equal [item, item2, item3], items
     end
@@ -113,7 +114,7 @@ module MeducationSDK
       Net::HTTP.expects(:get_response).raises(StandardError)
       MeducationSDK.config.logger.expects(:error).with("!!Recommender Error!!")
       MeducationSDK.config.logger.expects(:error).with("StandardError")
-      MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
+      MediaFile.expects(:where).with('rating > 2').returns(@per_result)
       Recommender.new(item).recommend
     end
 
@@ -121,7 +122,7 @@ module MeducationSDK
       @per_result.expects(:per).with(5).returns(@per_result)
       @per_result.stubs(to_a: [item3])
       Net::HTTP.expects(:get_response).raises(StandardError)
-      MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
+      MediaFile.expects(:where).with('rating > 2').returns(@per_result)
       items = Recommender.new(item).recommend
       assert_equal [item3], items
     end
@@ -130,7 +131,8 @@ module MeducationSDK
       @per_result.expects(:per).with(5).returns(@per_result)
       @per_result.stubs(to_a: [item3])
       Net::HTTP.expects(:get_response).raises(StandardError)
-      MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
+      MediaFile.expects(:where).with('rating > 2').returns(@per_result)
+      @per_result.expects(:where).with(safe_for_email: true).returns(@per_result)
       items = Recommender.new(item).recommend
       assert_equal [item3], items
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: meducation_sdk
 version: !ruby/object:Gem::Version
-  version: 1.6.5
+  version: 1.6.6
 platform: ruby
 authors:
 - Jeremy Walker
@@ -258,7 +258,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.9
+rubygems_version: 2.2.1
 signing_key: 
 specification_version: 4
 summary: The SDK for Meducation
@@ -320,4 +320,3 @@ test_files:
 - test/resources/vote_test.rb
 - test/services/recommender_test.rb
 - test/test_helper.rb
-has_rdoc: