meducation_sdk 1.6.5 → 1.6.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 88b274bb643e4cd8f5b49a2320791031006b1725
4
- data.tar.gz: 48542ce459f4b7b4c181d7c3ba3015a9244514e9
3
+ metadata.gz: fac66f47a5084d9fe4dd381d2764469aa15eaa8e
4
+ data.tar.gz: 855c4f242246eab96ac08fef50a5023f858a0f7d
5
5
  SHA512:
6
- metadata.gz: 32776277566684a0b2e58ad7e51952b9b396e21194f11167d5376d27d6f57325a4cc6d7773816ea1e07396fcd5aace9185460cf507e137f1f0547ca0e759ef9f
7
- data.tar.gz: d79509139ba22b70c044023877e73e4b7a84d5a27415a381f93212b6b39faf01062279988c0a83d83875e91fccb05596ec2b9a831d42f13adcb36745de0a30cd
6
+ metadata.gz: b5ef332c652eaeff2a7b5b3bfb83318ddf0fc72c47633827ebc55dfeeb0db7fcfa9e6120fe21c2c4f836c6de92f90bf31cfc283c1707df18ecef7c1b1591114d
7
+ data.tar.gz: c2f67243c3f55fd336c39a27ebe6d8b6d9ea0e81d12558cbaeb265339baa1e6c706a5c0e8d06114f2beb29fe73ef09e8912242214c668d02ea31666d768f6845
data/CHANGELOG.md CHANGED
@@ -1,3 +1,6 @@
1
+ # 1.6.9 / 2014-03-14
2
+ * [BUGFIX] Good resources padding recommendations should be safe for email.
3
+
1
4
  # 1.6.5 / 2014-03-14
2
5
  * [FEATURE] Allow recommendations of multiple items
3
6
 
@@ -17,7 +17,7 @@ module MeducationSDK
17
17
  recommendations = generate_recommendations
18
18
  if recommendations.size < @limit
19
19
  log "recommendations.size (#{recommendations.size}) is < limit of #{@limit}"
20
- recommendations += MeducationSDK::MediaFile.where('rating > 2').per(@limit - recommendations.size).order(:random).to_a
20
+ recommendations += MeducationSDK::MediaFile.where('rating > 2').where(safe_for_email: true).per(@limit - recommendations.size).order(:random).to_a
21
21
  else
22
22
  log "recommendations.size (#{recommendations.size}) is >= limit of #{@limit}"
23
23
  end
@@ -26,7 +26,7 @@ module MeducationSDK
26
26
  log_error("!!Recommender Error!!")
27
27
  log_error(e.message)
28
28
  log_error(e.backtrace)
29
- MeducationSDK::MediaFile.where('rating > 2').per(@limit).order(:random).to_a
29
+ MeducationSDK::MediaFile.where('rating > 2').where(safe_for_email: true).per(@limit).order(:random).to_a
30
30
  end
31
31
 
32
32
  def generate_recommendations
@@ -1,3 +1,3 @@
1
1
  module MeducationSDK
2
- VERSION = "1.6.5"
2
+ VERSION = "1.6.6"
3
3
  end
@@ -94,6 +94,7 @@ module MeducationSDK
94
94
  MediaFile.expects(:where).with({id: [item.id, item2.id]}).returns([item, item2])
95
95
  good_resources = mock
96
96
  MediaFile.expects(:where).with('rating > 2').returns(@per_result)
97
+ @per_result.expects(:where).with(safe_for_email: true).returns(@per_result)
97
98
  items = Recommender.new(item, limit: limit).recommend
98
99
  assert_equal [item, item2, item3], items
99
100
  end
@@ -113,7 +114,7 @@ module MeducationSDK
113
114
  Net::HTTP.expects(:get_response).raises(StandardError)
114
115
  MeducationSDK.config.logger.expects(:error).with("!!Recommender Error!!")
115
116
  MeducationSDK.config.logger.expects(:error).with("StandardError")
116
- MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
117
+ MediaFile.expects(:where).with('rating > 2').returns(@per_result)
117
118
  Recommender.new(item).recommend
118
119
  end
119
120
 
@@ -121,7 +122,7 @@ module MeducationSDK
121
122
  @per_result.expects(:per).with(5).returns(@per_result)
122
123
  @per_result.stubs(to_a: [item3])
123
124
  Net::HTTP.expects(:get_response).raises(StandardError)
124
- MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
125
+ MediaFile.expects(:where).with('rating > 2').returns(@per_result)
125
126
  items = Recommender.new(item).recommend
126
127
  assert_equal [item3], items
127
128
  end
@@ -130,7 +131,8 @@ module MeducationSDK
130
131
  @per_result.expects(:per).with(5).returns(@per_result)
131
132
  @per_result.stubs(to_a: [item3])
132
133
  Net::HTTP.expects(:get_response).raises(StandardError)
133
- MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
134
+ MediaFile.expects(:where).with('rating > 2').returns(@per_result)
135
+ @per_result.expects(:where).with(safe_for_email: true).returns(@per_result)
134
136
  items = Recommender.new(item).recommend
135
137
  assert_equal [item3], items
136
138
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: meducation_sdk
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.6.5
4
+ version: 1.6.6
5
5
  platform: ruby
6
6
  authors:
7
7
  - Jeremy Walker
@@ -258,7 +258,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
258
258
  version: '0'
259
259
  requirements: []
260
260
  rubyforge_project:
261
- rubygems_version: 2.1.9
261
+ rubygems_version: 2.2.1
262
262
  signing_key:
263
263
  specification_version: 4
264
264
  summary: The SDK for Meducation
@@ -320,4 +320,3 @@ test_files:
320
320
  - test/resources/vote_test.rb
321
321
  - test/services/recommender_test.rb
322
322
  - test/test_helper.rb
323
- has_rdoc: