medivo 0.1.18 → 0.1.19

data/lib/medivo/version.rb

@@ -1,3 +1,3 @@
 module Medivo
-  VERSION = "0.1.18"
+  VERSION = "0.1.19"
 end

data/lib/pdf/medivo/pdf_group.rb

@@ -50,7 +50,7 @@ module Medivo
         `pdftk #{args}`
       end
 
-      @pdfs.collect do |file|
+      @pdfs.each do |file|
         file.close
         file.unlink if file.respond_to? :unlink
       end
@@ -60,6 +60,7 @@ module Medivo
       pdf.read
     end
 
+    # don't really have to do close the pdf, but I think it will trash quicker if you do
     def close
       if pdf
         pdf.close

data/spec/dummy/log/test.log

@@ -665,3 +665,59 @@ Served asset /medivo/markerB.png - 200 OK (2ms)
 
 Started GET "/assets/medivo/arrow.png" for 127.0.0.1 at 2011-11-08 10:22:13 -0500
 Served asset /medivo/arrow.png - 200 OK (3ms)
+  Processing by OrdersController#download_requisition as HTML
+Rendered text template (0.0ms)
+Sent data unitedhealthcare_requisition.pdf (105.1ms)
+Completed 200 OK in 951ms (Views: 104.3ms)
+  Processing by OrdersController#download_result as HTML
+Sent data unitedhealthcare_result.pdf (2.1ms)
+Completed 200 OK in 734ms (Views: 1.4ms)
+  Processing by OrdersController#download_requisition as HTML
+Rendered text template (0.0ms)
+Sent data unitedhealthcare_requisition.pdf (63.4ms)
+Completed 200 OK in 952ms (Views: 63.2ms)
+  Processing by OrdersController#download_result as HTML
+Sent data unitedhealthcare_result.pdf (2.1ms)
+Completed 200 OK in 735ms (Views: 1.4ms)
+  Processing by OrdersController#download_requisition as HTML
+Rendered text template (0.0ms)
+Sent data unitedhealthcare_requisition.pdf (72.8ms)
+Completed 200 OK in 955ms (Views: 72.2ms)
+  Processing by OrdersController#download_result as HTML
+Sent data unitedhealthcare_result.pdf (2.1ms)
+Completed 200 OK in 799ms (Views: 1.4ms)
+  Processing by OrdersController#download_requisition as HTML
+Rendered text template (0.0ms)
+Sent data unitedhealthcare_requisition.pdf (73.1ms)
+Completed 200 OK in 908ms (Views: 72.6ms)
+  Processing by OrdersController#download_result as HTML
+Sent data unitedhealthcare_result.pdf (2.2ms)
+Completed 200 OK in 755ms (Views: 1.7ms)
+  Processing by OrdersController#download_requisition as HTML
+Rendered text template (0.0ms)
+Sent data unitedhealthcare_requisition.pdf (72.0ms)
+Completed 200 OK in 903ms (Views: 71.1ms)
+  Processing by OrdersController#download_result as HTML
+Sent data unitedhealthcare_result.pdf (2.4ms)
+Completed 200 OK in 761ms (Views: 1.8ms)
+  Processing by OrdersController#download_requisition as HTML
+Rendered text template (0.0ms)
+Sent data unitedhealthcare_requisition.pdf (68.7ms)
+Completed 200 OK in 902ms (Views: 68.3ms)
+  Processing by OrdersController#download_result as HTML
+Sent data unitedhealthcare_result.pdf (2.2ms)
+Completed 200 OK in 806ms (Views: 1.6ms)
+  Processing by OrdersController#download_requisition as HTML
+Rendered text template (0.0ms)
+Sent data unitedhealthcare_requisition.pdf (76.2ms)
+Completed 200 OK in 909ms (Views: 75.7ms)
+  Processing by OrdersController#download_result as HTML
+Sent data unitedhealthcare_result.pdf (3.0ms)
+Completed 200 OK in 760ms (Views: 2.2ms)
+  Processing by OrdersController#download_requisition as HTML
+Rendered text template (0.0ms)
+Sent data unitedhealthcare_requisition.pdf (72.7ms)
+Completed 200 OK in 905ms (Views: 71.8ms)
+  Processing by OrdersController#download_result as HTML
+Sent data unitedhealthcare_result.pdf (2.3ms)
+Completed 200 OK in 722ms (Views: 1.9ms)

data/spec/lib/pdf_generator_spec.rb

@@ -1,12 +1,31 @@
 require 'spec_helper'
 
 describe Medivo::PdfGenerator do
+  MD = <<-MD
+Catherine E. Palmier, M.D.
+Chief Medical Officer,
+UnitedHealthcare Clinical Services
+Southeast Region
+  MD
+
+  let(:uhc_cover_letter_fields)  {
+    { :full_name => 'dude man',
+      :address => '5 willywonka lane',
+      :first_name => 'fdudely',
+      :sched_date => '2/12/2001',
+      :app_date => '2/13/2001',
+      :app_time => '9:00',  # small field .. so too much text will break test
+      :lab_name => 'LabCorp',
+      :lab_address => '3 nowhere road',
+      :order_number => '87113',
+      :director_name=>MD }
+  }
 
   describe "#variable_fields generates pdf by filling in the variables" do
 
-    it "for negative results cover letter" do
+    it "simple cover letter" do
       name = "Duderoni"
-      path = medivo_fixture_path "negative_results.pdf"
+      path = medivo_fixture_path "hepc_negative_results.pdf"
       pdf_file = Medivo::PdfGenerator.variable_fields(path, {:patient_name=>name})
       text = pdf_to_text(pdf_file)
       text.should match name
@@ -14,25 +33,12 @@ describe Medivo::PdfGenerator do
     end
 
     it "for uhc requisition cover letter" do
-
-      fields = {
-              :full_name => 'my full name',
-              :address => 'my address',
-              :first_name => 'me!!!!!',
-              :sched_date => 'todays date',
-              :app_date => 'my appt date',
-              :app_time => 'appt time',  # small field .. so too much text will break test
-              :lab_name => 'LabCorp',
-              :lab_address => 'the lab address',
-              :order_number => 'the lab id'
-      }
-
       path = medivo_fixture_path "uhc_requisition_cover_letter.pdf"
-      pdf_file = Medivo::PdfGenerator.variable_fields(path, fields)
+      pdf_file = Medivo::PdfGenerator.variable_fields(path, uhc_cover_letter_fields)
 
       text = pdf_to_text(pdf_file)
       text = text.strip_space
-      fields.values.each do |value|
+      uhc_cover_letter_fields.values.each do |value|
         text.should match value.strip_space
       end
       pdf_file.unlink
@@ -40,35 +46,20 @@ describe Medivo::PdfGenerator do
   end
 
   it "#variable_fields_with_images accepts image param and stamps image onto pdf" do
-    md = <<-MD
-Catherine E. Palmier, M.D.
-Chief Medical Officer,
-UnitedHealthcare Clinical Services
-Southeast Region
-    MD
-
-    fields = {
-            :full_name => 'my full name',
-            :address => 'my address',
-            :first_name => 'me!!!!!',
-            :sched_date => 'todays date',
-            :app_date => 'my appt date',
-            :app_time => 'appt time',  # small field .. so too much text will break test
-            :lab_name => 'LabCorp',
-            :lab_address => 'the lab address',
-            :order_number => 'the lab id',
-            :director_name=>md
-    }
-
     path = medivo_fixture_path "uhc_requisition_cover_letter.pdf"
     img_path = medivo_fixture_path "Southeast.jpg"
     pdf_file = Medivo::PdfGenerator.variable_fields_with_images(
             path,
-            fields,
+            uhc_cover_letter_fields,
             [{:path=> img_path, :options=>{:at=> [40, 100], :width=>180, :height=>28}}]
     )
+
     show_me_the_pdf(pdf_file, '/tmp/test.pdf')
     text = pdf_to_text(pdf_file)
+
+    uhc_cover_letter_fields.each do |key, value|
+      text.should match value unless key == :director_name
+    end
     text.strip_space.should match "Catherine E. Palmier, M.D.".strip_space
     pdf_file.unlink
   end

data/spec/lib/pdf_group_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Medivo::PdfGroup do
 
   it "can call read on the pdf after creating it" do
-    path = medivo_fixture_path "result_faq.pdf"
+    path = medivo_fixture_path "hepc_result_faq.pdf"
     pdf_group = Medivo::PdfGroup.create do
       static_pdf(path)
     end
@@ -13,16 +13,16 @@ describe Medivo::PdfGroup do
 
   it "#variable_fields" do
     name = "Duderoni"
-    o = OpenStruct.new(:name=>name)
-    path = medivo_fixture_path "negative_results.pdf"
+    path = medivo_fixture_path "hepc_negative_results.pdf"
     pdf_group = Medivo::PdfGroup.create do
-      variable_fields(path, {:patient_name=>o.name})
+      variable_fields(path, {:patient_name=>name})
     end
     text = pdf_to_text(pdf_group.pdf)
     text.should match name
     pdf_group.close
   end
 
+
   it "#lab_requisition" do
     requisition_id = 170420
     stub_order_requisition(requisition_id, medivo_fixture_path("lc_order_with_requisition.xml"))
@@ -51,7 +51,7 @@ describe Medivo::PdfGroup do
   end
 
   it "#static_pdf" do
-    path = medivo_fixture_path "result_faq.pdf"
+    path = medivo_fixture_path "hepc_result_faq.pdf"
     pdf_group = Medivo::PdfGroup.create do
       static_pdf(path)
     end
@@ -63,12 +63,12 @@ describe Medivo::PdfGroup do
 
   it "handles a combination of pdfs" do
     name = "Duderoni"
-    cover_letter_path = medivo_fixture_path "negative_results.pdf"
+    cover_letter_path = medivo_fixture_path "hepc_negative_results.pdf"
 
     requisition_id = 170420
     stub_order_result(requisition_id, medivo_fixture_path("lc_order_with_normal_results.xml"))
 
-    faq_path = medivo_fixture_path "result_faq.pdf"
+    faq_path = medivo_fixture_path "hepc_result_faq.pdf"
 
     pdf_group = Medivo::PdfGroup.create do
       variable_fields(cover_letter_path, {:patient_name=>name})

data/spec/support/sample_data.rb

@@ -1,6 +1,9 @@
 unless defined? SampleUser
   SampleUser = OpenStruct.new(
           :member_id => 1,
+          :full_name=>'dude man',
+          :first_name=>'dude',
+          :last_name=>'man',
           :date_of_birth => Date.new(1938, 3, 3),
           :address1 => "422 Cattelranchy St",
           :city => "Dudeville",
@@ -24,21 +27,19 @@ class LabTestOrder
     return @pdf_requisition if @pdf_requisition
 
     cover_letter_fields = {
-            :full_name => user.full_name,
-            :address => "#{user.address1}\n#{user.address2}\n#{user.city}, #{user.state} #{user.zip_code}",
-            :first_name => user.first_name,
-            :sched_date => Date.today.to_s,
-            :lab_name => 'LabCorp',
-            :order_number => requisition_id
+      :full_name => user.full_name,
+      :address => "#{user.address1}\n#{user.address2}\n#{user.city}, #{user.state} #{user.zip_code}",
+      :first_name => user.first_name,
+      :sched_date => Date.today.to_s,
+      :lab_name => 'LabCorp',
+      :order_number => requisition_id
     }
 
     cover_letter_file_path = "#{FIXTURE_PATH}/uhc_requisition_cover_letter.pdf"
-    faq_path =  "#{FIXTURE_PATH}/result_faq.pdf"
 
     @pdf_requisition = Medivo::PdfGroup.create do
       variable_fields(cover_letter_file_path, cover_letter_fields)
       lab_requisition(requisition_id)
-      static_pdf(faq_path)
     end
   end
 
@@ -46,19 +47,21 @@ class LabTestOrder
     return @pdf_result if @pdf_result
 
     cover_letter_fields = {
-            :full_name => user.full_name,
-            :address => "#{user.address1}\n#{user.address2}\n#{user.city}, #{user.state} #{user.zip_code}",
-            :first_name => user.first_name,
-            :sched_date => Date.today.to_s,
-            :lab_name => 'LabCorp',
-            :order_number => requisition_id
+      :full_name => user.full_name,
+      :address => "#{user.address1}\n#{user.address2}\n#{user.city}, #{user.state} #{user.zip_code}",
+      :first_name => user.first_name,
+      :sched_date => Date.today.to_s,
+      :lab_name => 'LabCorp',
+      :order_number => requisition_id
     }
 
     cover_letter_file_path = "#{FIXTURE_PATH}/uhc_result_cover_letter.pdf"
+    faq_path =  "#{FIXTURE_PATH}/hepc_result_faq.pdf"
 
-    Medivo::PdfGroup.create do
+    @pdf_result = Medivo::PdfGroup.create do
       variable_fields(cover_letter_file_path, cover_letter_fields)
       lab_result(requisition_id)
+      static_pdf(faq_path)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: medivo
 version: !ruby/object:Gem::Version
-  version: 0.1.18
+  version: 0.1.19
   prerelease: 
 platform: ruby
 authors:
@@ -14,7 +14,7 @@ default_executable:
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2170124640 !ruby/object:Gem::Requirement
+  requirement: &2152951920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,10 +22,10 @@ dependencies:
         version: 3.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *2170124640
+  version_requirements: *2152951920
 - !ruby/object:Gem::Dependency
   name: jquery-rails
-  requirement: &2170124220 !ruby/object:Gem::Requirement
+  requirement: &2152951500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2170124220
+  version_requirements: *2152951500
 - !ruby/object:Gem::Dependency
   name: coffee-script
-  requirement: &2170123760 !ruby/object:Gem::Requirement
+  requirement: &2152951040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2170123760
+  version_requirements: *2152951040
 - !ruby/object:Gem::Dependency
   name: haml-rails
-  requirement: &2170123340 !ruby/object:Gem::Requirement
+  requirement: &2152950620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2170123340
+  version_requirements: *2152950620
 - !ruby/object:Gem::Dependency
   name: geocoder
-  requirement: &2170122920 !ruby/object:Gem::Requirement
+  requirement: &2152950200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +66,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2170122920
+  version_requirements: *2152950200
 - !ruby/object:Gem::Dependency
   name: rest-client
-  requirement: &2170122500 !ruby/object:Gem::Requirement
+  requirement: &2152949700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,10 +77,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2170122500
+  version_requirements: *2152949700
 - !ruby/object:Gem::Dependency
   name: pdfkit
-  requirement: &2170122080 !ruby/object:Gem::Requirement
+  requirement: &2152949280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -88,10 +88,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2170122080
+  version_requirements: *2152949280
 - !ruby/object:Gem::Dependency
   name: prawn
-  requirement: &2170121660 !ruby/object:Gem::Requirement
+  requirement: &2152948860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -99,7 +99,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2170121660
+  version_requirements: *2152948860
 description: Use the medivo platform to find lab locations, make labcorp appointments,
   place lab orders
 email:
@@ -261,11 +261,11 @@ files:
 - spec/dummy/tmp/cache/assets/E32/FC0/sprockets%2Fe55fb2eef11567fe04fdaf7e73af5ba4
 - spec/dummy/tmp/cache/assets/E59/D50/sprockets%2Fbe1cc4d9b0efb617e58baa16dd1dee58
 - spec/dummy/tmp/image_path_fb5f3a59200b_1320622886.pdf
+- spec/fixtures/hepc_negative_results.pdf
+- spec/fixtures/hepc_result_faq.pdf
 - spec/fixtures/lc_order_with_normal_results.xml
 - spec/fixtures/lc_order_with_positive_results.xml
 - spec/fixtures/lc_order_with_requisition.xml
-- spec/fixtures/negative_results.pdf
-- spec/fixtures/result_faq.pdf
 - spec/fixtures/Southeast.jpg
 - spec/fixtures/uhc_requisition_cover_letter.pdf
 - spec/fixtures/uhc_result_cover_letter.pdf
@@ -298,7 +298,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1506057069429317681
+      hash: -978377392272491129
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -307,7 +307,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1506057069429317681
+      hash: -978377392272491129
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.6.2
@@ -410,11 +410,11 @@ test_files:
 - spec/dummy/tmp/cache/assets/E32/FC0/sprockets%2Fe55fb2eef11567fe04fdaf7e73af5ba4
 - spec/dummy/tmp/cache/assets/E59/D50/sprockets%2Fbe1cc4d9b0efb617e58baa16dd1dee58
 - spec/dummy/tmp/image_path_fb5f3a59200b_1320622886.pdf
+- spec/fixtures/hepc_negative_results.pdf
+- spec/fixtures/hepc_result_faq.pdf
 - spec/fixtures/lc_order_with_normal_results.xml
 - spec/fixtures/lc_order_with_positive_results.xml
 - spec/fixtures/lc_order_with_requisition.xml
-- spec/fixtures/negative_results.pdf
-- spec/fixtures/result_faq.pdf
 - spec/fixtures/Southeast.jpg
 - spec/fixtures/uhc_requisition_cover_letter.pdf
 - spec/fixtures/uhc_result_cover_letter.pdf