mediawiki_selenium 1.6.2 → 1.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c55bb41a3040b8fe13f7959cb9471870fb964c47
-  data.tar.gz: d8dee93ee8a956288de1ae1e412e3512a2427689
+  metadata.gz: ffa3ecc9539e538abf8730f38ba611ded2b25006
+  data.tar.gz: 85ab4f6ebb1f28a385df0c95a492ee24d9d1ed78
 SHA512:
-  metadata.gz: 86045429284cab2eea77d9c5a2a8f76e7922d982c5ebb728e644ceea15b7126085a26872dd4790fe147f5bfd25f01e77a6baad6d4cbe515de1303dcc5b28fe5f
-  data.tar.gz: fc39ea530db1f558c0f61261b012e555bc6bc308b3ec17ce53330ae3a872f59f1fbbe28dda10c351d66b6dac982f74190ac5326cdee9bd1b50797ab6ff44968d
+  metadata.gz: 70bc364392d8c6d5e9264d610858f4565abe5eeb0e55ba440fb76b280a65e2be8e33e78e1f7122225b0fef11c913a3425279ce91f7627ed85a2fc6ac0ff882ba
+  data.tar.gz: 50b31211b5b9e1eae9611ddf1c18e5861b2381e78a085f140a1d1d43cee831f00853ffb838c24a151519fba1d98e36340937fbf42d930f50259eaef9bc93bf26

data/README.md

@@ -37,7 +37,7 @@ Create a `Gemfile` in the root of your MediaWiki-related project that
 specifies the version of `mediawiki_selenium` you wish to use (typically the
 latest version).
 
-    gem 'mediawiki_selenium', '~> 1.5.0'
+    gem 'mediawiki_selenium', '~> 1.6.3'
 
 Install the gem and its dependencies by running `bundle install`. (If
 [Bundler](http://bundler.io/) is not yet installed, install it with

data/RELEASES.md

@@ -1,5 +1,9 @@
 ## Release notes
 
+### 1.6.3 2015-12-15
+
+* Added support for all SauceLabs provided browsers
+
 ### 1.6.2 2015-10-23
 * Fixed undefined `last_session_ids=` method bug in `RemoteBrowserFactory`
   which entirely broke SauceLabs use in previous 1.6.x versions

data/Rakefile

@@ -0,0 +1,19 @@
+# pre-flight
+require 'bundler/setup'
+require 'bundler/gem_tasks'
+
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
+require 'yard'
+
+RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new(:rubocop)
+YARD::Rake::YardocTask.new(:yard)
+
+task default: [:test]
+
+desc 'Run all build/tests commands (CI entry point)'
+task test: [:build, :rubocop, :spec, :yard]
+
+desc 'Generate all documentations'
+task doc: [:yard]

data/UPGRADE.md

@@ -10,7 +10,7 @@ in the root directory of your project.
 First, update the `Gemfile` in your project's root directory to specify the
 new version.
 
-    gem 'mediawiki_selenium', '~> 1.6.2'
+    gem 'mediawiki_selenium', '~> 1.6.3'
 
 ### Update `require` paths in `env.rb`
 
@@ -37,7 +37,7 @@ if they don't apply to your test cases. The only must have is the first
 First, update the `Gemfile` in your project's root directory to specify the
 new version.
 
-    gem 'mediawiki_selenium', '~> 1.6.2'
+    gem 'mediawiki_selenium', '~> 1.6.3'
 
 ### Upgrade gems and dependencies
 

data/features/saucelabs_browsers.feature

@@ -0,0 +1,21 @@
+Feature: Support for entire suite of browsers provided by SauceLabs
+  Background:
+    Given I have configured my environment from `ENV`
+      And I have set "SAUCE_ONDEMAND_USERNAME" in my shell
+      And I have set "SAUCE_ONDEMAND_ACCESS_KEY" in my shell
+
+  Scenario Outline: All SauceLabs browsers are supported
+    Given I have configured my environment to use <browser> on <platform>
+    When I start interacting with the browser
+    Then the browser is open
+
+  Examples:
+    | browser           | platform   |
+    | firefox           | linux      |
+    | firefox           | windows    |
+    | chrome            | linux      |
+    | chrome            | windows    |
+    | internet_explorer | windows    |
+    | safari            | os x 10.11 |
+    | android           | linux      |
+    | iphone            | os x 10.11 |

data/features/step_definitions/saucelabs_steps.rb

@@ -1,5 +1,10 @@
 require 'net/https'
 
+Given(/^I have configured my environment to use (.*?) on (.*?)$/) do |browser, platform|
+  @configs = [ENV, { browser: browser, platform: platform, browser_timeout: 120 }]
+  @env = MediawikiSelenium::Environment.new(*@configs)
+end
+
 Then(/^the SauceLabs job should be marked as failed$/) do
   job_id = @env.browser.driver.session_id
 

data/lib/mediawiki_selenium/browser_factory.rb

@@ -5,7 +5,9 @@ module MediawikiSelenium
     autoload :Chrome, 'mediawiki_selenium/browser_factory/chrome'
     autoload :Phantomjs, 'mediawiki_selenium/browser_factory/phantomjs'
 
-    # Resolves and instantiates a new factory for the given browser name.
+    # Resolves and instantiates a new factory for the given browser name. If a
+    # specific implementation is not defined for the given browser, a `Base`
+    # factory will be returned.
     #
     # @example Create a new firefox factory
     #   factory = BrowserFactory.new(:firefox)
@@ -17,7 +19,14 @@ module MediawikiSelenium
     # @return [BrowserFactory::Base]
     #
     def self.new(browser_name)
-      factory_class = const_get(browser_name.to_s.split('_').map(&:capitalize).join(''))
+      factory_class_name = browser_name.to_s.split('_').map(&:capitalize).join('')
+
+      if const_defined?(factory_class_name)
+        factory_class = const_get(factory_class_name)
+      else
+        factory_class = Base
+      end
+
       factory_class.new(browser_name)
     end
   end

data/lib/mediawiki_selenium/browser_factory/base.rb

@@ -227,7 +227,7 @@ module MediawikiSelenium
       end
 
       def new_browser(options)
-        Watir::Browser.new(options[:desired_capabilities].browser_name, options)
+        Watir::Browser.new(browser_name, options)
       end
     end
   end

data/lib/mediawiki_selenium/browser_factory/firefox.rb

@@ -32,7 +32,11 @@ module MediawikiSelenium
       protected
 
       def default_browser_options
-        super.merge(profile: Selenium::WebDriver::Firefox::Profile.new)
+        profile = Selenium::WebDriver::Firefox::Profile.new
+        # Never show any firstrun pages.
+        # @see http://kb.mozillazine.org/Browser.startup.homepage_override.mstone
+        profile['browser.startup.homepage_override.mstone'] = 'ignore'
+        super.merge(profile: profile)
       end
     end
   end

data/lib/mediawiki_selenium/remote_browser_factory.rb

@@ -9,6 +9,8 @@ module MediawikiSelenium
   #  - sauce_ondemand_access_key
   #  - platform
   #  - version
+  #  - device_name
+  #  - device_orientation
   #
   module RemoteBrowserFactory
     REQUIRED_CONFIG = [:sauce_ondemand_username, :sauce_ondemand_access_key]
@@ -37,6 +39,14 @@ module MediawikiSelenium
         base.configure(:version) do |version, options|
           options[:desired_capabilities].version = version
         end
+
+        base.configure(:device_name) do |device_name, options|
+          options[:desired_capabilities]['deviceName'] = device_name
+        end
+
+        base.configure(:device_orientation) do |device_orientation, options|
+          options[:desired_capabilities]['deviceOrientation'] = device_orientation
+        end
       end
     end
 

data/lib/mediawiki_selenium/version.rb

@@ -1,3 +1,3 @@
 module MediawikiSelenium
-  VERSION = '1.6.2'
+  VERSION = '1.6.3'
 end

data/spec/browser_factory/base_spec.rb

@@ -97,8 +97,6 @@ module MediawikiSelenium::BrowserFactory
       before do
         expect(Selenium::WebDriver::Remote::Capabilities).to receive(browser_name).
           at_least(:once).and_return(capabilities)
-        expect(capabilities).to receive(:browser_name).
-          at_least(:once).and_return(browser_name)
       end
 
       it 'creates a new Watir::Browser' do

data/spec/browser_factory/firefox_spec.rb

@@ -16,10 +16,18 @@ module MediawikiSelenium::BrowserFactory
     describe '#browser_options' do
       subject { factory.browser_options(config) }
 
+      let(:config) { {} }
       let(:profile) { double(Selenium::WebDriver::Firefox::Profile) }
 
       before do
-        expect(Selenium::WebDriver::Firefox::Profile).to receive(:new).and_return(profile)
+        allow(Selenium::WebDriver::Firefox::Profile).to receive(:new).and_return(profile)
+        allow(profile).to receive(:[]=)
+      end
+
+      it 'attempts to disable any firtrun page' do
+        expect(profile).to receive(:[]=).with('browser.startup.homepage_override.mstone', 'ignore')
+
+        subject
       end
 
       context 'given a browser proxy' do
@@ -42,13 +50,11 @@ module MediawikiSelenium::BrowserFactory
 
         it 'sets dom.max_script_run_time to the given number' do
           expect(profile).to receive(:[]=).with('dom.max_script_run_time', 30)
-          allow(profile).to receive(:[]=)
           subject
         end
 
         it 'sets dom.max_chrome_script_run_time to the given number' do
           expect(profile).to receive(:[]=).with('dom.max_chrome_script_run_time', 30)
-          allow(profile).to receive(:[]=)
           subject
         end
       end

data/spec/browser_factory_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+module MediawikiSelenium
+  describe BrowserFactory do
+    describe '.new' do
+      context 'given a browser that has a specific implementation' do
+        subject { BrowserFactory.new(:firefox) }
+
+        it 'instantiates the concrete factory class' do
+          expect(subject).to be_a(BrowserFactory::Firefox)
+        end
+      end
+
+      context 'given a browser that has no specific implementation' do
+        subject { BrowserFactory.new(:lynx) }
+
+        it { is_expected.to be_a(BrowserFactory::Base) }
+      end
+    end
+  end
+end

data/spec/remote_browser_factory_spec.rb

@@ -47,6 +47,24 @@ module MediawikiSelenium
           subject
         end
       end
+
+      context 'given a device name' do
+        let(:config) { { device_name: 'tabliphone' } }
+
+        it 'configures the deviceName' do
+          expect(capabilities).to receive(:[]=).with('deviceName', 'tabliphone')
+          subject
+        end
+      end
+
+      context 'given a device orientation' do
+        let(:config) { { device_orientation: 'portrait' } }
+
+        it 'configures the deviceOrientation' do
+          expect(capabilities).to receive(:[]=).with('deviceOrientation', 'portrait')
+          subject
+        end
+      end
     end
 
     describe '#teardown' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mediawiki_selenium
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.6.3
 platform: ruby
 authors:
 - Chris McMahon
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-26 00:00:00.000000000 Z
+date: 2015-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -329,6 +329,7 @@ files:
 - LICENSE
 - README.md
 - RELEASES.md
+- Rakefile
 - UPGRADE.md
 - bin/mediawiki-selenium-init
 - features/api.feature
@@ -337,6 +338,7 @@ files:
 - features/recording.feature
 - features/rspec.feature
 - features/saucelabs.feature
+- features/saucelabs_browsers.feature
 - features/screenshots.feature
 - features/step_definitions/api_helper_steps.rb
 - features/step_definitions/browser_steps.rb
@@ -395,6 +397,7 @@ files:
 - spec/browser_factory/chrome_spec.rb
 - spec/browser_factory/firefox_spec.rb
 - spec/browser_factory/phantomjs_spec.rb
+- spec/browser_factory_spec.rb
 - spec/environment_spec.rb
 - spec/headless_helper_spec.rb
 - spec/page_factory_spec.rb
@@ -425,7 +428,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: An easy way to run MediaWiki Selenium tests.