mediawiki_selenium 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 01bb1e36bd275e158439389152f9f0e75df02ee6
-  data.tar.gz: 6b5c1825eeeb66c8551de98bf2de03ce8637207b
+  metadata.gz: c55bb41a3040b8fe13f7959cb9471870fb964c47
+  data.tar.gz: d8dee93ee8a956288de1ae1e412e3512a2427689
 SHA512:
-  metadata.gz: f600a40695ac3fa6d2876ad0458318e63b75acf15d60e072c7693a9b24bb6d05f347eaa9cc236614e848ed30bdeb779a60f8a62b8a0988005aaf96a0323b73d2
-  data.tar.gz: 03493b1449b8d70a92a1221b5e6c80a2cfe89faec2290b889b68156c36c3e7dfd0cf83b72b66ebee859b679580db818a11940f32adeb4bd80997a1fa1e28b859
+  metadata.gz: 86045429284cab2eea77d9c5a2a8f76e7922d982c5ebb728e644ceea15b7126085a26872dd4790fe147f5bfd25f01e77a6baad6d4cbe515de1303dcc5b28fe5f
+  data.tar.gz: fc39ea530db1f558c0f61261b012e555bc6bc308b3ec17ce53330ae3a872f59f1fbbe28dda10c351d66b6dac982f74190ac5326cdee9bd1b50797ab6ff44968d

data/RELEASES.md

@@ -1,5 +1,9 @@
 ## Release notes
 
+### 1.6.2 2015-10-23
+* Fixed undefined `last_session_ids=` method bug in `RemoteBrowserFactory`
+  which entirely broke SauceLabs use in previous 1.6.x versions
+
 ### 1.6.1 2015-09-29
 * Fixed bug in `UserFactory#user` and `UserFactory#password` that caused the
   incorrect resolution of alternative users/passwords when in the context of

data/UPGRADE.md

@@ -3,14 +3,14 @@
 You can check your current version by running `bundle list mediawiki_selenium`
 in the root directory of your project.
 
-## From 1.x releases to 1.6.0
+## From 1.x releases to 1.6.x
 
 ### Update your `Gemfile`
 
 First, update the `Gemfile` in your project's root directory to specify the
 new version.
 
-    gem 'mediawiki_selenium', '~> 1.6.0'
+    gem 'mediawiki_selenium', '~> 1.6.2'
 
 ### Update `require` paths in `env.rb`
 
@@ -37,7 +37,7 @@ if they don't apply to your test cases. The only must have is the first
 First, update the `Gemfile` in your project's root directory to specify the
 new version.
 
-    gem 'mediawiki_selenium', '~> 1.6.0'
+    gem 'mediawiki_selenium', '~> 1.6.2'
 
 ### Upgrade gems and dependencies
 

data/lib/mediawiki_selenium/remote_browser_factory.rb

@@ -45,13 +45,12 @@ module MediawikiSelenium
     def teardown(env, status)
       artifacts = super
 
-      self.class.last_session_ids = []
+      RemoteBrowserFactory.last_session_ids = []
 
       each do |browser|
         sid = browser.driver.session_id
-        url = browser.driver.send(:bridge).http.send(:server_url)
-        username = url.user
-        key = url.password
+        username = env.lookup(:sauce_ondemand_username)
+        key = env.lookup(:sauce_ondemand_access_key)
 
         RestClient::Request.execute(
           method: :put,
@@ -66,7 +65,7 @@ module MediawikiSelenium
           }.to_json
         )
 
-        self.class.last_session_ids << sid
+        RemoteBrowserFactory.last_session_ids << sid
 
         artifacts["http://saucelabs.com/jobs/#{sid}"] = 'text/url'
       end

data/lib/mediawiki_selenium/version.rb

@@ -1,3 +1,3 @@
 module MediawikiSelenium
-  VERSION = '1.6.1'
+  VERSION = '1.6.2'
 end

data/spec/remote_browser_factory_spec.rb

@@ -1,4 +1,6 @@
+require 'rest_client'
 require 'spec_helper'
+
 require 'mediawiki_selenium/browser_factory/base'
 
 module MediawikiSelenium
@@ -46,5 +48,43 @@ module MediawikiSelenium
         end
       end
     end
+
+    describe '#teardown' do
+      subject { factory.teardown(env, status) }
+
+      let(:config) do
+        {
+          sauce_ondemand_username: 'foo',
+          sauce_ondemand_access_key: 'bar',
+          build_number: 'b123'
+        }
+      end
+
+      let(:env) { Environment.new(config) }
+      let(:status) { :passed }
+
+      before do
+        browser = double('Watir::Browser')
+        driver = double('Selenium::WebDriver::Driver')
+
+        expect(factory).to receive(:each).and_yield(browser)
+        expect(browser).to receive(:driver).and_return(driver)
+        expect(driver).to receive(:session_id).and_return('123')
+      end
+
+      it 'updates the SauceLabs session for each browser and returns the URL as an artifact' do
+        expect(RestClient::Request).to receive(:execute).with(
+          method: :put,
+          url: 'https://saucelabs.com/rest/v1/foo/jobs/123',
+          user: 'foo',
+          password: 'bar',
+          headers: { content_type: 'application/json' },
+          payload: '{"public":true,"passed":true,"build":"b123"}'
+        )
+
+        expect(subject).to include('http://saucelabs.com/jobs/123')
+        expect(subject['http://saucelabs.com/jobs/123']).to eq('text/url')
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mediawiki_selenium
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - Chris McMahon
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-29 00:00:00.000000000 Z
+date: 2015-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber