media_types 1.0.0 → 2.1.1

data/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2020 Derk-Jan Karrenbeld
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/README.md

@@ -1,10 +1,10 @@
 # MediaTypes
-[![Build Status](https://travis-ci.com/SleeplessByte/media-types-ruby.svg?branch=master)](https://travis-ci.com/SleeplessByte/media-types-ruby)
+[![Build Status](https://github.com/SleeplessByte/media-types-ruby/workflows/Ruby/badge.svg?branch=master)](https://github.com/SleeplessByte/media-types-ruby/actions?query=workflow%3ARuby)
 [![Gem Version](https://badge.fury.io/rb/media_types.svg)](https://badge.fury.io/rb/media_types)
 [![MIT license](http://img.shields.io/badge/license-MIT-brightgreen.svg)](http://opensource.org/licenses/MIT) 
 [![Maintainability](https://api.codeclimate.com/v1/badges/6f2dc1fb37ecb98c4363/maintainability)](https://codeclimate.com/github/SleeplessByte/media-types-ruby/maintainability)
 
-Media Types based on  scheme, with versioning, views, suffixes and validations. Integrations available for [Rails](https://github.com/rails/rails) / ActionPack and [http.rb](https://github.com/httprb/http).
+Media Types based on  scheme, with versioning, views, suffixes and validations.
 
 This library makes it easy to define schemas that can be used to validate JSON objects based on their Content-Type.
 
@@ -64,7 +64,7 @@ class Venue
     'mydomain'
   end
   
-  media_type 'venue', defaults: { suffix: :json }
+  use_name 'venue'
 
   validations do
     version 2 do
@@ -103,17 +103,6 @@ class Venue
       end
     end
   end
-
-  registrations :venue_json do
-    view 'create', :create_venue
-    view 'index', :venue_urls
-    view 'collection', :venue_collection
-    
-    versions [1,2]
-    
-    suffix :json
-    suffix :xml
-  end
 end
 ```
 
@@ -125,13 +114,13 @@ If you include 'MediaTypes::Dsl' in your class you can use the following functio
 
 Adds an attribute to the schema, if a +block+ is given, uses that to test against instead of +type+
 
-| param | type | description |
-|-------|------|-------------|
-| key | `Symbol` | the attribute name |
-| opts | `Hash` | options to pass to `Scheme` or `Attribute` |
-| type | `Class`, `===`, Scheme | The type of the value, can be anything that responds to `===`,  or scheme to use if no `&block` is given. Defaults to `Object` without a `&block` and to Hash with a `&block`. |
-| optional: | `TrueClass`, `FalseClass` | if true, key may be absent, defaults to `false` |
-| &block | `Block` | defines the scheme of the value of this attribute |
+| param     | type                      | description                                                                                                                                                                   |
+| --------- | ------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| key       | `Symbol`                  | the attribute name                                                                                                                                                            |
+| opts      | `Hash`                    | options to pass to `Scheme` or `Attribute`                                                                                                                                    |
+| type      | `Class`, `===`, Scheme    | The type of the value can be anything that responds to `===`,  or scheme to use if no `&block` is given. Defaults to `Object` without a `&block` and to Hash with a `&block`. |
+| optional: | `TrueClass`, `FalseClass` | if true, key may be absent, defaults to `false`                                                                                                                               |
+| &block    | `Block`                   | defines the scheme of the value of this attribute                                                                                                                             |
 
 #### Add an attribute named foo, expecting a string
 ```Ruby
@@ -169,12 +158,12 @@ MyMedia.valid?({ foo: { bar: 'my-string' }})
 ### `any`
 Allow for any key. The `&block` defines the Schema for each value.
 
-| param | type | description |
-|-------|------|-------------|
-| scheme | `Scheme`, `NilClass` | scheme to use if no `&block` is given |
-| allow_empty: | `TrueClass`, `FalsClass` | if true, empty (no key/value present) is allowed |
-| expected_type: | `Class`, | forces the validated value to have this type, defaults to `Hash`. Use `Object` if either `Hash` or `Array` is fine |
-| &block | `Block` | defines the scheme of the value of this attribute |
+| param          | type                     | description                                                                                                        |
+| -------------- | ------------------------ | ------------------------------------------------------------------------------------------------------------------ |
+| scheme         | `Scheme`, `NilClass`     | scheme to use if no `&block` is given                                                                              |
+| allow_empty:   | `TrueClass`, `FalsClass` | if true, empty (no key/value present) is allowed                                                                   |
+| expected_type: | `Class`,                 | forces the validated value to have this type, defaults to `Hash`. Use `Object` if either `Hash` or `Array` is fine |
+| &block         | `Block`                  | defines the scheme of the value of this attribute                                                                  |
 
 #### Add a collection named foo, expecting any key with a defined value
 ```Ruby
@@ -218,14 +207,14 @@ MyMedia.valid?({ foo: [{ required: 'test', bar: 42 }] })
 ### `collection`
 Expect a collection such as an array or hash. The `&block` defines the Schema for each item in that collection.
 
-| param | type | description |
-|-------|------|-------------|
-| key | `Symbol` | key of the collection (same as `#attribute`) |
-| scheme | `Scheme`, `NilClass`, `Class` | scheme to use if no `&block` is given or `Class` of each item in the  |
-| allow_empty: | `TrueClass`, `FalseClass` | if true, empty (no key/value present) is allowed |
-| expected_type: | `Class`, | forces the validated value to have this type, defaults to `Array`. Use `Object` if either `Array` or `Hash` is fine. |
-| optional: | `TrueClass`, `FalseClass` | if true, key may be absent, defaults to `false` |
-| &block | `Block` | defines the scheme of the value of this attribute |
+| param          | type                          | description                                                                                                          |
+| -------------- | ----------------------------- | -------------------------------------------------------------------------------------------------------------------- |
+| key            | `Symbol`                      | key of the collection (same as `#attribute`)                                                                         |
+| scheme         | `Scheme`, `NilClass`, `Class` | scheme to use if no `&block` is given or `Class` of each item in the collection                                      |
+| allow_empty:   | `TrueClass`, `FalseClass`     | if true, empty (no key/value present) is allowed                                                                     |
+| expected_type: | `Class`,                      | forces the validated value to have this type, defaults to `Array`. Use `Object` if either `Array` or `Hash` is fine. |
+| optional:      | `TrueClass`, `FalseClass`     | if true, key may be absent, defaults to `false`                                                                      |
+| &block         | `Block`                       | defines the scheme of the value of this attribute                                                                    |
 
 
 #### Collection with an array of string
@@ -264,12 +253,12 @@ MyMedia.valid?({ foo: [{ required: 'test', number: 42 }, { required: 'other', nu
 
 Expect a link with a required `href: String` attribute
 
-| param | type | description |
-|-------|------|-------------|
-| key | `Symbol` | key of the link (same as `#attribute`) |
-| allow_nil: | `TrueClass`, `FalseClass` | if true, value may be nil |
-| optional: | `TrueClass`, `FalseClass` | if true, key may be absent, defaults to `false` |
-| &block | `Block` | defines the scheme of the value of this attribute, in addition to the `href` attribute |
+| param      | type                      | description                                                                            |
+| ---------- | ------------------------- | -------------------------------------------------------------------------------------- |
+| key        | `Symbol`                  | key of the link (same as `#attribute`)                                                 |
+| allow_nil: | `TrueClass`, `FalseClass` | if true, value may be nil                                                              |
+| optional:  | `TrueClass`, `FalseClass` | if true, key may be absent, defaults to `false`                                        |
+| &block     | `Block`                   | defines the scheme of the value of this attribute, in addition to the `href` attribute |
 
 #### Links as defined in HAL, JSON-Links and other specs
 ```Ruby
@@ -277,7 +266,7 @@ class MyMedia
   include MediaTypes::Dsl
 
   validations do
-    link :_self
+    link :self
     link :image
   end
 end
@@ -346,9 +335,6 @@ Venue.mime_type.identifier
 Venue.mime_type.version(1).identifier
 # => "application/vnd.mydomain.venue.v1+json"
 
-Venue.mime_type.version(1).suffix(:xml).identifier
-# => "application/vnd.mydomain.venue.v1+xml"
-
 Venue.mime_type.to_s(0.2)
 # => "application/vnd.mydomain.venue.v2+json; q=0.2"
 
@@ -359,43 +345,6 @@ Venue.mime_type.view('active').identifier
 # => "application/vnd.mydomain.venue.v2.active+json"
 ```
 
-## Integrations
-The integrations are not loaded by default, so you need to require them:
-```ruby
-# For Rails / ActionPack
-require 'media_types/integrations/actionpack'
-
-# For HTTP.rb
-require 'media_types/integrations/http' 
-```
-
-Define a `registrations` block on your media type, indicating the symbol for the base type (`registrations :symbol do`) and inside use the registrations dsl to define which media types to register. `versions array_of_numbers` determines which versions, `suffix name` adds a suffix, `type_alias name` adds an alias and `view name, symbol` adds a view.
-
-```Ruby
-Venue.register
-```
-
-### Rails
-Load the `actionpack` integration and call `.register` on all the media types you want to be available in Rails. You can do this in the `mime_types` initializer, or anywhere before your controllers are instantiated. Yes, the symbol (by default `<type>_v<version>_<suffix>`) can now be used in your `format` blocks, or as extension in the url.
-
-Rails only has a default serializer for `application/json`, and content with your `+json` media types (or different once) will not be deserialized by default. A way to overcome this is to set the JSON parameter parser for all new symbols. `.register` gives you back an array of `Registerable` objects that responds to `#to_sym` to get that symbol.
-
-```ruby
-symbols = Venue.register.map(&:to_sym)
-
-original_parsers = ActionDispatch::Request.parameter_parsers
-new_parser = original_parsers[Mime[:json].symbol]
-new_parsers = original_parsers.merge(Hash[*symbols.map { |s| [s, new_parser] }])
-ActionDispatch::Request.parameter_parsers = new_parsers
-```
-
-If you want to validate the content-type and not have your errors be `Rack::Error` but be handled by your controllers, leave this out and add a `before_action` to your controller that deserializes + validates for you.
-
-### HTTP.rb
-Load the `http` integration and call `.register` on all media types you want to be able to serialize and deserialize. The media type validations will run both before serialization and after deserialization.
-
-Currently uses `oj` under the hood and this can not be changed.
-
 ## API
 
 A defined schema has the following functions available:
@@ -416,7 +365,7 @@ Allows passing in validation options as a second parameter.
 
 Example: `Venue.version(42).validatable?`
 
-Tests wether the current configuration of the schema has a validation defined.
+Tests whether the current configuration of the schema has a validation defined.
 
 ### `register`
 
@@ -454,10 +403,254 @@ Example: `Venue.available_validations`
 
 Returns a list of all the schemas that are defined.
 
+## Ensuring Your MediaTypes Work
+
+### Overview & Rationale
+
+If the MediaTypes you create enforce a specification you _do not expect them to_, it will cause problems that will be very difficult to fix, as other code, which utilises your MediaType, would break when you change the specification. This is because the faulty MediaType definition will start to make other code dependent on the specification it defines. For example, consider what would happen if you release a MediaType which defines an attribute `foo` to be a `String`, and run a server which defines such a specification. Later, you realise you _actually_ wanted `foo` to be `Numeric`. What can you do?
+
+Well, during this time, other people started to write code which conformed to the specification defined by the faulty MediaType. So, it's going to be extremely difficult to revert your mistake. For this reason, it is vital that, when using this library, your MediaTypes define the _correct_ specification.
+
+To this end, we provide you with a few avenues to check whether MediaTypes define the specifications you actually intend by checking examples of JSON you expect to be compliant/non-compliant with the MediaType definitions you write out.
+
+These are as follows:
+
+1. The library provides [two methods](README.md#media-type-checking-in-test-suites) (`assert_pass` and `assert_fail`), which allow specifying JSON fixtures that are compliant (`assert_pass`) or non-compliant (`assert_fail`).
+2. The library provides a way to validate those fixtures against the MediaType specification with the [`assert_mediatype`](README.md#media-type-checking-in-test-suites) method.
+3. The library automatically performs a MediaType's checks defined by (1) the first time an object is validated against the MediaType, and throws an error if any of the checks fail.
+4. The library provides a way to run the checks carried out by (3) on load, using the method [`assert_sane!`](README.md#validation-checks) so that an application will not run if any of the MediaType's checks don't pass.
+
+These four options are examined in detail below.
+
+### MediaType Checking in Test Suites
+
+The library provides the `assert_mediatype` method, which allows running the checks for a particular `MediaType` within Minitest with `assert_pass` and `assert_fail`.
+If you are using Minitest, you can make `assert_mediatype` available by calling `include MediaTypes::Testing::Assertions` in the test class (e.g. `Minitest::Runnable`):
+
+```ruby
+module Minitest
+  class Test < Minitest::Runnable
+    include MediaTypes::Testing::Assertions
+  end
+end
+```
+
+The example below demonstrates how to use `assert_pass` and `assert_fail` within a MediaType, and how to use the `assert_mediatype` method in MiniTest tests to validate them.
+
+```ruby
+class MyMedia
+  include MediaTypes::Dsl
+
+  def self.organisation
+    'acme'
+  end
+
+  use_name 'test'
+
+  validations do
+    # Using "any Numeric" this MediaType doesn't care what key names you use.
+    # However, it does care that those keys point to a Numeric value.
+    any Numeric
+
+    assert_pass '{"foo": 42}'
+    assert_pass <<-FIXTURE
+    { "foo": 42, "bar": 43 }
+    FIXTURE
+
+    # The keyword "any" means there are no required keys, so having no keys should also pass.
+    assert_pass '{}'
+
+    # This MediaType should not accept anything other then a Numeric value.
+    assert_fail <<-FIXTURE
+    { "foo": { "bar": "string" } }
+    FIXTURE
+    assert_fail '{"foo": {}}'
+    assert_fail '{"foo": null}'
+    assert_fail '{"foo": [42]}'
+  end
+end
+
+class MyMediaTest < Minitest::Test
+  include MediaTypes::Testing::Assertions
+
+  def test_mediatype_specification
+    assert_mediatype MyMedia
+  end
+end
+
+class MyMediaTest < Minitest::Test
+  include MediaTypes::Testing::Assertions
+
+  def test_mediatype_specification
+    assert_mediatype MyMedia
+  end
+end
+
+```
+
+### Testing Without Minitest
+
+If you are using another testing framework, you will not be able to use the `assert_mediatype` method. Instead, you can test your MediaTypes by using the `assert_sane!` method (documented below) and rescuing the errors it will throw when it fails. The snippet below shows an example adaptation for MiniTest, which you can use as a guide.
+
+```ruby
+ def test_mediatype(mediatype)
+      mediatype.assert_sane!
+      assert mediatype.media_type_validations.scheme.asserted_sane?
+    rescue MediaTypes::AssertionError => e
+      flunk e.message
+    end
+  end
+```
+
+### Validation Checks
+
+The `assert_pass` and `assert_fail` methods take a JSON string (as shown below). The first time the `validate!` method is called on a MediaType, the assertions for that media type are run.
+This is done as a last line of defence against introducing faulty MediaTypes into your software. Ideally, you want to carry out these checks on load rather than on a running application. This functionality is provided by the `assert_sane!` method, which can be called on a particular MediaType:
+
+```ruby
+MyMedia.assert_sane!
+# true
+```
+
+### Intermediate Checks
+
+The fixtures provided to the `assert_pass` and `assert_fail` methods are evaluated within the context of the block they are placed in. It's therefore possible to write a test for a (complex) optional attribute, without that test cluttering the fixtures for the entire mediatype.
+
+```ruby
+class MyMedia
+  include MediaTypes::Dsl
+
+  expect_string_keys
+
+  def self.organisation
+    'acme'
+  end
+
+  use_name 'test'
+
+  validations do
+    attribute :foo, Hash, optional: true do
+      attribute :bar, Numeric
+
+      # This passes, since in this context the "bar" key is required to have a Numeric value. 
+      assert_pass '{"bar": 42}'
+    end
+    attribute :rep, Numeric
+
+    # This passes, since the attribute "foo" is optional.
+    assert_pass '{"rep": 42}'
+  end
+end
+```
+
+## Key Type Validation
+
+When interacting with Ruby objects defined by your MediaType, you want to avoid getting `nil` values, just because the the wrong key type is being used (e.g. `obj['foo']` instead of `obj[:foo]`).
+To this end, the library provides the ability to specify the expected type of keys in a MediaType; by default symbol keys are expected.
+
+### Setting Key Type Expectations
+
+Key type expectations can be set at the module level. Each MediaType within this module will inherit the expectation set by that module.
+
+```ruby
+module Acme
+  MediaTypes.expect_string_keys(self)
+
+  # The MyMedia class expects string keys, as inherited from the Acme module.
+  class MyMedia
+    include MediaTypes::Dsl
+
+    def self.organisation
+      'acme'
+    end
+
+    use_name 'test'
+
+    validations do
+      any Numeric
+    end
+  end
+end
+```
+
+If you validate an object with a different key type than expected, an error will be thrown:
+
+```ruby
+  Acme::MyMedia.validate! { "something": 42 }
+  # => passes, because all keys are a string
+
+  Acme::MyMedia.validate! { something: 42 }
+  # => throws a ValidationError , because 'something' is a symbol key
+```
+
+## Overriding Key Type Expectations
+
+A key type expectation set by a Module can be overridden by calling either `expect_symbol_keys` or `expect_string_keys` inside the MediaType class.
+
+```ruby
+module Acme
+  MediaTypes.expect_string_keys(self)
+
+  class MyOverridingMedia
+    include MediaTypes::Dsl
+
+    def self.organisation
+      'acme'
+    end
+
+    use_name 'test'
+    
+    # Expect keys to be symbols
+    expect_symbol_keys
+
+    validations do
+      any Numeric
+    end
+  end
+end
+```
+
+Now the MediaType throws an error when string keys are used.
+
+```ruby
+  Acme::MyOverridingMedia.validate! { something: 42 }
+  # => passes, because all keys are a symbol
+
+  Acme::MyOverridingMedia.validate! { "something": 42 }
+  # => throws a ValidationError , because 'something' is a string key
+```
+
+### Setting The JSON Parser With The Wrong Key Type
+
+If you parse JSON with the wrong key type, as shown below, the resultant object will fail the validations.
+
+```ruby
+  class MyMedia
+    include MediaTypes::Dsl
+
+    def self.organisation
+      'acme'
+    end
+
+    use_name 'test'
+    
+    # Expect keys to be symbols
+    expect_symbol_keys
+
+    validations do
+      any Numeric
+    end
+  end
+
+  json = JSON.parse('{"foo": {}}', { symbolize_names: false })
+  # If MyMedia expects symbol keys
+  MyMedia.valid?(json)
+  # Returns false
+```
+
 ## Related
 
-- [`MediaTypes::Serialization`](https://github.com/XPBytes/media_types-serialization): :cyclone: Add media types supported serialization using your favourite serializer
-- [`MediaTypes::Validation`](https://github.com/XPBytes/media_types-validation): :heavy_exclamation_mark: Response validations according to a media-type
+- [`MediaTypes::Serialization`](https://github.com/XPBytes/media_types-serialization): :cyclone: Add media types supported serialization to Rails.
 
 ## Development