mechanize_content 0.3.1 → 0.3.2

data/Gemfile

@@ -1,4 +1,7 @@
 source "http://rubygems.org"
 
-# Specify your gem's dependencies in mechanize_content.gemspec
 gemspec
+
+group :development do
+  gem "rake"
+end

data/lib/mechanize_content/image.rb

@@ -4,35 +4,35 @@ module MechanizeContent
     MIN_HEIGHT = 64
     AD_WIDTH = 728
     AD_HEIGHT = 90
-    
+
     def self.best_image(images, base_url)
       imgs = images.map{|i| Image.new(i, base_url)}
       top_image = imgs.select{|i| i.interesting_css?}.first || imgs.select{|i| i.interesting_file?}.first
       top_image.absolute_url if top_image
     end
-    
+
     def initialize(image, base_url)
-      @src      = image["src"]
+      @src      = URI.escape(image["src"])
       @width    = image["width"].to_i
       @height   = image["height"].to_i
       @base_url = base_url
     end
-    
+
     def interesting_css?
       valid_image?(@width, @height)
     end
-    
+
     def interesting_file?
       open(absolute_url, "rb") do |fh|
         is = ImageSize.new(fh.read)
         return valid_image?(is.width, is.height)
       end
     end
-    
+
     def valid_image?(width, height)
       big_enough?(width, height) && not_advertising?(width, height) && allows_hotlinking?
     end
-    
+
     def allows_hotlinking?
       begin
         open(absolute_url, "Referer" => "http://splitstate.com")
@@ -41,21 +41,21 @@ module MechanizeContent
       end
       true
     end
-    
+
     def advertising?(width, height)
       @src.include?("banner") || @src.include?(".gif") || ((width == AD_WIDTH) && (height == AD_HEIGHT))
     end
-    
+
     def not_advertising?(width, height)
       !advertising?(width, height)
     end
-    
+
     def big_enough?(width, height)
       width > MIN_WIDTH && height > MIN_HEIGHT
     end
-    
+
     def absolute_url
       URI.parse(@src).relative? ? (URI.parse(@base_url.to_s)+@src).to_s : @src
-    end    
+    end
   end
 end

data/lib/mechanize_content/version.rb

@@ -1,3 +1,3 @@
 module MechanizeContent
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/spec/mechanize_content/image_spec.rb

@@ -2,21 +2,31 @@ require 'spec_helper'
 
 describe MechanizeContent::Image do
   use_vcr_cassette :record => :new_episodes
-  
+
+  describe "#absolute_url" do
+    context "given a uri with a space" do
+      it "will be escaped" do
+        img = {"src" => "http://media.giantbomb.com/uploads/0/26/10180-psn icon_middle.jpg", "width" => 280, "height" => 283}
+        image = MechanizeContent::Image.new(img, "http://www.giantbomb.com/news/the-slow-motion-ballet-of-death-in-max-payne-3/3721/")
+        image.absolute_url.should eq("http://media.giantbomb.com/uploads/0/26/10180-psn%20icon_middle.jpg")
+      end
+    end
+  end
+
   describe "#interesting_css?" do
     context "given a gif" do
       it "is not interesting" do
         img = {"src" => "http://www.cmpevents.com/GD10/ablank.gif2", "width" => 500, "height" => 500}
         image = MechanizeContent::Image.new(img, "https://www.cmpevents.com")
-        image.should_not be_interesting_css    
+        image.should_not be_interesting_css
       end
     end
-    
+
     context "given a banner" do
       it "is not interesting" do
         img = {"src" => "http://www.cmpevents.com/GD10/banner.png", "width" => 500, "height" => 500}
         image = MechanizeContent::Image.new(img, "https://www.cmpevents.com")
-        image.should_not be_interesting_css    
+        image.should_not be_interesting_css
       end
     end
 
@@ -35,5 +45,5 @@ describe MechanizeContent::Image do
         image.should be_interesting_css
       end
     end
-  end  
+  end
 end

metadata

@@ -1,82 +1,79 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: mechanize_content
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 0.3.2
   prerelease: 
-  version: 0.3.1
 platform: ruby
-authors: 
+authors:
 - John Griffin
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-07-10 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2011-10-09 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: mechanize
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &70365206410400 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 2.0.1
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: imagesize
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *70365206410400
+- !ruby/object:Gem::Dependency
+  name: imagesize
+  requirement: &70365206409620 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 0.1.1
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *70365206409620
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &70365206408940 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 2.6.0
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: vcr
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: *70365206408940
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: &70365206408160 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 1.10.0
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: fakeweb
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: *70365206408160
+- !ruby/object:Gem::Dependency
+  name: fakeweb
+  requirement: &70365206407500 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 1.3.0
   type: :development
-  version_requirements: *id005
-description: pass in a url or urls and mechanize-content will select the best block of text, image and title by analysing the page content
-email: 
+  prerelease: false
+  version_requirements: *70365206407500
+description: pass in a url or urls and mechanize-content will select the best block
+  of text, image and title by analysing the page content
+email:
 - johnog@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rspec
 - .rvmrc
@@ -98,32 +95,35 @@ files:
 - spec/spec_helper.rb
 homepage: http://github.com/john-griffin/mechanize-content
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: -160408397260513251
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: -160408397260513251
 requirements: []
-
 rubyforge_project: mechanize_content
-rubygems_version: 1.8.5
+rubygems_version: 1.8.7
 signing_key: 
 specification_version: 3
 summary: scrape the best content from a page
-test_files: 
+test_files:
 - spec/cassettes/MechanizeContent.yml
 - spec/cassettes/MechanizeContent_Image.yml
 - spec/mechanize_content/image_spec.rb